From nobody Fri Nov 14 23:27:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759172956; cv=none; d=zohomail.com; s=zohoarc; b=cm//3SugcubheY1/SlN4Itf9kIF/1lkYuPUdebt/4OscsttQVyARYDftHicjL51w4yWkynDNsFXxcVzmbRb8+VMPU3kYBDRd8OMJROy6KKna4ET3MPcoKNET4EIUY4uwYP5vqMaCiFAR7tc6YCldhfB3rWPmgrS9h1Gr7AFAbew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759172956; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=G/jbWkOct8ZRYPtd0lNYycxs/HBJIrNJiaDda9/G8E8NkhTssjrI8AB9tlnbngh82zanrGkSWLUI3olbc8v7xr4IouXLqnQmGjZSrxCtwwL4qe6sVBLwc1w+sXh9zj2gaAyjaJ9ZLa2CPdZKxeSZX3V3/QXIHke+0XZnE8wcSxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759172956577612.0312568294194; Mon, 29 Sep 2025 12:09:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3JEP-0007UQ-Ut; Mon, 29 Sep 2025 15:08:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JEM-0007U3-EP for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JEI-0004tb-EQ for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:14 -0400 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-0gdmSRkRMSWCYlefMJkh6A-1; Mon, 29 Sep 2025 15:08:06 -0400 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-797ab35807eso125967646d6.1 for ; Mon, 29 Sep 2025 12:08:05 -0700 (PDT) Received: from x1.local ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-80142f5d6d1sm79626296d6.33.2025.09.29.12.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 12:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759172887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=QROChcx+fzImJMReQNHUqK+KRRyQeV5XBQPt0Dcx9C102KkXbZN7+CrisG8tieMbW6BC/q khXk64WwmfpqvnBH0Ak1eTuw4y2Ii69CisB2OwJ8y+Xgkl8aa5rAY0OC/4s70vtiCWGKOR qNno5c6Gzh/WuDFJ5d2ZZRlwNM4WofM= X-MC-Unique: 0gdmSRkRMSWCYlefMJkh6A-1 X-Mimecast-MFC-AGG-ID: 0gdmSRkRMSWCYlefMJkh6A_1759172885 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759172885; x=1759777685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=UCStf1LmfU4YDlCbfbcDeHh6nL8mgBVhbnBeHufoTOQpg8dYb3m9BJXUY+SpUWWl4u XPv8cofA1EutkDRLw3+TEExoF6IxXaUr9gC882OnFM5N0MJZ/pZcO3GKGS1CUnFUAof1 Gg9mdsVhAVfQ4JgjcwutlbrpbuivYfB77Z/vnBS+BXNqIFWORH2gRPz1tB8fa4G6/vmE 3S+/If8MYZWqOcb7zfXKPvFR6OEKbFNdPHoDsi2kBXZOzyOVChWfXtkeOyVKW8WQIhe+ NMdeWW5iEtwe68nUJnJPxlE5McSCKu96AcK6K4YefysC54/40Utmv/MWDKeswZYVaf6n 4u+Q== X-Gm-Message-State: AOJu0YytCTmT4pFacIncepAssvZo+DY9J0oYECt+tj1iPdt7kNrxMwDo mZEVry87Ap+dE7Jx9TR8XZjEAfhIv6MIGRn7XWT8lMPFWyRDC2WwycoJtaFXsBPN2jDAcUXvXD4 TpU1pZ/iN8bz8rGWMZ7TIL+slq0CKF8CKh49iVzXMD+nsIV5kz2yUcZc4Vsd3mC1SblpwDz9KT/ 7o2M6mTMhNpvl7VbrMIym+jLzGZw9QgHtrX1MvtA== X-Gm-Gg: ASbGnctlxVdL8J/iD6XT3yk+90WKNi0hZmqfqDUlSvwSjl252bxV4yMP8L+P2OuUAJB VzT/v88MY1q5iP+vD1xqr3T0tBGhGtVhmzQYTEcq0OXheHnJ1oCMaIFAfgJ8m4xOOxoPJotddT8 gOxiWfLl6ClC8zBfRhBx5hD4uC6/RykuXR8XDWc+rUzMyD0nXmDnyomgPA7CZZNnDOlfaZw15nk KEAi27JRsdYKODa079JsppfZej65DLhkYtXyoJeqXh1rIJguXs8zuJIXHVXSoGwm07Tb7apMcIC 7kAD250XCX6maNXT8RnjF04Rl0Olq/oF X-Received: by 2002:a05:6214:d62:b0:80a:71ea:38df with SMTP id 6a1803df08f44-80a71ea39b5mr208194666d6.43.1759172884853; Mon, 29 Sep 2025 12:08:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE+64ikqAdcPFOFM810wShTDGO76ItxX0fewMNqlUu8SMb2QmHTD5iEbFZ53s6ShZPj9CQfg== X-Received: by 2002:a05:6214:d62:b0:80a:71ea:38df with SMTP id 6a1803df08f44-80a71ea39b5mr208194076d6.43.1759172884218; Mon, 29 Sep 2025 12:08:04 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Peter Maydell , Richard Henderson , "Emilio G . Cota" , peterx@redhat.com Subject: [PATCH 1/3] qht: Zero-initialize qht_map Date: Mon, 29 Sep 2025 15:07:59 -0400 Message-ID: <20250929190801.931989-2-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250929190801.931989-1-peterx@redhat.com> References: <20250929190801.931989-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759172957352116600 Content-Type: text/plain; charset="utf-8" QEMU almost always do this across the tree except QHT. This prepares for rcu to track double free. Signed-off-by: Peter Xu --- util/qht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qht.c b/util/qht.c index 208c2f4b32..872d9f9cec 100644 --- a/util/qht.c +++ b/util/qht.c @@ -441,7 +441,7 @@ static struct qht_map *qht_map_create(size_t n_buckets) struct qht_map *map; size_t i; =20 - map =3D g_malloc(sizeof(*map)); + map =3D g_malloc0(sizeof(*map)); map->n_buckets =3D n_buckets; =20 map->n_added_buckets =3D 0; --=20 2.50.1 From nobody Fri Nov 14 23:27:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759172930; cv=none; d=zohomail.com; s=zohoarc; b=gd04FNRns533yMfHp7l+AxAwJ1NpsAVouqOOQsGDTCY5hCHCcc1Ev3ZrhK22QLgkevxibIkPAxtRwOlPh6ouPz2ab3kXE6DSJay4mZZhKz+vMM4UAcxr2YKQNJXU9TPecmi3+VSKjb3EaK6M03Ku0bBSVeRE8qM/LTu9or76IY4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759172930; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=lCYdW2MX3LO4qeA6kAydREd2PinGaRhaRdYa4/IPssckWzWSfLfAlOgYaboI/5P9ufdJS59Rk8+hm+HMml/b7O4puZP4G7OEEeud8Jls+EgaeFe1gReejHkJrU7x5Is0KP3hzdnB6s0DxS3YepJc+Y0EKN8jhQa5gFauFi4gPAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759172930426346.40790004725113; Mon, 29 Sep 2025 12:08:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3JEL-0007Tm-Vk; Mon, 29 Sep 2025 15:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JEK-0007Te-5x for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JEH-0004tg-Ni for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:11 -0400 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-xjM6icFfNeWkgP7rO4g21g-1; Mon, 29 Sep 2025 15:08:07 -0400 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4de4fb840abso91322771cf.1 for ; Mon, 29 Sep 2025 12:08:06 -0700 (PDT) Received: from x1.local ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-80142f5d6d1sm79626296d6.33.2025.09.29.12.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 12:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759172888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=T9DqXVjH2DkD5d4KS2XZQjdJXJBGWn7I9ktn0HsAj8FHmXgGYWXFqDm0/+wBUK1UY0uUcy wFkkGyk/z/PjKd5E4CUg2wroJbGR9Gsx1AyKeaNTPDn0Eco4H3X6hk+c8PN0Ej0BpUy02k R3XI4u8TGWM8BnDCwbhfbnyjdWi31q8= X-MC-Unique: xjM6icFfNeWkgP7rO4g21g-1 X-Mimecast-MFC-AGG-ID: xjM6icFfNeWkgP7rO4g21g_1759172886 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759172886; x=1759777686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=l4UTuHHe3iNIDnodV+442AVJFV4/IPvJeoE8/mtHKlOl7Ukg0ImTc6UXiV9yk7iOMm R1jY7uSfcooQBTBrH6WX65GX+OVAO8xjzOnG5pQ/wd0KcDeuZodKXCeqFSHQvlRvSuLB V4TDQjp0chw0BjVIQnzMu9x3ib+xwNGJmje/hnGGvqMZFIc0OFRoNp/PXaNqn4p+gySb rTSndymkFqBhb8Q/Lch5pfYVeKPEmjh44nkT9Apyihbb7hYyId2QiuIDtmEzYwd7X0oe QbxJKkVYxKpetpOKHnll4cLYymuI3QhwZehAaP0feOUvbMDmH+LqBDUqkKcIYY3FIRfF CZSg== X-Gm-Message-State: AOJu0Yz6snHvgskwa6kvQx0jYXK040bJENyzFvkvv42crdoKSE6klwwM jvh31jh5XRXg5cmGpr50Js1rXYQvwtNhbFIHLhy+UCtIfUGvduECRWhhTqCFelksCCGgaVHPRrH uaWsbqOFqGUreqnSJZVmM+is0tQ6zvJ3364/4W2Tg9614hcbueMmohU2YtbG5VV8NtLTZ2O3em+ SfLlcoeCNBqG3UV7g0ZdpkNYUMewTJeXA6KYReuQ== X-Gm-Gg: ASbGnctM/9ATiEZPQCOeGBgp2NuzhG187C99mQTTnHFDsEitIu98lFP5z8hUmioJp8y yxdlT8+VunaQywDeaNKPQ1pVtFG5sUtRnY+dt6PSmi3kp9097ukPCv3Ow1h99IDE08mG8dIUWsE XiZA//5Y2a2YjHT0wh2J+RijCZgtsLG2yVAIb4r/QvrwSBLywsxZe/dUGZ6/6eWmooy/kUnbR4h Jqdl4THy4B8RzQbEUYGod5jb8cUIAiaVcitHVjoWj+fWAA8E3hRrZ9ljwBO3VKprcUQwo4KJd94 UrR8ibrf6sDoNfmOC/S9KSsHw21xdPex X-Received: by 2002:a05:622a:311:b0:4b5:dc4f:7d67 with SMTP id d75a77b69052e-4e27f5228a8mr21018361cf.27.1759172885862; Mon, 29 Sep 2025 12:08:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPZjpvvOsystAqiLGeUBCYXzdPNH4TzWaN0T5jfauJtTgSKDZ4Dx51vb/N2Hg6+qjvy03scw== X-Received: by 2002:a05:622a:311:b0:4b5:dc4f:7d67 with SMTP id d75a77b69052e-4e27f5228a8mr21017781cf.27.1759172885262; Mon, 29 Sep 2025 12:08:05 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Peter Maydell , Richard Henderson , "Emilio G . Cota" , peterx@redhat.com Subject: [PATCH 2/3] tests/test-rcu-*: Zero-initialize allocated elements Date: Mon, 29 Sep 2025 15:08:00 -0400 Message-ID: <20250929190801.931989-3-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250929190801.931989-1-peterx@redhat.com> References: <20250929190801.931989-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759172931121116600 Content-Type: text/plain; charset="utf-8" QEMU almost always do this, so do it too with the RCU unit tests. It's preparation work to start asserting on possible rcu double free. Signed-off-by: Peter Xu --- tests/unit/test-rcu-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-rcu-list.c b/tests/unit/test-rcu-list.c index 8f0adb8b00..853c9e33d9 100644 --- a/tests/unit/test-rcu-list.c +++ b/tests/unit/test-rcu-list.c @@ -233,7 +233,7 @@ static void *rcu_q_updater(void *arg) TEST_LIST_FOREACH_RCU(el, &Q_list_head, entry) { j++; if (target_el =3D=3D j) { - struct list_element *new_el =3D g_new(struct list_element,= 1); + struct list_element *new_el =3D g_new0(struct list_element= , 1); n_nodes_local++; TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry); break; @@ -259,7 +259,7 @@ static void rcu_qtest_init(void) nthreadsrunning =3D 0; srand(time(0)); for (i =3D 0; i < RCU_Q_LEN; i++) { - new_el =3D g_new(struct list_element, 1); + new_el =3D g_new0(struct list_element, 1); TEST_LIST_INSERT_HEAD_RCU(&Q_list_head, new_el, entry); } qemu_mutex_lock(&counts_mutex); --=20 2.50.1 From nobody Fri Nov 14 23:27:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759172930; cv=none; d=zohomail.com; s=zohoarc; b=SM+8C1R2rzTuYld9vd+xTXydA7RKeN3Wkxx2iGFQdXvsoBcGyydLH4i9VC7kbz7g07gDRQkCwAbWzeAZeJyDtqD5EwM95C0LjufEx++MLoEgb0K5JK9/ySaufeAvyOjKLgJ+YCIpAKy9EDvlCPI0n75JwYBCNz3a5mliQh5NdKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759172930; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rajHt1rQETy/sbQa2hhoaq4bHcPDcuCq1ZBhR4uILPE=; b=UfulqDKj9hfo9VlvOSqq7xBKQxzSAPQk5ZO14yvbhGQu0KBiNrxj1cnyZEmCF6DGD2xTIJCI3kD+Lao7rdmlb9FK5KYjDwha9/jyx0l25PACFK7rNQV+v2pEFeMQeJeJ+fA/48ZF8U3wXACtBM+3tKp6HPBrQFZEMogpqUZ91bQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759172930099621.7056872884804; Mon, 29 Sep 2025 12:08:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3JEY-0007VV-2o; Mon, 29 Sep 2025 15:08:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JER-0007VF-9P for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3JEJ-0004u9-HX for qemu-devel@nongnu.org; Mon, 29 Sep 2025 15:08:18 -0400 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-mN_4f87mN3O-k9jfudBdJg-1; Mon, 29 Sep 2025 15:08:08 -0400 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-78f2b1bacfcso87230296d6.3 for ; Mon, 29 Sep 2025 12:08:08 -0700 (PDT) Received: from x1.local ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-80142f5d6d1sm79626296d6.33.2025.09.29.12.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 12:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759172889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rajHt1rQETy/sbQa2hhoaq4bHcPDcuCq1ZBhR4uILPE=; b=E3CPIUX3mnU2Kwypa+1uXJuPJJpwZyw1QMybIL6+6c+SpnowelvisiP+gxZXzcsUKEBY9/ HWhXbuP1of2YB/dS75inO63FXTbaWX+8AHnlw24Wga+Et6nPIJBlZ0TkjYUFEa0s/Ndp3V Puo6m7gP8/zexBjBl6JT0e94M2l8MAA= X-MC-Unique: mN_4f87mN3O-k9jfudBdJg-1 X-Mimecast-MFC-AGG-ID: mN_4f87mN3O-k9jfudBdJg_1759172887 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759172887; x=1759777687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rajHt1rQETy/sbQa2hhoaq4bHcPDcuCq1ZBhR4uILPE=; b=VS3ZV+CVg7VlmtUijzNRS2cqx19Y83FZuvbHayIgqB9KkOGIYkcZa4UySNN9Yu/aL1 UZvZrVqsSoTxvSoP4Phd0vFpCYOyhLr7i2EVJbQSP1XTF8llFhtSYiLOBHfoh2eIMo7o R7YhYLradvusoxJwo4DkQ6nkBoKDxTYk7iyOwti+uY4xp71PZJ/xGDrtfEXzwTKN7oFI zI6FHF9XJhKG6ec+pCjeakpOzp8Ye9a3RcjyCfspAhD/PfupnLfL/P6x6l/f8HKHiCPK akqCslzKHKFONuBt08tuDU/CiPqon8+2SIXLwNK6fDTfYTV0MxZFw2RaWgeWWFJhNtNt j3KQ== X-Gm-Message-State: AOJu0YyXE9kMbvtHglgjsPrvuuHLblDTXqOdFqghI83S6NhyoFbceMK5 Hep85FLH105K/qYqrNHnfIu2ymDkQ2ktshCLCB8AyyniRDcLYrM7zMHMoFmlsP4/ePhuI8x5aKj kD2gWKk6DBsCatxmj8/Dfw51CQur1UdwVIgfjmS6TG9lG/7XdOXECYv3sOiD+3Of1IfQHny4bKp xgzYcqDZbOocDMTsMgelOfFhc1yWExQMRfWxGfMg== X-Gm-Gg: ASbGncvj8lj+prf2G9M4ysh5IZWdF35ZdRUbyR85hKLsgPhB9U2AwSz2k0XsE9GP89W mEop5Ork9ZMJlv1oxzjSId/iTKZ+vijO5NyWzoxK7uGUWzAwbzYO6rmAXG4ipyYTMKZ8QEkojU/ vAseXhL1zbFjMaTfOeottyTpM6KhwMXw8pRrL3GQQAwxnuRVfCEV2RL4Smnfr4KcruV1LUhvIWB qIBdI/fUjuUFLh6/63DOFLZXBoSF63D9o57qxXdGdZJi5UJXjUTbCPFG3PwLAtC9gHItAreUaiE WxM6Pv+tOH5njVdxnUZ48a5f1SOjhhLS X-Received: by 2002:ad4:5c47:0:b0:7e3:4084:fcbe with SMTP id 6a1803df08f44-7fc2d9ebe2dmr264588356d6.19.1759172887107; Mon, 29 Sep 2025 12:08:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgaqs6QVjVe746cEYMJ1XKe14RcF5Mt0zm6vEYdOCadsljhqeWJyIzmVy9n8QhnbURGNs/yQ== X-Received: by 2002:ad4:5c47:0:b0:7e3:4084:fcbe with SMTP id 6a1803df08f44-7fc2d9ebe2dmr264587596d6.19.1759172886490; Mon, 29 Sep 2025 12:08:06 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Peter Maydell , Richard Henderson , "Emilio G . Cota" , peterx@redhat.com Subject: [PATCH 3/3] rcu: Avoid double rcu frees Date: Mon, 29 Sep 2025 15:08:01 -0400 Message-ID: <20250929190801.931989-4-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250929190801.931989-1-peterx@redhat.com> References: <20250929190801.931989-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759172931057116600 Content-Type: text/plain; charset="utf-8" Trap call_rcu1() to make sure it won't be invoked twice for one rcu head. Suggested-by: Peter Maydell Signed-off-by: Peter Xu --- util/rcu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rcu.c b/util/rcu.c index b703c86f15..9272fe5796 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -307,6 +307,8 @@ static void *call_rcu_thread(void *opaque) =20 void call_rcu1(struct rcu_head *node, void (*func)(struct rcu_head *node)) { + /* Avoid double rcu frees */ + assert(node->func =3D=3D NULL); node->func =3D func; enqueue(node); qatomic_inc(&rcu_call_count); --=20 2.50.1