From nobody Sat Nov 15 00:05:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759164889; cv=none; d=zohomail.com; s=zohoarc; b=GZyv/1xlm80YYhF31UhAACI5y4L6dwXaoYZPCQ0PpAQB/Rfn1nwonOcYC7ddbTZB/i6v7CRtAEK7FvKyYkT2olNA2z26AaBalN5KJSU2OlQZn36xLtmqG8SsgKB+SZ3AiK2HQCtXvWN9SUvv57s/2J4JBYxx1DHB8cJ2vE0s0/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759164889; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZhN+iR+ZF390fWQx/ABQD5ZU0M8Wt8Fgfqh6Toezzfg=; b=kc1GIPSrVVvvik+W5JeevXIjHNnKx/bxe9hSagBJ+os6d57fYtnWILo+TSymwjLmA3yDa3aDIA7s5oT0IkZ1fn4jQTK2OJDtJIBqgxEHe4LYtnJbE7fki5ELPHWnVpOWTKs7pdYl6w2yHSCoYk/tFf02iO+eD5hi74EkdOyqFxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759164889856540.3204661452816; Mon, 29 Sep 2025 09:54:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3H8A-0003IE-Hz; Mon, 29 Sep 2025 12:53:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3H7R-0002pB-MB for qemu-devel@nongnu.org; Mon, 29 Sep 2025 12:52:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3H7N-0002lP-QX for qemu-devel@nongnu.org; Mon, 29 Sep 2025 12:52:57 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-3lzaumJ_PMaAlBusMqgq1A-1; Mon, 29 Sep 2025 12:52:49 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 125A518005BE; Mon, 29 Sep 2025 16:52:46 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.27]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DDC081800577; Mon, 29 Sep 2025 16:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759164772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZhN+iR+ZF390fWQx/ABQD5ZU0M8Wt8Fgfqh6Toezzfg=; b=NbmoygWIgNnM8Z6K+iYlkOTuftoB50CsGihZM939Sy+YVIFN35SMqpA+wQzwYipc2GAL1X 8K+L6RRn/dtwIei/3tbdi4cpgqs8pwWLHo8VpbtMFlIrGfQBm6tNvyN4TU8fMym5DzztZM flHeMlpzun/BP/5Zgn/of1lE26XiQF0= X-MC-Unique: 3lzaumJ_PMaAlBusMqgq1A-1 X-Mimecast-MFC-AGG-ID: 3lzaumJ_PMaAlBusMqgq1A_1759164768 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane-Chen-AS , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 04/32] hw/nvram/aspeed_otp: Add 'drive' property to support block backend Date: Mon, 29 Sep 2025 18:52:02 +0200 Message-ID: <20250929165230.797471-5-clg@redhat.com> In-Reply-To: <20250929165230.797471-1-clg@redhat.com> References: <20250929165230.797471-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759164892238116600 From: Kane-Chen-AS This patch introduces a 'drive' property to the Aspeed OTP device, allowing it to be backed by a block device. Users can now preload OTP data via QEMU CLI using a block backend. Example usage: ./qemu-system-arm \ -blockdev driver=3Dfile,filename=3Dotpmem.img,node-name=3Dotp \ -global aspeed-otp.drive=3Dotp \ ... If the drive is provided, its content will be loaded as the initial OTP state. Otherwise, an internal memory buffer will be used. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20250812094011.2617526-5-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/nvram/aspeed_otp.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/nvram/aspeed_otp.c b/hw/nvram/aspeed_otp.c index e5b7ca96767c..abb37318231b 100644 --- a/hw/nvram/aspeed_otp.c +++ b/hw/nvram/aspeed_otp.c @@ -35,13 +35,25 @@ static bool aspeed_otp_init_storage(AspeedOTPState *s, = Error **errp) { uint32_t *p; int i, num; + uint64_t perm; =20 + if (s->blk) { + perm =3D BLK_PERM_CONSISTENT_READ | + (blk_supports_write_perm(s->blk) ? BLK_PERM_WRITE : 0); + if (blk_set_perm(s->blk, perm, BLK_PERM_ALL, errp) < 0) { + return false; + } + if (blk_pread(s->blk, 0, s->size, s->storage, 0) < 0) { + error_setg(errp, "Failed to read the initial flash content"); + return false; + } + } else { num =3D s->size / sizeof(uint32_t); p =3D (uint32_t *)s->storage; for (i =3D 0; i < num; i++) { p[i] =3D (i % 2 =3D=3D 0) ? 0x00000000 : 0xFFFFFFFF; } - + } return true; } =20 @@ -75,6 +87,7 @@ static void aspeed_otp_realize(DeviceState *dev, Error **= errp) =20 static const Property aspeed_otp_properties[] =3D { DEFINE_PROP_UINT64("size", AspeedOTPState, size, 0), + DEFINE_PROP_DRIVE("drive", AspeedOTPState, blk), }; =20 static void aspeed_otp_class_init(ObjectClass *klass, const void *data) --=20 2.51.0