From nobody Sun Sep 28 15:27:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1759049813; cv=none; d=zohomail.com; s=zohoarc; b=kIpVvJowICyLskIsTRD44fiuB9nWWgu9X0ezyoon35n9JRotYYdxCpE39FKcnIgh6fh6+wAqTjkUSV30+428bEtxO4Dtc4jrENXduhnYt1ap5mGn8NyziN+TNLcZIPcSOBxkXamEGTyPcIcrgbFtVlgyeWBS2HqSQE6mr+LuQG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759049813; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JJgDRg/qY6KbH78bXm9CCvJPA6fsm980NVa1KiLt4Uk=; b=c8N7y+j1bNoXPmNJVper6L6fLv/zl5jJ/33axVn+XRaPAFo07tgCsZSkNTvIKUGDkAB/WMeU3tNxiY0nae06FRj3Lo98Wwy8PRH1UdDNjBG11i6aKqaydxyeKh/DGG6XVoKWlliYhrkBRIQazU3DVwW/UQs5xfKqeMXzwWMPs3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759049812816616.8237177915463; Sun, 28 Sep 2025 01:56:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v2nC2-0006Ri-90; Sun, 28 Sep 2025 04:55:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v2nC0-0006RJ-ST for qemu-devel@nongnu.org; Sun, 28 Sep 2025 04:55:40 -0400 Received: from mgamail.intel.com ([192.198.163.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v2nBm-00045O-Lh for qemu-devel@nongnu.org; Sun, 28 Sep 2025 04:55:39 -0400 Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2025 01:55:20 -0700 Received: from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2025 01:55:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759049727; x=1790585727; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1bPMtFRL3YYOPfBbPcLgkc9GDo/yeMUTGUUDeY1Ngok=; b=aXyPVoPNPKjlIZYcTwa6njqorEAuOe6wgvtEzwEbJAFXYyCq98F1Mdun QrevVI2gxxVCaneO3EANIockvDwt32Dpb/xurr0j+mmKCfmRWVukdCW8a kwmXN8iPeVZIG1FIDb73bPvlUTTj5Ck7t4UgV08tBJvd5Ngbt1a1bJ2RI Szu+WnDow6Ez2OLON7VU1fzO31fVkxXKVGGevcd5TCNnIB74YAYhB8BL6 CgMHBsqk/eRyqPy18SUKS/UgS4Ljqf8ZUbrBvtNLPIZQ+xx6O08YAlui9 ujGXNT7Au6wGIBS3K886dx1+oibJO2F+hSBPNvE5bx20nyd4a4Y28sMV6 Q==; X-CSE-ConnectionGUID: Ylmka4j1SAiAaScEaFSKWw== X-CSE-MsgGUID: ZCITI5h1Q+eHOLf2gqQc0Q== X-IronPort-AV: E=McAfee;i="6800,10657,11566"; a="65167433" X-IronPort-AV: E=Sophos;i="6.18,299,1751266800"; d="scan'208";a="65167433" X-CSE-ConnectionGUID: OrNMCXMPTI26irWx+yq3tw== X-CSE-MsgGUID: 0IgDBlKrQ4GEUo0JJUbxEw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,299,1751266800"; d="scan'208";a="177810804" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, clg@redhat.com, eric.auger@redhat.com, steven.sistare@oracle.com, Zhenzhong Duan Subject: [PATCH v2 2/6] vfio/cpr-legacy: drop an erroneous assert Date: Sun, 28 Sep 2025 04:54:28 -0400 Message-ID: <20250928085432.40107-3-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250928085432.40107-1-zhenzhong.duan@intel.com> References: <20250928085432.40107-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.12; envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1759049814582116600 Content-Type: text/plain; charset="utf-8" vfio_legacy_cpr_dma_map() is not only used in post_load on destination but also error recovery path on source side. Assert it for destination is wrong. Fixes: 7e9f21411302 ("vfio/container: restore DMA vaddr") Signed-off-by: Zhenzhong Duan Reviewed-by: Steve Sistare --- hw/vfio/cpr-legacy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/vfio/cpr-legacy.c b/hw/vfio/cpr-legacy.c index 9a37e8c604..c2b81f4a4b 100644 --- a/hw/vfio/cpr-legacy.c +++ b/hw/vfio/cpr-legacy.c @@ -52,8 +52,6 @@ static int vfio_legacy_cpr_dma_map(const VFIOContainer *b= container, .size =3D size, }; =20 - g_assert(cpr_is_incoming()); - if (ioctl(container->fd, VFIO_IOMMU_MAP_DMA, &map)) { return -errno; } --=20 2.47.1