From nobody Sun Sep 28 15:25:46 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758895472; cv=none; d=zohomail.com; s=zohoarc; b=KT6EsPSn7Oqgnt7dxmXbRkzXx40JkrWpcCifG0r3/KHcFh4HCJpG+5T68gOGn/BZBuTbX401zbY1DxPpI9BvXPxAclkc77PMyFAOmB+nFDD9cAwwEXtOm0EtTkkzPAgmytnqnt21GLX7qAnTjr/240GIYoR58einz3x8DYvztYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758895472; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/1fRLQrqxZfLB+FGX2nC7+cCfne6Mu6ri4hCnmmDcFo=; b=mL4t8yFjF0UFdWXu/pK2UPbmTMAREOFcr0qGZJg+/XXO7RMbUv015dkrDtPnA03SO1E0XiHffNebOSPDSo4LIAidm2Hp3iVj1ruhcXEbMs8DGG9JZLNwGqR75/i1nPfQeVDwzCJkfWALgmlDUSFQo4U0W28TUbbLLlhBLYGRhBw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758895472634344.0927643700843; Fri, 26 Sep 2025 07:04:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v292C-000698-HE; Fri, 26 Sep 2025 10:02:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v2924-00066m-14 for qemu-devel@nongnu.org; Fri, 26 Sep 2025 10:02:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v291w-0004eG-54 for qemu-devel@nongnu.org; Fri, 26 Sep 2025 10:02:43 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-GtX-qUn-OpixKNw8q339Jw-1; Fri, 26 Sep 2025 10:02:30 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ADBC71800285; Fri, 26 Sep 2025 14:02:29 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.175]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 090A81956095; Fri, 26 Sep 2025 14:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758895352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/1fRLQrqxZfLB+FGX2nC7+cCfne6Mu6ri4hCnmmDcFo=; b=WGGynUp1QjXpnoPxzB6NQj3cF0CCIg7shjitBSPMv9yfNscbb+otpjEIFIrB3Ualt2+8Kz UzHXkYTEUSiQl9n+pRf2MIsnpVmW7zcKzrDhHLzEItWdHpevT1o6ElKrtbRla7E7tiMtTz dOw8n6EG4dCkT8mfxYzyZmgc1qEuO+s= X-MC-Unique: GtX-qUn-OpixKNw8q339Jw-1 X-Mimecast-MFC-AGG-ID: GtX-qUn-OpixKNw8q339Jw_1758895349 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Markus Armbruster , Paolo Bonzini , "Michael S. Tsirkin" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 08/32] system: check security of device types Date: Fri, 26 Sep 2025 15:01:19 +0100 Message-ID: <20250926140144.1998694-9-berrange@redhat.com> In-Reply-To: <20250926140144.1998694-1-berrange@redhat.com> References: <20250926140144.1998694-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.446, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758895474040116600 This wires up the DeviceClass types to have their security checked when devices are created. Signed-off-by: Daniel P. Berrang=C3=A9 --- system/qdev-monitor.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 2ac92d0a07..520fe5c495 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -43,6 +43,8 @@ #include "hw/qdev-properties.h" #include "hw/clock.h" #include "hw/boards.h" +#include "qapi/compat-policy.h" + =20 /* * Aliases were a bad idea from the start. Let's keep them @@ -644,6 +646,13 @@ DeviceState *qdev_device_add_from_qdict(const QDict *o= pts, return NULL; } =20 + if (!compat_policy_check_security(&compat_policy, + object_class_get_name(OBJECT_CLASS(d= c)), + object_class_is_secure(OBJECT_CLASS(= dc)), + errp)) { + return NULL; + } + /* find bus */ path =3D qdict_get_try_str(opts, "bus"); if (path !=3D NULL) { --=20 2.50.1