From nobody Sun Sep 28 17:02:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1758870866; cv=pass; d=zohomail.com; s=zohoarc; b=NMR3POrLIa6hsmsBt5KAhzNUkfI1+2fAQCESAudSOf7eF2YfCWdo5ype4uYg5u2mPIW2NaM11zvUeJSMZ5C4voIyZ2NPtl5gL7lN/u8zm8v5FnrqHp4VXjD0Rv101ur7Qh+tiS0MDYRwSL/uDFAZy/iLWSvhko6k6QAWobGbhQU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758870866; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1No14uufmwwp5G9V0a8LeBj83CWRkmx5IinZPAqDAU4=; b=dZ904I47SFNSiGD9tsHmts8N0IkPGNFSeGQPYHL94/57yFU5fSwPoVYwHWnbaTS3PYi6L9JTXUud1yNsWx3Ygvf9AtVt+CKoIlbm6hiUqUUpFTjFYLLC7U0dAt4zJYamW+O90stk86DoOeou1Ruln8BZ89CJQbgzpdkvdzcAV5I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758870866008460.22094364932764; Fri, 26 Sep 2025 00:14:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v22Zt-0006Gj-HB; Fri, 26 Sep 2025 03:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v22Zm-0006Eo-6j; Fri, 26 Sep 2025 03:09:07 -0400 Received: from mail-westusazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c000::1] helo=BYAPR05CU005.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v22ZW-0006YX-SZ; Fri, 26 Sep 2025 03:09:03 -0400 Received: from DS7PR06CA0003.namprd06.prod.outlook.com (2603:10b6:8:2a::27) by DM4PR12MB6301.namprd12.prod.outlook.com (2603:10b6:8:a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.10; Fri, 26 Sep 2025 07:08:39 +0000 Received: from DS2PEPF00003447.namprd04.prod.outlook.com (2603:10b6:8:2a:cafe::57) by DS7PR06CA0003.outlook.office365.com (2603:10b6:8:2a::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.11 via Frontend Transport; Fri, 26 Sep 2025 07:08:38 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by DS2PEPF00003447.mail.protection.outlook.com (10.167.17.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Fri, 26 Sep 2025 07:08:38 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Fri, 26 Sep 2025 00:08:27 -0700 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 26 Sep 2025 02:08:27 -0500 Received: from XFR-LUMICHEL-L2.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 26 Sep 2025 00:08:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WUUED2nla6tD5aYn0VXexEPIKGI9VYnkb9sP6MEussxlzWRiH7vpLky8ZBDvBMFKncsIE5uZ32OZcv47uO7EsD+oYTHQigB2TPTJzkoVkVJokYkqjjEUMUecTCcHAaBiZkOWYX/NsZ1K1QTCItGaA8lPSTk7Q6SyJT9gtOT9ovQH4ZKaOqQwnRYt2QYRIdDLyhy6EiFulcpec70iRgMTtf6zaBTSjr+tQeKAJo8vqTEIfFJpD04xTO1bOvKjiKhPZ71JsjeZnT9RHdJHUpvoeJIhqZkE2c9/F7QgWklc4bWQPJgTVrcPhLFbHxTKvgbxR8JPY8CaMKC/oCBlZU606g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1No14uufmwwp5G9V0a8LeBj83CWRkmx5IinZPAqDAU4=; b=eEIOGxF261k4KL377YtoBfzlh8KwF5RYViX+42pbfhUA+omfjQentCMtsHNu0okksuR4n6ivn4IosgQulHM7iipVfJH3bab8UuCgpPdTN0+ss2f0ho3+X9D6gSAEfJPQVESf4veBqST0DCxYCtG0n587+64Ev8xmAESRBTwdgtNZAyp38jzmUFtHcZYhb4QMH61BFOP9hp1bCw8FTtodOr//vYsk9UEGXJlEVX1PExNLEnFx4NJXvz/Zj8ks48HFy19iZVAR6xCaxVcw5GUj8PUuErQp39qJTUWPZ2fm75ZboP292rxay0BC6nPYLEanAcJ9rryPtoZZATkObMpaaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1No14uufmwwp5G9V0a8LeBj83CWRkmx5IinZPAqDAU4=; b=qoyhDA3DQcEpByx05Oa1jBrmC/AC9Ftq+3jLKs1RvB8547HvQypED9qpE8Kxvo8cFg3ch3WbbWDL8hY6MSrSdfT+2hRuug+4FWfW0v8iWn2tjK885VevqLVKB8Xnxq12XAnFzwBLoAAb+r9cwSgXZGr0CBwrQPVguKhG46NokeU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Luc Michel To: , CC: Luc Michel , Peter Maydell , Francisco Iglesias , "Edgar E . Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , "Frederic Konrad" , Sai Pavan Boddu Subject: [PATCH v6 08/47] hw/arm/xlnx-versal: xram: refactor creation Date: Fri, 26 Sep 2025 09:07:26 +0200 Message-ID: <20250926070806.292065-9-luc.michel@amd.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250926070806.292065-1-luc.michel@amd.com> References: <20250926070806.292065-1-luc.michel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003447:EE_|DM4PR12MB6301:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f87592d-f4c1-410b-463b-08ddfccb849c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Y/979NTQTvAOgdC61RddVGXwHIBNVEgD6cPixMf05issIaUgUmOWtTeVyF/4?= =?us-ascii?Q?JyyaZ2PCREwPBh3qCs4zi/bwmptWAfchKX2C1W5NsNjxI82fNtwYZ6X1Xku2?= =?us-ascii?Q?fY4AurHljfNyiNClcJO9S5hpKxrAtGucZY0sMDhIWGvLJSSTpSlVBcCrWrKN?= =?us-ascii?Q?HSokdxw5Mdrfy5xrSwIq5XKI8LbPZkX63TR4yUBv+zgMTDthasc27oIA3qI0?= =?us-ascii?Q?HZH+BpWoFFlrUblJhT9LeyeCkuazL4S1vK1eXBqFu1GabEUV6erYQQryvVPs?= =?us-ascii?Q?nOd3EeaMSHngt900jINizElHXoLvdK+CVO3AyWyW+bjN84ierQoUgdajUdNo?= =?us-ascii?Q?NG0ZcQ8tmah8B+lQY2dQovkrH1JnfSDpRvfjCOWks7XtepvW+/ufPpQcp7Cp?= =?us-ascii?Q?UuEu5eluUCTRhWaEw7DvZ08S9E+0u4CRtVdl2yxgAuLEOhuwZv0sk17WOotu?= =?us-ascii?Q?lSaAtJwpZRvu2Oew4UwFB/c1uoWGVXUVMAlrGLjm4rS5HeWt4US4Y2iJ1iGi?= =?us-ascii?Q?1SeFKaXk3ZO/q5gAiDzsjejHEObLoyZerRCBTzkuEMTERlv9qgAQD1wWHht9?= =?us-ascii?Q?dXzFuAYq5C1qfjmOHUbFPH6EHjL7i03G8QBBepKL/IpMuajz7Aw+wayBoC/8?= =?us-ascii?Q?1PD+9Fa1bxku7/aYIDj4LbpnQCLWKGcxPmlwByGgM6487KBIEiDhkKJ0msaJ?= =?us-ascii?Q?WYvIRwMZ0vuT3KyP9Epw9JH6nZ23jSf6VMzAz3T6eWMLQPLePuD/VTHoB/vD?= =?us-ascii?Q?mrQi5WHJk1PSZfgU2nZjuJzSr9X/Y1sfYNFM6PcVUTxUfUifT006KZw2kVwz?= =?us-ascii?Q?zbwycp4J4fZ+YevqaDCzVLbF4rhls04lLuz6etKWnbrf2SBTq/wYTR8Kix47?= =?us-ascii?Q?AnJCM33RU3NNDx8uDrwxEISx3cVMkCosIusdGuqALqadszN//wRjNIcXT8Io?= =?us-ascii?Q?3WaYvppsk1CEi9GmD3lrniduqN0jN4t4LKa6KAdaOBKIIx/HCVCYxxBb6OCw?= =?us-ascii?Q?Q80UhIkVCihWXdmddwdByG6Bcp/YllnDN7njTuMmp6GNG4CUcrVnGaXs40lc?= =?us-ascii?Q?27pwmbic6nldDPnJ3PA6vjAzJlIMNclX5Eayy+hw5hfHXKZ0h87RRYfKj07f?= =?us-ascii?Q?PpgX40StfOEIpglNwry2Oy3N/nM//4HOLstcTJbhswIjD6yAJO/LOy8nwm5M?= =?us-ascii?Q?IZWUYHa3SMtuPZVOHd3NbQ65IlIFADFWKpCk/qOVWeKjUuas5Y0WRbfQ0yE1?= =?us-ascii?Q?GtHXoeLxVd+PP7s7enOrOx41ttkab1RpXnUBMQgBFqPFYItTTSGuYP0WIDcW?= =?us-ascii?Q?6uWXuUGR/gNlSylKzYRjGxGpi9hAB0cc37p73raPTbB1KMbM0MfzDsYQwEv5?= =?us-ascii?Q?h6VJb95/+QqPPsW7RoJm48un+pCkdcYcbbpiwHMZgG80lcFOZldLd/KwZTvZ?= =?us-ascii?Q?BcNsJZ1LimTqZIY1DfJW1EXN4FBO1uSfEfUwlHNO3tDMsln7A2Xa1pUQLP55?= =?us-ascii?Q?8tbCdsJuzuWyXU6cIBl9Az9CxFw6DRN1ouWz?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 07:08:38.9062 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f87592d-f4c1-410b-463b-08ddfccb849c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003447.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6301 Received-SPF: permerror client-ip=2a01:111:f403:c000::1; envelope-from=Luc.Michel@amd.com; helo=BYAPR05CU005.outbound.protection.outlook.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1758870866721116600 Content-Type: text/plain; charset="utf-8" Refactor the XRAM devices creation using the VersalMap structure. Signed-off-by: Luc Michel Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- include/hw/arm/xlnx-versal.h | 6 ---- hw/arm/xlnx-versal.c | 59 +++++++++++++++++++++--------------- 2 files changed, 35 insertions(+), 30 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h index 4eeea98ff34..71c3314b8b4 100644 --- a/include/hw/arm/xlnx-versal.h +++ b/include/hw/arm/xlnx-versal.h @@ -18,11 +18,10 @@ #include "hw/or-irq.h" #include "hw/intc/arm_gicv3.h" #include "hw/rtc/xlnx-zynqmp-rtc.h" #include "qom/object.h" #include "hw/usb/xlnx-usb-subsystem.h" -#include "hw/misc/xlnx-versal-xramc.h" #include "hw/nvram/xlnx-bbram.h" #include "hw/nvram/xlnx-versal-efuse.h" #include "hw/ssi/xlnx-versal-ospi.h" #include "hw/dma/xlnx_csu_dma.h" #include "hw/misc/xlnx-versal-crl.h" @@ -86,15 +85,10 @@ struct Versal { =20 CPUClusterState cluster; ARMCPU cpu[XLNX_VERSAL_NR_RCPUS]; } rpu; =20 - struct { - OrIRQState irq_orgate; - XlnxXramCtrl ctrl[XLNX_VERSAL_NR_XRAM]; - } xram; - XlnxVersalCRL crl; } lpd; =20 /* The Platform Management Controller subsystem. */ struct { diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 5c2bd4be1f7..295fca3d60d 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -29,10 +29,11 @@ #include "hw/char/pl011.h" #include "hw/net/xlnx-versal-canfd.h" #include "hw/sd/sdhci.h" #include "hw/net/cadence_gem.h" #include "hw/dma/xlnx-zdma.h" +#include "hw/misc/xlnx-versal-xramc.h" =20 #define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72") #define XLNX_VERSAL_RCPU_TYPE ARM_CPU_TYPE_NAME("cortex-r5f") #define GEM_REVISION 0x40070106 =20 @@ -69,10 +70,18 @@ typedef struct VersalMap { uint64_t chan_stride; int irq_stride; } zdma[2]; size_t num_zdma; =20 + struct VersalXramMap { + uint64_t mem; + uint64_t mem_stride; + uint64_t ctrl; + uint64_t ctrl_stride; + int irq; + size_t num; + } xram; } VersalMap; =20 static const VersalMap VERSAL_MAP =3D { .uart[0] =3D { 0xff000000, 18 }, .uart[1] =3D { 0xff010000, 19 }, @@ -90,10 +99,17 @@ static const VersalMap VERSAL_MAP =3D { .gem[1] =3D { { 0xff0d0000, 58 }, 2, "rgmii-id", 1000 }, .num_gem =3D 2, =20 .zdma[0] =3D { "adma", { 0xffa80000, 60 }, 8, 0x10000, 1 }, .num_zdma =3D 1, + + .xram =3D { + .num =3D 4, + .mem =3D 0xfe800000, .mem_stride =3D 1 * MiB, + .ctrl =3D 0xff8e0000, .ctrl_stride =3D 0x10000, + .irq =3D 79, + }, }; =20 static const VersalMap *VERSION_TO_MAP[] =3D { [VERSAL_VER_VERSAL] =3D &VERSAL_MAP, }; @@ -639,41 +655,35 @@ static void versal_create_trng(Versal *s, qemu_irq *p= ic) mr =3D sysbus_mmio_get_region(sbd, 0); memory_region_add_subregion(&s->mr_ps, MM_PMC_TRNG, mr); sysbus_connect_irq(sbd, 0, pic[VERSAL_TRNG_IRQ]); } =20 -static void versal_create_xrams(Versal *s, qemu_irq *pic) +static void versal_create_xrams(Versal *s, const struct VersalXramMap *map) { - int nr_xrams =3D ARRAY_SIZE(s->lpd.xram.ctrl); - DeviceState *orgate; - int i; + SysBusDevice *sbd; + MemoryRegion *mr; + DeviceState *or; + size_t i; =20 - /* XRAM IRQs get ORed into a single line. */ - object_initialize_child(OBJECT(s), "xram-irq-orgate", - &s->lpd.xram.irq_orgate, TYPE_OR_IRQ); - orgate =3D DEVICE(&s->lpd.xram.irq_orgate); - object_property_set_int(OBJECT(orgate), - "num-lines", nr_xrams, &error_fatal); - qdev_realize(orgate, NULL, &error_fatal); - qdev_connect_gpio_out(orgate, 0, pic[VERSAL_XRAM_IRQ_0]); + or =3D create_or_gate(s, OBJECT(s), "xram-orgate", map->num, map->irq); =20 - for (i =3D 0; i < ARRAY_SIZE(s->lpd.xram.ctrl); i++) { - SysBusDevice *sbd; - MemoryRegion *mr; + for (i =3D 0; i < map->num; i++) { + hwaddr ctrl, mem; =20 - object_initialize_child(OBJECT(s), "xram[*]", &s->lpd.xram.ctrl[i], - TYPE_XLNX_XRAM_CTRL); - sbd =3D SYS_BUS_DEVICE(&s->lpd.xram.ctrl[i]); - sysbus_realize(sbd, &error_fatal); + sbd =3D SYS_BUS_DEVICE(qdev_new(TYPE_XLNX_XRAM_CTRL)); + object_property_add_child(OBJECT(s), "xram[*]", OBJECT(sbd)); + sysbus_realize_and_unref(sbd, &error_fatal); + + ctrl =3D map->ctrl + map->ctrl_stride * i; + mem =3D map->mem + map->mem_stride * i; =20 mr =3D sysbus_mmio_get_region(sbd, 0); - memory_region_add_subregion(&s->mr_ps, - MM_XRAMC + i * MM_XRAMC_SIZE, mr); + memory_region_add_subregion(&s->mr_ps, ctrl, mr); mr =3D sysbus_mmio_get_region(sbd, 1); - memory_region_add_subregion(&s->mr_ps, MM_XRAM + i * MiB, mr); + memory_region_add_subregion(&s->mr_ps, mem, mr); =20 - sysbus_connect_irq(sbd, 0, qdev_get_gpio_in(orgate, i)); + sysbus_connect_irq(sbd, 0, qdev_get_gpio_in(or, i)); } } =20 static void versal_create_bbram(Versal *s, qemu_irq *pic) { @@ -1194,15 +1204,16 @@ static void versal_realize(DeviceState *dev, Error = **errp) =20 for (i =3D 0; i < map->num_zdma; i++) { versal_create_zdma(s, &map->zdma[i]); } =20 + versal_create_xrams(s, &map->xram); + versal_create_usbs(s, pic); versal_create_pmc_apb_irq_orgate(s, pic); versal_create_rtc(s, pic); versal_create_trng(s, pic); - versal_create_xrams(s, pic); versal_create_bbram(s, pic); versal_create_efuse(s, pic); versal_create_pmc_iou_slcr(s, pic); versal_create_ospi(s, pic); versal_create_crl(s, pic); --=20 2.51.0