From nobody Sun Sep 28 17:07:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1758871408; cv=pass; d=zohomail.com; s=zohoarc; b=SujpbcDHnHDMck4s0/HukSog0KXS2ZoeYD4dGo7y6jHKUeUODw1ygh2C+f9jTUat1aroe5YPTvepK3jVpJ//cjAwWYFR9IhJt7UGAXHgtQMWEKCNeOwyHArwHF5mQ9CXTnWofVPgKsX4bdglsrSaendy4fdmnk++20eiY4dWVco= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758871408; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OlTAmkKqA5TD5PwrjTbs7NSjsdUQHpoxITuTPVXDjPQ=; b=L+K1pZqURZulEXA4owSOnlQV9lQOBD0ZPKNffcKRlyXg9my8n+gAfQLRFzMu5jQ+ZHjwifbvyjfvodCzC+xyUovoxhYiYK0AlTIpNDs4RMRWztQ3e7R2jV1GZFXchm8pxN2OMg18ZKObxieJmjKMJsuBPHdsqv16n/xjLwgpUiE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17588714083637.35134108349655; Fri, 26 Sep 2025 00:23:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v22aO-0006X9-Ux; Fri, 26 Sep 2025 03:09:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v22a9-0006QM-Dk; Fri, 26 Sep 2025 03:09:29 -0400 Received: from mail-westcentralusazlp170100005.outbound.protection.outlook.com ([2a01:111:f403:c112::5] helo=CY7PR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v22Zw-0006cb-4Y; Fri, 26 Sep 2025 03:09:28 -0400 Received: from DS7PR03CA0229.namprd03.prod.outlook.com (2603:10b6:5:3ba::24) by MN2PR12MB4343.namprd12.prod.outlook.com (2603:10b6:208:26f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9; Fri, 26 Sep 2025 07:09:05 +0000 Received: from DS2PEPF00003446.namprd04.prod.outlook.com (2603:10b6:5:3ba:cafe::75) by DS7PR03CA0229.outlook.office365.com (2603:10b6:5:3ba::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.20 via Frontend Transport; Fri, 26 Sep 2025 07:09:04 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by DS2PEPF00003446.mail.protection.outlook.com (10.167.17.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Fri, 26 Sep 2025 07:09:04 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 26 Sep 2025 00:08:52 -0700 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 26 Sep 2025 00:08:52 -0700 Received: from XFR-LUMICHEL-L2.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 26 Sep 2025 00:08:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dvl/qLh8ATWztdkKQFnd3MtzJjKpWesHgx1z/I/07N3qKM4xOCJGOn3rySX5OrT2sMAKCb0xmv9ayAqwtrbUNJcDYgudGpov0GQ/83xJBo7+LaY9XIY8vfKWXRusvUpC+sLWaIpdtA4BIdTUQqN1ZNbGcfxd28Qe6WjFh/XzF6QSDpgje406yWHwmrjOwwBcu52DI8NC9bgXF8I28hT8a8xjm4VvPspz5yFmwCVmKm/exIEFnuVvIkW39E8MC+an9dqEQxVxnUoR+RWo5HB1OxIudSX2PbNq9M3DrfUvUlKZObN72RDaeAjJIljsQZr6p7FhOuoosE4jRzXuQq3O3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OlTAmkKqA5TD5PwrjTbs7NSjsdUQHpoxITuTPVXDjPQ=; b=PzmnSiKME/92k0VsMuDQ14HE8ImQ14p2KO1Tl8TgI6qyhhDsR1Dcz4hlHoOAwrD0jMYt4fRUUXLYXCHiUl+pCs2YcRzdL4kxdr61obuX2itR5ELmgrJXtvYMt7H9Jpu1/AMds0KCe7FCYsh8hWcjOG8fj5SQPbl0ZGwlbBRJkaKetCKUSjaKG9VUZAJ7CKW5kAwaX2ld5Nxx3p9AAbTthNRFCTO0ap03MHnGs4+xdxOpRdeImW5nVpST2Zx055iG1FBdHFsR+h0X1aDAFOJlJ5UK6GJmJGFxlgWFPS6RRqkav+2Do7YKg31kanxuiUXClO8GL9dn1WiHpMpdxWp/hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OlTAmkKqA5TD5PwrjTbs7NSjsdUQHpoxITuTPVXDjPQ=; b=AdrOpwbZbj7L4uVhrt5uKM+HjnctU9GXuJDixREPCTW+uWISL2NcCGw8/W3hUXmef3X6EyJ33L7O2bN4sEHAwnVROL85sXWLfWIqLIXNVKk2IEznr0YQ8EWbrgNvGKtAdTJ85nAuisuOnky7FOaK+PBct//MHg1Dfv+oKmSCZ+k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Luc Michel To: , CC: Luc Michel , Peter Maydell , Francisco Iglesias , "Edgar E . Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , "Frederic Konrad" , Sai Pavan Boddu Subject: [PATCH v6 22/47] hw/arm/xlnx-versal: instantiate the GIC ITS in the APU Date: Fri, 26 Sep 2025 09:07:40 +0200 Message-ID: <20250926070806.292065-23-luc.michel@amd.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250926070806.292065-1-luc.michel@amd.com> References: <20250926070806.292065-1-luc.michel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003446:EE_|MN2PR12MB4343:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e5b2a54-6c93-413c-e6c1-08ddfccb941b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rtyeEs9XX8rXbnlsFszSmlLQcCBXI5AHPDJ/VXmGx8TFc4Xr3Clt7t2t1MQF?= =?us-ascii?Q?o3ZnVIg1ytn1d9YCBkYaU+am251aFzjpw7H7UOJWjk4w0P6XrHC8as+2EdiN?= =?us-ascii?Q?tzyz4EFJQ0GfwwPUHFiW4BsWP5HyseJkhm3ngNgzPCYdTuhilS/e/l+Kl9fN?= =?us-ascii?Q?UhOMAmmnHsYhTg1GvxG4kvkvIVo0TZxVM0I5xiYcTLrrfyfmp1/AtvDMWy37?= =?us-ascii?Q?brLFcQOop2euASpZ6NAOTc7dsbQ4aFCMFgVJ/lR2CGHKlsWWMBSs2RlUC21u?= =?us-ascii?Q?UEGWPUMuEyPoCmJpSFGoGKaW3QVmDdrIiBt6878kU+wzP4NaIp/rgnkBR0Ox?= =?us-ascii?Q?V4jppFohY583xlslxYtlZw6wxKQULzJHx9S9aq43KJt+PKUqGGNjOpp/7WoN?= =?us-ascii?Q?lLpMV150JH/bEDwSjIU9cDsK2F3sGichWTa4EAnfDdvONFW17a14hDzm95oW?= =?us-ascii?Q?w5iezM07QVBv8am9IevOTwwiFm3FdzsTFU9i0C86hw0e5JLLnrkH5p7QmUD8?= =?us-ascii?Q?+MYwl3QY23kJX/Wank6BY1M7+4JekYlh4UY+yCXQKj2vt7TGiJ2UWaLKlekd?= =?us-ascii?Q?x6CHsdPSTvuyNNL0CjpZf0nLH8WZ0O89baWUdLM/U+n90aEF25gvGLAT+R76?= =?us-ascii?Q?aBUhWnDpyptKCTJaRmAmMVt6yTF5jKgw7/2QCCVI+bYTDuBhdw2HDJZJHSNv?= =?us-ascii?Q?3QkaqURezCOUYH6gyRYGnEXGCb+ibcYJqn/BMGVhvV2Hgvi30pyRQXQ8e1g2?= =?us-ascii?Q?tYLcbKGS+5y0mxzLQW00zPNigt8JYSL9JgP1CYM01Ltol7GcBDkg1+u+2CCC?= =?us-ascii?Q?NfIE1OxeeT/UfLIzLX4f1s50+YMmxrWFHaYrvX5hdwtofBveqOHV8b9rDLgb?= =?us-ascii?Q?D0Rkg/hF61AcuQgE6sbmG6UoKbV1vJHBkZjyz9uDflI4DaEqDuzBiaI4GKZ7?= =?us-ascii?Q?Krr771jCAkUN9sh50HmQ7Px+RCv/Q5KtObOr2YzBCr8lGj7gubWz7tl2q6Bq?= =?us-ascii?Q?qAd9hOtW2SR0pFFbS/UTGNN+4rjHdBvtcLNpI4pT6+CzjqIEFlEbfUOasUd9?= =?us-ascii?Q?FjZUWGmPdYTvL2VdNsxeNvoxQSKZFbE1AEBvnO3cfPaCGu+Bc71NNXqyLWdz?= =?us-ascii?Q?lPDbIumwgtdhItIbnPD8QW+N9VaTSRlLUNyvCe2y7EFazTNo9R0ac2SaeHuQ?= =?us-ascii?Q?JcyF0s2PIqETtrKautWrJe3iGOchUvqKsj1FSJQL+OxD5Wy7UxpbUcmN51/Z?= =?us-ascii?Q?1qAfItZmqnR5+Y/ieRY6S1Tq74BxGf8TjZu3wgWDDcE6Sg4HXNgb6shrlteX?= =?us-ascii?Q?ZLFKT03Mu0cQNHvaq7JkcfuNxap5MVNJOu7tJy6w2kBVrlhPKTtYlYFEW1at?= =?us-ascii?Q?jLZdqwJfmswfswk5IUqedMnl2AvFuTzk00yU7Ebk6kJXtrqrfQ2Lpn4dlm7W?= =?us-ascii?Q?NPmJNyMcU+vfWCjpCCFwjN8t1JDKJivOd8tOyn1M9erQazrH3CT7XQY4CWHB?= =?us-ascii?Q?IKhSxfVZC11crOdJddFCYLPxbsmaIcyFW4w9?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2025 07:09:04.9153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e5b2a54-6c93-413c-e6c1-08ddfccb941b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003446.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4343 Received-SPF: permerror client-ip=2a01:111:f403:c112::5; envelope-from=Luc.Michel@amd.com; helo=CY7PR03CU001.outbound.protection.outlook.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1758871410914116600 Content-Type: text/plain; charset="utf-8" Add the instance of the GIC ITS in the APU. Signed-off-by: Luc Michel Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal.c | 50 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index ccb78fadd7f..e03411bc212 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -42,10 +42,11 @@ #include "hw/misc/xlnx-versal-cfu.h" #include "hw/misc/xlnx-versal-cframe-reg.h" #include "hw/or-irq.h" #include "hw/misc/xlnx-versal-crl.h" #include "hw/intc/arm_gicv3_common.h" +#include "hw/intc/arm_gicv3_its_common.h" =20 #define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72") #define XLNX_VERSAL_RCPU_TYPE ARM_CPU_TYPE_NAME("cortex-r5f") #define GEM_REVISION 0x40070106 =20 @@ -70,11 +71,13 @@ typedef struct VersalSimplePeriphMap { =20 typedef struct VersalGicMap { int version; uint64_t dist; uint64_t redist; + uint64_t its; size_t num_irq; + bool has_its; } VersalGicMap; =20 enum StartPoweredOffMode { SPO_SECONDARIES, SPO_ALL, @@ -213,10 +216,12 @@ static const VersalMap VERSAL_MAP =3D { .gic =3D { .version =3D 3, .dist =3D 0xf9000000, .redist =3D 0xf9080000, .num_irq =3D 192, + .has_its =3D true, + .its =3D 0xf9020000, }, }, =20 .uart[0] =3D { 0xff000000, 18 }, .uart[1] =3D { 0xff010000, 19 }, @@ -449,10 +454,52 @@ static MemoryRegion *create_cpu_mr(Versal *s, DeviceS= tate *cluster, memory_region_add_subregion(mr, 0, root_alias); =20 return mr; } =20 +static void versal_create_gic_its(Versal *s, + const VersalCpuClusterMap *map, + DeviceState *gic, + MemoryRegion *mr, + char *gic_node) +{ + DeviceState *dev; + SysBusDevice *sbd; + g_autofree char *node_pat =3D NULL, *node =3D NULL; + const char compatible[] =3D "arm,gic-v3-its"; + + if (!map->gic.has_its) { + return; + } + + dev =3D qdev_new(TYPE_ARM_GICV3_ITS); + sbd =3D SYS_BUS_DEVICE(dev); + + object_property_add_child(OBJECT(gic), "its", OBJECT(dev)); + object_property_set_link(OBJECT(dev), "parent-gicv3", OBJECT(gic), + &error_abort); + + sysbus_realize_and_unref(sbd, &error_abort); + + memory_region_add_subregion(mr, map->gic.its, + sysbus_mmio_get_region(sbd, 0)); + + if (!map->dtb_expose) { + return; + } + + qemu_fdt_setprop(s->cfg.fdt, gic_node, "ranges", NULL, 0); + qemu_fdt_setprop_cell(s->cfg.fdt, gic_node, "#address-cells", 2); + qemu_fdt_setprop_cell(s->cfg.fdt, gic_node, "#size-cells", 2); + + node_pat =3D g_strdup_printf("%s/its", gic_node); + node =3D versal_fdt_add_simple_subnode(s, node_pat, map->gic.its, 0x20= 000, + compatible, sizeof(compatible)); + qemu_fdt_setprop(s->cfg.fdt, node, "msi-controller", NULL, 0); + qemu_fdt_setprop_cell(s->cfg.fdt, node, "#msi-cells", 1); +} + static DeviceState *versal_create_gic(Versal *s, const VersalCpuClusterMap *map, MemoryRegion *mr, size_t num_cpu) { @@ -474,10 +521,11 @@ static DeviceState *versal_create_gic(Versal *s, redist_region_count =3D qlist_new(); qlist_append_int(redist_region_count, num_cpu); qdev_prop_set_array(dev, "redist-region-count", redist_region_count); =20 qdev_prop_set_bit(dev, "has-security-extensions", true); + qdev_prop_set_bit(dev, "has-lpi", map->gic.has_its); object_property_set_link(OBJECT(dev), "sysmem", OBJECT(mr), &error_abo= rt); =20 sysbus_realize_and_unref(sbd, &error_fatal); =20 memory_region_add_subregion(mr, map->gic.dist, @@ -499,10 +547,12 @@ static DeviceState *versal_create_gic(Versal *s, GIC_FDT_IRQ_TYPE_PPI, VERSAL_GIC_MAINT_IRQ, GIC_FDT_IRQ_FLAGS_LEVEL_HI); qemu_fdt_setprop(s->cfg.fdt, node, "interrupt-controller", NULL, 0= ); } =20 + versal_create_gic_its(s, map, dev, mr, node); + return dev; } =20 static void connect_gic_to_cpu(const VersalCpuClusterMap *map, DeviceState *gic, DeviceState *cpu, size_t = idx, --=20 2.51.0