From nobody Sun Sep 28 15:25:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758769058; cv=none; d=zohomail.com; s=zohoarc; b=Lw+16oFMd0bNNZPgZ6p9RVp61+/973vpHYiNjYkD3pBkcubfAPOcdTT24U95Lm7ArRvb4B3JWtXyjZbhnznO2bYweyXnvpOzFjfp1KC2jHy/zEtsmkz0de72c6SdYmTE2sYH5z17FFTcANVtdy2sPEGd2Oe+CrJ84kkgI0qilvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758769058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=NUlHM0leEcUHy2dwNWmd+PHUarnOvfUh3/6P9RSKK6jJsKZNO4VDRQyZipxM91RZUxoEY/v7uXB6nOvTu7AoEpoJoV14P2djVncEDTLtgmLoID61GhzilYlwLx24/V1SQP5mnp8Cnlj7xXoSpuevjbZPR+K0xuNksC4STjIWfhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758769058936384.89235113316124; Wed, 24 Sep 2025 19:57:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1c92-0001xe-T0; Wed, 24 Sep 2025 22:55:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1c8z-0001ww-S9 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:41 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1c8x-0002WH-7U for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:41 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3ee130237a8so310458f8f.0 for ; Wed, 24 Sep 2025 19:55:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb74e46bcsm939728f8f.8.2025.09.24.19.55.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 19:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758768934; x=1759373734; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=NXMwhVlA2jZsZhIoG/0DOBcr1eSNbEtKg/G9n9tZ4go3CtEqAXsL6RlOOHqcmfgquu mCFnSlhmdDUeD2RldT+Y4QcJGZgMbCXD76ivtTfwH3R714ZBrRrYrXMixcUfk2nzcSvC RRIUKhn8aj79U87S4Vl0QsbKFz37PBYtvB3U530nbvFvjyM+QO1VOIoOM3K1REDveWry Jbr3mNlV0DLPqpf3tU5zrcLInSmwmUIbYrd9hGlcrRDSWb3XWCrC5mwVBs7ZtoB5CYGL 45AI9LPgsI+Rgl+dSI9+R5OVHmqVLwGAEJimhJvHOndy4izNdEXMrPItDf420co6H4IX HinA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768934; x=1759373734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=vXws8dwpFX8E/3ehasBfJrJ4TvX1OGyu5uFNDZ9ATtltCD0HvIiv3Gtvm/mu6+mD+I HRVFMl9QqqeXeLOC/6OzWSXiSp/Os95IcwvP+adPS9Bz13u4kRHZWrtOQ1U0+/TzPxYi jUlA5DeTQuynBakVF4qAuXRCvenZKxZjppths7RxxI2yiOXC6FzK0eH4lbO4Pyu6/RaB wAVzKCyBQRJlgLAnJXglU2ytz3iME8MF3FPqetGBXic8CSiAZKBtVxtnEvDp4NK6I+lw n5Nwk6iBzSov9xfi0VNBwvXdJcfHk5VnJevUkIKJQX7s3GFuF/24ozbZXk5mjmKADSpp fdGQ== X-Gm-Message-State: AOJu0YyljbYx/AsNR263Hj/YTn4ZGeRpXIgBAj3GUrQ+RZ9FTb8CfD+9 0YVB4vLJxxDepyTP43sk6wqvFnNDH9cXmJFpNlKFg3EUnd42nUWjIVcrNf/G+DS0Q613JIEfgdt 6XpIYcSnMzA== X-Gm-Gg: ASbGncvpBf1qrZr3GpMj0dU1iOtNb7SF7wvmST3HAsM3vlCn4quueFbItbrAhKCOiK2 mhYmv2gAD6pFDclaHMb2Ng9tKvY8NqFVX8yt5OtgeYxWROzobEtqKoy7S0kXazVC3lx/mC60Gpr rYxFNBu9jzNkp4+2h5Po1b2fbd17FDf5beYNJJrsz2WCYM7ytYW3Oh9T4CDghdKCcMAG/k0Ad8z Tzviejg4r/ERm/3CrorCcSWMDvvWOYs/Si5fNnB0Wl3BzIAYmHgUKTeAFPl8OclnO/ieOQtUEJu BIn6E8iy7MIQIDShBZW9mqvkOdIUuQgGi0YH2B0LuL8WUCnYf2hmBiKA+RllmOz3iqqGkOx3rUw ruGFVbUxRkSfxw5eqEH9CxTzU7KdvNoqxHZNhxL/J7xQ95WaWiqjnXXF9zYv/KQynWOjKPNeS X-Google-Smtp-Source: AGHT+IGUgr+uSOvWhJNgshrow4YUrsqarBBn7PfgQ8z4KuRBhxvHTHxpq90zU3j/a00h/1m/rIhrZQ== X-Received: by 2002:a05:6000:607:b0:3e7:451f:3a6e with SMTP id ffacd0b85a97d-40e4bff51d6mr1567732f8f.51.1758768934460; Wed, 24 Sep 2025 19:55:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis Subject: [PATCH 2/4] cpus: Access CPUState::thread_kicked atomically Date: Thu, 25 Sep 2025 04:55:17 +0200 Message-ID: <20250925025520.71805-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250925025520.71805-1-philmd@linaro.org> References: <20250925025520.71805-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758769060662116600 cpus_kick_thread() is called via cpu_exit() -> qemu_cpu_kick(), and also via gdb_syscall_handling(). Access the CPUState field using atomic accesses. See commit 8ac2ca02744 ("accel: use atomic accesses for exit_request") for rationale. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/cpus.c b/system/cpus.c index 6062226d4ac..818a8047198 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -480,10 +480,10 @@ void qemu_process_cpu_events(CPUState *cpu) =20 void cpus_kick_thread(CPUState *cpu) { - if (cpu->thread_kicked) { + if (qatomic_read(&cpu->thread_kicked)) { return; } - cpu->thread_kicked =3D true; + qatomic_set(&cpu->thread_kicked, true); =20 #ifndef _WIN32 int err =3D pthread_kill(cpu->thread->thread, SIG_IPI); --=20 2.51.0