From nobody Sun Sep 28 14:52:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758769012; cv=none; d=zohomail.com; s=zohoarc; b=WHPzFNKaGWyMzeNkHavoMKz+SGvd0LGwxS31SN+dP/8Aryl37iTH/Ce6JQ6NiTc1DbWVq8zLhffQLJBEhLqaaQPuviTwqkZQ3l5zLZvrHvkLPDlf8ofJdFr0mGOw4iZnF8CcEmdT8pkZFFjLbz4KV5egW52mEj1gFX9/oAqqXlE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758769012; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xMXAhv3XdLrPB0PV3Q+hnkb3wlEo+D3tstmtaGw0sUA=; b=Au9Y1p2ieny3zo+POxJwvhre9PLJ+Q/+yBGe6NtSlcTTxt+9V0lxmunjs9ZbIYTdp2hTSuLtYreJuw3E0LMpDNq7rt2F4y7R2BcP7ubLtdKWAHmL5Tc5kcDObV1h0aJq77xUtDkAWlUhSr2lRqD0NZ0P6JInKxQNMNZUwNLE4b4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758769012492371.04069240554634; Wed, 24 Sep 2025 19:56:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1c8z-0001wh-42; Wed, 24 Sep 2025 22:55:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1c8w-0001w1-Ni for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:38 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1c8q-0002Ut-JD for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:38 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46e29d65728so2464775e9.3 for ; Wed, 24 Sep 2025 19:55:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fbb27sm923650f8f.4.2025.09.24.19.55.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 19:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758768928; x=1759373728; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xMXAhv3XdLrPB0PV3Q+hnkb3wlEo+D3tstmtaGw0sUA=; b=bFzsYGAw1Q/x2tctwIgYs7Gwk77D4GxYlTGn07PfLSq1NvWBss8QREd8oWuuFaEUuM BYnFcs/rCQ/3Uu4bDTDCuyFX81zQtdFIRQp1w6TI3OvbjSajLsIapap2mNIVybXAEKFl xSfp0LdLNL9PRKeWcn1TyGS2CZ95MCEANeor1JKxflr5/+3gKzPQtsUnn3EDDQat2gie jXd8otgOUSdOc5s09BFhpql13R0ivMJYFqGMqFlYhHOnWqXQEqjOvLjZDv3/mwRfnWC4 CNWEGEBrkfovzomz2uqzB0T7Brip63FhwB1hq/fpTJHzo1w56XRa5ds1u8lgZyWRIDlC gYPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768928; x=1759373728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xMXAhv3XdLrPB0PV3Q+hnkb3wlEo+D3tstmtaGw0sUA=; b=cCSjOeceMKZrehVmk92spHdyx6TchCRiYE0D0zIbv3N7hF9/ETWIPMQSNFor1rBsjI HAdAL3NyMBoMRloABYirGVukW3dn50SUzc69MVO/TMTvpUA7pwapWjFFxIw6eBG5MSeZ a1yITjtjF3GKLWihMHGQ4F14vCdjpuriM/MIkc92ZhOaJkGxYGwUo1v3jQVhe3gKkhUI 8qZQm0fEIzgU2bpwHnuHJVa7SB2ZxIu+swh99GteaQkmoGe9rK3JqnLQP6q0n4UzEn2u 4ArCK7mwzZ1q9S3IIV+DguxPzeqYsO3NdSEeJPscIqp56Dq234hV2FonamA+VijLFRif dqLw== X-Gm-Message-State: AOJu0YyGT5rp6HjefJWt/btIKjaBYx0qWcM8Eij4tTzmUIHGbduKwqM7 OX6N0VxECw9K/nQVJS0uUwGq8pxQrsJ3EGD/V/gXT8sVIvAEgBKBHkYy4DiG0SdvZs095oIKVsg h7pc7X8SPtw== X-Gm-Gg: ASbGnctFK88YoHQaJYJvsmqKhj1VVmNM/1E2VismHINn71rI1OxV7qIQQECuJ359Y5n imFPtpCkj/rWVhpQgoDKkhgnZC+bnm9n8wTb4cYI8sRmkmOQVVR/MnyNFjqDqsbmccDfKgW9Wg2 U7Ktqh0zLRk9Wg5qwHNreXBpOYnd3VkH9yqemj7gxKwN0NeRcJHbAAAoReW5d2VJFvY/68mMAHp Ad6mDqeClZyQ7Ac16pB1rEtIi2D4D7KqbhhTJtkoANT1Ut2WOGzbV22+3EHabcYL5XJp99xajR/ LSVzPXv3jMRb9Uhdi8ibefh2dlBU7Yab9SkML4ZDWSb+dNqH3DV01bDtywy7MhTUfilquoy00lz LiPGqkXVi+dlh0BK8/iqih81Q3bZlMbzcn2g/RpX8YvACx113PXH+fiElpbk+jxSvw61t9ExW X-Google-Smtp-Source: AGHT+IH5E3wc5wHlQSYSl0mVroUeAkhs1XovCn8+Atd2LZ5Czjlzr3ICvgFp2XHl6kTU62gS8zjStg== X-Received: by 2002:a05:600c:698c:b0:46e:1abc:1839 with SMTP id 5b1f17b1804b1-46e329ba122mr16536745e9.15.1758768928608; Wed, 24 Sep 2025 19:55:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis Subject: [PATCH 1/4] cpus: Only resume halted CPUs Date: Thu, 25 Sep 2025 04:55:16 +0200 Message-ID: <20250925025520.71805-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250925025520.71805-1-philmd@linaro.org> References: <20250925025520.71805-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758769014029116600 Avoid kicking running CPUs, trying to resume them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/cpus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/system/cpus.c b/system/cpus.c index aa7bfcf56e5..6062226d4ac 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -666,7 +666,9 @@ void resume_all_vcpus(void) =20 qemu_clock_enable(QEMU_CLOCK_VIRTUAL, true); CPU_FOREACH(cpu) { - cpu_resume(cpu); + if (cpu->halted) { + cpu_resume(cpu); + } } } =20 --=20 2.51.0 From nobody Sun Sep 28 14:52:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758769058; cv=none; d=zohomail.com; s=zohoarc; b=Lw+16oFMd0bNNZPgZ6p9RVp61+/973vpHYiNjYkD3pBkcubfAPOcdTT24U95Lm7ArRvb4B3JWtXyjZbhnznO2bYweyXnvpOzFjfp1KC2jHy/zEtsmkz0de72c6SdYmTE2sYH5z17FFTcANVtdy2sPEGd2Oe+CrJ84kkgI0qilvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758769058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=NUlHM0leEcUHy2dwNWmd+PHUarnOvfUh3/6P9RSKK6jJsKZNO4VDRQyZipxM91RZUxoEY/v7uXB6nOvTu7AoEpoJoV14P2djVncEDTLtgmLoID61GhzilYlwLx24/V1SQP5mnp8Cnlj7xXoSpuevjbZPR+K0xuNksC4STjIWfhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758769058936384.89235113316124; Wed, 24 Sep 2025 19:57:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1c92-0001xe-T0; Wed, 24 Sep 2025 22:55:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1c8z-0001ww-S9 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:41 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1c8x-0002WH-7U for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:41 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3ee130237a8so310458f8f.0 for ; Wed, 24 Sep 2025 19:55:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb74e46bcsm939728f8f.8.2025.09.24.19.55.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 19:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758768934; x=1759373734; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=NXMwhVlA2jZsZhIoG/0DOBcr1eSNbEtKg/G9n9tZ4go3CtEqAXsL6RlOOHqcmfgquu mCFnSlhmdDUeD2RldT+Y4QcJGZgMbCXD76ivtTfwH3R714ZBrRrYrXMixcUfk2nzcSvC RRIUKhn8aj79U87S4Vl0QsbKFz37PBYtvB3U530nbvFvjyM+QO1VOIoOM3K1REDveWry Jbr3mNlV0DLPqpf3tU5zrcLInSmwmUIbYrd9hGlcrRDSWb3XWCrC5mwVBs7ZtoB5CYGL 45AI9LPgsI+Rgl+dSI9+R5OVHmqVLwGAEJimhJvHOndy4izNdEXMrPItDf420co6H4IX HinA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768934; x=1759373734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMSkQ8tS0Fq3QSh+vFnvslWSeFrUAxUcnptpA9cP+L4=; b=vXws8dwpFX8E/3ehasBfJrJ4TvX1OGyu5uFNDZ9ATtltCD0HvIiv3Gtvm/mu6+mD+I HRVFMl9QqqeXeLOC/6OzWSXiSp/Os95IcwvP+adPS9Bz13u4kRHZWrtOQ1U0+/TzPxYi jUlA5DeTQuynBakVF4qAuXRCvenZKxZjppths7RxxI2yiOXC6FzK0eH4lbO4Pyu6/RaB wAVzKCyBQRJlgLAnJXglU2ytz3iME8MF3FPqetGBXic8CSiAZKBtVxtnEvDp4NK6I+lw n5Nwk6iBzSov9xfi0VNBwvXdJcfHk5VnJevUkIKJQX7s3GFuF/24ozbZXk5mjmKADSpp fdGQ== X-Gm-Message-State: AOJu0YyljbYx/AsNR263Hj/YTn4ZGeRpXIgBAj3GUrQ+RZ9FTb8CfD+9 0YVB4vLJxxDepyTP43sk6wqvFnNDH9cXmJFpNlKFg3EUnd42nUWjIVcrNf/G+DS0Q613JIEfgdt 6XpIYcSnMzA== X-Gm-Gg: ASbGncvpBf1qrZr3GpMj0dU1iOtNb7SF7wvmST3HAsM3vlCn4quueFbItbrAhKCOiK2 mhYmv2gAD6pFDclaHMb2Ng9tKvY8NqFVX8yt5OtgeYxWROzobEtqKoy7S0kXazVC3lx/mC60Gpr rYxFNBu9jzNkp4+2h5Po1b2fbd17FDf5beYNJJrsz2WCYM7ytYW3Oh9T4CDghdKCcMAG/k0Ad8z Tzviejg4r/ERm/3CrorCcSWMDvvWOYs/Si5fNnB0Wl3BzIAYmHgUKTeAFPl8OclnO/ieOQtUEJu BIn6E8iy7MIQIDShBZW9mqvkOdIUuQgGi0YH2B0LuL8WUCnYf2hmBiKA+RllmOz3iqqGkOx3rUw ruGFVbUxRkSfxw5eqEH9CxTzU7KdvNoqxHZNhxL/J7xQ95WaWiqjnXXF9zYv/KQynWOjKPNeS X-Google-Smtp-Source: AGHT+IGUgr+uSOvWhJNgshrow4YUrsqarBBn7PfgQ8z4KuRBhxvHTHxpq90zU3j/a00h/1m/rIhrZQ== X-Received: by 2002:a05:6000:607:b0:3e7:451f:3a6e with SMTP id ffacd0b85a97d-40e4bff51d6mr1567732f8f.51.1758768934460; Wed, 24 Sep 2025 19:55:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis Subject: [PATCH 2/4] cpus: Access CPUState::thread_kicked atomically Date: Thu, 25 Sep 2025 04:55:17 +0200 Message-ID: <20250925025520.71805-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250925025520.71805-1-philmd@linaro.org> References: <20250925025520.71805-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758769060662116600 cpus_kick_thread() is called via cpu_exit() -> qemu_cpu_kick(), and also via gdb_syscall_handling(). Access the CPUState field using atomic accesses. See commit 8ac2ca02744 ("accel: use atomic accesses for exit_request") for rationale. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/cpus.c b/system/cpus.c index 6062226d4ac..818a8047198 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -480,10 +480,10 @@ void qemu_process_cpu_events(CPUState *cpu) =20 void cpus_kick_thread(CPUState *cpu) { - if (cpu->thread_kicked) { + if (qatomic_read(&cpu->thread_kicked)) { return; } - cpu->thread_kicked =3D true; + qatomic_set(&cpu->thread_kicked, true); =20 #ifndef _WIN32 int err =3D pthread_kill(cpu->thread->thread, SIG_IPI); --=20 2.51.0 From nobody Sun Sep 28 14:52:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758769012; cv=none; d=zohomail.com; s=zohoarc; b=dbArSfvhkdacql0LKsuPTkf6EFCjtlGtPIVwNvB89XStPamWkk03kVo00qN9K+anwESgh79t/KR0xs/7PFbbZCUKRZqpcPEpNN6AzHolbz1cfUv/EizS1Fw9TW3Ys+XJAviqZk1oNLg4WpNYBjTZcgbzMknuoHats1Zldys8HF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758769012; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dyY/0JMwlhFdHMWPEQckqPFnacgRGiLG+fvLLRk2tvo=; b=W44cZavMyTxIb31SQt/jbrBJej5uIoSMFE8wmy9kATSDMbYe26egsSulTmmBpmT3ZmCpE+31fxX274h45hTx/hzn0UJIB53VCBz4KhfTKusdhcrdrNNAoor6Hb5WpqDI50DdNJ3aLnWwTRyM3gUYh2xTdbaRPOztDctYgG0k+MY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758769012880888.8688405468025; Wed, 24 Sep 2025 19:56:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1c98-0001yM-Rt; Wed, 24 Sep 2025 22:55:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1c96-0001y5-0w for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:48 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1c93-0002Xm-KR for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:47 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3f0ae439bc3so178643f8f.1 for ; Wed, 24 Sep 2025 19:55:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fb21esm962957f8f.7.2025.09.24.19.55.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 19:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758768941; x=1759373741; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dyY/0JMwlhFdHMWPEQckqPFnacgRGiLG+fvLLRk2tvo=; b=ny7dJPgPDGt6nB1aGPok4ozX90UjJ2hi/M3dlhtjT5DE/IHzCyQiJwSDOt+NmSBuba uHdWFBmroqj9rlFLF9rNv1zGMTsn3JLP9w0RJxk/XEutQDQI5O1kM9JzAUzQ9rJolMiw qo+16f+T3VQ0la30URLPbIvNhgIpjkDkXtdJ6Nt6qdkXHt0wlSmP7vFdXntMDcxdiwoV rfvKB93xP2MZGvRycNv4Yo9kDwOw5e4/3PKqThZ/6KBNdPGjJXlrQuQ8bVnfJDSfrlLp QMW/Es0WtHo06Db60FK+6zMGkUvMZrbq5lBh2GVBMgVYmDfF0tyjUNu5TruL9ukCeFqm LaLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768941; x=1759373741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dyY/0JMwlhFdHMWPEQckqPFnacgRGiLG+fvLLRk2tvo=; b=YhvDpek6ex7glKx7uNf1KnEQK5ExAGukHuuCvkXk/I1o1GmzqMJ34LTISHL+RUWWo0 zwbYbAgOkK/l/QGU5wKyAuMqUiMei6siBU2yi65AI7j04GoLRClVCankocJyLZVY5fS9 277amsdTWe3PPfUL3hmFj4j2u1Yb/lUDG43hTtva6RyL2apM48oLl68DMUZnuQjOLEE0 ALXS+Gr+U4qc2eWtBSh+c36Xd8lqUe6ImOUlOEhgvVOIeWhSgMfesBoHTblcpu8avJqy S+BpuMP9A4ZCoKBy/ZsBbtUj2xWb1+Tz9bH5PuTadX6KwH0YAogZHaGWH2jsX749pnPU bl8w== X-Gm-Message-State: AOJu0Yyi1kS+dfbAXzIpBZxNxKYn0ryV8RDxNTJLyu/70EEXpEZyrmg5 bklN9Ptq8XDBSgaHylI8QVeBA1Ts6z9FweKjpiXTdQ98pgRamhGKwVDdVAXJzw8uHSmk1+nco2e nMLhRcXBVPg== X-Gm-Gg: ASbGncuqiLYyNZcKxuHFDfKET69NUyPRkJTFnyHa8b2sQcYWfo3aFnAkFrbEap8fuPU NwyWJxBv8GlxWb2V8pOgj0CQay/LrKF1mRp3fwq6553IsLc/w/6YFrDy6EnRblSAIXkQKl1PNdc VTAxtmKTcjnGOoLzgEK2G2VD6s7nYW10QEZPqzruIIYyhXla0jql0Cr5FmVGwVQiUEX1zc5S+T7 6/2QHKk9ULX5bSXFcw1h/BN8ylh5ocz24iRlI8eMguA/61re+7AoLWO6uVXvU2TOTFozYaPCxgi vxildQqn7oXFamN4vgwa8gO+aB/bTAD91sYwQdB9kKL8A0yB3AVTvldqOBx/Pa6307ZZZRSKWab 9V6QWwGI5xwyOiZYVqhQ1Bcq7ldK1R96UTDSfMk5bbUp1UKrJ9fTzGRiO+d3nW1t3lLLvl1sWJp rq51BXwSs= X-Google-Smtp-Source: AGHT+IHtWu06zmRy5/nYPLdqSOFdRIyiwVELk28bvhojUK1W2UNKS10OKZZCuheCHeiGLdWsMgNVig== X-Received: by 2002:a05:6000:1861:b0:3ce:f0a5:d594 with SMTP id ffacd0b85a97d-40e458a9804mr1679320f8f.13.1758768940576; Wed, 24 Sep 2025 19:55:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis , Peter Collingbourne , Roman Bolshakov , Sergio Lopez Subject: [PATCH 3/4] accel/hvf: Make async_safe_run_on_cpu() safe Date: Thu, 25 Sep 2025 04:55:18 +0200 Message-ID: <20250925025520.71805-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250925025520.71805-1-philmd@linaro.org> References: <20250925025520.71805-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758769014063116600 Wrap hv_vcpu_run() calls with cpu_exec_start/end() in order to have the main loop perform more exclusive sections while all vCPUs are quiescent. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Could be related to the dubious thread_kicked access and pselect() in hvf_wait_for_ipi() (commit 219c101fa7f "arm/hvf: Add a WFI handler"). Cc: Peter Collingbourne Cc: Alexander Graf Cc: Roman Bolshakov Cc: Sergio Lopez --- target/arm/hvf/hvf.c | 2 ++ target/i386/hvf/hvf.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index b77db99079e..377eb4bbc6b 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1927,7 +1927,9 @@ int hvf_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 bql_unlock(); + cpu_exec_start(cpu); r =3D hv_vcpu_run(cpu->accel->fd); + cpu_exec_end(cpu); bql_lock(); switch (r) { case HV_SUCCESS: diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 8445cadecec..913ad47f3d8 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -749,8 +749,10 @@ int hvf_vcpu_exec(CPUState *cpu) return EXCP_HLT; } =20 + cpu_exec_start(cpu); hv_return_t r =3D hv_vcpu_run_until(cpu->accel->fd, HV_DEADLINE_FO= REVER); assert_hvf_ok(r); + cpu_exec_end(cpu); =20 /* handle VMEXIT */ uint64_t exit_reason =3D rvmcs(cpu->accel->fd, VMCS_EXIT_REASON); --=20 2.51.0 From nobody Sun Sep 28 14:52:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758769051; cv=none; d=zohomail.com; s=zohoarc; b=XTgNdh9QGC2A863wKJjFz5MOPBzOWkH0kN/kR1YG4TUe+yOeeac/R/3P7R2pVvrczVh3h0p6M+Q1F6Ho8bHkr3bzXEnRn5p+Tt407f0pwhR86M+9bAliz1fGl0bbl4UYptcQuxYqNoKpo0+p8kB27+u+hQr7KH5Je46F3kcmXPQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758769051; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M/w1oo89YkX4j56P5P1/JI5beHjfC7oSHrKTDCe6IzA=; b=AGrWjP3QFTY73jEC18rehp3DV3yaMaf+uw81Z2KNKa+DaO3/k//7ASFnUgHxnJZ38gzLYsMb7YaCZy3+tAsGQPIfmcokB9HWWBG/KzFRRfai9MdFBgJuv+WGPHVu0n5sQ+cW5UTMXDGIqEr+JHT6RZ6+2pRGTRivtBdt/YI08jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758769051612634.7233688468845; Wed, 24 Sep 2025 19:57:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1c9D-0001zP-Bz; Wed, 24 Sep 2025 22:55:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1c9A-0001z0-IT for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:52 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1c96-0002Z4-5K for qemu-devel@nongnu.org; Wed, 24 Sep 2025 22:55:52 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3b9edf4cf6cso560257f8f.3 for ; Wed, 24 Sep 2025 19:55:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fbb27sm924338f8f.4.2025.09.24.19.55.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 19:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758768946; x=1759373746; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M/w1oo89YkX4j56P5P1/JI5beHjfC7oSHrKTDCe6IzA=; b=qyu16QSsr6nWsVpF8lLOfRkQcDCotD0D1gaX2UBqWas36GL02cJEWMWFdGFEhQXhK5 k0qPB+BTDRqsB6wgVA5OxChPs78Iinyg+N3I2UXEO3J05ShhdDJjF/Zn+uLhDybF0jH9 xG0LNRuh1gMnb/VvunI0tTmeaCBdAWJV7QsgIbmF9B4K4ArVsoZKJTjed0Fi1Ykh6CP2 ZwNFzqz0wsMLqQ6p/r/yfjeSkk0WmmMm87atcFGHUn27iUc4WMPt7J8fvGnQyPSJk2eB bQlBm+SEOMXLM1d9/BhZ45Gvj5oGs/oqXIjHQjxYXObVsIaWXyprWjJeMZ6BRe9/QvEt 29kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758768946; x=1759373746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M/w1oo89YkX4j56P5P1/JI5beHjfC7oSHrKTDCe6IzA=; b=Iek/lj4Ao+30LSoUqt2UVKLm3MBvLlIE8VA01bJStqzTqrAvQAploMOkHXPv7IYzR2 o66RKLVAqHhn/iOshESuIq5BCWQcc5Q1ALdk/FVSfaClvFpf7harudz1cBrV+/49pWmH tUma9/5SjNyxPENh8ZfPVYZVTezuttvuowOJTX7+Dcm08kP4yn2IV6A9IzEaeoYs75SX yiL8B/FYiw2vyVWryG7oXpkiVJS+Pb72c3YiBowQaBhYg/vMTvx025VgC73rJePAokll IdauGVVs8JLvsHr7XAteEtzSxvpRJQHDw6r5JCZ/dEhwKUhF7Di1lOX88VDx+GZVRB3E hB+Q== X-Gm-Message-State: AOJu0Yx4inQfWkffXynQLmeFzTLODj5i3VZ3TCGBKjG3alNaedWJ41IV f5DtEPcD2ekl2Y7C/MXlVehCZTeAmIFY6PGe6i5DNF9c0W+CpZZ1egNHaEnwZaUP6hhH3JZdUJd 8rmdjGPF4Wg== X-Gm-Gg: ASbGncujWw83eFp/7urCDLGYEhl8SyY/M+1HkkQCXO8em/ImJDBSNraM7hxlMT4ZXR1 UjUEHO5y0tXQHRQm0gBNDNMAiNqazVpDZjz+y0Fk4PoqOsYYsyzLmxZJdOKRphexfDkPkCIbMuc g9bicCsCBn2LW/tctjSlp/vJ/UBfAiaFMXkZPDpmeuQJ7yq5+gab2yE7riQL3cPDOEFZ1ok0Cfq YzGyq0R0RwALfYkEUX4sTtur+PEuKl9u6dHHaGbKjBYwulJo8hdlU5wz4kPp+09ej3dN/r+NI2J jzKC/sECxJt/9sLa34P4qcZaa12CgrD/7q8/wf8iPuC3bhdwjvlR2DOP9jkwN4fb7gof1QRkrS7 GVJ8KypCJHCx2g+e0VdxQL0G3cTptBWJSHmH7G+06KU5VmIwM9HraKgKTSzGtYw00CjuRE/Cl6n y9y0nX328= X-Google-Smtp-Source: AGHT+IFsxdr+JXwJOUOGoHMw5I7UtgpECL0VwfTynMbpxTSApMyG+EeEUGFd6VlFOMXeXu/NxlYvXg== X-Received: by 2002:a05:6000:430e:b0:400:818:bae9 with SMTP id ffacd0b85a97d-40e4b85103emr1755260f8f.32.1758768945684; Wed, 24 Sep 2025 19:55:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis Subject: [PATCH 4/4] accel/tcg: Use cpu_is_stopped() helper to access CPUState::stopped Date: Thu, 25 Sep 2025 04:55:19 +0200 Message-ID: <20250925025520.71805-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250925025520.71805-1-philmd@linaro.org> References: <20250925025520.71805-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758769054272116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops-rr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 2fb46439971..f84342e0449 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -197,7 +197,7 @@ static void *rr_cpu_thread_fn(void *arg) qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 /* wait for initial kick-off after machine start */ - while (first_cpu->stopped) { + while (cpu_is_stopped(first_cpu)) { qemu_cond_wait_bql(first_cpu->halt_cond); =20 /* process any pending work */ --=20 2.51.0