From nobody Sun Sep 28 16:28:10 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758735206; cv=none; d=zohomail.com; s=zohoarc; b=Zoqz+cHZvl/ZsQ6rB0jqzPE11k49eNXjH3+t+TLRI9o5a7L+07x8eH2mBKZvDwu27aHlQqx10KbweK0c0sfVfrXSzEY199sgIjAsQsue6nQRu+TvYT7wy4JJSpzMcGNJqPYBSwGm0D8C2gZwOfgu4gPcdM5HsZAFGvBx4AhJ/cs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758735206; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zJl55yMN8mxVV2arqCWHPRSKMows93UfHOZHUInGBvY=; b=Z0k5t4G1Gu5hM1NZBRPlUAaD7JqIhxD+36av5ihP6eh4BfRRGmZOZ2EmN/ziYg/SSjwBweAY0Ra77UrgbqebPmurIs+K51H2tSfdNZfk+zbuufoccgQXMc0obtK6+S/wlcakuWI1A2pX7lhUl8AZpl3hbxaQp3qdh2yDqwvek/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758735206477738.8606116458733; Wed, 24 Sep 2025 10:33:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1TLd-0005jy-8q; Wed, 24 Sep 2025 13:32:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1TLE-0005Y1-Iy for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:50 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1TKZ-0006Yd-Sc for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:19 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3f0ae439b56so85538f8f.3 for ; Wed, 24 Sep 2025 10:30:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3f00cc58b91sm22757343f8f.1.2025.09.24.10.30.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 10:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758735036; x=1759339836; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zJl55yMN8mxVV2arqCWHPRSKMows93UfHOZHUInGBvY=; b=vt4g+R++ZtMdEhVZKszpaAVMOVLXBXFWVg58b4iA1cVyIpbtRTEC9EH5XARRev5YjN ZlXnbQIiA0IEMuJPkkRozp/7HYByByuTrJ3R3I0buvcKtHas9sp6+Zbz4iLOKGeLyaNj 6eA1r1i8Qxs0ub7oFPafCyVdQ4SJxAhb5ho5pYc5aI75ysR/TqvvqDfeYuZF1r+NETL5 AW1j4UnwewDqOZKOA2LS+EZ6P/83tSXZBrFDDi86SLnPKrVMCDgiM5LHJxJq0kuAqQCK OJI6VB6g7+YWOYbmbc8u9bq1lHdNzLXIgAAwAWHn1N1eY9mqUdrprsJjB8sB81ECpPSf Zq6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758735036; x=1759339836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zJl55yMN8mxVV2arqCWHPRSKMows93UfHOZHUInGBvY=; b=FGpe6J5eilL17G6YyTOjr3FgelMZA1xpwzuwsC39c3O/mHgiTLkfrYEFzes09E41IG j9mGhSu/iwcRfHVPlfZuo42AymhOqgGw+CgN/u6pQrEUPgl0oN+cmBuBJhHskcAT5NeO zPktJmM3MhOI/ya0PRe1mPJbNZQtOftyAFXex7fFFre1QecNDS5piDgo81pwEDsOXMLz 1yBOrF8ruF1FgwERdCH0co6I5OUAajOs5OuZBJ2u8alZNOX3UnwMnvcSb9Kg8+FwOYqG dQbCjjEpAqZwVZZPav2aklalV48l0yfaLLdvBlANtXwnq2rbPZ2fyDafhCCUh2iksyxx RXNg== X-Gm-Message-State: AOJu0Ywg/n4ckpAXRvBJ0HEWSvRGu1FNDY7W2TUGCqB5R5p6x/vfAB5a zDd9usRDzo0MA5f2D6KsCnG+b0qn7TxuTG6sp2a2gv2kL2uK6NeP2N1SBFJUzvIB5NrGl51zNIj 7+LB9vYP37g== X-Gm-Gg: ASbGncsQ8TylPFCm+Fhh6J95U0OJXjsYHHfn0Lew5JZzlWSkVqUnnZ0qgAk+V41rRCW JekZU5Gjj4t0UDLFeq78J4uTM8T2TLWNxC2AggBz/laUr1HCfejStcZ1kbwD7LflmdRLldwwq0x XCyVCdKdmYih7UYE36JFXi915HiVPbBr5CWTa7SSd8lXkxlyCo2Wirnrt3sEt5GdJDlX5TziQjS ze48emFd2WyeetJTc2nJm/JkzPpf3ERhPPtZu4nejBMweiwic61I897rehUTzdZWluWxiik6ryA 8Pm7sLKLDXXFsAMVLmrbZao9r8gwOZinmhzyb2F7auwOgAIy2Kr0eNN4QHXGQUEZ7V8tUrJui3t 9RjmyjfPHPTA/EF/ZmpBmw8roB0CDDxNcmnnwXZCYnu+qxFawAHVcNW/HqHakVekTJ9NWcJlc X-Google-Smtp-Source: AGHT+IFImt9yVd7VauyD9LQ2sQSXI0lfTRJiQqYsRBUMN4mYE3UXOEVyxvzIWTstANroPDg91Y0k/w== X-Received: by 2002:a5d:5f55:0:b0:3ee:14db:701c with SMTP id ffacd0b85a97d-40e49f66b7emr595130f8f.41.1758735036192; Wed, 24 Sep 2025 10:30:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bernhard Beschow , Nicholas Piggin , bharata.rao@gmail.com, benh@kernel.crashing.org, Chinmay Rath , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/ppc: Do not open-code cpu_resume() in spin_kick() Date: Wed, 24 Sep 2025 19:30:26 +0200 Message-ID: <20250924173028.53658-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924173028.53658-1-philmd@linaro.org> References: <20250924173028.53658-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758735208101116600 In order to make the code easier to follow / review, use the cpu_resume() helper instead of open-coding it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/ppc/ppce500_spin.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/ppce500_spin.c b/hw/ppc/ppce500_spin.c index 2310f62a91e..bc70e50e926 100644 --- a/hw/ppc/ppce500_spin.c +++ b/hw/ppc/ppce500_spin.c @@ -99,8 +99,7 @@ static void spin_kick(CPUState *cs, run_on_cpu_data data) =20 cs->halted =3D 0; cs->exception_index =3D -1; - cs->stopped =3D false; - qemu_cpu_kick(cs); + cpu_resume(cs); } =20 static void spin_write(void *opaque, hwaddr addr, uint64_t value, --=20 2.51.0 From nobody Sun Sep 28 16:28:10 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758735217; cv=none; d=zohomail.com; s=zohoarc; b=aspMkjyHZZTrma92sYq6AkvvKVn2LcHHAXBJWUKvc6YJ2qLZtQN3TLHGLUEP8tx64brSmXVQzIZOp3Uq6S0BOHtHtWsKuF1+iRpmSE9cUPtSjis/Hc/G/dxiIIfOaDoWiUiw5BYLNTvLz9lPM52z2u0yY2ibmBxLTWmY+HecyFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758735217; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=01ZOc4BKa2jNYsiKE/FtVTFT3ErOS4ymhecqLqiMBww=; b=SsZozuyO7LypfnLlIxpZa9vAd13DmebWSx05DXUShwg4MJyl1hus3OUIY51HABeLxLciqSq8vl/MoJk9djPHdWJX3U4m64POliugHEn1MC5G3JfGvUTPc+4gbfxg8bxndQSj5cTAwTZu0VhDXCeByMlyzYwBOS7/txTUTV1pGK4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758735216985503.8628504737409; Wed, 24 Sep 2025 10:33:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1TLa-0005gB-30; Wed, 24 Sep 2025 13:32:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1TKx-0005Sx-Nd for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:39 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1TKW-0006Zt-Fp for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:11 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-46cb53c5900so501325e9.3 for ; Wed, 24 Sep 2025 10:30:44 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2ab4897bsm39249895e9.17.2025.09.24.10.30.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 10:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758735041; x=1759339841; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=01ZOc4BKa2jNYsiKE/FtVTFT3ErOS4ymhecqLqiMBww=; b=X9upt1cHYhxtci0DVrA5NYLxGIGgE68LT7VGnlRxra236vtKX5Nt5588t5IN44iV5S pwndELeo8ZSO5nQFauML/qht1Wx/CLcad4n/jkZBIJ0d89hC37BQEL76Y+i+hHcwgul0 ETbwR17VGJTJMLGzipsL6QYRt4Xfx6Qf/Xf9faRthieqwxZqGYINSQTfnxsKqF99Hful PEva7sleeN4c5aigK5e+v07DLKQ7NeVnzq0OjDr9hgY4xx6v77t9CbNJXfhFZr6WwkLD 4BSED7IdNmKyKm471N18nlPH3pOkxeQc/iQn8U/GNI8mBl7m5MURytDjYaKljWNA8VkG wB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758735041; x=1759339841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=01ZOc4BKa2jNYsiKE/FtVTFT3ErOS4ymhecqLqiMBww=; b=AzRf9S3xHjY3+JzeGzkiHicovJVyZ5/HGahFKvdZ+gFvcthct1bVqagMIv3bqI/Bh7 ZgicEgnPvpMFiK8PyiaGatZ1njeIUXNNlbzSQzLiHblbDhzhlMPQyVnF5/d9V6nrsHRK 0IsH0eg3mVH+KsJmWHhPT56gv8bKDlMykFzC7i8j5Gds8AvLgCdd6g/qqKFMF04wFdiD rgUcgauOVtbfH4IPdVhDWyvaLSfvDexfrUsrpM0dxKrvkAxNr5H5CpVByZzCQuLiyAsc Tcex8sbhc86e6hYkdrVXPqBZQHYB4QQqtIAJuvUaJQbzRNWP98pYI15IFUQxLHGJoR9h gjcQ== X-Gm-Message-State: AOJu0YxzTCM/eVpuEcnNR6VANqwm2JrJFiRnnflR9YESyORedlwRd8j/ I1eZSl8kQ7ZrMZsy/EJEgdnMUMSlv/bX5BYzgvbWOeFIDQm82oG/iHo8fydHbF/d0QEXxj/omR6 z5M517xuA4g== X-Gm-Gg: ASbGncuLA5mkOhFYtEfl/yoO+v/hJyn/LqjYtexu2rnO7IFdtMIAZ6c4bkWvR2u8bJj 2/yK7+Yu0GjXB8Rt5Z7FGF0qBn33jkmNJtIkxzd6YomnueYAJoGTRfwRyu4WJ/OaBDYd+kyCEy3 N+c1GVCeBbmRQinmbVHgmkZnzXQVTDr0BwoYW747B3+2pHajnkMjl/MMSvDJBgPF/DpJmks4VRk +iX6rdq/zctnAkVGf6LWIu/ebndSnw8bvTcue87T1xpiMvZU7gNEOT3bKzi8lMaHWYJAyChoYY6 kePGIdaqRTEBVh8G8AyM0CMK+pqImiXJlBBQI/yc/kcoJyrXVCoQZf1QarH0+MIQpowxuyu7RA+ rskE36NLRo7eWlcpBAu7AY0EzfVOGEZh1vFk1CCSPbQXx1RRlbyOWsHaIci+RG9FjB6scX0Kc X-Google-Smtp-Source: AGHT+IEB80XlI7XMcmC7dB0vq+Tq4gZ16YHrlSbjKKLbhEKT1IpbbSmjtxZQGVRYJCfS8//HcyyxTA== X-Received: by 2002:a05:600c:8b33:b0:46e:1fc2:f9ba with SMTP id 5b1f17b1804b1-46e32a0d5e7mr7099235e9.25.1758735041569; Wed, 24 Sep 2025 10:30:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bernhard Beschow , Nicholas Piggin , bharata.rao@gmail.com, benh@kernel.crashing.org, Chinmay Rath , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] target/ppc: Have gen_pause() actually pause vCPUs Date: Wed, 24 Sep 2025 19:30:27 +0200 Message-ID: <20250924173028.53658-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924173028.53658-1-philmd@linaro.org> References: <20250924173028.53658-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758735218376116600 gen_pause() sets CPUState::halted =3D 0, effectively unhalting (a.k.a. "running") the cpu. Correct by setting the '1' value to really halt the cpu. Fixes: b68e60e6f0d ("ppc: Get out of emulation on SMT "OR" ops") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/ppc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 27f90c3cc56..a1a97e0fd2e 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1985,7 +1985,7 @@ static inline void gen_op_arith_subf(DisasContext *ct= x, TCGv ret, TCGv arg1, #if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) static void gen_pause(DisasContext *ctx) { - TCGv_i32 t0 =3D tcg_constant_i32(0); + TCGv_i32 t0 =3D tcg_constant_i32(1); tcg_gen_st_i32(t0, tcg_env, -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted)= ); =20 --=20 2.51.0 From nobody Sun Sep 28 16:28:10 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758735243; cv=none; d=zohomail.com; s=zohoarc; b=i4DLKSY/RkoZ0FRNNzfDg276nnPtAHYfMBKviNeJjFzUF2CzIAIWk5XTz85nOiudmC4bY5k90+ZYjLz2XZ4ydmHxt9rcAWoO3NZTDW4Bh5rXSjFUiEZpJtern1OX/AQdpmEnhtMwhiIro6O8SkXmpbDAuhGB5Te8TgYv4/6M4Ls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758735243; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fd0ACioI7nAwjU2+jn1cQHZUjIyZfiZiM6lI/YiscPY=; b=UoIXLGsaRj6/58W/TrLWeNAymidb9xdMnD6Ui+Xkm40MrKGms72L3HeWIX1Yb2jELZscq68sPociEE62artr4KHSlGkNZEz9eXCTBfsZdFvqJ9bhbA3uCbwnEP+oG1sOzIzbjSnDAtvHVF79YymNiKNPyA+dTGUVFDsleC8DldA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175873524366245.25973828506858; Wed, 24 Sep 2025 10:34:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1TLg-0005ly-5B; Wed, 24 Sep 2025 13:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1TLD-0005Y8-OM for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:50 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1TKa-0006bP-Uy for qemu-devel@nongnu.org; Wed, 24 Sep 2025 13:31:25 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-46e2826d5c6so430865e9.1 for ; Wed, 24 Sep 2025 10:30:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2a9b1dd4sm39652165e9.8.2025.09.24.10.30.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Sep 2025 10:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758735047; x=1759339847; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fd0ACioI7nAwjU2+jn1cQHZUjIyZfiZiM6lI/YiscPY=; b=KRHJseRlxLpprt2wqnWk4gv2JEuxxyDyDlSsRA8H3egbyWN8wshZceHS+RO5IjFkQ+ vVNkk2IKwltYCYhjh1HvhkMJGxje5xOssMRFX5JjGx+vJ/ZAnc7RvfasC95tKdqCJOc0 baPVgeerQR2MH1ALFVmCWHZPr3WxYE1NggLY1UyifVSgJpVLLVIAnFW+bDyLRCqjmOU7 ENRoOnZ3iJvUp2Ns8DGQOc/HxP5g9K1gyRR5x0oR21JIwi4KspO47SkF7UvfIap97Zq2 2qad060X/IAL5nYR1XnsCa6eYZ9NiWn4H6m3d9YdbzT7FcpAc/UQev8SLyo/rPrih+El Nv1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758735047; x=1759339847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fd0ACioI7nAwjU2+jn1cQHZUjIyZfiZiM6lI/YiscPY=; b=J8EbV0d3il6XfCGgY/+Ho9MpOfzZGAeuQ1xNoilQagACgirymF8VGGKUWCKay1s1Zi BtSwyllzKaXWgsYYXqgZMlJjFLxg6b+LtyAQBFiULLkhWQWogQN4cLRRZbG5rkWJTU5V 5bXZhY6uAX2ZA2DFoSxDNxa4jdb40Mh25LzcNCNVpY9ANVyXXi/gmS7n4keKD2QBVjER oMYkeihRjnlOx+GBZnJwd4Jr+3eC9rNViwNMXtC33Qcha8XgQzDX87YtX+InBflwjYIM ogbyiOW0WkQxzaZWdQaSQkUstVbNLBSzfcBK1u0rTR9VY5grT2J1qoiccirnB0DpzMtT LPwQ== X-Gm-Message-State: AOJu0YxHkfLso3SGdp1l4gwdPuQlahxvfh2N26trJTOtURsRMoK6j+gl gcqCpaeSOKdn8CKNYcwVFMXTMAcJD3+PnlEPI/bB6k8EgxRZJlbJBqTk1F6vsxHASFofTeIJvqU tVw3ZgX9nQQ== X-Gm-Gg: ASbGncuO/2XKIh0prTeSZKNJv76UrH+MgVGLKFziNyDLO39Ug1yyrbQNkHXe7hWiKEJ IwWYMkUfMIdSlapWSB20u3GVabkVtKqBmdc9R+HaLly1icjeBqn8u1MqX/sTiywX/c1XNeEx3CZ 1Au2yFVmprpxZx8lvJJdmlj9gmElu9duh1FNGnU9pbA56kggZ1xx59/XCX9fVaX3Sst/sNaCFBc zLkC80CRZiMbUT+IoL5GYD8C8ws8WogTI8w1nc0rtcZIClBhryu7eMICEKWzUN5L2spMIqc5DME zDhrT6MtNd5VtCouchnG6no6wvwS7zRLL8iAKpqSDt0kik/4c8BI5g402IvjzmIiLYu3on1CB3F r/FxjsqV3HXc/RjLObl+KOGRS2tj08lHCuAqVoM9G3yTuCxnL8F5JkgzTMe1RjbsL6GcgSLmA X-Google-Smtp-Source: AGHT+IE9JiUFqPAwF6RmQ+hjWrNP2s1/eKDamfcsa4fA52+Ybz+YIc8X7LNr//8o5jV2aMbvWpuNtw== X-Received: by 2002:a05:600c:8215:b0:45b:71ac:b45a with SMTP id 5b1f17b1804b1-46e329b2583mr6900535e9.11.1758735047128; Wed, 24 Sep 2025 10:30:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bernhard Beschow , Nicholas Piggin , bharata.rao@gmail.com, benh@kernel.crashing.org, Chinmay Rath , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] target/ppc: Re-use gen_pause() in gen_wait() Date: Wed, 24 Sep 2025 19:30:28 +0200 Message-ID: <20250924173028.53658-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924173028.53658-1-philmd@linaro.org> References: <20250924173028.53658-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758735244605116600 Avoid open-coding gen_pause() in gen_wait(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/ppc/translate.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index a1a97e0fd2e..1b5d2521deb 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1982,17 +1982,18 @@ static inline void gen_op_arith_subf(DisasContext *= ctx, TCGv ret, TCGv arg1, =20 /*** Integer logical = ***/ =20 -#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) static void gen_pause(DisasContext *ctx) { TCGv_i32 t0 =3D tcg_constant_i32(1); tcg_gen_st_i32(t0, tcg_env, -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted)= ); =20 - /* Stop translation, this gives other CPUs a chance to run */ + /* + * Stop translation, as the CPU is supposed to sleep from now, + * giving other CPUs a chance to run + */ gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); } -#endif /* defined(TARGET_PPC64) */ =20 /*** Integer rotate = ***/ =20 @@ -3368,11 +3369,7 @@ static void gen_wait(DisasContext *ctx) * to occur. */ if (wc =3D=3D 0) { - TCGv_i32 t0 =3D tcg_constant_i32(1); - tcg_gen_st_i32(t0, tcg_env, - -offsetof(PowerPCCPU, env) + offsetof(CPUState, hal= ted)); - /* Stop translation, as the CPU is supposed to sleep from now */ - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); + gen_pause(ctx); } =20 /* --=20 2.51.0