From nobody Sun Sep 28 17:04:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706307; cv=none; d=zohomail.com; s=zohoarc; b=DhO7pTGyENy607r30DbmUt7cA9pNqgI+VYF1pN9WL8EM3UE4CmQ96YSCA9na/0Et+Lb+BanTaTvz7gynCflIRioBzN6E5GqTEOZnoKdPIg91WAilViMUc1OU0wvS05m1QvPTuLWLd8CRKuUSNgl8ofd/ceq9D9kLTZn5sUbmTaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706307; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=EDUm7noE+jBJjXyrOfyaFd15IGwTO8OtL69umzZBTGftGhbG5PdJ7Fi0n4MnzIMFwQgngrIZUwDwKZ5y+FYYC+TztBGODhdtLLJgA+CFH7jyeej0YdU55jmjc9NWECgtPL4lBscZauDFb/BQz/DA6int3UnPiIOLK1UWmVQBXDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17587063069011007.4022815300503; Wed, 24 Sep 2025 02:31:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lol-0004wO-JR; Wed, 24 Sep 2025 05:29:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loi-0004uJ-7o for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loa-0004nj-Tr for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:39 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-Xq4U3lLZOiKiMJkqfy7OnA-1; Wed, 24 Sep 2025 05:29:28 -0400 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-63267baffcdso3458963a12.3 for ; Wed, 24 Sep 2025 02:29:27 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6344e493329sm4798120a12.14.2025.09.24.02.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=GqV//MTQzIcD6ji/VuXI8RIMOP7IPRl+legSQmLfftnfS2JgC80RzI7x9AGLHDZAZMXrrB wkjwdX6HVEKaFKK4/U6tMyAORxiRdeV9yG1GyJEvsumP+UFNi1ab6840n9RWNIsPw4LD32 it1+M3PPaJWGNIriALpB4+1R3pGkbhQ= X-MC-Unique: Xq4U3lLZOiKiMJkqfy7OnA-1 X-Mimecast-MFC-AGG-ID: Xq4U3lLZOiKiMJkqfy7OnA_1758706167 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706166; x=1759310966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=UKvHNNg+WrXhzVdj75Vp45RXgDPwLqLf5Oh/7RtVMa8didifg7oXAE8bLh8y5Xcwnv 7YXCLxxMYpQH+SHTro2H1D83c8Nkdyvx7S9C9zMiLUEatIjR6ymrylARrnmeiz1OhPft DIeHYoiyWjO5+9rqfOMI7n25HgmvO2BMRKQg9WcqGYPERFnoNELRArlTk3JP/7Ts1vxP UyYcEdpWZavshIDnxBALb5C1Y7ZxuueMcrXg09CSMI1J36JHVR1nbVsDW9l7TFVUgEX3 NjaDLBppWQXyqvVMrhdibc6XoqYjdwKo12lkoLZqthC5HfoVB+ezAFApYlFtVrAYVryG 4Awg== X-Gm-Message-State: AOJu0YwisNIR2auFnScdtpKO3wKWUOlZVl7AZnz0xEO3Pv7rMcqXPcd0 4vRE/jTjmBR7jmlUT+O5BcdNYNcV28F9/DBekrF1BbBHD+kG/CIamVTG8ZY6I8q3EO9SNomdg/G f8Wu5WlmxjnfzIastZAdUut8oSjsJpc6PM5vDauG37asXw4E4qLNu4Cw7MJ1agtQ3t6O2Ex3Bnn 9uJ6MeSHOPDL87IvqudSArynMOtuLjfmzo8CZzsNz6 X-Gm-Gg: ASbGnctXXvBoHIl00jE520vKniufh2zUFmu74eA9LZMFS4DnSEAqYcg5aC+qpBenrA+ me94j+rfVxQreZz739NqYGwl7r9NyrsjW3ZyKFP6bIvh/aMsFt8E016Y/ZR/dFIFxeozULE3iat IxDTw99rpac56kCtceQDu2cuxI+YJuvf2GApGMcwmyyK6nivTg8EIxdAfXSl09jv4AXqnWLCCQL 92jAymKuBOJkjw8wLa3oN7bINHGrjYGwPZOy8xJm2qIN36nVkb2vryRWu9xtwDNyairUgeE9VbD dE3FUMxybh+SZ8Ms17oUK5IoQrV49mce2NBFLYTJEogvrIb5S431tuSGeCjZ+1jt5IOav4HZ96t cmZANFIba8ie9cl9doo5f5pah5j3xGE/auAOmjcEtbmDRAA== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5032332a12.13.1758706165854; Wed, 24 Sep 2025 02:29:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEokRPoNgqaoabBYr5yUq8U/XC1DqxoUY9DayzWZfluI6qRymWdVqbp42/bCzvltMfRMpySbQ== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5032295a12.13.1758706165301; Wed, 24 Sep 2025 02:29:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Zhao Liu Subject: [PULL 11/29] rust/qdev: use addr_of! in QDevProp Date: Wed, 24 Sep 2025 11:28:31 +0200 Message-ID: <20250924092850.42047-12-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706307768116600 Content-Type: text/plain; charset="utf-8" From: Manos Pitsidianakis We want a &raw pointer, so unsafe { &_ } is not needed. Suggested-by: Zhao Liu Signed-off-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-6-zhao1.liu@intel.com --- rust/hw/core/src/qdev.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 71b9ef141c3..3ee5b242622 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -6,7 +6,7 @@ =20 use std::{ ffi::{c_int, c_void, CStr, CString}, - ptr::NonNull, + ptr::{addr_of, NonNull}, }; =20 use chardev::Chardev; @@ -129,17 +129,17 @@ pub unsafe trait QDevProp { =20 /// Use [`bindings::qdev_prop_bool`] for `bool`. unsafe impl QDevProp for bool { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_bool }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_bool); } =20 /// Use [`bindings::qdev_prop_uint64`] for `u64`. unsafe impl QDevProp for u64 { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_uint64 }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_uint64); } =20 /// Use [`bindings::qdev_prop_chr`] for [`chardev::CharBackend`]. unsafe impl QDevProp for chardev::CharBackend { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_chr }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_chr); } =20 /// Trait to define device properties. --=20 2.51.0