From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706233; cv=none; d=zohomail.com; s=zohoarc; b=KXMMP9MhK2q8O8iVQXsz8b0b1CSpNHBBeA+dlwvcJKjhUlPz0PPyB6cMMUfyjMFV5NVp6XO+HljL5gDFlsMXQorCayom/jXu43gkCZNCUsVV6ik+Tt7nAcZRMEl+4n3VWrMlYyfYpPz9IYSEXLcoXe1LOE6c1+851eIRBpzAi7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706233; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sxLN7RzrnIG6H43LZkavcvPiQ5d1T/R4AZOxvLvIHQQ=; b=HteVvzZP3f02NLzkSOGvTwRf6j42IkobtBGEXQsuiTt+UanSIt1sBn1XRtXELvPrqENVIDzGcSyUiJfflU3ANUlj93UvGcXPtBOgF1e7lFmhvnQAHYAHI3XIGDRSfoem6UuwIGwkI/82kFg/IWbtFrtp8cVYpB5yl51yi1brbxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706233968193.54658774069298; Wed, 24 Sep 2025 02:30:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoN-0004ba-C7; Wed, 24 Sep 2025 05:29:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoH-0004Z7-AJ for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoA-0004lE-6Z for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:13 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-JQwrumkLO8WiLb0bbYtUFg-1; Wed, 24 Sep 2025 05:28:56 -0400 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-63359dd377cso5207887a12.2 for ; Wed, 24 Sep 2025 02:28:56 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62fa5d4357esm12689164a12.23.2025.09.24.02.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sxLN7RzrnIG6H43LZkavcvPiQ5d1T/R4AZOxvLvIHQQ=; b=A5klvJmjDDXvs6TXCQBl086Hm/00gC0zm25glLBovcI6Na08lhTGKcE5kRIuRI99q7vQuO GUoRv+U8ncAOPoKMMaok4N2HjhnSQykVSft87OoQu6/kLZPsjuGoNmnEj45uHw8PkCZE56 cvUoIffMAQf8eXFMjALl9vm/bfzMIWI= X-MC-Unique: JQwrumkLO8WiLb0bbYtUFg-1 X-Mimecast-MFC-AGG-ID: JQwrumkLO8WiLb0bbYtUFg_1758706135 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706135; x=1759310935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sxLN7RzrnIG6H43LZkavcvPiQ5d1T/R4AZOxvLvIHQQ=; b=nX2ICj9zgkPIinnjDwRAJt8iH2Rw7HE+GRlFy6iXlA5DUR0C00lgzSi7k/r7WdKdnP IUX2CiPytuaqP+1VUHkVfVeuAM6XcCd8SL7vx80yRvwlG6sFYUWuUATkFHQII/F7JKXj 4pNEh/QIcoGcm9rwxuN8P7SnTqXQw2hBB8mZmqfU6ZkhpcYDnM38L+ZCoPxMorfBt7ei G1AWMESoeoYq21Taj2czZldQiuc4lYGIFPb9CaGRimrfW/Er7y97l9NwM1vgedFQEWau lUQCRa0dZtJZ/jgSi5v16uAYCELivr8Q650iQttLXx0A93wYQ1iBsM6VSUZz8P/TUiZ1 rGHQ== X-Gm-Message-State: AOJu0Yzw+WFfENl+8YnSiPGfWud3W/mLXrbzKjCITJEYBgx1eqgYw3iD L2egB7+v07+5isY6rJy2loRd9tnvwQN+f37g0UxxjwJPVnKthLVPkVdBLiu5U4HEF/UeGI5z3xG +IC3/VvUzILQX6FKaICSb6kuZ+Tijoa8Ksaw3S3uLv+sEmrrAv9Kjfloadt3G6tVukRHqrDGMIm x4skVlPYEfW/gKOLpIlTIcG+TOtyz+UnIfJ/OopuSV X-Gm-Gg: ASbGncuppVu8U0uXS8e7uHwihczEvU/T7CFe2VQhtw/9T0gRxVEbYmgGUux0zhz51NT e1uL/tVtYr1urZtzHCtpgbdH4BG1LEKVdOZv5ZcEZ3Kne9jFRV1zIQq2raS2MsKsaswA2IdeLW9 JERTUF5cHyW8TZNw/L4t0pJJ/NEgNTOBkCybhTlJNHTsO7UYh7uvGWoN3BtKkWxctmXSARTmDL3 LzNNRSmkrw7G8kjILC9f3kjk7JNYq+4Rd7XfdWbjrlqycwrQPd1laHksw1ap7FnKc4NPTwlnSat cHM2e8/1Ty9h3StJkOCMes8eFd6dmTKaY7I/PBx6MVpFpoPCfNSiwt3KI6yIefPONu4raupDYOI zDwtiwNa6z55F0SRm3ZWRVIvNPgC9OABTgZTQczcSgRcmuw== X-Received: by 2002:a05:6402:34d1:b0:634:b40:a0ce with SMTP id 4fb4d7f45d1cf-63467807609mr4857120a12.34.1758706134592; Wed, 24 Sep 2025 02:28:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuXyR1HUpsoER9Tam99y9GkdCDLQpTTr92c79H8aqY+3jrk9sv9YJjJXjH41I+1P64Qd417A== X-Received: by 2002:a05:6402:34d1:b0:634:b40:a0ce with SMTP id 4fb4d7f45d1cf-63467807609mr4857086a12.34.1758706134028; Wed, 24 Sep 2025 02:28:54 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 01/29] docs: use the pyvenv version of Meson Date: Wed, 24 Sep 2025 11:28:21 +0200 Message-ID: <20250924092850.42047-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706235609116600 The version in the system might be too old for QEMU; this will be especially true if Rust is going to be enabled by default. Adjust the docs to suggest using pyvenv/bin/meson, which is in fact what the "make" wrappers will be running internally. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Paolo Bonzini --- docs/devel/build-system.rst | 2 +- docs/devel/rust.rst | 2 +- docs/system/devices/igb.rst | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst index 2c884197a20..6204aa6a72e 100644 --- a/docs/devel/build-system.rst +++ b/docs/devel/build-system.rst @@ -450,7 +450,7 @@ are run with ``make bench``. Meson test suites such as= ``unit`` can be ran with ``make check-unit``, and ``make check-tcg`` builds and runs "non-Meso= n" tests for all targets. =20 -If desired, it is also possible to use ``ninja`` and ``meson test``, +If desired, it is also possible to use ``ninja`` and ``pyvenv/bin/meson te= st``, respectively to build emulators and run tests defined in meson.build. The main difference is that ``make`` needs the ``-jN`` flag in order to enable parallel builds or tests. diff --git a/docs/devel/rust.rst b/docs/devel/rust.rst index 13a20e86a16..2f0ab2e2821 100644 --- a/docs/devel/rust.rst +++ b/docs/devel/rust.rst @@ -66,7 +66,7 @@ __ https://mesonbuild.com/Commands.html#devenv As shown above, you can use the ``--tests`` option as usual to operate on = test code. Note however that you cannot *build* or run tests via ``cargo``, be= cause they need support C code from QEMU that Cargo does not know about. Tests = can -be run via ``meson test`` or ``make``:: +be run via Meson (``pyvenv/bin/meson test``) or ``make``:: =20 make check-rust =20 diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst index 71f31cb1160..50f625fd77e 100644 --- a/docs/system/devices/igb.rst +++ b/docs/system/devices/igb.rst @@ -54,7 +54,7 @@ directory: =20 .. code-block:: shell =20 - meson test qtest-x86_64/qos-test + pyvenv/bin/meson test qtest-x86_64/qos-test =20 ethtool can test register accesses, interrupts, etc. It is automated as an functional test and can be run from the build directory with the following --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706175; cv=none; d=zohomail.com; s=zohoarc; b=CaDnARId4m1xgeZlHbxZhEftEWU3BCdyjg6c/5iPb9LA3pBEW2M9833x+rIzb+vQ1LQAEW3j+2HhkkiLbc+inkwBXx5SPtaBFMf3ZFaDMOCXCHNRtH5h/zMElJ7Qckxgsn5YdbmDLknu46cropX7mKJn8dn0HTFRGMV+wn3ldH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706175; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CxCkSne5lIEz+6v/DtZSGsRBXxpV2mGxzrf4U3hlZ3E=; b=HkBKtZYrdh7nTvxp/Z9OGpTBsVA6fscSAF/21nvJpXckQK5UfeHv5xAAdjPQrgG7sjvW4oXUeE7o0exftUjARjZWnqZ4Rv1oR+TXUJrX1YPgkzsyz0POS6S4tVGZ1xji9YjgKhdeOEtOYGGEvERKQS69r0e7yQ593UdaZcDw9VE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706175776502.9703693400895; Wed, 24 Sep 2025 02:29:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoL-0004aX-ST; Wed, 24 Sep 2025 05:29:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoE-0004XV-Bz for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lo8-0004l1-3V for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:09 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-VhKQ_cnYO02k3-A56ORUzw-1; Wed, 24 Sep 2025 05:28:59 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b2e9e07a887so205178266b.0 for ; Wed, 24 Sep 2025 02:28:59 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3163e9b70esm236882566b.42.2025.09.24.02.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CxCkSne5lIEz+6v/DtZSGsRBXxpV2mGxzrf4U3hlZ3E=; b=PEI6OK/gGyeNRZI/KglddCdc4j/Sq+mRFw9AHLTAnkRy30FaIWTaX574u3A/UJJCTJcMp+ QarQUGwaJ0KL46uOW7npq4WRtCVuwUVAIEcw+GjY6jxq5+xiEmhZh4KhncohpuiHBAPIda 2uQ/gSvKSmhNcTlN+7vyXFaMhte/1ks= X-MC-Unique: VhKQ_cnYO02k3-A56ORUzw-1 X-Mimecast-MFC-AGG-ID: VhKQ_cnYO02k3-A56ORUzw_1758706138 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706137; x=1759310937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CxCkSne5lIEz+6v/DtZSGsRBXxpV2mGxzrf4U3hlZ3E=; b=Jgajjco0qRlGWIDcXrrEfGJy2dLZnI+d9gwsHWTEtoree76RSb/nAyIYjSfqp4UKw1 92vPEQ6kxesDWlyP8+GiV3Ey8llZKHrvsZTr8p4Mj71epV0AO6pjYw+6QfZlCT977BET uNz5/Cek7z1n6VXoHEiGr7ugKg53fMhTAX8CNuwxdNVBVQsWw5Ph6bI6YIQpT7L7GJvm qQ6kzUUfWIcpOddcXuTYXffkx2GIq0KBXlIEo4z0GD9ppabzuMop2lR2kRE0VycMlNOl hUkO2llwAbAlGroAOem97bHoVHM7F+hPCJ+QfTWKMISBN4Yv2qhyMsBJb2AixG6nnKcH fttA== X-Gm-Message-State: AOJu0YzS5WfJDd8yfaLn6Brf471Fk6VGOH5ERH/BggTTwOB9eMV8Xwpg X3/FTE+RuLPVW6icv7wbJBcdK4d8srVVeHGQCFZ0mQ5l4EBwoMjKe80GM87qZMu4MSYK3RKURth btQ0JDGJVpxVTopQMNEEvDq9OFu+rGbrHKdv4gpxvMWAILmUMrVoeyeglFIQyl/BWnmxga6R/Cq JsI1TKqgqPkQdxhB78r/m5IPH3Ie6avsXrHZsl1vQp X-Gm-Gg: ASbGncsbeVfTUt9mUJxpKvjTVkCacvrj7ROiUyrKBhHX1cTmCI3MuqBBgxZH2LFuTuK x2WhJXf3UfsqV5khbG9a5BO3uDSa1bEeGr1zVHL50IaKDmF9/8ueSGLLhdlbkCCKVcr7hDhIi76 DydLJTKqxJTzCc9bTGrzfrrpJsR8b1GmiyuUF2xQd8xuCG7srsE6Io1d3KXO3JXZMZTb56kPvw7 zFJtBGx5C+X5dxdr/Wm2i/uSx9PIOBoMXRi0xzg3zXgEyUYXbxo82fCZOcuvmadDZcDQlj0osow VN2iUMWFSeIagJ7hsch7RWAA8S8v66vUvJPOJ551rW+wHDOOs1yOHFR3aRWV62UVp1xhYkCNsrl +0u81DDjK97Sa1PpoNkzcwMHX2SnjDgK5gMBSOl2Rfh3b3g== X-Received: by 2002:a17:906:f590:b0:b2e:51cc:9b9 with SMTP id a640c23a62f3a-b3027d3e5a8mr550170466b.24.1758706137287; Wed, 24 Sep 2025 02:28:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMW/EaiCphCU8LY3mf9U8MF3IfLZCXOhbU5+69ONTRLAqAHzNSWw8O9susRhfo321/NvySiw== X-Received: by 2002:a17:906:f590:b0:b2e:51cc:9b9 with SMTP id a640c23a62f3a-b3027d3e5a8mr550168266b.24.1758706136793; Wed, 24 Sep 2025 02:28:56 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis Subject: [PULL 02/29] rust: build: add back common and util tests Date: Wed, 24 Sep 2025 11:28:22 +0200 Message-ID: <20250924092850.42047-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706177882116600 Content-Type: text/plain; charset="utf-8" These were dropped by mistake when extracting the crates. Reviewed-by: Manos Pitsidianakis Signed-off-by: Paolo Bonzini --- rust/common/meson.build | 3 +++ rust/util/meson.build | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/rust/common/meson.build b/rust/common/meson.build index b805e0faf57..07d073182ed 100644 --- a/rust/common/meson.build +++ b/rust/common/meson.build @@ -24,6 +24,9 @@ _common_rs =3D static_library( =20 common_rs =3D declare_dependency(link_with: [_common_rs]) =20 +rust.test('rust-common-tests', _common_rs, + suite: ['unit', 'rust']) + # Doctests are essentially integration tests, so they need the same depend= encies. # Note that running them requires the object files for C code, so place th= em # in a separate suite that is run by the "build" CI jobs rather than "chec= k". diff --git a/rust/util/meson.build b/rust/util/meson.build index 87a893673d2..96330504459 100644 --- a/rust/util/meson.build +++ b/rust/util/meson.build @@ -44,6 +44,10 @@ _util_rs =3D static_library( =20 util_rs =3D declare_dependency(link_with: [_util_rs], dependencies: [qemuu= til, qom]) =20 +rust.test('rust-util-tests', _util_rs, + dependencies: [qemuutil, qom], + suite: ['unit', 'rust']) + # Doctests are essentially integration tests, so they need the same depend= encies. # Note that running them requires the object files for C code, so place th= em # in a separate suite that is run by the "build" CI jobs rather than "chec= k". --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706402; cv=none; d=zohomail.com; s=zohoarc; b=PxCK8DJMV1zTmgT0mDVDSy3jHFdpvE7pBKfiDSBlLGkiYh6CBrT2hIK2Ifyfga/MSwaMJS9uI4ByKX6VnG8rCZkDUqcMm8qu7amggzOpGWSztC/e7nTL4uq63WNODEcqre8Q2pCRwPnuQcAkcaHtmRzncPbYvqNk2LzCYC44BEg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706402; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4hJt6IuC0vyLZr1331KBBwz4pXpM7XhSe3x8xtgsFGY=; b=X8uOszXOozhU/nR/txVaWICH7EknWWOjTXTz4jXENnE/j/F5iN3gb9OQVCKRPpPfMIlcUdQk6CV7LJUiYJOmVuIbav6vLMRbj/mKBTydWDeM5PzN7RiYn0nmXCCm1dGQ24otv8gX2J0hwYb4IYfC8Fir79MCMmK/XNserHq8IYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706402954800.7748163677738; Wed, 24 Sep 2025 02:33:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoQ-0004cs-2f; Wed, 24 Sep 2025 05:29:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoI-0004Zb-4K for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoA-0004l9-AQ for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:13 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-yWbQS6yIOzCWA7W7P8XqXg-1; Wed, 24 Sep 2025 05:29:02 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b2ef8e0133fso214148266b.0 for ; Wed, 24 Sep 2025 02:29:01 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2d5c22db22sm569500866b.68.2025.09.24.02.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4hJt6IuC0vyLZr1331KBBwz4pXpM7XhSe3x8xtgsFGY=; b=bA3WSt/13oqw6SIib8q3bTo+SIen5MC5bZKgtdGzRkNHk/Gx0gOlMNk+Ly/2L6oPSwW08J zFUI5MgoKMJXc4LHIlRHp+ntNVwsAq7NZjDW8E2IDRHvGvcLUBb2wKm2OMjGzdZvS3CQEJ EeFxBdZ7LwdkLzlZ4toEUn+6nUJY1+0= X-MC-Unique: yWbQS6yIOzCWA7W7P8XqXg-1 X-Mimecast-MFC-AGG-ID: yWbQS6yIOzCWA7W7P8XqXg_1758706141 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706140; x=1759310940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hJt6IuC0vyLZr1331KBBwz4pXpM7XhSe3x8xtgsFGY=; b=jS8QSWM90+spZePC6iWyzzmgnTqxC804HCFOeTmf/LftgWvixlZTddD9uUoUX6siLy oUUXYkjMHapizTfcKTXTJHdgJz8Asr/6jW67eTDDjvf2XyGgetAxoACSWFP4tVl4RdEJ AGNcSqoRgQqo5YQosklrMaNUaC6WtEnt3Itp8eCpzL90ACy1t8J+oFbrsSNKes8tKKl2 h0d8WehXyOYnRtAnPfXj4UCl49X7KyVVVN/B0IBeBKnHi49idJGICdDTRwTdCP7fwKWF +QC9J0znDJ4H6TrJD9lDgV5AMSl2qUxBmlz0gsm/VHPgCWyXla94pkwmEtwfiv99m5WY QaTw== X-Gm-Message-State: AOJu0YwUBiJ9lmv/+jPLC4PFcx7QVgYCOcNVzW+dWACehdkKwCnZZNkV a2EhhDfBXJ+dA5AlqEgR0LtIYaSvhN0XWA7Eg08CwmjgIIL/cfWnoMwIqPbS4M95jYkGfyscu/g 876X7VgUAfrsjho3btySNEqx7KBnNN4Hbun1Iy3JyivyWTfkYhZIY54aUZ/QWfQ7mK9Rzjgv7iL fk4TG6V/upHcHHwykCIESPcXJ0Zx8Jqn3EHIVgjJYo X-Gm-Gg: ASbGnctTFrbfsUY+6L+jHVlFTAN6ZmTLmOQshxo2bn60apOLA3YSpTvcA6peazTj9HR 2ncZviUEdXGKBc38rAZ7R1PJOxPWCPDTMQiBi09mGicIpRHTjzVzwVv4yZgKXc2ZWszAbDN4DqD 3ngTVhTY1T2ywttIeOtetVPqaVfFfFJ+O+M66hhAxRe8NsJoKWA2i2ipVijtNazOGlWbXg5KMJe VwrUZucP7skV491AGIR4/IFsWp6JH+CkOZHa1Ph6ANXP19JJuuZY4JyIj5h78pMauaq9OET//k9 3ICEmyEj1cWBobpGSYClT+ZFoLkJBr6QY2y5jnj737gm5DAHLKOptzhtioZXe1a+61B7t2EVq9a vsRIxaVKD9z2JzoR/jvaXKcfsiLnqXtkyKoLOLtMA80C90g== X-Received: by 2002:a17:906:c14e:b0:b07:c714:f3ca with SMTP id a640c23a62f3a-b302a84f6c9mr589812966b.50.1758706139944; Wed, 24 Sep 2025 02:28:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGRiKSUbM+jAMl5IXfzA8a/ZgIWbv3ntJ5e6m1yyWXXoz6LFLxkpFfEk0Dx/CXRehI2E8cfQ== X-Received: by 2002:a17:906:c14e:b0:b07:c714:f3ca with SMTP id a640c23a62f3a-b302a84f6c9mr589810566b.50.1758706139441; Wed, 24 Sep 2025 02:28:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis Subject: [PULL 03/29] rust: vmstate: use "cast()" instead of "as" Date: Wed, 24 Sep 2025 11:28:23 +0200 Message-ID: <20250924092850.42047-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706404919116600 Content-Type: text/plain; charset="utf-8" Reported by clippy, fix it. Reviewed-by: Manos Pitsidianakis Signed-off-by: Paolo Bonzini --- rust/migration/src/vmstate.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/migration/src/vmstate.rs b/rust/migration/src/vmstate.rs index c05c4a1fd66..e04b19b3c9f 100644 --- a/rust/migration/src/vmstate.rs +++ b/rust/migration/src/vmstate.rs @@ -144,7 +144,7 @@ macro_rules! vmstate_of { $crate::bindings::VMStateField { name: ::core::concat!(::core::stringify!($field_name), "\0") .as_bytes() - .as_ptr() as *const ::std::os::raw::c_char, + .as_ptr().cast::<::std::os::raw::c_char>(), offset: ::std::mem::offset_of!($struct_name, $field_name), $(num_offset: ::std::mem::offset_of!($struct_name, $num),)? $(field_exists: $crate::vmstate_exist_fn!($struct_name, $test_= fn),)? --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706320; cv=none; d=zohomail.com; s=zohoarc; b=GRH1qB5yqkrFU8RaF+D/7KpT475avbbudJvJk+KArKwgWNGmSvzEsEdW+me4MQrfgIbVDaBJ6BXyaF4NfSXpKK8Im9DE5UbPunJFbphHcy4uR87xQiEOmC0bwdLCl3sKeq6J+A2ZOo+FoAk9r/MLoYzu2f78FmD1iH/jtHaEA3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706320; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/mGe1RNZOMFuiqKM/TEXFkBBUfbfbrXn7gTWkrNC4UA=; b=fjQfwYJy5NAR2navuG0ZgPI9V2zVWml1hp2zxFg1UPubfowNx5HTfgy9/PwUQG1BwU7Wkq2kdBqc/dtBN7OH/5P9bhztWqBUwx0yGXiv8AMoiNFmGUTwK4l6qDq2N2LrY3K0uajQ76gE1OxLEQferKe+NE0dPxceu7tfzWzk+hk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706320206699.6995280922796; Wed, 24 Sep 2025 02:32:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoQ-0004d0-Cz; Wed, 24 Sep 2025 05:29:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoM-0004bb-IX for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoB-0004lR-9D for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:17 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-Msg-lM61MhiHBs2frcFGTA-1; Wed, 24 Sep 2025 05:29:04 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b2fca156551so75321266b.1 for ; Wed, 24 Sep 2025 02:29:04 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2713332a68sm1096623066b.99.2025.09.24.02.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/mGe1RNZOMFuiqKM/TEXFkBBUfbfbrXn7gTWkrNC4UA=; b=Ybk0pX1Z6SvjcEiqXgxO9A3aQj61yzXlZrzXUgp+utsb3qmzsfuRZDIdBQI/Al6sUas1c5 syYCoZBRHcnUuSXFuJ6jsvNouZUpesoLYYj2Cj8GfrOm8bRdpEN0ZAGQVnF2RTutyUStFX MMPSNmMAIXYaGXREZveZ3uHfvEHJMeo= X-MC-Unique: Msg-lM61MhiHBs2frcFGTA-1 X-Mimecast-MFC-AGG-ID: Msg-lM61MhiHBs2frcFGTA_1758706143 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706142; x=1759310942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/mGe1RNZOMFuiqKM/TEXFkBBUfbfbrXn7gTWkrNC4UA=; b=uUI4f4uHdcWvKUF1dIoPvZPds+uUyc502A/D83FFWxq5cBW8r2B/vWDDlKzPsWVH8x /NIKfyzsMlGCwN4gXU+Ul0t3F5SVgd05uqpfQ+S4obBkqTxyUCLvxHBKToomp4Aztj75 tNU9sfQJGJsQqMOAFB3frfp2bINaCa1fZ/FApl9uivcx3Atof0GrdX8rz42eFyZ1lvrV 1cjarAITCGjBGWCk0rTO5xT91Q49d5db7tgIuzjQ4pq7DzmcWHBQSgnpH1WK1J5vf4K9 Lk6Tk9dfNH853q0SIS8t5I/kPitTCNajGZ2eT6QF7Jd6lY3mtJY+tLSS4w3MR8MBPBVq f1xw== X-Gm-Message-State: AOJu0YwOVppIufYKsT7qmaIITQ9ksod88IMIOfCXaAblVFhnwTZg9xDM XhOYxLgmCSN7FZyFGJl0aCYKgetOp5RUkEqCAPtvp1y7I1c5s3K9DHZgWrx5fwDcMHuflcX14iI BH489qFsK5TBWCIwhZijRUPYI8u7mPrJJU9mduh6uvOkLF3CsxSIbtl3x67qvGEFh1/RkujNjyc z7ZFSiyjGtZ1BtLv5PeT7kiMSr1OQ/ZCR/AFaLWcD3 X-Gm-Gg: ASbGnctWtExwr/sZp3TrN/F+HpvkelNRpRawPPSGbd6QB/JdU4/BSr0aKlzmPuELAA6 Ec3Fo7HFZEhIYS+4fjMtU9U0Ok1MeRDg3lNJD0SUBQT1UYaeo+lwOJSDfDTOetsnhaQ92RPdECN L04GFPPH8u7UFAvUbpqa4iEBp68uQ4atWhpyzpMyZrKZmEM22G3AC+91Z6HakSobBenzTD0Xp+F MftIjCxl4OXP2fXaJyTaleadS0cstCT1FI0YMZmHOMIqmSvg+1PmvpJGS7XKn1/MdwhwniIjQQq 68rn/vlhy0eiMk02chUFe+wJzrDwnP7hd4+EzFuco7eUz+ROnvPbx57faYSwxLtBXDQcwI9golb A2BdEr1KEvD/9dRFAjzgFDEoz8Vv5dV2pUpx0dE6K9e7C3A== X-Received: by 2002:a17:906:7953:b0:b2a:47c9:8ff5 with SMTP id a640c23a62f3a-b32c9898862mr206071666b.10.1758706142207; Wed, 24 Sep 2025 02:29:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnFUqr714rN43b87P1Pk5M6M0dHEWb7no3YtufmOcSFtpQIFVGypgmJPP3vB0WNKLpL/B5bw== X-Received: by 2002:a17:906:7953:b0:b2a:47c9:8ff5 with SMTP id a640c23a62f3a-b32c9898862mr206068366b.10.1758706141716; Wed, 24 Sep 2025 02:29:01 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis Subject: [PULL 04/29] rust: build: remove "protocol: rust: from doctests Date: Wed, 24 Sep 2025 11:28:24 +0200 Message-ID: <20250924092850.42047-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706324054116600 Content-Type: text/plain; charset="utf-8" It is added already by rust.doctest. Reviewed-by: Manos Pitsidianakis Signed-off-by: Paolo Bonzini --- rust/bql/meson.build | 1 - rust/common/meson.build | 1 - rust/migration/meson.build | 1 - rust/qom/meson.build | 1 - rust/util/meson.build | 1 - 5 files changed, 5 deletions(-) diff --git a/rust/bql/meson.build b/rust/bql/meson.build index f369209dfdd..7214d944089 100644 --- a/rust/bql/meson.build +++ b/rust/bql/meson.build @@ -47,6 +47,5 @@ bql_rs =3D declare_dependency(link_with: [_bql_rs], # in a separate suite that is run by the "build" CI jobs rather than "chec= k". rust.doctest('rust-bql-rs-doctests', _bql_rs, - protocol: 'rust', dependencies: bql_rs, suite: ['doc', 'rust']) diff --git a/rust/common/meson.build b/rust/common/meson.build index 07d073182ed..aff601d1df2 100644 --- a/rust/common/meson.build +++ b/rust/common/meson.build @@ -32,6 +32,5 @@ rust.test('rust-common-tests', _common_rs, # in a separate suite that is run by the "build" CI jobs rather than "chec= k". rust.doctest('rust-common-doctests', _common_rs, - protocol: 'rust', dependencies: common_rs, suite: ['doc', 'rust']) diff --git a/rust/migration/meson.build b/rust/migration/meson.build index 5e820d43f50..2a49bd1633e 100644 --- a/rust/migration/meson.build +++ b/rust/migration/meson.build @@ -48,6 +48,5 @@ migration_rs =3D declare_dependency(link_with: [_migratio= n_rs], # in a separate suite that is run by the "build" CI jobs rather than "chec= k". rust.doctest('rust-migration-rs-doctests', _migration_rs, - protocol: 'rust', dependencies: migration_rs, suite: ['doc', 'rust']) diff --git a/rust/qom/meson.build b/rust/qom/meson.build index 40c51b71b23..21e12148da4 100644 --- a/rust/qom/meson.build +++ b/rust/qom/meson.build @@ -38,6 +38,5 @@ qom_rs =3D declare_dependency(link_with: [_qom_rs], depen= dencies: [qemu_macros, qo # in a separate suite that is run by the "build" CI jobs rather than "chec= k". rust.doctest('rust-qom-rs-doctests', _qom_rs, - protocol: 'rust', dependencies: qom_rs, suite: ['doc', 'rust']) diff --git a/rust/util/meson.build b/rust/util/meson.build index 96330504459..7ca69939ce5 100644 --- a/rust/util/meson.build +++ b/rust/util/meson.build @@ -53,7 +53,6 @@ rust.test('rust-util-tests', _util_rs, # in a separate suite that is run by the "build" CI jobs rather than "chec= k". rust.doctest('rust-util-rs-doctests', _util_rs, - protocol: 'rust', dependencies: util_rs, suite: ['doc', 'rust'] ) --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706189; cv=none; d=zohomail.com; s=zohoarc; b=KleaKJzMLaPx9pyJ4utF5Shxg2M/fBtQ1cG8lB/uJmCAQCsj2A6C5cNNgwQ+2om6fbMZfTAobZuM0SDF8Vbs1jO/7ehdRAXpOGH7rFzgjI4WyoQy82xjsBJ2dpZYDuTsdE8MYVZOQLi8PXVY97QbIPX8JVmeiekOz1fOGld/O/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706189; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4J9lM6M2NH6+IBy5oZZhi7qe3sJv/LOLw1XFzXMwbNc=; b=eYfs8/7xex9oKvphoR8a8Kt38zG5K2d/EB3arPxsvGiN5EVGGUOo4fE014ifOvaidc5+0uNpVY0JJGW3P10wUQzYzLZ5o1b2UCs5Uos2VORVClXGLMazNNdLXNpe1nrXMAw7LuW+zCQMHdagKu2YftNrJa4VcqMj2kAJaufYlzk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706189184389.6076859592888; Wed, 24 Sep 2025 02:29:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoR-0004dO-Oo; Wed, 24 Sep 2025 05:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoP-0004cr-Px for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoE-0004ll-CC for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:20 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-3rvgeYAFMqKSbzowkChNEw-1; Wed, 24 Sep 2025 05:29:07 -0400 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-631dbb59345so5553742a12.3 for ; Wed, 24 Sep 2025 02:29:06 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6347788dc8bsm1688110a12.9.2025.09.24.02.29.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4J9lM6M2NH6+IBy5oZZhi7qe3sJv/LOLw1XFzXMwbNc=; b=gHBgRBh4KQAcTf62FtLQvUhjnm4vpRGl/vfYFiTGlvxDb9GGmQ2wemp9zFhWi5ruEjsTep q4esAbuNL6jxu5KOOIYmbIw/0AkIXgaIzkltkU0u0A52tBXoTUqc2y4HFc0bfe0vte5A+l 1h5da82AQFoLfCJnObCCEKr3xzs9jpI= X-MC-Unique: 3rvgeYAFMqKSbzowkChNEw-1 X-Mimecast-MFC-AGG-ID: 3rvgeYAFMqKSbzowkChNEw_1758706146 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706145; x=1759310945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4J9lM6M2NH6+IBy5oZZhi7qe3sJv/LOLw1XFzXMwbNc=; b=j06J7g2+jPETuN4ZGYHPSgJuf7RL7wdbLK7Y6I0cU5wQd2qAnhyDfY3maSmWYRvCJ5 /TbW1CycaGGWPYSn+82AKVLca/CLJAwIxsbH2y+9GtgWK8vM2NEBnddZ6/hm2WtMj/r2 +j9rl1+jNNJcHXeeqZKXPspXf7Ad5B+mkvcySd65QWNDI/IZtkrtMC2xMcdjyFB/Evxr RxKxMxiroGTZ1x3+GQrB17PpDjOyRPGHQLP4AfYlAigCHwXU1TePiwdmP4UgAJRCe0/Q Zr7IWSilkncB4qVKgUGJFDt8HCu+03MqNKjB7Is9BL+ghqch5UZRGqFgMSdaMO78KwvG /Zlg== X-Gm-Message-State: AOJu0Ywh0t5Bu5ysofj5Jt/EHckk9VNUb3w+0lEK97MWDg5RSqv8uroi edRYNSNzqBVG+wMSCLP2jpmSN7Qj1/duxSTCwwy+k8pdE7svE+CJ5ykbvYQyFAt7sw/jhrFKCZS Sfu/6jTEBQOocD0rRtohTYjXiko+9PkoLHEkKNitNowfzV0/mUeq7WqfyJ6NhPVFgPVQZjkkHLE B73uxlkmNBxt7AWuAlnIxJlVrD3LfXfbwew2NNYPSp X-Gm-Gg: ASbGnctrlzeIsMxXzs+8LfO7mlS77Gvyo3tUm618loWqM689Dp5tyOeRD4iX7+wJFck NadvCCOj258+jmM5d4eEJEvMEP6dqUKS0inhPu7JefT7KMoQwGngiuMtVynNV6RfCAiBzGmPhyR lE6zcRVLjWk190AgtqI+mX3BSV2Gywd6Qdd84SeX4OF0JVaHInW48fBYW4PyEwM2GHwssfXQUCA j1UszfXFWhUBgalcOF0Klv/yGA98VCctLsFjihxnHMS8UzACaPxz/lmTyKWD97dZMHsf2GGX7Rd EqZOHp4fqJqfCSXLe+ONV0l4ta8/9RzL/0ITTHlZNLYv9MQGXO7P5wkiTSzfMRuXr4Ilf8wOH/4 qWJrSeDlHhSIQZvkWB9ZS0QaOKyeFWeo4kMgW1+J8IGfZ0A== X-Received: by 2002:a05:6402:505a:b0:62f:65f5:a8cd with SMTP id 4fb4d7f45d1cf-63467679abamr4666552a12.7.1758706145313; Wed, 24 Sep 2025 02:29:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvcC8bkXEj/h60ZkLfx+nh+e6fwJ3ON1CaVmstnBdpVSz8tjJ6xPKUf2NaNIaJWQdAihqaqg== X-Received: by 2002:a05:6402:505a:b0:62f:65f5:a8cd with SMTP id 4fb4d7f45d1cf-63467679abamr4666530a12.7.1758706144716; Wed, 24 Sep 2025 02:29:04 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 05/29] subprojects: add attrs crate Date: Wed, 24 Sep 2025 11:28:25 +0200 Message-ID: <20250924092850.42047-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706190228116601 Content-Type: text/plain; charset="utf-8" The attrs crate is a simple combinator-based for Rust attributes. It will be used instead of a handwritten parser. Signed-off-by: Paolo Bonzini --- rust/meson.build | 2 ++ rust/qemu-macros/Cargo.toml | 1 + rust/qemu-macros/meson.build | 1 + scripts/archive-source.sh | 2 +- scripts/make-release | 2 +- subprojects/.gitignore | 1 + subprojects/attrs-0.2-rs.wrap | 7 ++++ .../packagefiles/attrs-0.2-rs/meson.build | 33 +++++++++++++++++++ 8 files changed, 47 insertions(+), 2 deletions(-) create mode 100644 subprojects/attrs-0.2-rs.wrap create mode 100644 subprojects/packagefiles/attrs-0.2-rs/meson.build diff --git a/rust/meson.build b/rust/meson.build index c7bd6aba45f..b3ac3a71970 100644 --- a/rust/meson.build +++ b/rust/meson.build @@ -13,10 +13,12 @@ libc_rs =3D dependency('libc-0.2-rs') subproject('proc-macro2-1-rs', required: true) subproject('quote-1-rs', required: true) subproject('syn-2-rs', required: true) +subproject('attrs-0.2-rs', required: true) =20 quote_rs_native =3D dependency('quote-1-rs', native: true) syn_rs_native =3D dependency('syn-2-rs', native: true) proc_macro2_rs_native =3D dependency('proc-macro2-1-rs', native: true) +attrs_rs_native =3D dependency('attrs-0.2-rs', native: true) =20 genrs =3D [] =20 diff --git a/rust/qemu-macros/Cargo.toml b/rust/qemu-macros/Cargo.toml index 3b6f1d337f8..c25b6c0b0da 100644 --- a/rust/qemu-macros/Cargo.toml +++ b/rust/qemu-macros/Cargo.toml @@ -16,6 +16,7 @@ rust-version.workspace =3D true proc-macro =3D true =20 [dependencies] +attrs =3D "0.2.9" proc-macro2 =3D "1" quote =3D "1" syn =3D { version =3D "2", features =3D ["extra-traits"] } diff --git a/rust/qemu-macros/meson.build b/rust/qemu-macros/meson.build index d0b2992e204..0f27e0df925 100644 --- a/rust/qemu-macros/meson.build +++ b/rust/qemu-macros/meson.build @@ -8,6 +8,7 @@ _qemu_macros_rs =3D rust.proc_macro( '--cfg', 'feature=3D"proc-macro"', ], dependencies: [ + attrs_rs_native, proc_macro2_rs_native, quote_rs_native, syn_rs_native, diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh index 035828c532e..476a996a70d 100755 --- a/scripts/archive-source.sh +++ b/scripts/archive-source.sh @@ -27,7 +27,7 @@ sub_file=3D"${sub_tdir}/submodule.tar" # in their checkout, because the build environment is completely # different to the host OS. subprojects=3D"keycodemapdb libvfio-user berkeley-softfloat-3 - berkeley-testfloat-3 anyhow-1-rs arbitrary-int-1-rs bilge-0.2-rs + berkeley-testfloat-3 anyhow-1-rs arbitrary-int-1-rs attrs-0.2-rs bilge-0= .2-rs bilge-impl-0.2-rs either-1-rs foreign-0.3-rs itertools-0.11-rs libc-0.2-rs proc-macro2-1-rs proc-macro-error-1-rs proc-macro-error-attr-1-rs quote-1-rs diff --git a/scripts/make-release b/scripts/make-release index 87f563ef5f7..bc1b43caa25 100755 --- a/scripts/make-release +++ b/scripts/make-release @@ -40,7 +40,7 @@ fi =20 # Only include wraps that are invoked with subproject() SUBPROJECTS=3D"libvfio-user keycodemapdb berkeley-softfloat-3 - berkeley-testfloat-3 anyhow-1-rs arbitrary-int-1-rs bilge-0.2-rs + berkeley-testfloat-3 anyhow-1-rs arbitrary-int-1-rs attrs-0.2-rs bilge-0= .2-rs bilge-impl-0.2-rs either-1-rs foreign-0.3-rs itertools-0.11-rs libc-0.2-rs proc-macro2-1-rs proc-macro-error-1-rs proc-macro-error-attr-1-rs quote-1-rs diff --git a/subprojects/.gitignore b/subprojects/.gitignore index f4281934ce1..983c4c1549e 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -8,6 +8,7 @@ /slirp /anyhow-1.0.98 /arbitrary-int-1.2.7 +/attrs-0.2.9 /bilge-0.2.0 /bilge-impl-0.2.0 /either-1.12.0 diff --git a/subprojects/attrs-0.2-rs.wrap b/subprojects/attrs-0.2-rs.wrap new file mode 100644 index 00000000000..cd43c91d63e --- /dev/null +++ b/subprojects/attrs-0.2-rs.wrap @@ -0,0 +1,7 @@ +[wrap-file] +directory =3D attrs-0.2.9 +source_url =3D https://crates.io/api/v1/crates/attrs/0.2.9/download +source_filename =3D attrs-0.2.9.tar.gz +source_hash =3D 2a207d40f43de65285f3de0509bb6cb16bc46098864fce957122bbacce= 327e5f +#method =3D cargo +patch_directory =3D attrs-0.2-rs diff --git a/subprojects/packagefiles/attrs-0.2-rs/meson.build b/subproject= s/packagefiles/attrs-0.2-rs/meson.build new file mode 100644 index 00000000000..ee575476cb2 --- /dev/null +++ b/subprojects/packagefiles/attrs-0.2-rs/meson.build @@ -0,0 +1,33 @@ +project('attrs-0.2-rs', 'rust', + meson_version: '>=3D1.5.0', + version: '0.2.9', + license: 'MIT OR Apache-2.0', + default_options: []) + +subproject('proc-macro2-1-rs', required: true) +subproject('syn-2-rs', required: true) + +proc_macro2_dep =3D dependency('proc-macro2-1-rs', native: true) +syn_dep =3D dependency('syn-2-rs', native: true) + +_attrs_rs =3D static_library( + 'attrs', + files('src/lib.rs'), + gnu_symbol_visibility: 'hidden', + override_options: ['rust_std=3D2021', 'build.rust_std=3D2021'], + rust_abi: 'rust', + rust_args: [ + '--cap-lints', 'allow', + ], + dependencies: [ + proc_macro2_dep, + syn_dep, + ], + native: true, +) + +attrs_dep =3D declare_dependency( + link_with: _attrs_rs, +) + +meson.override_dependency('attrs-0.2-rs', attrs_dep, native: true) --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706396; cv=none; d=zohomail.com; s=zohoarc; b=RjKmr14GZlPe3RqxqWf48HPvgFEewAFa9/ENVnLRUab2k/YU1rPrmtjMMU656ofcqEbty3qQKNnxmq7bT4njZSKidgwWt3SqlhFtBg1pU41+C6Syei/DV0ENDd0HQqqJLFBiwvPBV6S2ccGSb+7/A7KU1P0dqFfcrRw5R7jeEOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706396; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=i/j0P/MSV+X5BLJW2jx5BBKNa2M5lI05wnZcxCRbxSk=; b=OVWIpEBpFvPUu7VjTUXIYINZZW0qKVeDCTN4GinfJxVmzTHVQa7QpEzQxy3iaiN/nP2nbqKRPKX50fTrJrL9QeDZBqLTCf+HGV5ifObRKLXo6vEsPE9Iz2MHnzj7iOkMGBzPEOLkDqohMMYEghsne7pkMNT5N9f7UGx8yqkZ43c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706396344416.82260229622364; Wed, 24 Sep 2025 02:33:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoT-0004ff-U4; Wed, 24 Sep 2025 05:29:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoS-0004dY-9E for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoP-0004me-K0 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:24 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-7XHbMKErPqySi057Tk8vvQ-1; Wed, 24 Sep 2025 05:29:17 -0400 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-b2f989de76eso73893966b.1 for ; Wed, 24 Sep 2025 02:29:16 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2ba267f745sm720317166b.33.2025.09.24.02.29.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i/j0P/MSV+X5BLJW2jx5BBKNa2M5lI05wnZcxCRbxSk=; b=e57obKe10H4g6OtLrJIkU5K5x7Jb7LO773GgveJfHizi+W+u4TkrS21YD32LiwillxPTQ5 znX7//Lh4xTjfJOb9CPUv19oMGoX7EIDuE5xsu05OxKnyUuIOomEv26dq6ttMNHKsqfiz6 7YppdldRViuHhSZxalsRB6CHHAytmh4= X-MC-Unique: 7XHbMKErPqySi057Tk8vvQ-1 X-Mimecast-MFC-AGG-ID: 7XHbMKErPqySi057Tk8vvQ_1758706156 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706155; x=1759310955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i/j0P/MSV+X5BLJW2jx5BBKNa2M5lI05wnZcxCRbxSk=; b=P5dpGzEIkXQylxdIo26kHarcbh3S/aoBrpAbxomZbrFDEQA3qK/jFjueiF2dAj/UEk z2xhzc2l/Fecf28Hjeku8EM09Sj5oGLA+MQqf9Bg3osEc0qi1Lh7zYzPjGNmerD6u5X/ 9Jv4Pj+1uRAEtB7hrbZuZ/Oi1xW1EgSwYk3+T2hPlH2z+mZQGfhewKfFCbaaucPRCgWy 3vjfJylxD5R1Wgls1d+X+EufEENueq+Mg3KtDpB/cQ5wO8KFhG1otHwDVLCtdjsCE3G4 PWHP4vrv3n7SVBWc0akNBIdc3uCuC2lfObMolYMdeEAEmxv4u49ltgs7dWtZ5atvveMU UEVg== X-Gm-Message-State: AOJu0Yw/PwcGmouXHxYUnR2YBcSYiDyhhXJYXfHVf8hoziShwbP3NrJk HoN+DH0L14PgGgAAxG/Lj+Jrca0heglkan/BNamVtoAFZleSkO86DCdTfu0a3O+P+0ooVB4SYWr lttBYL3AghtDO6FXpSROtzDNi4K6XmmLF5JV0Ne/Tt/LtPXjn8cHuqP5PkQBjyJa4EoqrEXfmOT mXitUxHDn5dpb/8z4kMedEGYOq/rePNRLsAQ3mszEC X-Gm-Gg: ASbGncvKIjVzmDndnMEVCdq7wc4A9AsLjRcFX8uqCYjRudmuJIaBkNzOQM23cPU0puv zOJZT8GAVecfS7CYMijoVbgTu79KKP3/4ItEmxJLal7CbaHLD+GNuQiMnuILHOpHDEoU2DcyWvh zc+uGmAejs8UdCmbMHi9ROIooxByPE10/q2u/oLP9N60KZXykzoorPuDAu1GVzMthNOWyQZxU16 n5w9RP2vJfx4qJVwblP03h432DiOJs847HiU7HF/6xzzfjj7CYl8/tqJCg4DzBBbHAsnd7OEmVR OaMKbwwvM6Nf8DK6SeemduxfWM2HPQ5VI2q+bTQ5ll2EpYeNPsjdte4kLDvJFrkzTENPbKJHG9C CK85vQOuUg/GJLWcjCIzXSiWZVn/AbA2fOEfIqYQCwAP7QQ== X-Received: by 2002:a17:907:d1a:b0:b2a:10a3:7112 with SMTP id a640c23a62f3a-b32caf90a7emr175817066b.24.1758706154963; Wed, 24 Sep 2025 02:29:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMlv3+YnITlkTGPOSxHh5xSGdLNPdYRVziQLvktkLpNKacbi9KQjjECAXYQhgJxXfHsYOOKQ== X-Received: by 2002:a17:907:d1a:b0:b2a:10a3:7112 with SMTP id a640c23a62f3a-b32caf90a7emr175776166b.24.1758706146742; Wed, 24 Sep 2025 02:29:06 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 06/29] rust: qemu-macros: switch #[property] parsing to use combinators Date: Wed, 24 Sep 2025 11:28:26 +0200 Message-ID: <20250924092850.42047-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706397169116600 Content-Type: text/plain; charset="utf-8" Since we are going to add more attribute parsing for high-level migration state macros, use the attrs crate instead of a handwritten parser for device properties as well. Signed-off-by: Paolo Bonzini --- rust/Cargo.lock | 11 +++++ rust/qemu-macros/src/lib.rs | 86 ++++++++++++++--------------------- rust/qemu-macros/src/tests.rs | 8 ++-- 3 files changed, 49 insertions(+), 56 deletions(-) diff --git a/rust/Cargo.lock b/rust/Cargo.lock index eea928621a7..8315f98c46f 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -14,6 +14,16 @@ version =3D "1.2.7" source =3D "registry+https://github.com/rust-lang/crates.io-index" checksum =3D "c84fc003e338a6f69fbd4f7fe9f92b535ff13e9af8997f3b14b6ddff8b1d= f46d" =20 +[[package]] +name =3D "attrs" +version =3D "0.2.9" +source =3D "registry+https://github.com/rust-lang/crates.io-index" +checksum =3D "2a207d40f43de65285f3de0509bb6cb16bc46098864fce957122bbacce32= 7e5f" +dependencies =3D [ + "proc-macro2", + "syn", +] + [[package]] name =3D "bilge" version =3D "0.2.0" @@ -188,6 +198,7 @@ dependencies =3D [ name =3D "qemu_macros" version =3D "0.1.0" dependencies =3D [ + "attrs", "proc-macro2", "quote", "syn", diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs index 830b4326985..7ab18061776 100644 --- a/rust/qemu-macros/src/lib.rs +++ b/rust/qemu-macros/src/lib.rs @@ -3,10 +3,14 @@ // SPDX-License-Identifier: GPL-2.0-or-later =20 use proc_macro::TokenStream; -use quote::{quote, quote_spanned, ToTokens}; +use quote::{quote, quote_spanned}; use syn::{ - parse::Parse, parse_macro_input, parse_quote, punctuated::Punctuated, = spanned::Spanned, - token::Comma, Data, DeriveInput, Error, Field, Fields, FieldsUnnamed, = Ident, Meta, Path, Token, + parse::{Parse, ParseStream}, + parse_macro_input, parse_quote, + punctuated::Punctuated, + spanned::Spanned, + token::Comma, + Attribute, Data, DeriveInput, Error, Field, Fields, FieldsUnnamed, Ide= nt, Meta, Path, Token, Variant, }; mod bits; @@ -159,61 +163,37 @@ enum DevicePropertyName { Str(syn::LitStr), } =20 -#[derive(Debug)] +impl Parse for DevicePropertyName { + fn parse(input: ParseStream<'_>) -> syn::Result { + let lo =3D input.lookahead1(); + if lo.peek(syn::LitStr) { + Ok(Self::Str(input.parse()?)) + } else if lo.peek(syn::LitCStr) { + Ok(Self::CStr(input.parse()?)) + } else { + Err(lo.error()) + } + } +} + +#[derive(Default, Debug)] struct DeviceProperty { rename: Option, defval: Option, } =20 -impl Parse for DeviceProperty { - fn parse(input: syn::parse::ParseStream) -> syn::Result { - let _: syn::Token![#] =3D input.parse()?; - let bracketed; - _ =3D syn::bracketed!(bracketed in input); - let attribute =3D bracketed.parse::()?; - debug_assert_eq!(&attribute.to_string(), "property"); - let mut retval =3D Self { - rename: None, - defval: None, - }; - let content; - _ =3D syn::parenthesized!(content in bracketed); - while !content.is_empty() { - let value: syn::Ident =3D content.parse()?; - if value =3D=3D "rename" { - let _: syn::Token![=3D] =3D content.parse()?; - if retval.rename.is_some() { - return Err(syn::Error::new( - value.span(), - "`rename` can only be used at most once", - )); - } - if content.peek(syn::LitStr) { - retval.rename =3D Some(DevicePropertyName::Str(content= .parse::()?)); - } else { - retval.rename =3D - Some(DevicePropertyName::CStr(content.parse::()?)); - } - } else if value =3D=3D "default" { - let _: syn::Token![=3D] =3D content.parse()?; - if retval.defval.is_some() { - return Err(syn::Error::new( - value.span(), - "`default` can only be used at most once", - )); - } - retval.defval =3D Some(content.parse()?); - } else { - return Err(syn::Error::new( - value.span(), - format!("unrecognized field `{value}`"), - )); - } +impl DeviceProperty { + fn parse_from(&mut self, a: &Attribute) -> syn::Result<()> { + use attrs::{set, with, Attrs}; + let mut parser =3D Attrs::new(); + parser.once("rename", with::eq(set::parse(&mut self.rename))); + parser.once("default", with::eq(set::parse(&mut self.defval))); + a.parse_args_with(&mut parser) + } =20 - if !content.is_empty() { - let _: syn::Token![,] =3D content.parse()?; - } - } + fn parse(a: &Attribute) -> syn::Result { + let mut retval =3D Self::default(); + retval.parse_from(a)?; Ok(retval) } } @@ -235,7 +215,7 @@ fn derive_device_or_error(input: DeriveInput) -> Result= , Error>>()?; let name =3D &input.ident; diff --git a/rust/qemu-macros/src/tests.rs b/rust/qemu-macros/src/tests.rs index 9ab7eab7f37..00a106612fc 100644 --- a/rust/qemu-macros/src/tests.rs +++ b/rust/qemu-macros/src/tests.rs @@ -60,7 +60,7 @@ struct DummyState { migrate_clock: bool, } }, - "unrecognized field `defalt`" + "Expected one of `default` or `rename`" ); // Check that repeated attributes are not allowed: derive_compile_fail!( @@ -73,7 +73,8 @@ struct DummyState { migrate_clock: bool, } }, - "`rename` can only be used at most once" + "Duplicate argument", + "Already used here", ); derive_compile_fail!( derive_device_or_error, @@ -85,7 +86,8 @@ struct DummyState { migrate_clock: bool, } }, - "`default` can only be used at most once" + "Duplicate argument", + "Already used here", ); // Check that the field name is preserved when `rename` isn't used: derive_compile!( --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706235; cv=none; d=zohomail.com; s=zohoarc; b=OOoUnGXV2BTHk3ASeVZQ/oKHbhDLijv/UzxT1YePdobPyBnIntQLn+e46mvM8/5mu9xWj4bjFdj2kOj8NNTiBm5jMvMGu6EBPa+HufDgQ0xJbW3tnLf5Djr//owx4ombE/orO2eJ5Nh/vySdCJRwb/zVy+ha/1pDDstcYjMwOpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706235; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cQtQgz5paDlJPQB2PzlMqA4uvKzTZV/KR4MEWJ2j6p8=; b=gzRlz2f/K/PpXcitZf5s2viUJYab1ezcHmyqXE9zkpfGKToQJ/j3mIYD0Kplva73lOVv0xmdyzn4JBBGLHJuhubTjXUKyq5iJYt+uaWjjVEXhhgjufPnuFy2dBsdrVeDzrPkuSFqdpHEqKMl19jgk6qr36MoykeI6hamfdXSE5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706235641343.84655889257033; Wed, 24 Sep 2025 02:30:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LoY-0004jf-3b; Wed, 24 Sep 2025 05:29:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoW-0004iO-Ej for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoP-0004mh-D6 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:28 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-fYuwfd_8PACXOPLLYLBflA-1; Wed, 24 Sep 2025 05:29:18 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b07c2924d53so317575866b.3 for ; Wed, 24 Sep 2025 02:29:18 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b27d7eeafc7sm1054233966b.86.2025.09.24.02.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cQtQgz5paDlJPQB2PzlMqA4uvKzTZV/KR4MEWJ2j6p8=; b=IV4pwMCB0SKcIeQ/avuGIIQ+sbZ/r6Q+y6WQ1oHNyESbabA0lCydDw/6qZE8TpXBjRxqMb xNDM7Vb/bvCgyGPg/cmQ4vPscHWtCYLr7xN7tofiZ0y6bvNPIJbpviuRz9rf4Elc7yd0pj YU8SYS6PSfB6e1o5JUlT6UakJ/t9pMg= X-MC-Unique: fYuwfd_8PACXOPLLYLBflA-1 X-Mimecast-MFC-AGG-ID: fYuwfd_8PACXOPLLYLBflA_1758706157 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706156; x=1759310956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cQtQgz5paDlJPQB2PzlMqA4uvKzTZV/KR4MEWJ2j6p8=; b=wb1fiXtQ+szRGQW04XItvP2poM3KAMEeAm6FSJOi+Ra98OHm18V9tWgRVpJIuGHVFm Yy3Ex/g3zva/EYEDfmwZVnNYZpn9b407joGSSxt287kN3SMkiVVpG/vx+bFdkVawWyNX f6tM/6kOfjZeJanwSYD+St4EdZYCP4skqm4lTQRF+hTCZ9w7TvzuLqc18URRmQeTVomV gTDhjA9qLRsjDwCkI9WNdam8S6vA3p0GARScr8lIQIQ68zEIV5NEoPQfDv6eZsNr2vlM OXTpAc7WLq5H5b0Jp0WUXiOqtsKkn6KIEgKNSAtvX/TwNxJuMua5Zd4HegG/z3CHvq6G UDXQ== X-Gm-Message-State: AOJu0YxR8nA1kPCPtwfiwEyq+yXTe7dA2H7ilUbkQ+8Dk1pr675hTiEE yCUMwV7Z+1yEtMpB5JU/3z8IBAgXktV7EyLcR7ohnQrwl6NM9q5EU1rcbQIHzuC1aA919GKjsy8 5/kdJxAyqISv/EqkeCC5BIxM6gFGnnbit7yy+6wGGSzp3ii0lB3XfC9a4u16Lq0jBHDdYXK5PGG UoGzpXkSSOWfWNFqeVJnF5K8DhMEWlpxIr30p0t07V X-Gm-Gg: ASbGncuC/2f+ua4yT1r6c88iEIXK2CZcSXl3RjLPI0bWQkvfrAIM8q1GNrs6qvonDbh Rf6gn65f3aX1KuqSwLm9jCeN/Gb3yiLLn6uy/r6r5WKKlcXPoiMJxTEDKFdgbvNPB94rx+vyVIi 5NNJitX1yKqpFRpcerOxvm9TP6RyUn0sXXdHmGse7ZO6S5MLVMxpDjTnSbd4i4mhlG1+hnNd8od xEkI6Nsy9+H6a+0QaViFw34UbfuE8JcSpX9L0LFPc3IIFndzVHKmAp+yxWazdU1IOA2oeUxxxdU BCDo7zhgTiR3YMNRsIqnt2Jl3BC3dS1u9pIgnevqVbiGF2gm3HaR9iMvxja2gu1peWOr8J1eY+T A0vc/LLJVdV4/WJHREEfZzdgdA5jBekzFHSVP/2XYr1/26Q== X-Received: by 2002:a17:907:3dab:b0:b2c:bf1e:2788 with SMTP id a640c23a62f3a-b302ac325acmr545950066b.39.1758706156144; Wed, 24 Sep 2025 02:29:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUPph/8p4yfLKz9JGOSXuhkU3JFaptmlKllL6HwAJB2mvMlYDczB5flsfU+2ErEWuwnLjtJQ== X-Received: by 2002:a17:907:3dab:b0:b2c:bf1e:2788 with SMTP id a640c23a62f3a-b302ac325acmr545948166b.39.1758706155728; Wed, 24 Sep 2025 02:29:15 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 07/29] subprojects: Update .gitignore for proc-macro2 and syn Date: Wed, 24 Sep 2025 11:28:27 +0200 Message-ID: <20250924092850.42047-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706236690116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-2-zhao1.liu@intel.com --- subprojects/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/.gitignore b/subprojects/.gitignore index 983c4c1549e..38e949640f6 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -17,7 +17,7 @@ /libc-0.2.162 /proc-macro-error-1.0.4 /proc-macro-error-attr-1.0.4 -/proc-macro2-1.0.84 +/proc-macro2-1.0.95 /quote-1.0.36 /syn-2.0.66 /unicode-ident-1.0.12 --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706341; cv=none; d=zohomail.com; s=zohoarc; b=J+MouprOH9r0YYUx4SwyO43/qZMwZfNBX+xfkoI/wAchXBbfrTsdeZbiIOq1xhlTKwHp+MzHBHLrVj169AbRXdXuBefIW5t13Da9MJsF0wXRfIAGk3VY2RsoDKZsPkEYLibG3eB7TV4laEFJFwELhvIr5syJONAizFV01b+rom4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706341; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/64Gu6b95cqgymZa2iJ9Dsvt2JhtLtmji/4lA/f78T0=; b=nhb6mESl581Y4e8PqX3mkTvajvYorZ4X5viOAg1+r1AlMOVJE2K1BgDhex8irx95TqS/hdsbMp60mcmURg42ANx8TM3zDPYCqK2weoTB+H9bDX9NELXWPrq3qIV9fl+4x1OBRzQRwXzhVppkyeYXhqW2EgDSbk+avVvQ3hj8y1g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706341715322.65123053406535; Wed, 24 Sep 2025 02:32:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Loc-0004mm-0E; Wed, 24 Sep 2025 05:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoZ-0004kd-Sr for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoT-0004my-0k for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:31 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-qsfbHJ5GPDOy8uBNC8DRiA-1; Wed, 24 Sep 2025 05:29:21 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-afe6216085aso583861266b.1 for ; Wed, 24 Sep 2025 02:29:21 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b1fcfe88bb8sm1469689166b.56.2025.09.24.02.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/64Gu6b95cqgymZa2iJ9Dsvt2JhtLtmji/4lA/f78T0=; b=PQSY4QW9B/96XVnCtGH/52p99t+5Bi3Uaeo6QmRiKdf9OQXFw15+s4KxID0UEvHQeUNCkO 4qoq7LOGVGXtg+gi7Yg0hct9dXP4eu6A/MdF+p0NB/l/372hmKtgqNsPRfyjHcBaVBqMRv uzPK0ouaMeRr15za30XPMMeEVE3Ixco= X-MC-Unique: qsfbHJ5GPDOy8uBNC8DRiA-1 X-Mimecast-MFC-AGG-ID: qsfbHJ5GPDOy8uBNC8DRiA_1758706160 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706160; x=1759310960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/64Gu6b95cqgymZa2iJ9Dsvt2JhtLtmji/4lA/f78T0=; b=vacQPUJ0dB92fq9aOKlfCGzB4fsDENezc2Gy+eyzEsQBsAc80E0A+/WsAm544rq2t8 QCnq/bR16t3aUZi2HyJiVvcXtd5G/xUqk1CnGMfxiHlRQBKXIHepfDMu1vbp/6GwoVY+ 2m86m3Is+jIw2KdukkK6F3RIwf+vkt85wrqy29yuyYQ7fH7w8ay78fijxJzTkz7KsA+l 4IYGIIBuA49tZtJ5pd8U4Qt48AIsbxElovEF1OnIg52KR4Ykol9ViJNAVb3pteXp4cz+ Qa7M23VzXUQHsGejDGdOEXVn6BoYnTSTNbwLk201V2kuV8XLJ1mE0CWPB5SFy0MLOHtS RJCg== X-Gm-Message-State: AOJu0YxgFi18XLNBYdUGOpmRRjsGqRchavqiyoFyQ0JPDrqpTPwsTpD7 3UlJW1R0dyS6LaxdkYCQQWz+gHOvveOhQAvU0iWTjdDvUycT/8oj3xVjkbB3DrNMMjblmc1HNoP xQ9oy/uEreSX6v2ZuILGJOMOp2gm8NHyq2BE2Y8t9jnYbJ//1ijYFg7TquUHo9Lm0ZdCvofzQvp WF1KsigyM2YN2UVFgbqWEdcgRrtz2zs1vedZj0P5GM X-Gm-Gg: ASbGncvl8azsnfy2J+OdqVD8i3CisywmsLUpYXbx3CuxJEnLGZQVy1p2hWSPuc8rEeP qc7cryMZckRjF0iRyurrDl+tK+vlHHUlL53T91mNAEQHa8bD/ISQ8q1E4M9xf4mRnx+7DYC9X/2 2WjF48YPxmzo0LwCLjZGh5SBG7OdAztpmRnRVM70m4CdDkxJ6ojPsXC6yQlowspIe3IQEuoYmyE TwdveWzGIQAWPM1eL71Wq531jaZbogstTHxj/CF16C8QAAbkyrQ5wacatwmhJcmBvjLx863JAqX Zuht9rQU2GrYyH+DtLvnf/GzMQlUOSYQbh3reSeYSqZru/GQu99IPYpp90zDW6gYfuSsfYUuvAE cYFVghZvIpAcx/Nb+5+U44/uwXUj8+D+Hk50L6tDwLdhCAg== X-Received: by 2002:a17:907:3d0d:b0:b04:6fc9:f108 with SMTP id a640c23a62f3a-b3026e7496amr548660966b.24.1758706159189; Wed, 24 Sep 2025 02:29:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhTuI2dLSW24mpq2xa+z1xoEEHONHmSmjNbY7VG9ZzG4w6429rzEoVVf/hSFgfBzcdCVmPLw== X-Received: by 2002:a17:907:3d0d:b0:b04:6fc9:f108 with SMTP id a640c23a62f3a-b3026e7496amr548657866b.24.1758706158641; Wed, 24 Sep 2025 02:29:18 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 08/29] subprojects: Ignore .wraplock file generated by meson v1.9.0 Date: Wed, 24 Sep 2025 11:28:28 +0200 Message-ID: <20250924092850.42047-9-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706342185116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu The .wraplock file is automatically generated by meson v1.9.0 (the related issue: https://github.com/mesonbuild/meson/issues/14948). Ignore it for now. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-3-zhao1.liu@intel.com --- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/subprojects/.gitignore b/subprojects/.gitignore index 38e949640f6..58a29f01204 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -21,3 +21,6 @@ /quote-1.0.36 /syn-2.0.66 /unicode-ident-1.0.12 + +# Workaround for Meson v1.9.0 https://github.com/mesonbuild/meson/issues/1= 4948 +/.wraplock --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706491; cv=none; d=zohomail.com; s=zohoarc; b=Uw+wlUgrcawDh4sTQIAOlTbi+RTje9wugliKEWPdWH4PWqiqwqKxaNqfH/l1seHPAXzkKRePnhhlxaFSGzfPB/FJ19DpeSFabTTu9UgvrBZ1P9PHqTLup3jLfzTfBdg/EoPEus+PEMY3V3v90QAwxfdP8CmTP41lR4jceatrwIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706491; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7ejcUKAyx1DDoRWuve8SmmSZaJ05MRViPVUHIuBU4JY=; b=PW3jgmquKOQFzXrwU7Kn85tonJbA9cKvTHDGaX7KuFa7LBTaKaqr8IbrMSZk3xe2vCwkWerHXBb3EWIZ0w3lxqEUlW/rkG1hYcOSnX7YfW2k6F9e9+MSvUNKv3DjSqesTV7ee6ZFPoRif+/XA6Q6Tp/RWXu9Q+HlMiXkpwvXxNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706491185326.87743491371384; Wed, 24 Sep 2025 02:34:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lod-0004oS-Jv; Wed, 24 Sep 2025 05:29:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loc-0004n2-Bd for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoV-0004nE-3e for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:34 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-BQqhbT1RNjOAVfaI6mY65g-1; Wed, 24 Sep 2025 05:29:23 -0400 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-b044a42959dso815380766b.1 for ; Wed, 24 Sep 2025 02:29:22 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b28a990f6e1sm946869966b.37.2025.09.24.02.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ejcUKAyx1DDoRWuve8SmmSZaJ05MRViPVUHIuBU4JY=; b=VhT1t8GYVFxdkgJjIZp+vzHZAtVJAVwGfkFHy+MbtbUKYFvYmeLRVYQVLDM3PgLv4xu6+v 1MKSOsBf5Wa+/lPJsZRLNrw1QsbW4dTr99STWWVe+yXefXKOY7ACFgCB5tQRWkzD46gASB NxtgxJ7Xvfp/eql0W41WWwsKwH5nuts= X-MC-Unique: BQqhbT1RNjOAVfaI6mY65g-1 X-Mimecast-MFC-AGG-ID: BQqhbT1RNjOAVfaI6mY65g_1758706162 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706161; x=1759310961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ejcUKAyx1DDoRWuve8SmmSZaJ05MRViPVUHIuBU4JY=; b=FMa9NpW7Eaot1hlosS/ycoaaKSYpKlhbegM/PhXGfmpPZ9gR4NWgZtQtuFgbiS3LpA 9m2L1V/0OeLYMWR/ZV0408zUUMudp6eT5p2oZQucGOttT9pukdPtLdv7dp13kIF+Xq0D kqSO1q0p6hl2frizyuBLpWXRFPEV5w3WQcPYRfLsW8ihT7/pPYIQpS6TiCbmUKLieLcr W9+ZYrNGghXR/3gz+/NDi439cdawVmEywACwNN/jA0EK30QtWQcaCXttI1PCuYr8FmN0 GzE+RvtIVklOZWNX3O+7a8Kp/CiIhNq6VvF5Gjcix+rJxAnHnzh0DsudVZKAWfuAKqsW LXBw== X-Gm-Message-State: AOJu0YwMJJqtCwlUuiQVlVnBn9rz9Eqba4T9NGsaxh/1dlT3vBk0TK7q 0UUmaeaoOUaA/jJks2MF2OQQS2SDZ61QstT4qizqoINf5g+SDrJbZADUFWJMy/4RopBsB50ckJP 4/Di24aAuwagOwSPsV4RqWCPCel5QPdSNPbIGaUWPZx+136D//diLda+zoW7zmVyNygi06lHCDB LZLAfemXjnl8aYnHblx7ZJ0H8ripIdgaHZuOswRN5z X-Gm-Gg: ASbGnctF2M3gIEX+S2CiMeBVhNlq8w0h8tITm/6/ssFwExxuUqBLKbOU+2ZPMzzoP1c Q7jgXsq58swD1f/t3nDBu4tmMVMOLc7YjiRIzTPIRacGL0Ug2i3u7qz1294AgaKu8llIyVjPOJ+ MFi2tpcIu50p1IB3ZpKT+ZkIqqSGK4EUjg2oyZRjpQ6S+aDk9G34Ig/5qbPTl8lmTXQnbMNm4iJ r3kTZM6t+h/rh08GQcepH18iR06vVhTbNsrq1kfnuslhLw74BeK4iGZyQt4019S7BOYO2DxcU7y ki0MO/bDaUTLLYfG7kqCLcE1WmcHB13t3DftSiRss6hG1h5EuZh57F0FIQcwHtBRz4v4ZGW8sCQ cv9Ai92bntK46VvjY3ULJVCaPdBLgoj9qB82nljphiNRWmQ== X-Received: by 2002:a17:907:25ca:b0:b24:7806:b59 with SMTP id a640c23a62f3a-b302b4160c1mr545713466b.55.1758706160920; Wed, 24 Sep 2025 02:29:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPR4/gPoDSSP9fNF3CCGFgfzPlERnka5KYzQMiknzSK3KvyJWuZwFeWgywQURUT59VpjS/AA== X-Received: by 2002:a17:907:25ca:b0:b24:7806:b59 with SMTP id a640c23a62f3a-b302b4160c1mr545710566b.55.1758706160444; Wed, 24 Sep 2025 02:29:20 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 09/29] rust/qemu-macros: Fix Clippy's complaints about lambda parameter naming Date: Wed, 24 Sep 2025 11:28:29 +0200 Message-ID: <20250924092850.42047-10-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706492339116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu error: `rename` shadows a previous, unrelated binding --> qemu-macros/src/lib.rs:265:14 | 265 | |rename| -> Result { | ^^^^^^ | note: previous binding is here --> qemu-macros/src/lib.rs:245:30 | 245 | let DeviceProperty { rename, defval } =3D prop; | ^^^^^^ =3D help: for further information visit https://rust-lang.github.io/rus= t-clippy/master/index.html#shadow_unrelated =3D note: requested on the command line with `-D clippy::shadow-unrelat= ed` Rename the lambda parameter to "prop_rename" to fix the above clippy error. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-4-zhao1.liu@intel.com --- rust/qemu-macros/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs index 7ab18061776..37e1b723bd5 100644 --- a/rust/qemu-macros/src/lib.rs +++ b/rust/qemu-macros/src/lib.rs @@ -242,8 +242,8 @@ macro_rules! str_to_c_str { =20 let prop_name =3D rename.map_or_else( || str_to_c_str!(field_name.to_string(), field_name.span()), - |rename| -> Result { - match rename { + |prop_rename| -> Result { + match prop_rename { DevicePropertyName::CStr(cstr_lit) =3D> Ok(quote! { #c= str_lit }), DevicePropertyName::Str(str_lit) =3D> { str_to_c_str!(str_lit.value(), str_lit.span()) --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706478; cv=none; d=zohomail.com; s=zohoarc; b=iwnAz10ZzaN3jkJmUd8N8AHpUDDG4vSr+UjIiaLd7qNeaLGHC5bAnw8HWElrvRjCUVy0vQKrK+4OI77gP2lLIYASvpQLoUHNEQuQv2yuqavvBrCRTto+rbKGma7AYcu7cK6NV+z0SKEc11Y66Xe3hzrF4Ssfz2XnIyCIF8nE4h8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706478; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6U2o/f653CpyKtbmcaZXYBHLnD9ktRk3jYJpmo8H640=; b=Nv+9Ix9pPofC8fZshk0rzXPC4i5TBY/fBDOD5SyYSDKWuILJVHaRTWlRy0xz11F6OB/2JiQCZ9c1oN+fB3keTN1P+33VIE0+MJ9WX+TBtq2A8CAYsJm3fXmX38Rz30cpyhEEB+T2SSqbTXhbKHFco2OhOR9gLzvNCDHEa6gxxJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706478153353.50889783501884; Wed, 24 Sep 2025 02:34:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lof-0004p7-IQ; Wed, 24 Sep 2025 05:29:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loc-0004n3-Bf for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LoW-0004nQ-Hq for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:34 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-iECyiTw-M0eI0HpS_fra-g-1; Wed, 24 Sep 2025 05:29:25 -0400 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-afe7b40b15fso236849166b.1 for ; Wed, 24 Sep 2025 02:29:25 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a3fb3ff84sm837246266b.49.2025.09.24.02.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6U2o/f653CpyKtbmcaZXYBHLnD9ktRk3jYJpmo8H640=; b=LcV5gbQ2m946vRAOmHTLGmFZ2BGdBdcDs9Cxyn4RV4oGG/QEFEwPel1G3RjEgiSuZrsFo3 8if/eDIgv8c92W9P31VCSOC2eCXvyFn939S6z1+it9d1EsV+hN49QImVKZyMXLm1CHqUNb OqUGHZQ/Cdjr3QBAYF7lKh8PHSjcLbA= X-MC-Unique: iECyiTw-M0eI0HpS_fra-g-1 X-Mimecast-MFC-AGG-ID: iECyiTw-M0eI0HpS_fra-g_1758706164 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706163; x=1759310963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6U2o/f653CpyKtbmcaZXYBHLnD9ktRk3jYJpmo8H640=; b=KSEDpDTtN3wyHFs3niJgmX54QYsqxWXSPQfLgRvMfCVndbHA7hCuH6ZGKIVttwPPvA pQwsWzXUivHnUq7SdZ3RH40vDV8vcOiF1vQlkGItHuUnOtadhWNlHgdGO2AMYvfFzMFa NiJAxCWM92PkfRIVvqnHKPmpeV/q/mOPEbM1V0VbJ45PwETkWdPAE3K/MgyQr+FWn7kO NTKQjhTygQDfoSoRjvDXY3Feepj3jAl5xsWoxQ3fzkK2cnjTL+2pS/8Ixx5VtnFM2Eb7 NJQq94UOGbOgFIRhFbuU2cvr8tdNWeOo4PpICHlxf1doL0oJFfDNxXX/CGgeawj8zQDu 54Rg== X-Gm-Message-State: AOJu0YxdmFmX/rUz86j+nOMmUWpy+wHXpa8OFdLF1S71jnVoW4+IYEhd w9mWRoIFQYoQAYXJEqvr8hMScnkxkLLn86zghs2DrfV8YBraZshvf0e+VRVdo5Bz84Oc5v3giGo LDnsaoazzoqhMTOaDanou7/2WiJkDlLq+CSrleChygq9Kq3JxuyrwdmvTMpfsVBtJjVQzLSYVDl LCOKI+S67Sva94sh2CJr9DsFbXPycvSLaX1V6AdwHz X-Gm-Gg: ASbGncsOxfo2qazkbw7EKcqzURgpxyKK0VwTOzmfpf+K66adA0Mmi8gTJGKB5F1MVaY vftrxPAwz8v5CxavQh8hSLuq/vYfW/qbg6gLU5WqlOKK4Ho0Ynebx1o/KamySV3KbQcOKrxrh5e 8ni6l9sCkWuahZWyjrfGHc8q0Mz1jrXgRwCB5xTsKdj4NFKadpvMk4jTQaiDlK/uBJUJTyGMEoa g0u6wgaRAJ09vAf3HdJEnOooPUn7trM9o3IRfl6gqtwah0zqoNz8EbpaWYX3MRAIsVA8aAFpG8C +pcWTzL49uGqz8hbC1/Hn0Vsxmo30bOkPDImFX4Weeyo6FX4oz3UJA1qGYr+DtAaSXsqg6ic6lY Te9sLcj8NKS6m0BpO82BteuhCidpoOWmj+DBotgY9DS30Ag== X-Received: by 2002:a17:907:1ca5:b0:aff:9906:e452 with SMTP id a640c23a62f3a-b302ab33e68mr621581866b.31.1758706163529; Wed, 24 Sep 2025 02:29:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiEf3wvV027g/ng3yXV4a5RdBmNcS2Pel/HMB2YYHKR+j8wiu4EcqoaqGKu2yxCQRNZLDIPA== X-Received: by 2002:a17:907:1ca5:b0:aff:9906:e452 with SMTP id a640c23a62f3a-b302ab33e68mr621579766b.31.1758706163079; Wed, 24 Sep 2025 02:29:23 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 10/29] rust/common/uninit: Fix Clippy's complaints about lifetime Date: Wed, 24 Sep 2025 11:28:30 +0200 Message-ID: <20250924092850.42047-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706480321116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Clippy complains about the following cases and following its suggestion to fix these warnings. warning: the following explicit lifetimes could be elided: 'a --> common/src/uninit.rs:38:6 | 38 | impl<'a, T, U> Deref for MaybeUninitField<'a, T, U> { | ^^ ^^ | =3D help: for further information visit https://rust-lang.github.io/rust= -clippy/master/index.html#needless_lifetimes =3D note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 38 - impl<'a, T, U> Deref for MaybeUninitField<'a, T, U> { 38 + impl Deref for MaybeUninitField<'_, T, U> { | warning: the following explicit lifetimes could be elided: 'a --> common/src/uninit.rs:49:6 | 49 | impl<'a, T, U> DerefMut for MaybeUninitField<'a, T, U> { | ^^ ^^ | =3D help: for further information visit https://rust-lang.github.io/rust= -clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'a, T, U> DerefMut for MaybeUninitField<'a, T, U> { 49 + impl DerefMut for MaybeUninitField<'_, T, U> { | warning: `common` (lib) generated 2 warnings (run `cargo clippy --fix --lib= -p common` to apply 2 suggestions) Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-5-zhao1.liu@intel.com --- rust/common/src/uninit.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/common/src/uninit.rs b/rust/common/src/uninit.rs index e7f9fcd2e3f..8d021b1dfc6 100644 --- a/rust/common/src/uninit.rs +++ b/rust/common/src/uninit.rs @@ -35,7 +35,7 @@ pub const fn parent_mut(f: &mut Self) -> *mut T { } } =20 -impl<'a, T, U> Deref for MaybeUninitField<'a, T, U> { +impl Deref for MaybeUninitField<'_, T, U> { type Target =3D MaybeUninit; =20 fn deref(&self) -> &MaybeUninit { @@ -46,7 +46,7 @@ fn deref(&self) -> &MaybeUninit { } } =20 -impl<'a, T, U> DerefMut for MaybeUninitField<'a, T, U> { +impl DerefMut for MaybeUninitField<'_, T, U> { fn deref_mut(&mut self) -> &mut MaybeUninit { // SAFETY: self.child was obtained by dereferencing a valid mutable // reference; the content of the memory may be invalid or uninitia= lized --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706307; cv=none; d=zohomail.com; s=zohoarc; b=DhO7pTGyENy607r30DbmUt7cA9pNqgI+VYF1pN9WL8EM3UE4CmQ96YSCA9na/0Et+Lb+BanTaTvz7gynCflIRioBzN6E5GqTEOZnoKdPIg91WAilViMUc1OU0wvS05m1QvPTuLWLd8CRKuUSNgl8ofd/ceq9D9kLTZn5sUbmTaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706307; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=EDUm7noE+jBJjXyrOfyaFd15IGwTO8OtL69umzZBTGftGhbG5PdJ7Fi0n4MnzIMFwQgngrIZUwDwKZ5y+FYYC+TztBGODhdtLLJgA+CFH7jyeej0YdU55jmjc9NWECgtPL4lBscZauDFb/BQz/DA6int3UnPiIOLK1UWmVQBXDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17587063069011007.4022815300503; Wed, 24 Sep 2025 02:31:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lol-0004wO-JR; Wed, 24 Sep 2025 05:29:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loi-0004uJ-7o for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loa-0004nj-Tr for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:39 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-Xq4U3lLZOiKiMJkqfy7OnA-1; Wed, 24 Sep 2025 05:29:28 -0400 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-63267baffcdso3458963a12.3 for ; Wed, 24 Sep 2025 02:29:27 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6344e493329sm4798120a12.14.2025.09.24.02.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=GqV//MTQzIcD6ji/VuXI8RIMOP7IPRl+legSQmLfftnfS2JgC80RzI7x9AGLHDZAZMXrrB wkjwdX6HVEKaFKK4/U6tMyAORxiRdeV9yG1GyJEvsumP+UFNi1ab6840n9RWNIsPw4LD32 it1+M3PPaJWGNIriALpB4+1R3pGkbhQ= X-MC-Unique: Xq4U3lLZOiKiMJkqfy7OnA-1 X-Mimecast-MFC-AGG-ID: Xq4U3lLZOiKiMJkqfy7OnA_1758706167 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706166; x=1759310966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltuB628keKCxP/f10xoJleC3spK/ALW7x74bQTNSw6c=; b=UKvHNNg+WrXhzVdj75Vp45RXgDPwLqLf5Oh/7RtVMa8didifg7oXAE8bLh8y5Xcwnv 7YXCLxxMYpQH+SHTro2H1D83c8Nkdyvx7S9C9zMiLUEatIjR6ymrylARrnmeiz1OhPft DIeHYoiyWjO5+9rqfOMI7n25HgmvO2BMRKQg9WcqGYPERFnoNELRArlTk3JP/7Ts1vxP UyYcEdpWZavshIDnxBALb5C1Y7ZxuueMcrXg09CSMI1J36JHVR1nbVsDW9l7TFVUgEX3 NjaDLBppWQXyqvVMrhdibc6XoqYjdwKo12lkoLZqthC5HfoVB+ezAFApYlFtVrAYVryG 4Awg== X-Gm-Message-State: AOJu0YwisNIR2auFnScdtpKO3wKWUOlZVl7AZnz0xEO3Pv7rMcqXPcd0 4vRE/jTjmBR7jmlUT+O5BcdNYNcV28F9/DBekrF1BbBHD+kG/CIamVTG8ZY6I8q3EO9SNomdg/G f8Wu5WlmxjnfzIastZAdUut8oSjsJpc6PM5vDauG37asXw4E4qLNu4Cw7MJ1agtQ3t6O2Ex3Bnn 9uJ6MeSHOPDL87IvqudSArynMOtuLjfmzo8CZzsNz6 X-Gm-Gg: ASbGnctXXvBoHIl00jE520vKniufh2zUFmu74eA9LZMFS4DnSEAqYcg5aC+qpBenrA+ me94j+rfVxQreZz739NqYGwl7r9NyrsjW3ZyKFP6bIvh/aMsFt8E016Y/ZR/dFIFxeozULE3iat IxDTw99rpac56kCtceQDu2cuxI+YJuvf2GApGMcwmyyK6nivTg8EIxdAfXSl09jv4AXqnWLCCQL 92jAymKuBOJkjw8wLa3oN7bINHGrjYGwPZOy8xJm2qIN36nVkb2vryRWu9xtwDNyairUgeE9VbD dE3FUMxybh+SZ8Ms17oUK5IoQrV49mce2NBFLYTJEogvrIb5S431tuSGeCjZ+1jt5IOav4HZ96t cmZANFIba8ie9cl9doo5f5pah5j3xGE/auAOmjcEtbmDRAA== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5032332a12.13.1758706165854; Wed, 24 Sep 2025 02:29:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEokRPoNgqaoabBYr5yUq8U/XC1DqxoUY9DayzWZfluI6qRymWdVqbp42/bCzvltMfRMpySbQ== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5032295a12.13.1758706165301; Wed, 24 Sep 2025 02:29:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Zhao Liu Subject: [PULL 11/29] rust/qdev: use addr_of! in QDevProp Date: Wed, 24 Sep 2025 11:28:31 +0200 Message-ID: <20250924092850.42047-12-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706307768116600 Content-Type: text/plain; charset="utf-8" From: Manos Pitsidianakis We want a &raw pointer, so unsafe { &_ } is not needed. Suggested-by: Zhao Liu Signed-off-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-6-zhao1.liu@intel.com --- rust/hw/core/src/qdev.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 71b9ef141c3..3ee5b242622 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -6,7 +6,7 @@ =20 use std::{ ffi::{c_int, c_void, CStr, CString}, - ptr::NonNull, + ptr::{addr_of, NonNull}, }; =20 use chardev::Chardev; @@ -129,17 +129,17 @@ pub unsafe trait QDevProp { =20 /// Use [`bindings::qdev_prop_bool`] for `bool`. unsafe impl QDevProp for bool { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_bool }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_bool); } =20 /// Use [`bindings::qdev_prop_uint64`] for `u64`. unsafe impl QDevProp for u64 { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_uint64 }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_uint64); } =20 /// Use [`bindings::qdev_prop_chr`] for [`chardev::CharBackend`]. unsafe impl QDevProp for chardev::CharBackend { - const VALUE: *const bindings::PropertyInfo =3D unsafe { &bindings::qde= v_prop_chr }; + const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_chr); } =20 /// Trait to define device properties. --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706481; cv=none; d=zohomail.com; s=zohoarc; b=mTC+rxVJ435oHo6d6+YQll/cEOtCnioF7BKecn1DOtQ5wHwpNkG1gFz1aKJewS1fzz6tcTpzyTpKRWlKoHMuMHimHH0mQQkVyZWkWj0wolcNS/xLQDx4OFad/j2vXL2HrKwDTDDKaEAJbUGuLEe/AW2XDQUOCmXd1Y1WHbZap7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706481; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xoARvTbtXhp2bZv3DG4znBAUsLqgG710YBnBSzlsqKw=; b=YTwxC3QvSt68SxQV6vRkPsYzczrgPn2vy4HqIU1KBVBh8kvmVyCFu9GGaVId33vZseohIY0iuoVKZGMfv2H84KDoqBzeSDgSTsdewiKvbas54WxH1LZd+DcIIcUpnqJsooXhcNDn1fBKPgzZ/G/m6JIjecjTqSb6eOBPF1b/H5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706481439768.5333900449746; Wed, 24 Sep 2025 02:34:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lor-0005Cs-7p; Wed, 24 Sep 2025 05:29:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loj-0004wP-FH for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lod-0004o0-Qi for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:40 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-o-1HNM7tMW-YMeK0AqR37A-1; Wed, 24 Sep 2025 05:29:30 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b25f63db20bso72702866b.0 for ; Wed, 24 Sep 2025 02:29:30 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b29912fb4d2sm893729566b.14.2025.09.24.02.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xoARvTbtXhp2bZv3DG4znBAUsLqgG710YBnBSzlsqKw=; b=Nmx/dNHlwav4077OpN8QWmG9KdDytRfimoWna66wXKUHS7zNaIHGGHoeOR1IOcYKlr9TL6 RCOzKeVjSnCd3IwpnfgXDJpVTga7sDVzmt1Zlb7pWWQ2PBMPMizIOoTz1aiuebpoc1n4NJ 4ZiVYz16zQ0RBlsrsbHytdXuANxZQs4= X-MC-Unique: o-1HNM7tMW-YMeK0AqR37A-1 X-Mimecast-MFC-AGG-ID: o-1HNM7tMW-YMeK0AqR37A_1758706169 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706169; x=1759310969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoARvTbtXhp2bZv3DG4znBAUsLqgG710YBnBSzlsqKw=; b=NoXi4So0AmiC2oEk8IprNUd/xOHVYLdOaKjnBM/eEyt2LAd2m5o+s0FDAI7sZ92Y/9 FcF2N3eY+7zQccPGB0CkOY/MjWHW+e4APObY/JjzOJNl1FGyeMYuoYrVRRuGfGOcxKYw EFArFaFlFnHM3S9EDzE2qJbYBvsyfKrfJ8I5P1gXaNUUcV7Rze9ZXxmzWCXrWf46+xGg P3p+DgWK/62fqv6vPIALaGIgbJCuULqV0MjdMaPF9iNbP/rnddsupSuEkj1kKtB0a+/j phjszNcRZSAS5HXaPqgkBoeg6LRnEGyxYkViVAWwkGf3hWxRkcnkm5SE/D3Js5psVqAe 9HvA== X-Gm-Message-State: AOJu0YyP8qPbndVW9O+mmfar92vRuHW+13cjEaWG44YNdNZEnrS1dsYi VbVmi3Pip7W1zxb+ChfH0fIFmzYjr9FAyLflQVIXHz4saZR/iy5sS/6heNi7ALrHhxVP9ts10Ku xQQEJ9zjy+Y9nSSfZydErBzDlyUEDpzpM3GhUHGpZtkWdIOktjowBtOB8+bWby656RzPRJBOa38 ZE9B/zU0gvtEARGJmg6+THcdNorA0DkadNZu7qgJEf X-Gm-Gg: ASbGncvV9I+GhTRBZPkWx2eTXGknVfPCOIx8EpcTHxuNFrwNpLG1xBNbJJZqX14IJL5 W6L31kgvnjDbaa0gYJX94l05vghn37puWlHW+pYRHuJrn00ySxskdoZB+OfP0ThSZiZTWOFjbP0 Jy3+IDXiqgo+1I2bgOcuT8bj1SluAmT4vKXcn+/9ac7pQPA+OGM5RC9EtCeVGAuxN2TCtRFG3VD GJVJFl0G/Q+nEByu3R7bdlQv69RP2pIE9z9xmpf7Bfk7n8HgK4x+UBPqLezliDaZZPq1YcrbqUH 8SMDTS65uJX2/B7ZbAw321tdYpbKU3LYhMJbcOdHSGL3csYnKRRSo+/+jMKp6w4/ofqm7q7FfIe /1hvYKE3+w+PrfF4nMaIS4wCkz9IVdtfNbxbWT67d4bV8Fg== X-Received: by 2002:a17:907:3eaa:b0:b04:6f77:9cff with SMTP id a640c23a62f3a-b32cb7827d2mr185074866b.27.1758706168698; Wed, 24 Sep 2025 02:29:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWyGN7LuM/bvTaNp5/1TM4iQgQUquYtwycl9ti2v547UHd27XPPBCRUdBgy/x9lH+RmFsXew== X-Received: by 2002:a17:907:3eaa:b0:b04:6f77:9cff with SMTP id a640c23a62f3a-b32cb7827d2mr185072166b.27.1758706168157; Wed, 24 Sep 2025 02:29:28 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Zhao Liu Subject: [PULL 12/29] rust/qdev: Refine the documentation for QDevProp trait Date: Wed, 24 Sep 2025 11:28:32 +0200 Message-ID: <20250924092850.42047-13-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706482310116600 Content-Type: text/plain; charset="utf-8" From: Manos Pitsidianakis Refine the documentation to clarify: * `unsfae` requires that `VALUE` must be valid. * using `*const` instead of `&` because the latter will cause compiler error. Signed-off-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-7-zhao1.liu@intel.com --- rust/hw/core/src/qdev.rs | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 3ee5b242622..2735e2b2c10 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -109,9 +109,16 @@ pub trait ResettablePhasesImpl { /// /// # Safety /// -/// This trait is marked as `unsafe` because currently having a `const` re= fer to -/// an `extern static` as a reference instead of a raw pointer results in = this -/// compiler error: +/// This trait is marked as `unsafe` because `VALUE` must be a valid raw +/// reference to a [`bindings::PropertyInfo`]. +/// +/// Note we could not use a regular reference: +/// +/// ```text +/// const VALUE: &bindings::PropertyInfo =3D ... +/// ``` +/// +/// because this results in the following compiler error: /// /// ```text /// constructing invalid value: encountered reference to `extern` static i= n `const` @@ -119,7 +126,7 @@ pub trait ResettablePhasesImpl { /// /// This is because the compiler generally might dereference a normal refe= rence /// during const evaluation, but not in this case (if it did, it'd need to -/// dereference the raw pointer so this would fail to compile). +/// dereference the raw pointer so using a `*const` would also fail to com= pile). /// /// It is the implementer's responsibility to provide a valid /// [`bindings::PropertyInfo`] pointer for the trait implementation to be = safe. --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706237; cv=none; d=zohomail.com; s=zohoarc; b=AUMu8y5EbNrwa3T2lhM1W+JvTaH34v2NtEwhU9JkVqG1jWhcebwB7bZdUHjqdeDcJU2AFcbdigwRl+kOGyxIXQLpGlOZufZKIaUnAqoCNzaA7Jw0Fc9dRMVXDSqkZq167qUI71QQzhO830XTULtMedo7gbTyXOy9sNiLCS7qPyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706237; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rrETRcAm62saupPnRfR+kklTa3hHwGRAVoeNUg91XF8=; b=KKE8PIx80frRBvaiSvvcTXKMe8vjI2X0qouTLOExAoiV96aOWfYrr5atKIZyWO+STjNpO7tkqmSz1oHaKKozEniYqBMcyHWQwFPXQ9CJyFrNm8qXHHP1utS6bKKcaGwpS/j1M/qzsS28ImyYfM/1KgnRluA/UBiPzz9ps41pDSk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706237046549.5515458355117; Wed, 24 Sep 2025 02:30:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lop-00055z-HJ; Wed, 24 Sep 2025 05:29:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loh-0004tG-QM for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lof-0004oE-4e for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:39 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-J1SAo9IJOay2hwtMGmL7fg-1; Wed, 24 Sep 2025 05:29:32 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b07c2924d53so317594866b.3 for ; Wed, 24 Sep 2025 02:29:32 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62fa5d4189bsm12451913a12.19.2025.09.24.02.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rrETRcAm62saupPnRfR+kklTa3hHwGRAVoeNUg91XF8=; b=CRbP3ZJvshzuNt+lIn4OLrX5mYCwzjwPILh94ZwWWu5QXTw87JIQjFqPitlYLYlzKkAMJM go1A98hhZXv6XL1MRupvgC0iEN8awHomjdjbpzIw2dKeFm501VgMne+aYPL55coV+BSEAd 54kE1EzP1deILedINXPF+WPTYHNUF68= X-MC-Unique: J1SAo9IJOay2hwtMGmL7fg-1 X-Mimecast-MFC-AGG-ID: J1SAo9IJOay2hwtMGmL7fg_1758706172 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706171; x=1759310971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rrETRcAm62saupPnRfR+kklTa3hHwGRAVoeNUg91XF8=; b=Ll0nBNw/6ob788WPmwYUyKhm9K9AeI5zlLBcEpWw+QWD+Z+5Gpm4X/fTqt5QrxiIQL 1+SOC5DoXnci0XrnIl0U0KFWOquQDGvmz1Yffl/xWv3ShmJieHxPUQ0TjE0neIXH6M+R EKAWUY2sIOTC9roS0KqQZYTwwQ6JHCR/0bwlpOuM45ZRXHvPaFekDm/Xm0bAOioVvGbU 2zrweOVU8ST3luJxzfE9epA9H9prK3qDz0qcJkvNIs7orMq78qKCV8EBvXsbXem89p5z J0xQnkSXdE/Ogq59nEOpfnvKiORRiYzUVZU91a4hsWAZumYF1uJtIBQkrGJg0rvhyQ9n ApVA== X-Gm-Message-State: AOJu0YzEoaGT5/LpaVKRE39FB3xJ5+CNR9mt0Pub1zaiVEAiUbeCnggO cWprm82ybUkw1vd1tX3YkqjSCWNIIuKvU/TO90mCYL0u8lbGqCK71X1wKTG0oNMBKVlCR09LB7L bwrb8w2CvVMTXWFcJUGw/hSpUc40yhpHb0HC1KWL/8iXYU0xUAJIRM/dlGA5VseBuLkEU089cIC EXOXt0fDkhsnk6kByML9i9Iqe4A1y1ohuXTcZ/rFOH X-Gm-Gg: ASbGncu4+75+2IBlcPAsM+Hdlgt/LwGzBZSA239YwzBSE70T044NA0VR+o66S4X4Zfz Jv3sYZcF8Z3j9Mk3aVz4FxVhmV71pZoqWMmO7cv/Bcy/z2ybAkl4E/Gd3TIgcdtlzf3A3/uQD0R oX4E+E1dBZGKOX68sPTQYF26mHi8OZoUxR6yiuH1SzbKnnAZxWxrc/BhQGSAzDNnvLFRHnfgdzj MgKKUoenTKJxWU0iba2qPMpHImmqE/rqMLpLKUx0Z3gMythECcyilkTXOT6nZKx+Msrs6r5lUlX PfaMTxrFOU/XlFznFiBo2AYDFVgCdmhPxWUVid5RREegQkfiGSjQpW+VmhBuYnp7Ks5DKJhIfP/ x8TN1RKX5AMCdvax3PaQyOoegGaM1xuC/20LuoHzKlJbjFg== X-Received: by 2002:a17:907:9486:b0:b0c:5929:4cff with SMTP id a640c23a62f3a-b3027d3e801mr547639666b.26.1758706170804; Wed, 24 Sep 2025 02:29:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXN3snPdzdMyH+o0Lti3iJvD4aab2yra2EmLI78qCqzCalagpUQF33ZLYoBqQdXYVll6dePg== X-Received: by 2002:a17:907:9486:b0:b0c:5929:4cff with SMTP id a640c23a62f3a-b3027d3e801mr547637066b.26.1758706170371; Wed, 24 Sep 2025 02:29:30 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu Subject: [PULL 13/29] rust/qdev: Support property info for more common types Date: Wed, 24 Sep 2025 11:28:33 +0200 Message-ID: <20250924092850.42047-14-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706239145116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Add a helper macro to implement QDevProp trait for u8/u16/u32/usize/i32 /i64. Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-8-zhao1.liu@intel.com --- rust/hw/core/src/qdev.rs | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 2735e2b2c10..85422e0379e 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -134,20 +134,24 @@ pub unsafe trait QDevProp { const VALUE: *const bindings::PropertyInfo; } =20 -/// Use [`bindings::qdev_prop_bool`] for `bool`. -unsafe impl QDevProp for bool { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_bool); +macro_rules! impl_qdev_prop { + ($type:ty,$info:ident) =3D> { + unsafe impl $crate::qdev::QDevProp for $type { + const VALUE: *const $crate::bindings::PropertyInfo =3D + addr_of!($crate::bindings::$info); + } + }; } =20 -/// Use [`bindings::qdev_prop_uint64`] for `u64`. -unsafe impl QDevProp for u64 { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_uint64); -} - -/// Use [`bindings::qdev_prop_chr`] for [`chardev::CharBackend`]. -unsafe impl QDevProp for chardev::CharBackend { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_chr); -} +impl_qdev_prop!(bool, qdev_prop_bool); +impl_qdev_prop!(u8, qdev_prop_uint8); +impl_qdev_prop!(u16, qdev_prop_uint16); +impl_qdev_prop!(u32, qdev_prop_uint32); +impl_qdev_prop!(u64, qdev_prop_uint64); +impl_qdev_prop!(usize, qdev_prop_usize); +impl_qdev_prop!(i32, qdev_prop_int32); +impl_qdev_prop!(i64, qdev_prop_int64); +impl_qdev_prop!(chardev::CharBackend, qdev_prop_chr); =20 /// Trait to define device properties. /// --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706502; cv=none; d=zohomail.com; s=zohoarc; b=eunmQJAVXgZy08efTYa5DZr57f7j59i84j9IGvr72+tEcMa4pQvQ5LhphQrIQYk0cyr7JKRsJUvitgSGQ8F2tWyQXzHaUtUN9BWJUGMao+dRXhAUY4+6rsqHKpTCX45++TzVnGx0g4A/GCOKObSP1GsS3PFGayWzN4rKAaZgt+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706502; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8v7cUZBltXG+hT2nF8O88wJMH1Aq/7McKhlOMyN52ZY=; b=NDWgh4Z+TL1BqNWtPGoLDQJl7LlL6GJNV+MLgRBqgVOtf/T3SBANt83jiDLaMFeUn5gbtcoKBpGZYoP5vaRLDAXIM8jdn/NK1k2ohC6JYUyVUV7C5TktHdj9ZXftnjqCkijdZQ8AfMuKlCxnaWMKEEL7pp3Ua4zYxVJSMqaXrWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706502904415.5650039946272; Wed, 24 Sep 2025 02:35:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Loy-0005GA-DU; Wed, 24 Sep 2025 05:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Low-0005Eu-CY for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loo-0004p8-3L for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:53 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-iYylprS2NcCzUo0dI2QQmg-1; Wed, 24 Sep 2025 05:29:39 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b2cc0d644bcso204809166b.2 for ; Wed, 24 Sep 2025 02:29:39 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b26847b9f37sm1151972066b.18.2025.09.24.02.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8v7cUZBltXG+hT2nF8O88wJMH1Aq/7McKhlOMyN52ZY=; b=g3+xRm8wYsHsfMlHNpoB70ptpx8DpKt8bjDct3jvpBzCwfApmbGk0eTWDLiWGY3sTJT10n 50Bg+G0tzsWWzjwqM4Eu79YMQ+hkUmuT6RTR/9Xy1hDaqcF4eJ4T4nbhcfGM6ME7ITe67W oM+oxjMAn5sv02WB3/bRtJPlRg0JxEs= X-MC-Unique: iYylprS2NcCzUo0dI2QQmg-1 X-Mimecast-MFC-AGG-ID: iYylprS2NcCzUo0dI2QQmg_1758706178 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706178; x=1759310978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8v7cUZBltXG+hT2nF8O88wJMH1Aq/7McKhlOMyN52ZY=; b=fYfoOcxCLGrySEb+AW1gKqn8g2B3SwPF6HvbE+fsggOSvIHRJTc/1zhTDOYh2u6gmu I5b6luMSGbAEHpmRq+dsaVJZvt+NLQ1kAKc0a/EJEayylZpy2obaAo+ObzYSZwhg26Dv Jq1CzrRIfwp5GqDZTc+QnBzB/rANguxXKzj0NKm13mcdNVtNEdlLgukhAviNAE2MUUj/ e38IjG7cLyLrXUmmzSR+5R/NdwtRTTXQQi5zHtk/JNaFKmwFOb0FnXo7iZYuS2YPhlL0 Q1OFNFTR3NecqBUfdbV1h5VHztlMSOHsn/PbJNqnkCnhN3Zz0deUFgN2zJm9iy9esZCj Lhng== X-Gm-Message-State: AOJu0YyXAlYPSs4/CXubxpUcDDE2hDvvOUM+a7yfiVOT2mTRtESu7tLH DL7lUeUsp1SVQJPn/vJuya+rzSpzMSkckLiOABP9cqzVFdj8gaw0VhL7XCusJUVa22cbdm9R+op P6VeC86zh/jpMa+6awH889hmDXvANaZOP4GYyN5Lcx+lsDAC6dSYOdKvDK56ODvJXfkucBWuvJG PcGrYZGSIVucSxPeynhaLdAM6I+9vsC06tLyzmAXIo X-Gm-Gg: ASbGncuekB+0rHt/jNqAowMtoE1FwKzf4/PA/WXCqMcI0NeO7hRfWUILB93zsppibbK EBn/do3RcY/hRV35ZeY23R4ALJ3cYkPVRiF9E0hINSsZWRRFmGgdZMmq4WGtu2Qxb0SHXv2tmwM 1XoelcM7IzdRzEjeFG770iML01t0K/3Z9NxYJ7lF9PLnJnpDAom+kB+y22REuLtq6x33HcK2710 I0GlPzIIKcODTAaFEmMmW9K1YyTEXq0OB8DpFXinuDHuFbjRSWMexu53N85kOXtLAESO5Wzr9R0 kC3BnNkYVOGlqR8L3EJs4qxXKOyLf7ialCWp9twOKgiz1w+ZF7tQD+PlKZe9H/wfHQmsdtmzc0E sX6wIOWuIHmPIsgSQA5ptGPjb7azxsvYIAa07uEMzLj7oXw== X-Received: by 2002:a17:907:934c:b0:afe:e7f1:289d with SMTP id a640c23a62f3a-b302b22ac3dmr578936966b.62.1758706177536; Wed, 24 Sep 2025 02:29:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG89ZmLGf6N/dkjnzdkAbubgqCHYnmo9XiRdIgNZfmWBCEdtgwfeLjffBP9k+NvpCx6CCuuKg== X-Received: by 2002:a17:907:934c:b0:afe:e7f1:289d with SMTP id a640c23a62f3a-b302b22ac3dmr578919866b.62.1758706173366; Wed, 24 Sep 2025 02:29:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu Subject: [PULL 14/29] rust/qdev: Support bit property in #property macro Date: Wed, 24 Sep 2025 11:28:34 +0200 Message-ID: <20250924092850.42047-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706504767116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Add BIT_INFO to QDevProp trait, so that bit related property info could be bound to u32 & u64. Then add "bit=3D*" field in #property attributes macro to allow device to configure bit property. In addtion, convert the #property field parsing from `if-else` pattern to `match` pattern, to help readability. And note, the `bitnr` member of `Property` struct is generated by manual TokenStream construction, instead of conditional repetition (like #(bitnr: #bitnr,)?) since `quote` doesn't support this. In addtion, rename VALUE member of QDevProp trait to BASE_INFO. And update the test cases about qdev property. Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-9-zhao1.liu@intel.com --- rust/hw/core/src/qdev.rs | 19 ++++++++++++------- rust/qemu-macros/src/lib.rs | 18 +++++++++++++++--- rust/qemu-macros/src/tests.rs | 8 +++++--- 3 files changed, 32 insertions(+), 13 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 85422e0379e..9c82e1716c5 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -109,8 +109,8 @@ pub trait ResettablePhasesImpl { /// /// # Safety /// -/// This trait is marked as `unsafe` because `VALUE` must be a valid raw -/// reference to a [`bindings::PropertyInfo`]. +/// This trait is marked as `unsafe` because `BASE_INFO` and `BIT_INFO` mu= st be +/// valid raw references to [`bindings::PropertyInfo`]. /// /// Note we could not use a regular reference: /// @@ -131,14 +131,19 @@ pub trait ResettablePhasesImpl { /// It is the implementer's responsibility to provide a valid /// [`bindings::PropertyInfo`] pointer for the trait implementation to be = safe. pub unsafe trait QDevProp { - const VALUE: *const bindings::PropertyInfo; + const BASE_INFO: *const bindings::PropertyInfo; + const BIT_INFO: *const bindings::PropertyInfo =3D { + panic!("invalid type for bit property"); + }; } =20 macro_rules! impl_qdev_prop { - ($type:ty,$info:ident) =3D> { + ($type:ty,$info:ident$(, $bit_info:ident)?) =3D> { unsafe impl $crate::qdev::QDevProp for $type { - const VALUE: *const $crate::bindings::PropertyInfo =3D + const BASE_INFO: *const $crate::bindings::PropertyInfo =3D addr_of!($crate::bindings::$info); + $(const BIT_INFO: *const $crate::bindings::PropertyInfo =3D + addr_of!($crate::bindings::$bit_info);)? } }; } @@ -146,8 +151,8 @@ unsafe impl $crate::qdev::QDevProp for $type { impl_qdev_prop!(bool, qdev_prop_bool); impl_qdev_prop!(u8, qdev_prop_uint8); impl_qdev_prop!(u16, qdev_prop_uint16); -impl_qdev_prop!(u32, qdev_prop_uint32); -impl_qdev_prop!(u64, qdev_prop_uint64); +impl_qdev_prop!(u32, qdev_prop_uint32, qdev_prop_bit); +impl_qdev_prop!(u64, qdev_prop_uint64, qdev_prop_bit64); impl_qdev_prop!(usize, qdev_prop_usize); impl_qdev_prop!(i32, qdev_prop_int32); impl_qdev_prop!(i64, qdev_prop_int64); diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs index 37e1b723bd5..3e21b67b471 100644 --- a/rust/qemu-macros/src/lib.rs +++ b/rust/qemu-macros/src/lib.rs @@ -179,6 +179,7 @@ fn parse(input: ParseStream<'_>) -> syn::Result { #[derive(Default, Debug)] struct DeviceProperty { rename: Option, + bitnr: Option, defval: Option, } =20 @@ -187,6 +188,7 @@ fn parse_from(&mut self, a: &Attribute) -> syn::Result<= ()> { use attrs::{set, with, Attrs}; let mut parser =3D Attrs::new(); parser.once("rename", with::eq(set::parse(&mut self.rename))); + parser.once("bit", with::eq(set::parse(&mut self.bitnr))); parser.once("default", with::eq(set::parse(&mut self.defval))); a.parse_args_with(&mut parser) } @@ -222,7 +224,11 @@ fn derive_device_or_error(input: DeriveInput) -> Resul= t {{ @@ -252,14 +258,20 @@ macro_rules! str_to_c_str { }, )?; let field_ty =3D field.ty.clone(); - let qdev_prop =3D quote! { <#field_ty as ::hwcore::QDevProp>::VALU= E }; + let qdev_prop =3D if bitnr.is_none() { + quote! { <#field_ty as ::hwcore::QDevProp>::BASE_INFO } + } else { + quote! { <#field_ty as ::hwcore::QDevProp>::BIT_INFO } + }; + let bitnr =3D bitnr.unwrap_or(syn::Expr::Verbatim(quote! { 0 })); let set_default =3D defval.is_some(); let defval =3D defval.unwrap_or(syn::Expr::Verbatim(quote! { 0 })); properties_expanded.push(quote! { ::hwcore::bindings::Property { name: ::std::ffi::CStr::as_ptr(#prop_name), - info: #qdev_prop , + info: #qdev_prop, offset: ::core::mem::offset_of!(#name, #field_name) as isi= ze, + bitnr: #bitnr, set_default: #set_default, defval: ::hwcore::bindings::Property__bindgen_ty_1 { u: #d= efval as u64 }, ..::common::Zeroable::ZERO diff --git a/rust/qemu-macros/src/tests.rs b/rust/qemu-macros/src/tests.rs index 00a106612fc..ec137132ae7 100644 --- a/rust/qemu-macros/src/tests.rs +++ b/rust/qemu-macros/src/tests.rs @@ -60,7 +60,7 @@ struct DummyState { migrate_clock: bool, } }, - "Expected one of `default` or `rename`" + "Expected one of `bit`, `default` or `rename`" ); // Check that repeated attributes are not allowed: derive_compile_fail!( @@ -106,8 +106,9 @@ unsafe impl ::hwcore::DevicePropertiesImpl for DummySta= te { const PROPERTIES: &'static [::hwcore::bindings::Property] = =3D &[ ::hwcore::bindings::Property { name: ::std::ffi::CStr::as_ptr(c"migrate_clock"), - info: ::VALUE, + info: ::BASE_INFO, offset: ::core::mem::offset_of!(DummyState, migrat= e_clock) as isize, + bitnr: 0, set_default: true, defval: ::hwcore::bindings::Property__bindgen_ty_1= { u: true as u64 }, ..::common::Zeroable::ZERO @@ -133,8 +134,9 @@ unsafe impl ::hwcore::DevicePropertiesImpl for DummySta= te { const PROPERTIES: &'static [::hwcore::bindings::Property] = =3D &[ ::hwcore::bindings::Property { name: ::std::ffi::CStr::as_ptr(c"migrate-clk"), - info: ::VALUE, + info: ::BASE_INFO, offset: ::core::mem::offset_of!(DummyState, migrat= e_clock) as isize, + bitnr: 0, set_default: true, defval: ::hwcore::bindings::Property__bindgen_ty_1= { u: true as u64 }, ..::common::Zeroable::ZERO --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706400; cv=none; d=zohomail.com; s=zohoarc; b=JWRl2senom8JdNlbZp77YLVfdyNhQ5/kNPJS4NY7IKlF8A+QPjJRTpT1714GXmrymhZ4IY0gYgNpJOEHFt0DhwoYo4USoJZfmPoClZkouLq6pQaRwxlnRkPUrOwWVIU4HBnP+JJuADZ59CRj6LgSsvRQecd7tdcpTvpqf5QP4iI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706400; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HXmvPGZW6Xy2j6d5SQMF9drQH62wek/K3jL06MV925U=; b=n5PQNGGryvVFkuWFJyRFyrqK2Fglth+6sK4jaEgrQHHyMxUrbwiI2ha8AFZ1wio9l/2ecXujlx0RiXcH6L+p+Liloj3pEsYNpAaorZ4K26tkDkNUk6EVZUjM0yiOf4/y57rIVofheijLEljjp7aG14h87aKXuqOsqDtkXduWjZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706400691460.21832692303497; Wed, 24 Sep 2025 02:33:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Loy-0005G0-5V; Wed, 24 Sep 2025 05:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lov-0005EH-07 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loq-0004pJ-8r for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:52 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-0kUguhR8MUiV5kId6M3o6w-1; Wed, 24 Sep 2025 05:29:41 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b2e6b2bb443so264352166b.2 for ; Wed, 24 Sep 2025 02:29:41 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62fa5f27640sm12429827a12.39.2025.09.24.02.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXmvPGZW6Xy2j6d5SQMF9drQH62wek/K3jL06MV925U=; b=MysXxtF5Y0+cGfPUIIjrt9yPAsP792F1KwMqWp0WZnKBSKPZJPkesIUZR431JArcuO/uEd dmnuZsNK2ryPjS4B87X9U6c3idYTRsJW1Rm0BqpKYcsF9aUPZVu66m4EIg0E6topBdlfM5 C83mSdU9k2GV17IzpmJhWI7c8/M6Xgc= X-MC-Unique: 0kUguhR8MUiV5kId6M3o6w-1 X-Mimecast-MFC-AGG-ID: 0kUguhR8MUiV5kId6M3o6w_1758706180 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706180; x=1759310980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HXmvPGZW6Xy2j6d5SQMF9drQH62wek/K3jL06MV925U=; b=Ca9jqOA/LOXr7CK9XP9lo/HBe9KjcjuC+s5tKefO6SZaGMX+Z6wzRtCbxtLEQQCx7j jv1fBx71hLjtwXXs8gjKDqxoN23x8slcdRhUEMGd/K8RisuQ0Ci5xb4opj3yLNpQXICL Erf8WHdZpzfCc4geLx6iD78xswYGVAdpX/Y63so4aalTcKzdPwRJDCEhfOH+eM9BUtYc C9IeDb0Wa1az/nC9UhrmXs6ChagugSZyWC/nEZfgKIP3/lNCm7t+vJZaYYtcDPhXrIYN B6zG2iFJ3nwMPnq2GMNi6c7m4RkYwfnYpNkd64WkqIN8ymFZeAPDirqMKX3KY9VVvBVZ eMzA== X-Gm-Message-State: AOJu0Yy8hCa6kmoYxo9VA1OgKdEstSyKJAUOy5SSWHsuGvF5zxlKqoSi 4ZUcaqfzR0u+7j+wfmfjozqXmfGoMLeT3z5z6N2bkLsty2dI1jFdR1UEbMuzujj1NzpfLg7RM6K 8M92ioNH7o1jkeG1q+oEngoRJcSmKd6MRCAGQMkfdMCm4bXJVJIyNxB2jRSNCispaL+LtEkPB2W N294UH9LE2Lahn42vOa46Ll2IOtDzne7CcZz4IDQ2a X-Gm-Gg: ASbGncs33obArk0fkcdtmRjj6ZJzBa1rrlIS6Jg7bmHNWOHiPrxwW0X2zKRD7vuqfxW kMZheYmEiUOenVKWbRyei6GCRnScJYuNJFU3N462IYW2XGnueo8b7qNDC68hXULB/2NCMSuEEpV Z6CoJIIp5Wm+e7mTo0W++B6n2Y2O6djSoZKmh6jMAXKhn9gUWO3bd4Huxaz2SFQtva+aCjViZvm YSz20wTEQamXdWJC4DOJopgOsEx7wvagUJsDDPtu/CBRxA3ZXowj97urr2Nysie06BP8D5hTxEW mPza2HM4dA8t71fp59LZuF+XU6o3dDKebhtjC0ObfgI9noQsJy5e2EnjofzKXaHEKI9I67fcfdJ kMJrY3YeoUqn1wHffntl64NMkcMZKHo/teVGCcbiDUTj04A== X-Received: by 2002:a17:906:4fca:b0:ae3:b2b7:7f2f with SMTP id a640c23a62f3a-b302a36d276mr638233866b.40.1758706179755; Wed, 24 Sep 2025 02:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcVaNEYDYvuMwc5KljUL2ILfOCZq9WbaTbv8PpkQPjvlWw7PbjtCqBlFk/hyGs+i+Cp1gw3A== X-Received: by 2002:a17:906:4fca:b0:ae3:b2b7:7f2f with SMTP id a640c23a62f3a-b302a36d276mr638230866b.40.1758706179290; Wed, 24 Sep 2025 02:29:39 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu Subject: [PULL 15/29] rust/qdev: Test bit property for #property Date: Wed, 24 Sep 2025 11:28:35 +0200 Message-ID: <20250924092850.42047-16-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706403067116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu There's a diference between Rust and C: Though C macro (e.g., DEFINE_PROP_BIT or DEFINE_PROP_BIT64) always requires default value, Rust side allows to omit this "default" field in #property, and provides a default value ("0" - false) for this field. This minor difference does not break user habits and should be acceptable. Therefore, the test cases also cover this scenario. Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-10-zhao1.liu@intel.c= om --- rust/qemu-macros/src/tests.rs | 99 +++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) diff --git a/rust/qemu-macros/src/tests.rs b/rust/qemu-macros/src/tests.rs index ec137132ae7..ac998d20e30 100644 --- a/rust/qemu-macros/src/tests.rs +++ b/rust/qemu-macros/src/tests.rs @@ -89,6 +89,19 @@ struct DummyState { "Duplicate argument", "Already used here", ); + derive_compile_fail!( + derive_device_or_error, + quote! { + #[repr(C)] + #[derive(Device)] + struct DummyState { + #[property(bit =3D 0, bit =3D 1)] + flags: u32, + } + }, + "Duplicate argument", + "Already used here", + ); // Check that the field name is preserved when `rename` isn't used: derive_compile!( derive_device_or_error, @@ -145,6 +158,92 @@ unsafe impl ::hwcore::DevicePropertiesImpl for DummySt= ate { } } ); + // Check that `bit` value is used for the bit property without default + // value (note: though C macro (e.g., DEFINE_PROP_BIT) always requires + // default value, Rust side allows to default this field to "0"): + derive_compile!( + derive_device_or_error, + quote! { + #[repr(C)] + #[derive(Device)] + pub struct DummyState { + parent: ParentField, + #[property(bit =3D 3)] + flags: u32, + } + }, + quote! { + unsafe impl ::hwcore::DevicePropertiesImpl for DummyState { + const PROPERTIES: &'static [::hwcore::bindings::Property] = =3D &[ + ::hwcore::bindings::Property { + name: ::std::ffi::CStr::as_ptr(c"flags"), + info: ::BIT_INFO, + offset: ::core::mem::offset_of!(DummyState, flags)= as isize, + bitnr: 3, + set_default: false, + defval: ::hwcore::bindings::Property__bindgen_ty_1= { u: 0 as u64 }, + ..::common::Zeroable::ZERO + } + ]; + } + } + ); + // Check that `bit` value is used for the bit property when used: + derive_compile!( + derive_device_or_error, + quote! { + #[repr(C)] + #[derive(Device)] + pub struct DummyState { + parent: ParentField, + #[property(bit =3D 3, default =3D true)] + flags: u32, + } + }, + quote! { + unsafe impl ::hwcore::DevicePropertiesImpl for DummyState { + const PROPERTIES: &'static [::hwcore::bindings::Property] = =3D &[ + ::hwcore::bindings::Property { + name: ::std::ffi::CStr::as_ptr(c"flags"), + info: ::BIT_INFO, + offset: ::core::mem::offset_of!(DummyState, flags)= as isize, + bitnr: 3, + set_default: true, + defval: ::hwcore::bindings::Property__bindgen_ty_1= { u: true as u64 }, + ..::common::Zeroable::ZERO + } + ]; + } + } + ); + // Check that `bit` value is used for the bit property with rename whe= n used: + derive_compile!( + derive_device_or_error, + quote! { + #[repr(C)] + #[derive(Device)] + pub struct DummyState { + parent: ParentField, + #[property(rename =3D "msi", bit =3D 3, default =3D false)] + flags: u64, + } + }, + quote! { + unsafe impl ::hwcore::DevicePropertiesImpl for DummyState { + const PROPERTIES: &'static [::hwcore::bindings::Property] = =3D &[ + ::hwcore::bindings::Property { + name: ::std::ffi::CStr::as_ptr(c"msi"), + info: ::BIT_INFO, + offset: ::core::mem::offset_of!(DummyState, flags)= as isize, + bitnr: 3, + set_default: true, + defval: ::hwcore::bindings::Property__bindgen_ty_1= { u: false as u64 }, + ..::common::Zeroable::ZERO + } + ]; + } + } + ); } =20 #[test] --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706480; cv=none; d=zohomail.com; s=zohoarc; b=We60gX0HB9C9nIlu81aud0iuf4qDl7b7xRY5ZI8gNxtMildJKdIVdCCnkuTQjEBTH/5+oc0o8Xez5NOwiD7I3xvUxeysryZWBhFQaG3/sL+Qd4xqFxWWaisjHMB216khWw4rzKF1tg/Ggksdqvjm2SX/r6AX9XbZ3vvT5XzxKq8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706480; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cGRXr7IOuXBD087dAOWEFFsD7KAtBeiyHVV7B7Xyq60=; b=cxesGJjvCm6TdrBbXPRDoDV2F5Ac4uSMF6KBxVJ35JYpa4Bv/fqwjJBpTvwVM37FgAk3UCXI5PQn1sH2PN4HvCZb+JpgskA5FQxlNruaQsuP7AJh+slCxFlmI2gzkw5f3rQbsdmikHUmTP2+eaBtyCJGbMvz/9EOIhv9R9U+iE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17587064806031009.4107985874066; Wed, 24 Sep 2025 02:34:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lp0-0005H3-8c; Wed, 24 Sep 2025 05:29:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loy-0005FF-4s for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Los-0004pX-2t for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:54 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-ME0kMPCAMB6hPOZEXzEo_Q-1; Wed, 24 Sep 2025 05:29:43 -0400 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-afe7b40b15fso236869866b.1 for ; Wed, 24 Sep 2025 02:29:43 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b29abf51da3sm907646666b.75.2025.09.24.02.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGRXr7IOuXBD087dAOWEFFsD7KAtBeiyHVV7B7Xyq60=; b=OwXzWETmDs1xmyc5QZnWBqpiB2JDhm3XJJgimoprp0/Q8keHkN+m45H2S4jVdY5JAy7XDc K5yaI+CwKylKMa47qBeWHyG1r1obZ2Rm+O09pCiMOx9JnOrgLBG09gTq67MAHjXl8yXe+H xeaO9wNUqx+w9JV8jDj6k5BVe/E7TNE= X-MC-Unique: ME0kMPCAMB6hPOZEXzEo_Q-1 X-Mimecast-MFC-AGG-ID: ME0kMPCAMB6hPOZEXzEo_Q_1758706182 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706182; x=1759310982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cGRXr7IOuXBD087dAOWEFFsD7KAtBeiyHVV7B7Xyq60=; b=aSjgmqcE3QE9gVrHJET56m9ig3sc6JREw0LNdS/RVU52mkXD/7IMpbhuaLqODavZIn TQkrPcgJZBT97mfOYJ4IqUyXbaiFuC6Kvi8KkNe9+YNgrJRzoG1t5GFBnXwOXq56wIu0 T9cjF8eOTtKUJEsXx/61KnDXidytI/W5gvdOQkFjq3Jo0yEyNFBsowW0GUHweI90EzJ5 fuRo0cprbuLSFzDcIoGPpRYmpHpYmkFkIdmhvYkHtre3TS0eKn1m4qKd9IuhgToBA41D e6beTE5zZ944HUdQFO/VrYPkLF02bwO2r1KeSLtXxlihj0NySYb/iELuENMQrx8due7g TQJw== X-Gm-Message-State: AOJu0Yz3GEFLr97w6WZ5eYYwFsJA8SDw35kF/jCnDPwpXdE9+jC9vk23 B76N/sKiFblckIYJh9Y5EG6TnifEHwLe+Rp43JLHua+/2u82IJCSUcJs359u2P49rX34ht3DHBJ JCW65m1m3ZpUt6kONtTi+nyHn3azPbynMwjPYLUyAT41s389hi2mE+jlRPwLiqcuCv19AzKxCuS 8/4D8bn0oFFM/Pe+FOFTKAoPxrZeIdnk4PHZiUU9rY X-Gm-Gg: ASbGncuf8KD2VoQKszoVh3DC4rJVjtEAcKxZjQ2Q9yKuzsOX1T8xRYoyHQnhWKidUf7 S/kZS9Ok8ngaO03eBA6tVVxmbIGcyIVvHJg5LSw2RUlbYugQyf4nKbdR+HKULlYZWpVha0lsJQR UTX5cixzjJ1+mJJLkIxjd/vWiamtFz4Kae3ABVxtHj/5JWGKS8F9h29ahATptwH5xpM3gBdWOyu Ms92E/SELx6wrozQVmG4EH78K82pF3JITuPw+5ATKIEuIEw1tBnjsNwFCo+cuyfvsN6X/Y47KWj /2Zaqq2aEQjEOnsgSjnfvFjTsfwOTEeujunhn8UEsp24oqVcL+Eec9INdab3yDatpTJ2zHVsmY9 2Fl2Gg7ZNVLdxUMF+1gtUFBFNw3bNeR/JEY/8V6FiFEoBJw== X-Received: by 2002:a17:906:f590:b0:b2e:51cc:9b9 with SMTP id a640c23a62f3a-b3027d3e5a8mr550345266b.24.1758706181686; Wed, 24 Sep 2025 02:29:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaStrNEzvYEI+nuTAoiuUJXSw+KmgVILcCMs/tlOlHpHDm7XCGBgLOKCZHhibWfuojAtb4cQ== X-Received: by 2002:a17:906:f590:b0:b2e:51cc:9b9 with SMTP id a640c23a62f3a-b3027d3e5a8mr550342966b.24.1758706181206; Wed, 24 Sep 2025 02:29:41 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu Subject: [PULL 16/29] rust/hpet: Clean up type mismatch for num_timers property Date: Wed, 24 Sep 2025 11:28:36 +0200 Message-ID: <20250924092850.42047-17-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706482221116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Now `num_timers` is `usize` other than `u8`. Although the type field in `declare_properties` macro hasn't been used, it's better to explicitly point this out and clean up this before doing other property work. Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-11-zhao1.liu@intel.c= om --- rust/hw/timer/hpet/src/device.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index 3cfbe9c32bb..fce75415579 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -909,7 +909,7 @@ impl ObjectImpl for HPETState { HPETState, num_timers, unsafe { &qdev_prop_usize }, - u8, + usize, default =3D HPET_MIN_TIMERS ), define_property!( --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706235; cv=none; d=zohomail.com; s=zohoarc; b=XOypY1vPMfAkzibZx1neBIR9gRIX0hw8msA531XMPjicWl9OfQYpaNheN99OQRKFZwy9BXfz6Tugm9z2GKkZvf/8UlkvQ6YkBB/vtZZgjVVeCPkKGDbM2VoRFS4Qu6EN9lE0+D80irMs9q2TAx9I5B7QsVnZ1fEdcicOelomRkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706235; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DQUPVZSKZhpdKrFkjv8ftxjx2NnW+jSnVDAPdZWCuMI=; b=da0JVlcqtsRVZX+/cXjzwHz4L7VwFdTqG/9dkvfCIxJ+6tj9iwt3JgGUO0GCawUZTI3rh/fpe03x248tab2d4BHDRSH973V08x7LJNlLA4A1unEE7EQg6HJBPGdRPPasTRJ9uWSgDqMWt9Sr1WQe914JBmgWxiI1unZ7Ol4srDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706235634195.32390897943105; Wed, 24 Sep 2025 02:30:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lp1-0005Hz-FM; Wed, 24 Sep 2025 05:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loy-0005GJ-CL for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lot-0004pd-2E for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:56 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-ivMewdKTOiWlriHp0i0aiQ-1; Wed, 24 Sep 2025 05:29:46 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b04a8ae1409so640533666b.2 for ; Wed, 24 Sep 2025 02:29:45 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b1fd271f895sm1489702866b.97.2025.09.24.02.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQUPVZSKZhpdKrFkjv8ftxjx2NnW+jSnVDAPdZWCuMI=; b=XLZ8uvtJTyjRAGxxrbZG1XSXCHgKK7YMY9tgodZA+buF8JP9OLhOEf91xQ+BikjasSrc8G QapPQscXw0SCIYXC5ZARamLP8AMvoK823DbNWt0iJBW0cxAeBbnE8wm5QT1PYe+jk/YVnT VNFeV1S8tPBvbHONJUKwraD+I9wnUNE= X-MC-Unique: ivMewdKTOiWlriHp0i0aiQ-1 X-Mimecast-MFC-AGG-ID: ivMewdKTOiWlriHp0i0aiQ_1758706185 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706184; x=1759310984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DQUPVZSKZhpdKrFkjv8ftxjx2NnW+jSnVDAPdZWCuMI=; b=q/ZV5+KdOois4+1Wr3uywbqco6wrSwFT27KyTD1/F5zm2wJLzRzCDtmi+Z84Lul7X2 ANTTKcvW+sWEKzLCVxjajqEU9LzGt4by30BPIhoiY2f9IDDsT1UEue/OqD+wiLGfLb5A xcgf0sqd0j8sJf4URCF889/vbmsdSw2F0duF0cSIgbIN78Io+05Pubq+osdBuptP2OYp 5gWUAJKGdRH6PDutOwP/T8qetX8ddoeu6l8bwflGzBixMicmK3hj2wTqHgp/uhSGwocw QxpcNFVQFxOdq1hynHvlql4mKNzM3IoO1YeUYhry5ebrDQ4ETmuFqYHCGxW9XduaJj2o EPBg== X-Gm-Message-State: AOJu0YzeeYZX0Qg+zSMv4/8L8OnlRPqSIdIthLGLgCo/DBT9sMZHnhMU IFcLeBETKP/G0j2qxkoiRdNnLebvg3eXk2j9qzou9vnNbo7X3qFVUMOIYjgdxG//8zYLHSKGtos 7T+EkNRcqbDtZam/RWDA0LbdR7F86Zc1SfuiIfcixiNXlZpYb5gDPpJq5TnysJY2+rhhR1t+VIp x3pVaCq+4hmC3kFdKAA5kSJkwsSRQas1cNwS/pDwYm X-Gm-Gg: ASbGncvBxq7r5IuaXXot15tlG3+epihM2fjJp0+FVTZEJpAsr7ehkYptVUNyOLCDKIc oGxfzYbNL4Jhm+x/KjjYTrFVWgMB5QH1MpobpY8MgzpFW9hkqZST74TZQVLUvMn9dszNHB3FlDH bOK6g7p5XjmBog2NGhH8p4kJtKbN2JJniGSz/Y6xPHeZajErz53kI8Z/4DS6RuWQWX+NPUPQGHm wfQaBbmKuEmCDcp3ce+kLKv+eQPU0w1iWg+1daiYFCiIe8osxbCAYy0rwkI3Ujgsni+NQjFE9n0 DoJCV9U4R8G5UgU2j20u/ZN8EqbF/OV8tj5/lIce4CxuMeceMYufZtn/x1kxLGatqPuSPCj8k9E QRRQ1Xz0qgkTIxIJRPeOL20MQM4uzxYf0Ar8tA95pcF1+Lw== X-Received: by 2002:a17:906:f042:b0:b29:d157:9a0f with SMTP id a640c23a62f3a-b302802deaamr572549366b.25.1758706184059; Wed, 24 Sep 2025 02:29:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFjqcNYeRBMBFY7tRlEFITHRc3g1r3wmija6z20r8YuFPyxyD9EQMTiZ6yI2N44RtjZZYU/g== X-Received: by 2002:a17:906:f042:b0:b29:d157:9a0f with SMTP id a640c23a62f3a-b302802deaamr572547166b.25.1758706183561; Wed, 24 Sep 2025 02:29:43 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 17/29] rust/hpet: Convert qdev properties to #property macro Date: Wed, 24 Sep 2025 11:28:37 +0200 Message-ID: <20250924092850.42047-18-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706236829116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu Convert HPET's properties to #property macro: * num_timers: usize property. * flags: u32 bit property. * int_route_cap: u32 property. * hpet_offset_saved: bool property. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-12-zhao1.liu@intel.c= om --- rust/hw/timer/hpet/src/device.rs | 55 ++++---------------------------- 1 file changed, 7 insertions(+), 48 deletions(-) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index fce75415579..86638c07666 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -13,9 +13,8 @@ use bql::{BqlCell, BqlRefCell}; use common::{bitops::IntegerExt, uninit_field_mut}; use hwcore::{ - bindings::{qdev_prop_bit, qdev_prop_bool, qdev_prop_uint32, qdev_prop_= usize}, - declare_properties, define_property, DeviceImpl, DeviceMethods, Device= State, InterruptSource, - Property, ResetType, ResettablePhasesImpl, SysBusDevice, SysBusDeviceI= mpl, SysBusDeviceMethods, + DeviceImpl, DeviceMethods, DeviceState, InterruptSource, ResetType, Re= settablePhasesImpl, + SysBusDevice, SysBusDeviceImpl, SysBusDeviceMethods, }; use migration::{ self, impl_vmstate_struct, vmstate_fields, vmstate_of, vmstate_subsect= ions, vmstate_validate, @@ -520,7 +519,7 @@ fn write(&mut self, reg: TimerRegister, value: u64, shi= ft: u32, len: u32) { =20 /// HPET Event Timer Block Abstraction #[repr(C)] -#[derive(qom::Object)] +#[derive(qom::Object, hwcore::Device)] pub struct HPETState { parent_obj: ParentField, iomem: MemoryRegion, @@ -540,10 +539,12 @@ pub struct HPETState { // Internal state /// Capabilities that QEMU HPET supports. /// bit 0: MSI (or FSB) support. + #[property(rename =3D "msi", bit =3D HPET_FLAG_MSI_SUPPORT_SHIFT as u8= , default =3D false)] flags: u32, =20 /// Offset of main counter relative to qemu clock. hpet_offset: BqlCell, + #[property(rename =3D "hpet-offset-saved", default =3D true)] hpet_offset_saved: bool, =20 irqs: [InterruptSource; HPET_NUM_IRQ_ROUTES], @@ -555,11 +556,13 @@ pub struct HPETState { /// the timers' interrupt can be routed, and is encoded in the /// bits 32:64 of timer N's config register: #[doc(alias =3D "intcap")] + #[property(rename =3D "hpet-intcap", default =3D 0)] int_route_cap: u32, =20 /// HPET timer array managed by this timer block. #[doc(alias =3D "timer")] timers: [BqlRefCell; HPET_MAX_TIMERS], + #[property(rename =3D "timers", default =3D HPET_MIN_TIMERS)] num_timers: usize, num_timers_save: BqlCell, =20 @@ -901,44 +904,6 @@ impl ObjectImpl for HPETState { const CLASS_INIT: fn(&mut Self::Class) =3D Self::Class::class_init::; } =20 -// TODO: Make these properties user-configurable! -declare_properties! { - HPET_PROPERTIES, - define_property!( - c"timers", - HPETState, - num_timers, - unsafe { &qdev_prop_usize }, - usize, - default =3D HPET_MIN_TIMERS - ), - define_property!( - c"msi", - HPETState, - flags, - unsafe { &qdev_prop_bit }, - u32, - bit =3D HPET_FLAG_MSI_SUPPORT_SHIFT as u8, - default =3D false, - ), - define_property!( - c"hpet-intcap", - HPETState, - int_route_cap, - unsafe { &qdev_prop_uint32 }, - u32, - default =3D 0 - ), - define_property!( - c"hpet-offset-saved", - HPETState, - hpet_offset_saved, - unsafe { &qdev_prop_bool }, - bool, - default =3D true - ), -} - static VMSTATE_HPET_RTC_IRQ_LEVEL: VMStateDescription =3D VMStateDescriptionBuilder::::new() .name(c"hpet/rtc_irq_level") @@ -1001,12 +966,6 @@ impl ObjectImpl for HPETState { )) .build(); =20 -// SAFETY: HPET_PROPERTIES is a valid Property array constructed with the -// hwcore::declare_properties macro. -unsafe impl hwcore::DevicePropertiesImpl for HPETState { - const PROPERTIES: &'static [Property] =3D &HPET_PROPERTIES; -} - impl DeviceImpl for HPETState { const VMSTATE: Option> =3D Some(VMSTATE_HPET); const REALIZE: Option util::Result<()>> =3D Some(Self::re= alize); --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706318; cv=none; d=zohomail.com; s=zohoarc; b=bIdupmRzGu6aEN0a9ltf1nWbBkwP4WL03zm3zlLLM+66HEtgLroARLfjR2+jlfXeT5pxCm98Ql9QBNK0FCi15A5MT1W5uGoAd5O+cX0QXGXuMXuNuKiHXcMzbZWiCmoymJOg6+zvY4oEZ/p0MB3gB1zoxzvMEyXRvOBAWgemkV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706318; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iIHJDm7aNxFUbTsEnGeRE1qG811mxITS7dOJUdDzhCI=; b=Gtwalq4VlEzDnoUeHjdSNRD78SI8FgwuubLYg+sw/Vvqn/9uQ9B10yKsPFUg6tB7IkzODzRHnkyN26TUoLID7xv7R5bd8iA02gwcaaum5FA+JhOS3oGS8jym1dQJyA9Gwm/AKrAuF1abVhMHalI63pir0lgUzy+Pnuj/FY+qMRM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706318680376.6082380979028; Wed, 24 Sep 2025 02:31:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lp4-0005LX-KL; Wed, 24 Sep 2025 05:30:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp1-0005JC-Mp for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lot-0004pj-0y for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:59 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-gOnjK2UxOay9E7HwvAUFFg-1; Wed, 24 Sep 2025 05:29:48 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b2d604db3easo267300566b.3 for ; Wed, 24 Sep 2025 02:29:47 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6cb9sm834859966b.36.2025.09.24.02.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iIHJDm7aNxFUbTsEnGeRE1qG811mxITS7dOJUdDzhCI=; b=Cw+uy1P6DeLeyV2sy8tlfpDv+Oz3aoIoRIbxOeUtCfBt//gqDCSu4FxkwUaYIubou13Z22 RPlCfFLwl0pZ+6icmbkaChlBICmtHCfzfW8Ovvfz8VQQSWTLHbQkllQFihWQMvGJNvNQrZ F3C0q8KlQ+A2NWqzJljQos+or42Aug4= X-MC-Unique: gOnjK2UxOay9E7HwvAUFFg-1 X-Mimecast-MFC-AGG-ID: gOnjK2UxOay9E7HwvAUFFg_1758706187 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706186; x=1759310986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIHJDm7aNxFUbTsEnGeRE1qG811mxITS7dOJUdDzhCI=; b=YV3QZXWcuTYR8iLZH+oR375DRTX+3C3asR10ATqBeCq2V1+ZtioiImyNIi3dzTMGpz 2Sxg0nY+meGxqCXJQJ/LPFp6M+hrP2IgLFE7UTYdGkVk9Wx+x342nJLl8+jn9xJdpnwG GRVWfSjp4W227uqDbSETCDbcjOjUYDSLuOwsqdNn/6lN+qkssBl5ZiCl5iYIqSRYMk32 5MP+WI1PxzLtMcPDMtxscJN4epTIEXx+MGbhjiuOyqlRLgy5rcvAZcacptp/86MPkwX6 FxGtLJQY//L7iNCwG2xtblJoHmnlYkR8+QlAzj0jqWMH07/yWWjjw1hlavXF8eDDw0NR lJ/w== X-Gm-Message-State: AOJu0YwVe3KLwO9mLfQ19RrNLZdz8qSjiBZs6W900Go6BhWblyJpd87i yaae01Rhh165tE6BoobBnKVDItzus0mB6qDE/freiK0cnZI/5sgIpjGMKWTirBbgqMpIB8bDjEE yDeVdp37ofWh9SpGUPc7c1pWnFveDcXasNgGW6EMQLWGLWPIEsq7CAsvOceXjTTXEYINjZHryzb yYeIcQ5jqIBP6upoMnkz7yxVAn1nrkiJw0MBj3dZK/ X-Gm-Gg: ASbGncvfDXB/tX0m2YVSMvCtMUV2i3krr+cV9EWsuJeuNsNgELI7TlZaNsT8aTgMyLW imGjgbBDvjvXH5bVhjXrAus5UI3rCY88zzuzr3KTtVRrGmnBJcxxhysQAoha/pmuwaPVo5ZuKF1 tJCLmz6jJfwS8ERIxJSlc14bBGI8OUKqy4oA0UIF5ON7YRK01G7kwvgsLHTXd1sHnNfFBybMrjW +HPUmRMNTtnDiLys5h0o+heVulcGOss5uNXUVF5yzI6WsiExQRzNN7y1FxFZHNRnrBBRX+iEolU nliP0JKF+58IwZZwjlyxX70iYsvP8It9qnqi5uZuHor6hw4LrlbaPCwA/Qb3c8A1vYDAuga2liE nAc+lJBELsffphstCy2+cOyD9kaq5ExKDeUsMtk5Hk4vFwA== X-Received: by 2002:a17:907:7f9f:b0:b2f:963:1d2f with SMTP id a640c23a62f3a-b302b2245c1mr588086266b.51.1758706186319; Wed, 24 Sep 2025 02:29:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmoP3C/NHDS4xRr4gqAP8qX1UBKgqfm2XW05R9uIlJdS1Od78xbxBKY9m2d+9zBVQP43lM7A== X-Received: by 2002:a17:907:7f9f:b0:b2f:963:1d2f with SMTP id a640c23a62f3a-b302b2245c1mr588084166b.51.1758706185893; Wed, 24 Sep 2025 02:29:45 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , Manos Pitsidianakis Subject: [PULL 18/29] rust/qdev: Drop declare_properties & define_property macros Date: Wed, 24 Sep 2025 11:28:38 +0200 Message-ID: <20250924092850.42047-19-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706320062116600 Content-Type: text/plain; charset="utf-8" From: Zhao Liu After HPET's #property conversion, there's no use case for declare_properties & define_property. So get rid of them for now. In future, if there's something that #property really cannot resolve, they can be brought back. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu Signed-off-by: Paolo Bonzini Link: https://lore.kernel.org/r/20250920160520.3699591-13-zhao1.liu@intel.c= om --- rust/hw/core/src/qdev.rs | 53 ---------------------------------------- 1 file changed, 53 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 9c82e1716c5..a4493dbf011 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -248,59 +248,6 @@ pub fn class_init(&mut self) { } } =20 -#[macro_export] -macro_rules! define_property { - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty, bit =3D $b= itnr:expr, default =3D $defval:expr$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - bitnr: $bitnr, - set_default: true, - defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval = as u64 }, - ..::common::zeroable::Zeroable::ZERO - } - }; - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty, default = =3D $defval:expr$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - set_default: true, - defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval = as u64 }, - ..::common::zeroable::Zeroable::ZERO - } - }; - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - set_default: false, - ..::common::zeroable::Zeroable::ZERO - } - }; -} - -#[macro_export] -macro_rules! declare_properties { - ($ident:ident, $($prop:expr),*$(,)*) =3D> { - pub static $ident: [$crate::bindings::Property; { - let mut len =3D 0; - $({ - _ =3D stringify!($prop); - len +=3D 1; - })* - len - }] =3D [ - $($prop),*, - ]; - }; -} - unsafe impl ObjectType for DeviceState { type Class =3D DeviceClass; const TYPE_NAME: &'static CStr =3D --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706617; cv=none; d=zohomail.com; s=zohoarc; b=awfpKCBBnICO6F75Z10kSBU/d30TB0MNpOMwSfuUAMO1YNRyv5mfqdF/aLbNvtj3JBPypTcJG/EKDcjDoURxdRwUsxn+EHJDCQkWwzp2yl1EDmrt9bGz5hficIZmy9wxzhlxDbHSHdECSMiUFZbalrSxYV9OJPmM2BRMOfL/ddA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706617; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5Lr8fIGw+ra7DxehRDJAgbjkaaSFobuUwVbfza7dpxE=; b=JhlJVfWcgW8I67pAXA8WVkZvYpLtwuCzhTVb+5T9WjQtV3BSHhozwylOdkcnYGg2ucsUNwRoF1KcONw0efndAdkK5BV64qCCfWcrEm24E/4IX5R1qa8vP88MnWSq7DGC6YHir2hPZ3MUbK0n54En59IwnWWQNPi339wkf6G8n+8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706617477910.2395795835798; Wed, 24 Sep 2025 02:36:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lp7-0005N8-3X; Wed, 24 Sep 2025 05:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp1-0005J8-HV for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Loy-0004q8-44 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:29:59 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-G2xi3pd-M8SswEIwGpdwcA-1; Wed, 24 Sep 2025 05:29:51 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b3347f0b205so37571266b.0 for ; Wed, 24 Sep 2025 02:29:51 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b32859673b4sm130560566b.30.2025.09.24.02.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Lr8fIGw+ra7DxehRDJAgbjkaaSFobuUwVbfza7dpxE=; b=i/Kw9wSx3ToCViat8L16lrDB5IdqWnVMV89nfw+EMl4Evv03KHb0nsdxgxsUpFQs7F62Sk CGYZpPHk/Gi+7ll+jyVzTPEujAY/FfG59cJrPmSl49jX9BvDPhsWOkvMAxZCOShH9OwWvK 5uypY2kpVhD9iLrUPOQRDC99obkHu88= X-MC-Unique: G2xi3pd-M8SswEIwGpdwcA-1 X-Mimecast-MFC-AGG-ID: G2xi3pd-M8SswEIwGpdwcA_1758706190 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706189; x=1759310989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Lr8fIGw+ra7DxehRDJAgbjkaaSFobuUwVbfza7dpxE=; b=f/AI1ws7In8TENTsJqKSb3DsFOZQAL+UUhrV17EZ3Jziqa/xGd1La/g2l02+fniXIQ S55y4vPc4JHbqhFq613NfEic8pjxhHX7FuuoL64b270wezqRPc/5OzBTbtWX29zJq/ZO gB4Jn92BzOEJQi6zGuvr2dHLgWd6yCNIGe09YFFWKg8Kw9Z7hH0yajYuOb3khHSTNO6x lU24Y4BgahAv+z7r2liHzl3Ud6KeuL3QWKMKBPL/ZCNRedIlXqfGtqY8Y0zugdhhY9/s RW2RLuPygcaaZmgWhvUDms3Gt5mFSDdA66KhrhRb4ywvD3ad1HaZZW2nrqkD8SxZrIiE bVfA== X-Gm-Message-State: AOJu0YzyhxBgszNK4YWr8ROgpHGlhtEX3A/q2YRwOn0Uv/8IZW7Jyq40 8r5ia8JqQLByPwYhFSF4j9C40W8XvgUQ5y+iAuAUF9HMIGwlWZpJyBeqVRAEijawRVnBPCiw7Ra C0VIJmLs2QnqQgr+U8eYExYolGfRTppputbyVc9F5hrc+0i2+8jE43p80jtoMUEKIIXZtjtRS1g wzRWeE51D+fHIA8mtuXF3qFl0q85yW6JM6UutCQAbe X-Gm-Gg: ASbGncuTrU9addeIlpCv3n6hW1/qVrQkQyzCWDq044Jti17Po2rXUnnTWIh//U8+qZX 6ksbw0dbYEwIDFyP7PIsFawlEIctLjhGRYp3c7G/ilsiayaogqyNu/N5Q7WbU52uzOZ9fEeN17v 7z43/ODrlCKZBaLEUc7d+zH4Q+MT/QZ0BZpF02nWI36oPw6F3Kjj58t5YvXIh1XKh4WjGFX3chw Kj8QdUFrlC0qdsXK1/DLNAw07sD/UuN7f9ebjImzYtXBLfqCckCFXcFeodweeJDVeRYzouPUHWj JyUsGS7rxRiL4+JgfRx/BjLGpR6YQVUzkBEdS/oNAzF+1IOA7VjjaYssfSOsADP7A4TH3E8jo+R PiLfa0nmDwBiRcjm05NbTv88l5hxlWrliP5CVp2JdOyZURA== X-Received: by 2002:a17:907:d14:b0:b1d:285d:185d with SMTP id a640c23a62f3a-b3021ca6d78mr537924166b.0.1758706189067; Wed, 24 Sep 2025 02:29:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMQNcYKQvCMZuf1j6Q0h3pUx+56rZgVUcElX3RFudcdOG4EbiU3uNSSjPlf2xO9OUrxqBuwQ== X-Received: by 2002:a17:907:d14:b0:b1d:285d:185d with SMTP id a640c23a62f3a-b3021ca6d78mr537920766b.0.1758706188618; Wed, 24 Sep 2025 02:29:48 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 19/29] linux-user: avoid -Werror=int-in-bool-context Date: Wed, 24 Sep 2025 11:28:39 +0200 Message-ID: <20250924092850.42047-20-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706621176116600 linux-user is failing to compile on Fedora 43: ../linux-user/strace.c:57:66: error: enum constant in boolean context [-Wer= ror=3Dint-in-bool-context] 57 | #define FLAG_BASIC(V, M, N) { V, M | QEMU_BUILD_BUG_ON_ZERO(!(= M)), N } The warning does not seem to be too useful and we could even disable it, but the workaround is simple in this case. Cc: qemu-stable@nongnu.org Cc: Richard Henderson Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Paolo Bonzini --- linux-user/strace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 1233ebceb08..758c5d32b6c 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -54,7 +54,7 @@ struct flags { }; =20 /* No 'struct flags' element should have a zero mask. */ -#define FLAG_BASIC(V, M, N) { V, M | QEMU_BUILD_BUG_ON_ZERO(!(M)), N } +#define FLAG_BASIC(V, M, N) { V, M | QEMU_BUILD_BUG_ON_ZERO((M) =3D= =3D 0), N } =20 /* common flags for all architectures */ #define FLAG_GENERIC_MASK(V, M) FLAG_BASIC(V, M, #V) --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706310; cv=none; d=zohomail.com; s=zohoarc; b=bGu6ZCG9WgXCzXFeYUE8mrkKQ2DkbmqKgQfDhohLUzH9vodONRimu31LpDEpSo3XD4vGfwizc7GgM3SqhV+E9j/NSkSWYLegOGv7pVNNvMsyzPTHfIXltjrBXgbp5P8/0G/ASNSRvXDBJvT1Qrv6ezxyFQQwq8xAUKjIxvCXU7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706310; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I8cEfG6CElNn+HuO5d12EMpl/GXUm1guGpqHc+tS2vE=; b=hBFV2pf41gDJpN7zcpOdrWnkcJMNidachHJRMEr5R4qWSSD1pVokyHC229S3UnVeYi1u7xCvsbP6E199enOuUobVI5PmAwQG/pRvLla36soCnZhCXRwojgxt7KsJME9mDyJqDnVGesvG3FLUYHLNeMsBbRFcT8cX0Ueuste6lBo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706310683346.28125367193286; Wed, 24 Sep 2025 02:31:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Lp9-0005OW-L0; Wed, 24 Sep 2025 05:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp7-0005Nu-D2 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp0-0004qZ-0Y for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:04 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-KRsb8OqoOaOFSpE-DSDJEA-1; Wed, 24 Sep 2025 05:29:54 -0400 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-6345ebdf489so2327362a12.0 for ; Wed, 24 Sep 2025 02:29:54 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63469f30772sm2789490a12.22.2025.09.24.02.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I8cEfG6CElNn+HuO5d12EMpl/GXUm1guGpqHc+tS2vE=; b=dGhEq7vwqz+Qf04vDB7unaj9XFC6W23S6sMicFQc8R+e3Dw+v4sV4189aUTmxIWj20V53e nTtG6wsIb+NtjyrCMy7elU5Q8O42pABqMifff9YlLoppHtQrr+3Odszfre1a6xyzPa+r+s YxwHP2icmDa5Sltwbgo1H415WAff68E= X-MC-Unique: KRsb8OqoOaOFSpE-DSDJEA-1 X-Mimecast-MFC-AGG-ID: KRsb8OqoOaOFSpE-DSDJEA_1758706193 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706192; x=1759310992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I8cEfG6CElNn+HuO5d12EMpl/GXUm1guGpqHc+tS2vE=; b=S1Kk4d7k7H6Eb07oHzB52+YFHF3aLpY6RL6JPx+0lHVZtH6lYmd8s6zddB60JuNsMP O+eARMPC1XitnIVBr+sZBc0//PtFWTg2LR1tyOR2N9X+cJVyzaRWecFRqHNtJry8vUVe qjDCWYiLXtm2w1zjCM+j42y5qowIJ7ilkrw63KTD9X2XotKINP/jlqC/u4PlQQ1i1rX3 +kBG7+tLSYtMRTSdm6672M3jYiRHWkjnrRmXGLm1p9fcoYV7oyk53x/LzIrR4nTakgwV 75FLFJ30DnpVLVEB3iGSwbqnClTdBlpbLxBlhm1iNHZrkuutW76L5wlb/+CMKtzCwECZ E4BA== X-Gm-Message-State: AOJu0YxzO+Rx7ZNeuXUY2FwQUVrbdifXkjp1oNNlsaHjf6ABEMyEMTd4 JjVl7jFlbpOXTmwZcf4P53nD1DB03qZwqFUfb88KmjEGmUXLg1LrNbemJ6TdlsEPNd7kvWDzJpT n5Sp1fpKsb0WxInIttssTPPSZNu4V2OQ9Jn3QVZd3XuQ737Hzbsw1nVwGM5RSOpL211H9k0K+Sh n3EqGFgTcwH/HA1VbXT2D7JhDrRLCuKejWRAxPPVgb X-Gm-Gg: ASbGncsUTNxGeVEFEFmWAPmN+G4u7P8Ix8q12ZDcq9ELVlbsqnPVvPUP9LKrW88iOWJ Go2vVyTjhbBvz8YiXRzaoDRwIavLe+azEJqeLMhIj12Q1Y9b5MkC65E/9bdnVwSkoOgOFqKKMUu AEQurLo8zFeTTZBi1WyZVEzobaOsbgKpdMV42KRPtFy4aVPRdKYZGhUBuwZGy8N5RtuK/UmMmMD 8u4BUUF2jNDdPgKGNggW3a8VH66PTJlvXvMwhiDSyyPqY/1sfcnGkTBIIE4q/tcFKFQsd1oFIq4 emBSEAwd69gg3L1FGIKT6vRHj0T/cujOBr7NqxaOdybuNEOJvmbpb/hUwfikbaXC++VJGiIbpmw Cahy881BDIMhN0Ga8r7OKzkut98KiQJ7YLNWSRhwAHAq9cw== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5033808a12.13.1758706192583; Wed, 24 Sep 2025 02:29:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjVEYltsJo1r+6P6oKmTUcpZaXo+ShhEFNdBI4+yNKm2nKg1uTx1QkX0y7LQR5Kt3m7vec1Q== X-Received: by 2002:a05:6402:5246:b0:62f:26cb:8072 with SMTP id 4fb4d7f45d1cf-634677b5849mr5033733a12.13.1758706191284; Wed, 24 Sep 2025 02:29:51 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 20/29] docs/devel: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:40 +0200 Message-ID: <20250924092850.42047-21-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706312143116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Remove the instruction to call object_unparent(), and the exception of the "do not call object_unparent()" rule for instance_finalize(). Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-1-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- docs/devel/memory.rst | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/docs/devel/memory.rst b/docs/devel/memory.rst index 42d3ca29c43..f22146e56ce 100644 --- a/docs/devel/memory.rst +++ b/docs/devel/memory.rst @@ -165,17 +165,14 @@ and finalized one by one. The order in which memory = regions will be finalized is not guaranteed. =20 If however the memory region is part of a dynamically allocated data -structure, you should call object_unparent() to destroy the memory region -before the data structure is freed. For an example see VFIOMSIXInfo -and VFIOQuirk in hw/vfio/pci.c. +structure, you should free the memory region in the instance_finalize +callback. For an example see VFIOMSIXInfo and VFIOQuirk in +hw/vfio/pci.c. =20 You must not destroy a memory region as long as it may be in use by a device or CPU. In order to do this, as a general rule do not create or -destroy memory regions dynamically during a device's lifetime, and only -call object_unparent() in the memory region owner's instance_finalize -callback. The dynamically allocated data structure that contains the -memory region then should obviously be freed in the instance_finalize -callback as well. +destroy memory regions dynamically during a device's lifetime, and never +call object_unparent(). =20 If you break this rule, the following situation can happen: =20 @@ -201,9 +198,7 @@ this exception is rarely necessary, and therefore it is= discouraged, but nevertheless it is used in a few places. =20 For regions that "have no owner" (NULL is passed at creation time), the -machine object is actually used as the owner. Since instance_finalize is -never called for the machine object, you must never call object_unparent -on regions that have no owner, unless they are aliases or containers. +machine object is actually used as the owner. =20 =20 Overlapping regions and priority --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706324; cv=none; d=zohomail.com; s=zohoarc; b=AWLdOs1nWtZtrlEvGNo80Qoe5/xrxEjBRCN3PQl8puUACAB0Vw95POnPBIDXouDKnNN3KyK832Hjj2cwRMv8Hqu583n9nY1jghjk74fIhYZkHmXD15I3A+cXnZRNIRxtGd/FPNYKzb0u02W8iW1IMCsLLMUoEQ3kV62sSVYNUb4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706324; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y/XW/L14MoMb/+kv4FvaAffCMOO2k+fD1qoCEwPIK8o=; b=mSyLSMW/gQjdSZP9rmXZ9hOKfxLR6hJUL8ngi4509bNGYxx+6y2sgSKYIApaBs6Nv0r0WqP8+h85v5lhlJfI3RXhlHMjIlCmihW8RpkYeQ5dkqTuNjzX3OyqrlofUicfDmfFX0q9PI3MyxvoZbg5TSxRL+uVPxH9pE6+/YwO0XE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706324907763.9495947359658; Wed, 24 Sep 2025 02:32:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LpB-0005P6-G7; Wed, 24 Sep 2025 05:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpA-0005Op-0G for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp4-0004qn-A9 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:07 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-55Ts5bbpOO2AO5uRU4fJAA-1; Wed, 24 Sep 2025 05:29:55 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b04a302fb7cso591013166b.3 for ; Wed, 24 Sep 2025 02:29:55 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a660738dcsm842067166b.84.2025.09.24.02.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y/XW/L14MoMb/+kv4FvaAffCMOO2k+fD1qoCEwPIK8o=; b=XpqBW5+nLwIWEnKctTtxiFhzrPPFjgX9IrslpvuRve2CVqoI2VSzOhoPs3/yMBBMJzZmN7 DrnWEz0Ixh90NuYkLVGmAEUOxAq359m9eKQiz8rLiejgtuVRSG1mSoSbTuA6ZAnLiEpN7S 7gzZfJL/20uSDp4xJ4mXzSbyfhDJSt8= X-MC-Unique: 55Ts5bbpOO2AO5uRU4fJAA-1 X-Mimecast-MFC-AGG-ID: 55Ts5bbpOO2AO5uRU4fJAA_1758706195 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706194; x=1759310994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y/XW/L14MoMb/+kv4FvaAffCMOO2k+fD1qoCEwPIK8o=; b=X9WeE+asxCacvjRRG6Y+U+DAhHik2kgDa7P7Uh5kPWB2fY5l69naQYNtFF3GsZqO/r mYzS9N3E0XZMoWPA7523FH+6OYHIir5wgtqVzJnp/xOxRxsewl7EcLX3Q28VRyM43lR5 uGAVCbs+XJiycn8jtyMUL2TVf7koRGktZjP+JxUjwyezLQQ7MQTt9fE+dMzraKdX2Nib fZMEQt0qLCYh8o8rJ4+c6fOOgccX0MKo/lkcDt459Id+rbZLu64m1O/Pu+/++ush9aFR MxKqGOBdpSwPMx4g9mJ9c+W8tRQWN9KKxDQp8Q7ESWzGFjZyQ4vNeKoqvfnnyW2nN8xM 2vww== X-Gm-Message-State: AOJu0YxgnpAK7/MshW6KQKQLOTDjFRtvXpF/fTGFYdE15PWr6QcYPRrY Qd8DDjez2ZLrz7qx96azAjLCcGFDzvW5FZWMtx7ucVw7gzEAcFAExAYyL8ajMZnjwsKEeIrW40D WU7nOeyRmVeE9A3h/25i0ZnAFJZpCDgYDitERroK+WSjS6FSuv6R7h665pq+fm8FBdYTkbf+9zd Qz6+PoPVBPwjg2ZNa59inc1oFbiaQQGSEoKljDqfgO X-Gm-Gg: ASbGncs3kGnSubtOzAzuHCG+aWRbtzxTrESqqtjVj7d7gNY+WmC9MqP3Ccz0mkhSigm D5RQEea/FvhpQzPwoLOMs0XMzbcTSm8dkbROEkuaeA47eONLwO7XvcaiJvfHH0QFa3OEyjmTGOV n2yhwi0QqkmWDWfvHBIGxws0L1yv9pZ/lFXdLm1abChC1vUixu/fRTVT2gJsI7m1tocjK79OAsU lxciTJ0HED0dvgootYQzpcZXoXyDJuW7Kn88foMDXdJ62Xi75yOOjab3wdDDm7jhXKTa/Cl4dxj 5SjH2sEOp9zm28184Ezgc4os25HI/53cbY1mTjaglQrc/VohmYr5yvoBHPNhPS/8ISSIZz5FxPO LpgSxRjXWlWVrYUpOdAzHPZH4lJ31NWQwN5KlY89mLmG/tA== X-Received: by 2002:a17:907:2684:b0:b2d:e514:5348 with SMTP id a640c23a62f3a-b302af25c48mr612513266b.33.1758706193756; Wed, 24 Sep 2025 02:29:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsr/n0FH4WBt5zip9OnDytlsECvMZdytAy4u8yZUMAQ75jFafqmkuG1D1zLAJUSmTSuMAztw== X-Received: by 2002:a17:907:2684:b0:b2d:e514:5348 with SMTP id a640c23a62f3a-b302af25c48mr612510666b.33.1758706193208; Wed, 24 Sep 2025 02:29:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 21/29] vfio/pci: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:41 +0200 Message-ID: <20250924092850.42047-22-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706326224116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the insntance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-2-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/vfio/pci.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d14e96b2f82..bc0b4c4d562 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2025,7 +2025,6 @@ static void vfio_bars_finalize(VFIOPCIDevice *vdev) vfio_region_finalize(&bar->region); if (bar->mr) { assert(bar->size); - object_unparent(OBJECT(bar->mr)); g_free(bar->mr); bar->mr =3D NULL; } @@ -2033,9 +2032,6 @@ static void vfio_bars_finalize(VFIOPCIDevice *vdev) =20 if (vdev->vga) { vfio_vga_quirk_finalize(vdev); - for (i =3D 0; i < ARRAY_SIZE(vdev->vga->region); i++) { - object_unparent(OBJECT(&vdev->vga->region[i].mem)); - } g_free(vdev->vga); } } --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706492; cv=none; d=zohomail.com; s=zohoarc; b=ebhFIj/9DJrvBNqgnfXQgpbz3H+lWV/6lbEsd/mfYBlsg6C6UP4VuZh4ZbQIpd8X84w0889Aq0MxYYy34LF7iYbpYKgSqLiW7ltfGLg1w+9BVi4cXry0IDdTHNm08OnNqRAF4FPzkNRpfyDxzlMuxJ4DPBZG+YqOwNgik0pJ71s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706492; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NEIu1N4KnJLuolNTYTrmzVOdvxoxWz6ae7kAlH7RbdY=; b=IqZMnpUIa7x0jyP/zuwhTHbxngvOc3Ef27Xa+7/mTrnx+eca8wK5xjBLmKVd961bZX+RKSDkhZ5G98BqyEuoALjI8FIEckUtDJJiKwzj1VFwIEfzOW48PfIXE1lilqjDI1tJ1Zidtzzv1IOuUbyKdzs8opHJ9UrjYyNYEK/NGII= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706492170893.7424738121779; Wed, 24 Sep 2025 02:34:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LpL-0005hC-ST; Wed, 24 Sep 2025 05:30:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpE-0005ZI-7O for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp6-0004rA-9x for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:10 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-w4X_InbgO2Gt3Bh2Ej4iow-1; Wed, 24 Sep 2025 05:29:59 -0400 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-b04a302fb7cso591017066b.3 for ; Wed, 24 Sep 2025 02:29:58 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a2a5f6c94sm833205366b.13.2025.09.24.02.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NEIu1N4KnJLuolNTYTrmzVOdvxoxWz6ae7kAlH7RbdY=; b=QH3XxHGkKwWxsx4w+GCAWVaOhPwMTHGUR5doTv3UbdmtwdDAQMmWNOcVVmBRPKD16bFTZK N/a6j6QxjcXejZ5AgiFUWduTcIetWr8vMUT/U0aXfApLcyPQ1TdRUFCiIrqimSh+a8bxEu 9K9pTv83WsGYmCEwA4Au4V0qV5lpJ2s= X-MC-Unique: w4X_InbgO2Gt3Bh2Ej4iow-1 X-Mimecast-MFC-AGG-ID: w4X_InbgO2Gt3Bh2Ej4iow_1758706198 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706197; x=1759310997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEIu1N4KnJLuolNTYTrmzVOdvxoxWz6ae7kAlH7RbdY=; b=dqX5Kk6Wh01dDgOVrUVRWw6P6Gw0wt+cyUzEi5nAae6LSCrPZwBKRhvxLD2Wag8xn1 OzmClHNunEyL3ZyiFlMkGHrxJ+qL/rep54jEIMOUfJySGyOoDdDlJcT1ciI1ZMzcO7Fm VPGe79gu4+yhTB7DF6r+JOplaNPYCpKOGSujGlzHMwxFuSbCn98QQSgdZgUeMr0RcCLC 1CMLeyrNQPDw7+cjtHCNb9csGsK6UC0fBbNP1oTQsa25PAo8eQD/0P3DxO2WHif4q9nn e+NTTVu/cMYyWp9kLuc/qFpcrj9a5Wq8WDuNYLjudGqaf64JZn4vOuqCYZ1qgAVy7uCu i+tQ== X-Gm-Message-State: AOJu0Yy/eoJPAHeNeIkIB/ZSVjQDOJdWZWoY+M4zs1qvybutkluxm2Dx FPtyWENHBBMPushYWwFvlTIEtoNCzNKaOo6LSGIyky4EIQaUOZGYDSv8ybWtFIbZbWO2GslIEYD /ocvJKYmgAiS9h/INJJmsKU9NJhOcqWtzIHjV3AfCOVtFCmsW+gWx1TZpedT9kgWmlvDcsAH7zS A4rZo2g7vmMsI3m84MYxDS1leLpyENDxNGVjZEcssv X-Gm-Gg: ASbGnctE6Oozi4fp5Ekb/StjiIXGOwbz1ggjU5q5Bug4No2EDB8fLEZdm267xwYs6KC 30y+pbV9LSAXyLDvljkrOlSMxyWhGCg8J9R6n8UDPZP1Nb0wn8nSEizn02JpwKYQ1EnTzbHri/Q Gd8tVPXNuSEFEoGNxCQ2TGQck119A7HCT6jbC0aty2zxAQ9X4k67RSuoVptHXTqvQesWzocwy7Y qLEIzoq4IRqn6AZAfcUNQyyCSjeCa9ZcwCbAUX2vangivJP6/6LaOTCeb288xkoQZYLuTxzbBpx P6ejagiVK031ueHV0FoezIPWch7QQdV+JH5qZ6W4sUBJBH9/Xv5K00ieS5HxWpDhO4f5qEC9n7M fFU+yJLhvldPWqQS0xJiieHhlAM32foIioetP8fVLWzzeaQ== X-Received: by 2002:a17:907:6d0b:b0:b04:806b:c612 with SMTP id a640c23a62f3a-b3026c84e17mr593311466b.10.1758706196848; Wed, 24 Sep 2025 02:29:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsXdHFGSH4xJGFwB5B3XpkCOKRY6g7Q0fiyeoi5GrYk4wCs84w4wrUIYxFH4736GandEGRdA== X-Received: by 2002:a17:907:6d0b:b0:b04:806b:c612 with SMTP id a640c23a62f3a-b3026c84e17mr593308666b.10.1758706196328; Wed, 24 Sep 2025 02:29:56 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 22/29] hw/core/register: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:42 +0200 Message-ID: <20250924092850.42047-23-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706494359116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-3-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/core/register.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/register.c b/hw/core/register.c index 8f63d9f227c..3340df70b06 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -314,7 +314,6 @@ RegisterInfoArray *register_init_block64(DeviceState *o= wner, =20 void register_finalize_block(RegisterInfoArray *r_array) { - object_unparent(OBJECT(&r_array->mem)); g_free(r_array->r); g_free(r_array); } --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706349; cv=none; d=zohomail.com; s=zohoarc; b=ROCpE4/c5y8Uodqt0lXA2ed1Klo9Npcp0GlRAYMOAGG2lPcYhUErLkydbe73y/Hd1gWJVPt3mP1LGIWqcFE64OQVwaVknmlG5eS3tlh2pN+FVTEX02Ks/kgPBNCE9ZtBBuDnzvwwO3NUH2Ot1CjfmA/f0dhV6iMe2VsOuu+sl/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706349; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qs8pcMa93ewjzBHLMnxD/fqYcxndHhw9EpDQZaSEytE=; b=OrhpHBXm1u6QEN6UpCWGZkKk1JbKys+uUbzaeKF/zj6TmARb03HrlVLuoux+XO0dpjRisVHmtd/FK9T2NmUOpCGxZOzhtsblSdPFEH2UyhRbletlAmkjS3Q1JdsHWXVxqaXe28JiohQumX37y6oAPDMsLuiznF14tDLAX3ZPgd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706349716379.3745703799947; Wed, 24 Sep 2025 02:32:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LpC-0005TK-IS; Wed, 24 Sep 2025 05:30:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpB-0005P5-7D for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Lp7-0004sc-1H for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:08 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-CIjnR_dSOSSXO7yt0SsSMw-1; Wed, 24 Sep 2025 05:30:01 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-afcb7338319so824403266b.0 for ; Wed, 24 Sep 2025 02:30:01 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2a88413acbsm799483666b.24.2025.09.24.02.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qs8pcMa93ewjzBHLMnxD/fqYcxndHhw9EpDQZaSEytE=; b=QrIjnmaMwlq9V8ROgt5TmaUHTieBmpTd8245hIy0bQuZDTvSGmLgwcQmPsg5dnXtzjsaUr YRI3EJX9E6B9nciTOPTD0I93CyRBMB5Nqr9RXG9bgjRkRljohuomHZTNuC3FoiptWDasCL WaFJyIRLbNYUeVccRPZj1FyMV5qJwl0= X-MC-Unique: CIjnR_dSOSSXO7yt0SsSMw-1 X-Mimecast-MFC-AGG-ID: CIjnR_dSOSSXO7yt0SsSMw_1758706201 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706200; x=1759311000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qs8pcMa93ewjzBHLMnxD/fqYcxndHhw9EpDQZaSEytE=; b=p/ozXfA09mSIQuMNy4n9W36dnS+a9c/YxXJ51IbF2M98noZlHBd+vKYvb+lOF5Vapa DWZMHoajsVjqBOpH7EgxGrLX42aRVtyGhjVLG5vUt8JqABomo1x3yrDrqBLfNNe2KNha Dfy7wDtq597Zqy5vT4UkxB4ns4HAyW1Qh8HjF45f3BV1R2BgjJ/ZhXQGFbY8KL9IKQTe eskK/AtK0UEPCUrQ5SwRbfbeoEssJcRlvzzPSb3TSPXusL06lWkAzJDHk05DShY1m9Lx XykpvHY1kF2fd52o4vz+noL9nam4Pvg/miZpqzpnsgPM6mjP+pqxXNUvM5xl17qxXdkq tlPA== X-Gm-Message-State: AOJu0Yz/Zfb+7CwrB6eAmsUCOYFfNh2mzZBzEgILoYqo82W3RwI+r6+a TD54+z4a9Q9NPLhgoRWFYvxGiWGtlZBEeGFYukwcP+hwFzhuPpNoLcX0wcbC2y87TXy2IJ60F3I TPE8uDHYd+eoMeePRfrCgV0XHtu3S4bEmoLnmTpTdXC4JnrAzxEa2dq0wuUrtsTj4lyP5MqJvTP jjhWGhPCniZ13+G9svZUEbkoLYagxXGQZDWhFCgrky X-Gm-Gg: ASbGncuE37fHF/84Yeh7GGtotz02St50aebRhkXv/XybLQ+aik3Ur65H6gejFTF8jBZ IaNKASBYdO+Kzjuf9/EnnpbFFf1ICL2U8kKJqnSu6KF5kHk64M2NVszgeGtL914RsqezVV6nL7O UFl8k1sZnLsZxwbrRJZGM7X5FAErSOPgSPzQLeMLSgZm7dNaI8z8arwxf1lXueUAsxU9ERts5T+ cQgWOkaphL5DElTW5eRLvD1blBne7tpLuHkOdP5wmrGwRmdrodan+ADmtSYdeoYgADj2RvrsbvC 82/2I2OsAow2Zlb/Y8dDyITXmiZh6t8HrIdFweUcVVMglLvg2fVOaaRxGwK7GFXZysEZPq4QbQC VyXB/Vlfy9SAgX2WL8lVqntP+JaZLSpPHebewSufuefD3Cg== X-Received: by 2002:a17:907:9618:b0:b0d:d831:6fba with SMTP id a640c23a62f3a-b302b51c6f9mr542193966b.59.1758706199487; Wed, 24 Sep 2025 02:29:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkQEu1SiVnwN0oEFQ5TqX4SLQjWfPo6UBQ/0pGEwP2uHs8CLhU6Ia0cESfSjlFuYUaH0tkww== X-Received: by 2002:a17:907:9618:b0:b0d:d831:6fba with SMTP id a640c23a62f3a-b302b51c6f9mr542191466b.59.1758706199045; Wed, 24 Sep 2025 02:29:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 23/29] hv-balloon: hw/core/register: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:43 +0200 Message-ID: <20250924092850.42047-24-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706350459116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-4-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/hyperv/hv-balloon.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/hyperv/hv-balloon.c b/hw/hyperv/hv-balloon.c index 6dbcb2d9a29..2d6d7db4ee0 100644 --- a/hw/hyperv/hv-balloon.c +++ b/hw/hyperv/hv-balloon.c @@ -1475,16 +1475,6 @@ static void hv_balloon_ensure_mr(HvBalloon *balloon) balloon->mr->align =3D memory_region_get_alignment(hostmem_mr); } =20 -static void hv_balloon_free_mr(HvBalloon *balloon) -{ - if (!balloon->mr) { - return; - } - - object_unparent(OBJECT(balloon->mr)); - g_clear_pointer(&balloon->mr, g_free); -} - static void hv_balloon_vmdev_realize(VMBusDevice *vdev, Error **errp) { ERRP_GUARD(); @@ -1580,7 +1570,7 @@ static void hv_balloon_vmdev_reset(VMBusDevice *vdev) */ static void hv_balloon_unrealize_finalize_common(HvBalloon *balloon) { - hv_balloon_free_mr(balloon); + g_clear_pointer(&balloon->mr, g_free); balloon->addr =3D 0; =20 balloon->memslot_count =3D 0; --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706345; cv=none; d=zohomail.com; s=zohoarc; b=eCfTpVIgZ2jj/R4by0orW4n26S/U3HryX9pngx17BSlKcYLzPTNnWtjg7loYw2yPoNL2wxTu7GTXx1hhn1SdXojBP4Vdx417jmJpTyAnaU/9/UDem7WV5cpr9MCyv321qVkvZxvP03tVPDSb51Z4X+lHOjBAKl3NWQJTK5qKKXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706345; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eLACulWrroEz1Bbdqp6RPLMUguLtq4kl6Dbini6ddkA=; b=T5ieFKXxjWVINksD4lpKXdig/eFP00VBnNS1U5tsLdHrIrHqW8f58zwnhAMFo+qDmbSBqj07xC2mrOllLLtaDlo+WLoUPFfaVa6q3kWHipLroTVlOSUk3vIBucGyrl/gaqjqse4k0G4AGVnkAKBUUacVr694j/xelh2p2wHWL7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175870634566133.25167721887817; Wed, 24 Sep 2025 02:32:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqC-0006Nx-LT; Wed, 24 Sep 2025 05:31:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpF-0005ZS-UU for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpA-00052q-FD for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:13 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-dcs-b-mvP_uoHJegIq6PuA-1; Wed, 24 Sep 2025 05:30:04 -0400 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-6341958f08fso2797916a12.0 for ; Wed, 24 Sep 2025 02:30:03 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2eca89e388sm448896866b.106.2025.09.24.02.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eLACulWrroEz1Bbdqp6RPLMUguLtq4kl6Dbini6ddkA=; b=LznutvwVD8tyYHamiHBJx9EpntMz2HkStYWJzSwVOcJs3Vd7YPkqqOqMNWB3p6noZqTSsR 1xivDzBDxK1TZIkSPcbAXfTMaPcuncIzWqNlv0PF9DQCAXxub2Y0V0zGPxMow6ZjDr6g/E zTzck2Rvf+CihvuqoQR5Ao62wrlzTes= X-MC-Unique: dcs-b-mvP_uoHJegIq6PuA-1 X-Mimecast-MFC-AGG-ID: dcs-b-mvP_uoHJegIq6PuA_1758706203 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706202; x=1759311002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLACulWrroEz1Bbdqp6RPLMUguLtq4kl6Dbini6ddkA=; b=Oe6vwNQ3nDvMz5XBpDqGT8ykdg6dNCFdvBhnBzUgt0T/CVhp/aeY+PC6nrxGFa11tt heKXRKAw95lJ7Q5HqyK1IX7qNiHFZ4CI/URCAkVl/DHpnlc0mEdncX+EEdoTy/r0zd6v 2tmDoDx0xj8tAYV/LozbWEtrp84H5QGr2LnXrARY5htQfYH+WPpLDihVDO/aXmZqInuY UawfcH/tuZY6zUTCjuRUMIAs3UT1ImLURDNrlw62pTD0HQH2MiLbc5evdEzEaQY22UCh MuDaAsiOifml6ScEao/XT2q2MtSGpl6/MZpQ2Sv2jzJUBIabOfRKk2BV7nvtbAPUiAoJ id+A== X-Gm-Message-State: AOJu0Yxqrsv5PSbQxmHBrxj5dCBluLFK3XYNbXIveytJYaJihIRD+QWt aRA1H0oaCxvZ+e8+y9tm+Z84patb9GaZdcHu5HVigpsaGk7UUqzlaegw1WCwbD4lktYey0dEvbW JC1JmEIJtLRn/Enx3qBYL4C6s6+gxvENaFJQne0lymyVsYF8AABSoJjSX5d0/cGKNfkhJXypfeq bVsrJCxGsFZrWQMSP8Gq58uhNl6qHf8BEW22+qk+yX X-Gm-Gg: ASbGnct1p6ft6kDbJXFvKqI+aV8CuV5LKnpBZ3M56HROw4JC5N2KZdLOS/MKRBlGp/Y Z5Z+P2WHCWdSSwKoKBc1Yu0xZ/u+69F1aB0NA0bfuEoO3lHOx9NRpa+NNtdjxz+RF0nNQuCZFIU qRy9+2+7Glrx0yuMVO0SoqY/wtr94sOKvKZlB3J/5I7TUdGLZ3XhDFsWYa+LeO3rH7P9ydDN8Mx RhI/c1BCIHr5YAVu/FiRGulYJ8ACvic/W1piQj5v8qjp3gvdz079leRw5Ch1KXaciXWcmbbJtMO 9nUsWR0zwOxkq0YsuKQyPincdbsJ/h9zXhVusy8eWcpreV+J225WUnM73rn3IOx5sxXjk5U7ge0 kHoe284b2h7gQNDgnPTDSAfmsNZeADQ6IN1i6p2fqM//QRQ== X-Received: by 2002:a17:907:72d5:b0:b0c:1701:bf77 with SMTP id a640c23a62f3a-b3026d7dd1cmr559222766b.18.1758706202341; Wed, 24 Sep 2025 02:30:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEAAMN4AaOH70eogHBanRceM2xgIddenJo6xIRhEGt4zCuk3kTL1oZd7KH3VOgis/UXn6CgTA== X-Received: by 2002:a17:907:72d5:b0:b0c:1701:bf77 with SMTP id a640c23a62f3a-b3026d7dd1cmr559218866b.18.1758706201824; Wed, 24 Sep 2025 02:30:01 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 24/29] hw/sd/sdhci: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:44 +0200 Message-ID: <20250924092850.42047-25-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706346460116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-5-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/sd/sdhci.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 3c897e54b72..89b595ce4a5 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1578,10 +1578,6 @@ static void sdhci_sysbus_finalize(Object *obj) { SDHCIState *s =3D SYSBUS_SDHCI(obj); =20 - if (s->dma_mr) { - object_unparent(OBJECT(s->dma_mr)); - } - sdhci_uninitfn(s); } =20 --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706399; cv=none; d=zohomail.com; s=zohoarc; b=M7gn5HtcHJhVHjHK6uHD638cDyv7mZC5cXZi6CWEz7Azb3V4+hY4FZRjUtyJpjr11odnwuWpXe/NFs3zfipJ6yWzI8srwx5JV34bsd2MO1+B+eiaRJufvu7eZxd083Yv3UK4dtvhwXBxUlqK123e7JQflZ9y2zAw5m4Pn7NGrSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706399; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H+LXSYu1vPoTI2M5Dk2GrlTJk3l5n1j7O+7TuG4JzCk=; b=bjfZTVUzpT++1m0P9W4ICBPx0IcpLyYiU2oLthFWEak24puxsGw4gFv0CEjGRnoYXbAYSVftTtiC2bw6pDNAkGC8iPp1qEIdPlBC9XGjRO1/LcLKZtkQ61cypgbEwC4miF7kveSNE2Fpp+0SMZyLMSb8jYEcG40e1MP5VvUIcZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706399778830.067235364687; Wed, 24 Sep 2025 02:33:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqS-00072n-EY; Wed, 24 Sep 2025 05:31:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpN-0005py-Av for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpI-00054S-5S for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:21 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-tZNW-OJpPwao-feVLyTeWQ-1; Wed, 24 Sep 2025 05:30:07 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b335ec149a8so34534966b.1 for ; Wed, 24 Sep 2025 02:30:07 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b33411470b8sm72632866b.98.2025.09.24.02.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+LXSYu1vPoTI2M5Dk2GrlTJk3l5n1j7O+7TuG4JzCk=; b=So404Bu8HyRWOWaTM4AfR29wHe3rZD9RhXiBAdT1rT+32c8HRIupa34BKpNLiaM7Kc+VlN YlqN8wh2zynk/6NR9KsoiG+I432uBmSEmHWtjjNH74b+RnAUv95Wz1DmCEoS6VoktXsHsL TIiLYnrVhSNKjEXUX1RUUVrS5DfcKgY= X-MC-Unique: tZNW-OJpPwao-feVLyTeWQ-1 X-Mimecast-MFC-AGG-ID: tZNW-OJpPwao-feVLyTeWQ_1758706206 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706205; x=1759311005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+LXSYu1vPoTI2M5Dk2GrlTJk3l5n1j7O+7TuG4JzCk=; b=JhAoiFcyA40DXaz8JsePegybxmqcxqqAtarRSWz6cCno/m7gc8QpWLWpHu3OxZjdwf YuMKi403a8nYSELSzCW7NHbcxTMxH3ESCPibjopskhP58ZaMRH+mBLd6tOahk/MyyohN uJSGinBtK5rJaJl3qKu6Gsnn7djLMkzSajPBecwvheOp73dTywdN6ON0XtgaB54UsY8t dl+F534naprK+kthW3So2YdqZ9flgn8m5J4lzH0B4H+XwZlmFi+rYHrMhzuESSIwMOtr pYJjO4TYDwkC90wt79qbpU/l2CBW8XT+KZHeBRI033Rkoyx6Fd734y14/+3myHMg+FlE /q4A== X-Gm-Message-State: AOJu0YzlC6Drb1LAbesIo5VNLogyChuc3PPGoSQdsLdCGxKfJXiEQiP0 M/ud+9MZ4VDkvG308HNlo01ArzzGzdDEh/vS7VvAdNn+mI0gERoVp+yo1m1XfrHA0RFsOlYyFHj 80SjCHoMUQ01Qr3wtCSuSVRNIK8YT2i46Ex9rQr5n4SRP+r0ql4o7cPPsaAw3rPawCD3nUBSUfA P4SbonkgbMOzAsv+2XlX5RCCXrPBwEtz1USTgL/ybM X-Gm-Gg: ASbGncuTY8qfwLZ5hAI/m2T7xHfpQuG6qReJn5rAF+nxyHgxOVfPjY8ikw1/giqhdBT A6bbZV2WSI+dbRa7x9tBtru9TIQT+IptpclvhtGf8WncFbMTru7cYMZD5zviMP2uFlrWne2QS0q 3/52Ly3mwZGoAjRyXsyGPBrapkeb0bbIF8827KhOT6D1ublYbBXxk+lliyIpx27x9FrmbQfT0Dc fTfEZ8otZSqKrTPA32lwHXkbWnSgOYha0eWNJ6gxoLAeJV2Y+XpViLx9/LVpk0aNAnFfQOxKa04 GD5rwIyl0s2wi1iGKq08Abi3g6IlbFkns7eAAk5Jtj544p3MTyCB2Sdgdc+95d6S/Ozt1GqBDv/ TQlTEVzY4NNLhmtAcsb8MXRv1QrkPqKodsvXbRcWDM7jeeg== X-Received: by 2002:a17:907:7e88:b0:b2c:fa41:c1cb with SMTP id a640c23a62f3a-b302ac2b4f4mr597049966b.31.1758706204977; Wed, 24 Sep 2025 02:30:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHw7yBCZpQ53lyypzzXWv658CtjB+C2D8W+j4togBI1SVOu5bWjyvlytsaYT0c3vkDdhFOaBQ== X-Received: by 2002:a17:907:7e88:b0:b2c:fa41:c1cb with SMTP id a640c23a62f3a-b302ac2b4f4mr597042566b.31.1758706203688; Wed, 24 Sep 2025 02:30:03 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 25/29] vfio: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:45 +0200 Message-ID: <20250924092850.42047-26-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706400851116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-6-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/vfio/pci-quirks.c | 9 +-------- hw/vfio/region.c | 3 --- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index c97606dbf19..b5da6afbf5b 100644 --- a/hw/vfio/pci-quirks.c +++ b/hw/vfio/pci-quirks.c @@ -1159,15 +1159,12 @@ void vfio_vga_quirk_exit(VFIOPCIDevice *vdev) =20 void vfio_vga_quirk_finalize(VFIOPCIDevice *vdev) { - int i, j; + int i; =20 for (i =3D 0; i < ARRAY_SIZE(vdev->vga->region); i++) { while (!QLIST_EMPTY(&vdev->vga->region[i].quirks)) { VFIOQuirk *quirk =3D QLIST_FIRST(&vdev->vga->region[i].quirks); QLIST_REMOVE(quirk, next); - for (j =3D 0; j < quirk->nr_mem; j++) { - object_unparent(OBJECT(&quirk->mem[j])); - } g_free(quirk->mem); g_free(quirk->data); g_free(quirk); @@ -1207,14 +1204,10 @@ void vfio_bar_quirk_exit(VFIOPCIDevice *vdev, int n= r) void vfio_bar_quirk_finalize(VFIOPCIDevice *vdev, int nr) { VFIOBAR *bar =3D &vdev->bars[nr]; - int i; =20 while (!QLIST_EMPTY(&bar->quirks)) { VFIOQuirk *quirk =3D QLIST_FIRST(&bar->quirks); QLIST_REMOVE(quirk, next); - for (i =3D 0; i < quirk->nr_mem; i++) { - object_unparent(OBJECT(&quirk->mem[i])); - } g_free(quirk->mem); g_free(quirk->data); g_free(quirk); diff --git a/hw/vfio/region.c b/hw/vfio/region.c index d04c57db630..b165ab0b937 100644 --- a/hw/vfio/region.c +++ b/hw/vfio/region.c @@ -365,12 +365,9 @@ void vfio_region_finalize(VFIORegion *region) for (i =3D 0; i < region->nr_mmaps; i++) { if (region->mmaps[i].mmap) { munmap(region->mmaps[i].mmap, region->mmaps[i].size); - object_unparent(OBJECT(®ion->mmaps[i].mem)); } } =20 - object_unparent(OBJECT(region->mem)); - g_free(region->mem); g_free(region->mmaps); =20 --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706395; cv=none; d=zohomail.com; s=zohoarc; b=FY6p9IsK9nsM+vzKsVy26uZ/kBe0tZPPr1MppRIN7Q+0Y9LYjUrmommy59Dsqw8txEfwI2oSs4qMOR6QHRbur0mbL4MhR67VawVt1NrQRWtoz5yeaM0RWK3Jkl6ptqLMQpm9j0HqeS8Btzy9RdEV9KrrR2iEAiQx2o0B7ruv134= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706395; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lfUywyyQC7TDO8J0Ge3oQBTlQoIjAPXNPeMkAMHIjcI=; b=I38tlaFX0Datce7GKkdKNOOrg3PWfJ8M+pAmXLWK5WFB07zwJVJtpGCWKS/Oa5R7F+W/X+/NLRArLYFf4geRvKX1BkhOwkDR29Y0kvc/rEgBBok+dBcFQ4+KU5Mu6TQdN7MJfXIaNm/uqregaMqMAfu3LLg6/11uQ31kmq+1gpM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175870639577726.506926087818442; Wed, 24 Sep 2025 02:33:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqJ-0006Y9-2T; Wed, 24 Sep 2025 05:31:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpP-0005t7-B1 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpK-00055O-N9 for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:22 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-xU0Vth7rM3WXELJqcDuw6g-1; Wed, 24 Sep 2025 05:30:13 -0400 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-634741fccc9so1067860a12.2 for ; Wed, 24 Sep 2025 02:30:13 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2e33da6226sm513053166b.110.2025.09.24.02.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfUywyyQC7TDO8J0Ge3oQBTlQoIjAPXNPeMkAMHIjcI=; b=KVSXPK06Mnkv1ZOk6LPJpIkV1cAuIwYeJBysJ1lJPrGrVO+Y6xoYAoCW6RGJJOCABrJA1E Go7ez7Ic3eRlNkhqUQpG9uGj6Av1P2hzExUOSxlWSJT+6mOi1G9ApFmvlDIXIvjSfktXYK ad/3djUZgipJp8U3cCgcVk70li/m4OA= X-MC-Unique: xU0Vth7rM3WXELJqcDuw6g-1 X-Mimecast-MFC-AGG-ID: xU0Vth7rM3WXELJqcDuw6g_1758706212 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706210; x=1759311010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lfUywyyQC7TDO8J0Ge3oQBTlQoIjAPXNPeMkAMHIjcI=; b=VKSIHA40oLwgvAbNgLq0gkkYozod6ki6HZi49wPeWOHzZLS0+9VZXVMSTpDpiMW4yw Z+oBC7HR8feD6A3XpCmyhdMWa0k0PckpVLqocA4W63KMrqVdShda7z2+r7xX+jk5Ep72 9+zBmyX0yHYHkQqMQu3DFbV3Xi64YJJ1Q+wHxanY2qMm27gPoWXtrqvC0gnft6QhRz2K YBisindncCgoi4y6M8gnOfbAjzPxX411GZ5P+nOKUuHCqI8XFiaWq+iJO8X3qKAaI/8E PqFoTqWKs5hTzRRqbC/NyZYnxw56qMZM3hED7giZeCVimHgJ287AvJ1iYORYeJpfecTr FiyA== X-Gm-Message-State: AOJu0YxJWBS1Vz/hHhNcDsSN59EWDO3Ixl5TLmEdfyJwz8otGb0PjdkM fsatd0krjFFlWy9UGyaIzwZdj1VrWDtmSZnv2C4ahdNX87774Is7VYDHUzaCBBsFrhKMcnydBIx 5lOEVmAjAQfpqIrbSyzzr8AXqcgolZFU+2U4YSKzd0gPZG6N/tATh0Zc98knQVpKShP9+M9c44W tCA0OyihMa/0qAcjGuNGE559PWxQdufm4mvSs3LL3O X-Gm-Gg: ASbGncuG1rUaOb0764GhH40sdVfQH5m75llSO0BLnbpzGmSTr+dT80vdgzmvsZQHdGs kXTXRSWQiY3LmQL1qfn1/IQplQThJUjBLxpLc7DaBTWWu+deb/W+5k/dxj2LgnqCu4M9EnpG4ze BZuOTU86FWcEQ/bHZlcUSIxDC7uDi2LTmO78OWJ3CB33AKJmf/fpkbxvh3VuKb2qu9zmpEjs7Tm jv4QLnQTRQOJCuN/HrIY0YC+od9VMjy2JzULW+7ZQv6Wyfx+MeTddzV6X7Uzwz7bYRiAbBNu1ym pyNbX7mxCPy1l/7qd+jM4xciBNTW12JO5R7Ue6JueDWdzQAhFi/LNlMvLtLeTHCirgJYnTL2Gut +x+K1SQV9oAEdsakqw1NrOFDSG7Uj8ymJe0e42lFiEVJ/Yw== X-Received: by 2002:a17:907:724b:b0:b04:7ef0:9dd6 with SMTP id a640c23a62f3a-b302b11e21bmr617135066b.55.1758706210487; Wed, 24 Sep 2025 02:30:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBv26aG+WXqSnyMwmt2w/8kD3fCQw1qknKr1M/CZ0E3ooktbRHf4Sz/w8WyJm16upCEJgeEQ== X-Received: by 2002:a17:907:724b:b0:b04:7ef0:9dd6 with SMTP id a640c23a62f3a-b302b11e21bmr617115066b.55.1758706207381; Wed, 24 Sep 2025 02:30:07 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 26/29] hw/xen: Do not unparent in instance_finalize() Date: Wed, 24 Sep 2025 11:28:46 +0200 Message-ID: <20250924092850.42047-27-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706396900116600 From: Akihiko Odaki Children are automatically unparented so manually unparenting is unnecessary. Worse, automatic unparenting happens before the instance_finalize() callback of the parent gets called, so object_unparent() calls in the callback will refer to objects that are already unparented, which is semantically incorrect. Signed-off-by: Akihiko Odaki Reviewed-by: Daniel P. Berrang=C3=A9 Link: https://lore.kernel.org/r/20250924-use-v4-7-07c6c598f53d@rsg.ci.i.u-t= okyo.ac.jp Signed-off-by: Paolo Bonzini --- hw/xen/xen_pt_msi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hw/xen/xen_pt_msi.c b/hw/xen/xen_pt_msi.c index 09cca4eecb1..e9ba17317ab 100644 --- a/hw/xen/xen_pt_msi.c +++ b/hw/xen/xen_pt_msi.c @@ -637,14 +637,5 @@ void xen_pt_msix_unmap(XenPCIPassthroughState *s) =20 void xen_pt_msix_delete(XenPCIPassthroughState *s) { - XenPTMSIX *msix =3D s->msix; - - if (!msix) { - return; - } - - object_unparent(OBJECT(&msix->mmio)); - - g_free(s->msix); - s->msix =3D NULL; + g_clear_pointer(&s->msix, g_free); } --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706487; cv=none; d=zohomail.com; s=zohoarc; b=a5ZLjC19eX4oaWOxmUcxNoXocYTiDVPETLUkuL+p7FOwTP5Cj8It/nwotZtS19nzt6Z1p/GNy2WRyz3hClwwGDFvsTHL9s18k9EEYEOJZa27s7E1gAWOrmO+rW/POPPc4uuEK+KRoxuwfqX4h+UuoQhSEISRkIDO/tufV7pgckc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706487; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dSmdwGepvE9H8r72ac4KPADoXQRxf1WYajt+tsbQlxo=; b=TOdsk+EfUvzXqVp5PfWe2fdmxaoDCUjK6iBI3keBKLG9aPFeOBr8ylzCjX/gTtr3hnypBfrnnMq/FxTynBiXYAksi1zCKent7fjNwrDO8+lkW0mlllViDfoVHOFD9G/5VGWqFkS71of2t8vVmzaAVIwzrDgPJRWhOtFrzHYF3uI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706487172914.7570437361843; Wed, 24 Sep 2025 02:34:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqN-0006kL-45; Wed, 24 Sep 2025 05:31:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpN-0005px-Aa for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpK-00055G-KV for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:20 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-b3WhJ2e3Pkmya3rqt_v5eQ-1; Wed, 24 Sep 2025 05:30:13 -0400 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-62b77ca3f64so6554191a12.3 for ; Wed, 24 Sep 2025 02:30:12 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62fadb1ee79sm12133259a12.33.2025.09.24.02.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dSmdwGepvE9H8r72ac4KPADoXQRxf1WYajt+tsbQlxo=; b=C+Yz+JhA+KWpt+oiA40tl4RkM1rFObOIZn+P0ehNCBmM6H7EqJMvR+foNzMR9D0Pay7QVy vxjxhQnKcof8nNdDt+0+Rs/gEXzKbcXIHjmktxn8pC/QT021TM4NscY7W0JWLdjP/trHuf Y+a72ppgBLbLk26OgslG+vHuCTFyXe0= X-MC-Unique: b3WhJ2e3Pkmya3rqt_v5eQ-1 X-Mimecast-MFC-AGG-ID: b3WhJ2e3Pkmya3rqt_v5eQ_1758706212 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706210; x=1759311010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dSmdwGepvE9H8r72ac4KPADoXQRxf1WYajt+tsbQlxo=; b=gw59/wnlFGgtQMkeRyzTnx9HzYEONf5d1ACmzFLtHfzgXDpTQDXu+301BjGKlnMTOu wIKG32uIMohHff1/lPDsfQeOozH/e4HiZmX4+91fDM+4THmJ4agbC6ZOBqT708TQF2eP BXGyRIvSmbZTj+7CbrA7k1TLIWsB/d9er2ljnbyOhVFmTbMsbrRetwwsgVtfaYyudvjY IBuWr+g2m456ewtaUFKfaGFxA1I7lHrB1O9BhOkinAJHewGL3IrcWhpvg57ODudfbuuY YD7jz/g1v81K3MOEe3Zhhr1AiEJ7mz7s1JtxFwdDkroJ8rz2sqMTh1z2vl7Axu9Za2aC PMAA== X-Gm-Message-State: AOJu0Yx34r6ANYDa/ZlGhqO36VHPIKkWB638I2Pe5s0azZahekIeqUcu oxQPS4M28KlUNQqv/4TPKd/rHU9Zj73kqYvP2TnmfwtWUWT9QQzn+5iusnU1tz55MIRk5k0avHv I6PbFdB37LQ/oNwfPMrl9Y2mXmpCMVDdExTCPxHO5+aSdJ2ZB8kPG4WDapHEgJRjvcIVSXeKRhv xCCI1HvkDyY9ykun9/w+pEuNvnMwwt0fAGd+Kl3jPx X-Gm-Gg: ASbGncu9Ly1japKQyvyLreTwMEGkNZiQv0neuFCCVEKJPdEuTiHOqDWQsrLxCBH+JeB bJZa6zOBnWhsYTniv3U4gZa3TT04ImaderEswkmtgytsl/slxOIzdesPnaSriFTsTSguHzkzWHH tWAf3OrmVoqR3rf+txfuDf+x8f72v9QWXRwdITkgvAlLViEKglB32pvCb6BJbGxt1TQugV2t8qe VaeYluiREnjQPL4Hjze+ps6cXbviY0P0ch1fTw2dhoKfrP58HD7OuVSiAJdZYEH7DvD5/KcPe+4 BD8Z8i0PMF/JNZn620EzqgoFLXyQBbw7iFES6vJKbMz+vWoHpNDtkyrtBPckjtJVOe+0JQt99lk AyKObabSUzdfxw2sh2JagLScryTZEF8Ma6MzXmeq5KvvAqQ== X-Received: by 2002:a05:6402:324b:b0:615:6a10:f048 with SMTP id 4fb4d7f45d1cf-63467801c85mr4221202a12.33.1758706210141; Wed, 24 Sep 2025 02:30:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEw/G1iVZ7QiyE/vnosYDTU5639/gVvfD2Z1d/feOI81v0jov5GUlj4AI528rT089348XzSrw== X-Received: by 2002:a05:6402:324b:b0:615:6a10:f048 with SMTP id 4fb4d7f45d1cf-63467801c85mr4221176a12.33.1758706209695; Wed, 24 Sep 2025 02:30:09 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Stefan Hajnoczi Subject: [PULL 27/29] docs/code-provenance: clarify scope very early Date: Wed, 24 Sep 2025 11:28:47 +0200 Message-ID: <20250924092850.42047-28-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706488290116600 The AI policy in QEMU is not about content generators, it is about generated content. Other uses are explicitly not covered. Rename the policy and cla= rify its scope in the TL;DR section, as a matter of convenience to the reader. Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- docs/devel/code-provenance.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code-provenance.rst index b5aae2e2532..dc3524ac177 100644 --- a/docs/devel/code-provenance.rst +++ b/docs/devel/code-provenance.rst @@ -285,8 +285,8 @@ Such tools are acceptable to use, provided there is cle= arly defined copyright and licensing for their output. Note in particular the caveats applying to= AI content generators below. =20 -Use of AI content generators -~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Use of AI-generated content +~~~~~~~~~~~~~~~~~~~~~~~~~~~ =20 TL;DR: =20 @@ -294,6 +294,10 @@ TL;DR: believed to include or derive from AI generated content. This includes ChatGPT, Claude, Copilot, Llama and similar tools.** =20 + **This policy does not apply to other uses of AI, such as researching AP= Is + or algorithms, static analysis, or debugging, provided their output is n= ot + included in contributions.** + The increasing prevalence of AI-assisted software development results in a number of difficult legal questions and risks for software projects, inclu= ding QEMU. Of particular concern is content generated by `Large Language Models @@ -322,10 +326,6 @@ The QEMU project thus requires that contributors refra= in from using AI content generators on patches intended to be submitted to the project, and will decline any contribution if use of AI is either known or suspected. =20 -This policy does not apply to other uses of AI, such as researching APIs or -algorithms, static analysis, or debugging, provided their output is not to= be -included in contributions. - Examples of tools impacted by this policy includes GitHub's CoPilot, OpenA= I's ChatGPT, Anthropic's Claude, and Meta's Code Llama, and code/content generation agents which are built on top of such tools. --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706354; cv=none; d=zohomail.com; s=zohoarc; b=SoEwQU5itoMPoRjnG82U0VDV697nMnQUbHfNBasbgwYF8tt2WDhfMvJ0BlqWmjH5wFxf3X6Pic2ons07wAJZb6otpqXN0c5yDq+rjjWW2/ooRMLVgrSn6JGXM2VbnS/Zp5x8rGboT6uMRhJ80YZ78NhI3rmvQNfrw7CD7qAlCVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706354; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o3Vto+snCtjNXaumgbXK+T8T39rA/AJYllmWXUTaf0k=; b=LSQufX1IJ+1ZwIfdqZQ0Ks3SHXyIkB+QWAVwIWvIZed1ZGM+Px5+Ojtav5gOyVs3juDbfKBVT8P7mADlCxiDEBzT9gL12o+pG0NLEt3+Rw4G+1DivALLMQES0aJdzuvn57GypsLMEeGax0iI6foIc1X4nzOFgEoyHRQuXJxAW68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706354803313.7808559769197; Wed, 24 Sep 2025 02:32:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqM-0006ja-6z; Wed, 24 Sep 2025 05:31:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpW-0005wD-3x for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpN-00055r-FY for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:29 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-N0Uuu8ETN1GUCvw3GkErpA-1; Wed, 24 Sep 2025 05:30:16 -0400 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b2fca156551so75438866b.1 for ; Wed, 24 Sep 2025 02:30:16 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b2cfdcc2d12sm623801066b.60.2025.09.24.02.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3Vto+snCtjNXaumgbXK+T8T39rA/AJYllmWXUTaf0k=; b=bIlf1MCz1G4F+ZpMPK7jJL+DKr2hIsNTulllt7I8FMcZhNzQVsC9hLuHTvZ+69ISdNygxH VAxCTxbTZetM2a1Dfl+ofBuUH7HwQkCEhmHJDgcu6cA005WJKN2ZE45RGO1Hs/RbmBDEti CELAdhrAb9HZkUYXYmcRUQDv7OzIzMA= X-MC-Unique: N0Uuu8ETN1GUCvw3GkErpA-1 X-Mimecast-MFC-AGG-ID: N0Uuu8ETN1GUCvw3GkErpA_1758706215 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706214; x=1759311014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3Vto+snCtjNXaumgbXK+T8T39rA/AJYllmWXUTaf0k=; b=HohaZuVIh0B3Cjk3Xq9cYVodRAIBITf+d/VVjfyc9Le0BJ9snvzBLyXrgTK6iXMBsF a519DhOCfsuymkPwZ1zpzOY+MOD73tqy49HC6uY85fEdX6FVMs79tGAMlzNkHOd07TXB FJ7s4CrwPWP+UZPLq2t2vtjsSu01NFAAT1smy3lUba+aHep2L5k18GZg9rCMxPJyo9hr 4OWv8lqUU0wcLGxZCqpmFQDMKHfBuz1PZJhkesezYKgW/GepBJztBw+vwu5mlK744C8Y xroYinHXFAFJ7VXdaLtsD6HVug7zFtcQoDOYbedD3U5D/+ZF0RBVqpX+iBNT75sQ5kth krpQ== X-Gm-Message-State: AOJu0YymYzapBivjFNApRDsCYx6SfLaPETC6gOM/5qGdDq/2H6EdRopr YtUaMRwnAssHMzZHa/67PzwiDC2z0qwg4jxfVLUjJabt0s3j4ioHMgCK0cKWALnz2guJGAtcOQw Rhp7Drf9Ae0TeQ7sjT7gg8PcqiX4ij/hjgrJpIk9alaafuO3acDbW7yev1YEKXlyZlAxvDhOzko lmlcfM3OBbSPqUCEoVVJqthlmspFvcAPuu20e1cTBP X-Gm-Gg: ASbGncvsf3AaJIgcd+/LZ8/rJuIKFpYiYFW5gmDzyrx9rSvjdJkTGnRbZCVi7L6PkDa rMh5RTOslu7r2nOSRGAkhzNZ8asyQZaFNXJq0e/bp5H3zppmK+m+2eVXz5oRK4WzJwHo15qIW5d yQG4O/Df3z8AVXid+TA0EI5z7NvJWmFZ/qJ8/R7PtquxzSXiiDyXVXvrjUKiMjRpRZlkp/8yuru 3G/ebdmkrol1E6SSr5WRTIZBdhCJtuKrffx6G9Fsn4ntmJMfY8UTUCHHz4zxVA9o/uo+pLWIxgL Nopj5OuE9zgnZzMXfXDKf/+eKFJAvAPLS3jlOudycviAWJpkwaDWXwrzpJxfUlfBM5B0v6AOYZ8 BJUAxVrCS6RbZaXq3BjVCn7lES3z4LWVN/z1q/kOcdsyo/Q== X-Received: by 2002:a17:906:c114:b0:b07:87f1:fc42 with SMTP id a640c23a62f3a-b32ca37f1aamr206054166b.16.1758706214355; Wed, 24 Sep 2025 02:30:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH28+ROajyM4RrVwHCB7tj1EZOrG6XKTMXPV2YrkUMJ6Zop5uSYSlridsC3Js59JYpLc7U29A== X-Received: by 2002:a17:906:c114:b0:b07:87f1:fc42 with SMTP id a640c23a62f3a-b32ca37f1aamr206049666b.16.1758706213738; Wed, 24 Sep 2025 02:30:13 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 28/29] docs/code-provenance: make the exception process more prominent Date: Wed, 24 Sep 2025 11:28:48 +0200 Message-ID: <20250924092850.42047-29-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706356311116600 QEMU's AI generated content policy does not flesh out the exception process yet. Do it, while at the same time keeping things informal: ask contributors to explain what they would like to use AI for, and let them reach a consensus with the project on why it is credible to claim DCO compliance in that specific scenario. In other words, exceptions do not "solve the AI copyright problem". They take a position that a reasonable contributor could have, and assert that we're comfortable with the argument. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Paolo Bonzini --- docs/devel/code-provenance.rst | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code-provenance.rst index dc3524ac177..6968d54be8a 100644 --- a/docs/devel/code-provenance.rst +++ b/docs/devel/code-provenance.rst @@ -331,8 +331,13 @@ ChatGPT, Anthropic's Claude, and Meta's Code Llama, an= d code/content generation agents which are built on top of such tools. =20 This policy may evolve as AI tools mature and the legal situation is -clarifed. In the meanwhile, requests for exceptions to this policy will be -evaluated by the QEMU project on a case by case basis. To be granted an -exception, a contributor will need to demonstrate clarity of the license a= nd -copyright status for the tool's output in relation to its training model a= nd -code, to the satisfaction of the project maintainers. +clarified. + +Exceptions +^^^^^^^^^^ + +The QEMU project welcomes discussion on any exceptions to this policy, +or more general revisions. This can be done by contacting the qemu-devel +mailing list with details of a proposed tool, model, usage scenario, etc. +that is beneficial to QEMU, while still mitigating issues around compliance +with the DCO. After discussion, any exception will be listed below. --=20 2.51.0 From nobody Sun Sep 28 16:28:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758706556; cv=none; d=zohomail.com; s=zohoarc; b=RSJ5LmmuoO5NCgJZ6PqMe51uT7mJun5shyRJDnhMjxioOqclT7P3YJ64zUp70pUjBnowJG4ovRtrG2i5h5o6gJzFi/g3cnJGWrHR/qYBwzEzzKdtgLFqvkh7zzf3NQXxCEgjp+C2Hq1fSTAFpPNQeSSZcGdSXgdKdFmO7wkfWho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758706556; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TF+uRkbdU4sqmkTEUKCHp2+nyTo8mJw1hvaCWSytbjg=; b=kahyBPonDKmPDe1apEJ18gEXvbICg2CoZXB3/VE9PqkiRBv2bFs46Sj9Z+fBlWo31vxFE2YRE7diBKQWriEw522DOPYyKe/d3o3SzW7d0DnB93QG2dPOYTEgi9pJv1mS7xBh5Omyv9iPueZ0Jk55xTk14s3YEh+TsIDzMpjwrC4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758706556118109.06826217689513; Wed, 24 Sep 2025 02:35:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1LqA-0006Mh-Aj; Wed, 24 Sep 2025 05:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpX-0005wF-TS for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1LpO-000562-VM for qemu-devel@nongnu.org; Wed, 24 Sep 2025 05:30:30 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-u21SsSdRM_u8nr29JppqZw-1; Wed, 24 Sep 2025 05:30:18 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b311b7aa78fso136822366b.3 for ; Wed, 24 Sep 2025 02:30:18 -0700 (PDT) Received: from [192.168.10.48] ([176.206.127.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b26847ba016sm1136962266b.21.2025.09.24.02.30.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Sep 2025 02:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758706219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TF+uRkbdU4sqmkTEUKCHp2+nyTo8mJw1hvaCWSytbjg=; b=PbPrcXTxjKmXx/Sq3kF1yVfRWUlz2+ZlOwlNBDb2Ol0faoRuIt2FAhOySCnSQjXW/7oBBq ideowLHc6tdv03usr2ZvCgo5IeEskDm0u/E7Lv1jlfuxbCmUha+sqYIm4vpYlLBnmfw+rO IB2VoQ8vy9sNX1WljXKudM+mNhmszBY= X-MC-Unique: u21SsSdRM_u8nr29JppqZw-1 X-Mimecast-MFC-AGG-ID: u21SsSdRM_u8nr29JppqZw_1758706217 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706217; x=1759311017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TF+uRkbdU4sqmkTEUKCHp2+nyTo8mJw1hvaCWSytbjg=; b=FKJf+sR/c47bPCCT6SWEa6+Pkso3ZnZXogECzpBjK1HaqWCPV37t0VGxwzltPDxqGA dFnLPzlSUhz2r9j0MEhIuefwpoyBMRbbzeAOiwkDQnvO4hjL0Vafup+Q9o43nRt+7Yse wwk+S/bFPKc7FdVhrt/z+xjLgLD5Roy8t2IlYV6GQX8IiduXyvOHbI1nZRcoDTM01DHd b5GN2MoHliCM4Cx5yhminh6BDx4lPoEUm+x8TpDuRYiTVO+XH9eGAA68F1GCGmwiWtOo jso3TDs/yd915cR7xyYPiHbQTxK9utI1Rk/zNulOu54ZBeCOCXKhy0wh8bNyOr31HwjC 9tYg== X-Gm-Message-State: AOJu0YxDZn6OeaQblOhum1cbWuJgZ5ijpReGcgFyeWz49NaHYUj9Y7BN p1hHYY1HnJXft/LIlBDOeRf4yksEkJ6XP+91Nq6OC4TDaiHL2BAa3HVy/GdmOtpR5wO0Oe8yG4U ScPCf8C167AJBbCzSXucLJxbDqgsesmw1IpbH3XJ8Jg+Xtm07BsPXNqF28xTl0yrj7MIAkJNrww TTJye4s1/KpqZbmYEeFRWzS7RyyHnAy6tN0FrYbN5p X-Gm-Gg: ASbGncvTvBvZGtn3GstXDM1t9Ki59jxGqc+j2Pokqwu2AoaG+hIKqQVJHhesrE8QVLb zf7S+3WJmLothiVnKrJ9uNry3IdnIplLZey9YRa2xAdepwIxqTIPDko9RKOwmIXFyMFc71EAVha d7cEueZf7lPIJtuszZXU1gbVA1Xnmwb6ZWdPbV89wQns/OBHConacCCCOFl5bU2HcjSic2I/uu5 7C0eetxJsgtYlkc7+DlHtIGImhqWdadjKC52l49kfmMCyX1gHTQ5y/d4qqxLpOcWAvY+UffEWL2 xXz/LDJCT2yqxUpax087q19c+jpxxI2vvYWv6yNrMg7dhIO+eyJ2isRISYiH1f9P7+5Y3sI/KMW yYVfGVlwSaqeyY09aC781swwBUnMnMbVzLcCDe6Z+FnIT+Q== X-Received: by 2002:a17:907:3f2a:b0:b32:b055:949a with SMTP id a640c23a62f3a-b32b0559c0emr209611166b.33.1758706216622; Wed, 24 Sep 2025 02:30:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnhaSUFNJb9H7tB3abHwb6xuv5TRziTs6lTGe9LpUqrw86umi8ccwvv138ZeOgw9sLGCVT8g== X-Received: by 2002:a17:907:3f2a:b0:b32:b055:949a with SMTP id a640c23a62f3a-b32b0559c0emr209608066b.33.1758706216152; Wed, 24 Sep 2025 02:30:16 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi Subject: [PULL 29/29] docs/code-provenance: AI exceptions are in addition to DCO Date: Wed, 24 Sep 2025 11:28:49 +0200 Message-ID: <20250924092850.42047-30-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250924092850.42047-1-pbonzini@redhat.com> References: <20250924092850.42047-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758706564378116600 Content-Type: text/plain; charset="utf-8" Using phrasing from https://openinfra.org/legal/ai-policy (with just "commit" replaced by "submission", because we do not submit changes as commits but rather emails), clarify that the contributor remains responsible for its copyright or license status. [This is not my preferred phrasing. I would prefer something lighter like "the "Signed-off-by" label in the contribution gives the author responsibility". But for the sake of not reinventing the wheel I am keeping the exact words from the OpenInfra policy.] Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- docs/devel/code-provenance.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code-provenance.rst index 6968d54be8a..8cdc56f6649 100644 --- a/docs/devel/code-provenance.rst +++ b/docs/devel/code-provenance.rst @@ -341,3 +341,9 @@ or more general revisions. This can be done by contacti= ng the qemu-devel mailing list with details of a proposed tool, model, usage scenario, etc. that is beneficial to QEMU, while still mitigating issues around compliance with the DCO. After discussion, any exception will be listed below. + +Exceptions do not remove the need for authors to comply with all other +requirements for contribution. In particular, the "Signed-off-by" +label in a patch submission is a statement that the author takes +responsibility for the entire contents of the patch, including any parts +that were generated or assisted by AI tools or other tools. --=20 2.51.0