From nobody Sun Sep 28 16:34:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758696290; cv=none; d=zohomail.com; s=zohoarc; b=EyV/CaxpZU5VUI0FLULV83HuSLRsK1qsnZD+J0+vYaGGoqzOWO6dR9WQa04ixiVOeck3Cf2b+nJD9/5DrhjERsXr2cMI/41yhVuR2mdB5auXEGdJhNLrjkmMHiPRNKYh7WRoMZ9QW2jRQYTHNzrGQAsxEMxTwZAsSND0I0Cxvfk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758696290; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=raTA0kM5nFI+z4B5gzD6Ep5lYfS+FsUc1xyZ0yVdXQ0=; b=Xj64efmfEOyKNbyl/6kgJ8zAPbRkVWZay9TdD1xKhJkl6aZHsK/t8XW6dDqIarasREQJyQcgV5323nL+1Dn1seO+UQIt/I7ygik9+2aDMzSj0d2ZtKznaSWSopD1MlzjF3n8fJgDd4PwH87ciqVVseyUIO2nNy2tjAhK/0XvuTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758696290011571.3102862274201; Tue, 23 Sep 2025 23:44:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1JBg-0002fg-Bd; Wed, 24 Sep 2025 02:41:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1JBB-0002Y7-SV for qemu-devel@nongnu.org; Wed, 24 Sep 2025 02:40:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1JAz-0006mG-KR for qemu-devel@nongnu.org; Wed, 24 Sep 2025 02:40:41 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-euXcDny4NZKx8lV_sB9I2w-1; Wed, 24 Sep 2025 02:40:18 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 55721195608B; Wed, 24 Sep 2025 06:40:17 +0000 (UTC) Received: from thuth-p1g4.str.redhat.com (dhcp-192-176.str.redhat.com [10.33.192.176]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 340BB1955F19; Wed, 24 Sep 2025 06:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758696028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raTA0kM5nFI+z4B5gzD6Ep5lYfS+FsUc1xyZ0yVdXQ0=; b=e95SQrmAkrE2/tn7mgaKuNOHDAMJCyZEY0WdAHQqmGDUl0U0SFFOZc0AxqkRU9ZffzkfC3 G9UpDsfv605jzEpfF7DKBvqGo1P8kmifFZRSWPZxmwtzjRP6MoaSOtx/vXyDQJhS6uwG8q W02vCYqlCdE7je43qA0RDwPZm4ySi4U= X-MC-Unique: euXcDny4NZKx8lV_sB9I2w-1 X-Mimecast-MFC-AGG-ID: euXcDny4NZKx8lV_sB9I2w_1758696017 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell Subject: [PULL 10/12] tests: Fix "make check-functional" for targets without thorough tests Date: Wed, 24 Sep 2025 08:39:54 +0200 Message-ID: <20250924063956.519792-11-thuth@redhat.com> In-Reply-To: <20250924063956.519792-1-thuth@redhat.com> References: <20250924063956.519792-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758696292297116600 Content-Type: text/plain; charset="utf-8" From: Thomas Huth If QEMU gets configured for a single target that does not have any thorough functional tests, "make check-functional" currently fails with the error message "No rule to make target 'check-func'". This happens because "check-func" only gets defined for thorough tests (quick ones get added to "check-func-quick" instead). The same problem can happen with the quick tests for targets that do not have any functional test at all. To fix it, simply make sure that the targets are always available in the Makefile. Reported-by: Peter Maydell Closes: https://gitlab.com/qemu-project/qemu/-/issues/3119 Signed-off-by: Thomas Huth Message-ID: <20250918125154.126072-1-thuth@redhat.com> --- tests/Makefile.include | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 3538c0c7407..62a4fc8ed31 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -113,6 +113,9 @@ check-functional: @$(NINJA) precache-functional @QEMU_TEST_NO_DOWNLOAD=3D1 $(MAKE) SPEED=3Dthorough check-func check-func= -quick =20 +.PHONY: check-func check-func-quick +check-func check-func-quick: + # Consolidated targets =20 .PHONY: check check-clean --=20 2.51.0