From nobody Sun Sep 28 17:04:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758664517; cv=none; d=zohomail.com; s=zohoarc; b=Y6TRPOcJT4oOTRdzdV0GKojjQ11SFYitc6hrvh1LCn0FoOS+Yx3oDY5djiLLj2EWa5Fu7kHcIIUwhES/K004lF6KZTUmuodFSO5aG8tcpcpFuGdLZ+jrxl69b2N181L18IeE6BK6bjBjS3OoTKFWNWIAyLvYmxeYWk/gYEhge3U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758664517; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3tkOqHK5ejgU7JIInVN+rKgDfoWboky6FhXhkFrd/5A=; b=BEJaUGkfh5bS5jLUmRckzkozHx0rBJd8gPhkX5nwSN4D5sE896i1BVtsgnNA2FGRY5kjpWsD28ZpnhuIw9vBqGWHm7i68ItJAetbE/YJBMblbWjhAYvaigYN4Nh28s9HM7MwzCYNYQWtYZbsWXtOO1iolW6uKx+DvP/EARJIoi8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758664517769768.1554379699794; Tue, 23 Sep 2025 14:55:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1Ay9-0006Lo-8S; Tue, 23 Sep 2025 17:54:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1Ay6-0006KT-3o for qemu-devel@nongnu.org; Tue, 23 Sep 2025 17:54:38 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1Ay4-0003jN-DZ for qemu-devel@nongnu.org; Tue, 23 Sep 2025 17:54:37 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-24457f581aeso60505845ad.0 for ; Tue, 23 Sep 2025 14:54:35 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-269802e14f1sm168294035ad.71.2025.09.23.14.54.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 14:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758664475; x=1759269275; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3tkOqHK5ejgU7JIInVN+rKgDfoWboky6FhXhkFrd/5A=; b=IiPHP9Ws22ffgZ0/bs2NfR+x+igKL5hLp8ArkBclhXKUw2bxQzHdGZI4860DU3Qn71 ag84k8r3hhzmGOln9uGMfBaD82lMoJfoHqW6V9ArRLimiKGCqeX8gTlgesO9Tc+rqszt DCmpVAAdW4DEY6qjs3nbnzsSymwKCwscVqzTmVdyrgK4cxBJG2ZV0ePuaown/nE+qirt GHs79o78gD+UweDRCRYvW2tP8WUFnPTRtm55igTV3XNynR2nN7NZxhlp7raApZqo3tmz tmoMABhgT37Tkynqoa+zwF4QclQsyLGl2yyeUL2CihqlfCICrU6eBDQaQwi8AHpIRmn9 T0EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758664475; x=1759269275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3tkOqHK5ejgU7JIInVN+rKgDfoWboky6FhXhkFrd/5A=; b=lXDc5htdIvOhE1tT2VFv9EqUvyCdcN3YRJQAb/fiUX1p7fplv4SVKGeN7xxvYr33vn s2dRSSGcYSLSR3n5ghRzcGA67ClsWQyQer66Nxy7G6vxjfkBdF/GqHKmhj/wYm/elPRI nV/2lUmAui8owD9bTv7Vw1f7Ot86iWDiNV5DMEkht/+ZZ7JR8Mq2U2LgQkcOpH+X2MgW cNfKaV8Cq+4duq+7a4p/4tutniYN0CxltEXntT9R/q6/7o0qrowFoGLtyu0tGZleTlSV GvZyLT9lwUPl8Xpj2PTo/J5VbGqN0gvfr/19sjatljQz5o857V5W6womZ+nc4NBW/sjI n5qg== X-Gm-Message-State: AOJu0Yz7jde7NLxzuZ6idR7C+L/RikfeeDQRHM/F2jchvyIZ9X8r4R5T i78FjEJgO4S1wpuiT8OpLjD7kdlxod5FaPUP6TcftfhrFM+engPTaWx+1b68PfnVEGNGe9EYJTP m7Qf5 X-Gm-Gg: ASbGncv+R2gPdJzOjz3ZLYsv/+BbOoJoONe5r78h4Mww1r/laHxlpIZMTV76wdKVtOH 5qTsqQT127B2XABJo5iPNrMkpd809CWfKEhU7wtu7093zLR6PJnaqsMfiffELjaJ6vIVwe1wQMz eHfB6qQswVKxWaa9O+hUGCGSoJGGyCBvsuPkQN1RVxPLFFW5tFuzSPsE+fu18nOgIMo2cHaqgiW Ib6FJR+0vkJz+2IOetFuxQSxZiR94QmysvtjkfTTqwLIG69UYnoPwCu99GTOWezNIz3KDPb9TAB U/uDkzqVONpJ3oLvWVtAPK5aYHDyf/sOsbW5zSj8J2skLSkpOpAqe79PZAJlN21dpZcgjoqM0Wy pmfzT/YTV1lP6cBWAFoiBptiaJede X-Google-Smtp-Source: AGHT+IHRJgiKIW6ISvVJIrNpGL51FXSlJ3tm6v5g1PhoZ/EziWy+Ll9Q46Db0pJGvBxKrMVWYwzj5Q== X-Received: by 2002:a17:903:22d0:b0:248:ff5a:b768 with SMTP id d9443c01a7336-27cc09e4465mr40093885ad.10.1758664474299; Tue, 23 Sep 2025 14:54:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 10/10] accel/tcg: Improve buffer overflow in tb_gen_code Date: Tue, 23 Sep 2025 14:54:24 -0700 Message-ID: <20250923215425.3685950-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923215425.3685950-1-richard.henderson@linaro.org> References: <20250923215425.3685950-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758664519606116600 Content-Type: text/plain; charset="utf-8" If we only have one vcpu, or within cpu_exec_step_atomic, we needn't jump all the way back out to the cpu loop to empty the code gen buffer. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 31bc0f8bc5..da9d7f1675 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -289,6 +289,10 @@ TranslationBlock *tb_gen_code(CPUState *cpu, TCGTBCPUS= tate s) tb =3D tcg_tb_alloc(tcg_ctx); if (unlikely(!tb)) { /* flush must be done */ + if (cpu_in_serial_context(cpu)) { + tb_flush__exclusive_or_serial(); + goto buffer_overflow; + } queue_tb_flush(cpu); mmap_unlock(); /* Make the execution loop process the flush as soon as possible. = */ --=20 2.43.0