From nobody Sun Sep 28 17:41:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758595394; cv=none; d=zohomail.com; s=zohoarc; b=CK412oRkmXpIStNZSxVanLfmxmaMANT69+YsCZp2X75VRGdBaFN/0OBv/eGVL+AhdrSyAP2YE4Zplv2qBv9G6z29kFBNDR/5Jdf1gp5yx5B4g3gnpXDqwmMQXKtw9XoR7+GCuSeENUaeuHKxl8LZQGEzzFwfuw2Ri3EyU8evfPw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758595394; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WtS+tUcTZk2GBqf6yxqhjiU0irGyIDNvqIFdhqaZrSY=; b=SxJ2MxASK2rENL+7jZqJMwfUKCDZ+KBBwhCh6gRQIYym+YyJQD18bcYvZisaKgRhh8j+8EX4zGESBOQOIiXw/Dxaw9goQRvGktqkCNHs+qMlLPH+ZQBIhbxV25bQVSewIz1aSmBbW0uV0SRXhVbakGLVZoZeLOOPUyslpp8Zqq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758595394562576.4737969378825; Mon, 22 Sep 2025 19:43:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0swN-0004EK-Ss; Mon, 22 Sep 2025 22:39:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0swK-0004Ds-O3 for qemu-devel@nongnu.org; Mon, 22 Sep 2025 22:39:36 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v0swE-0003gx-JD for qemu-devel@nongnu.org; Mon, 22 Sep 2025 22:39:36 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-b553412a19bso1637846a12.1 for ; Mon, 22 Sep 2025 19:39:29 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77f0da43089sm9899622b3a.90.2025.09.22.19.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 19:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758595167; x=1759199967; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WtS+tUcTZk2GBqf6yxqhjiU0irGyIDNvqIFdhqaZrSY=; b=wwyDa6JkLfuLYwBHIc8zEiL39+DMOFgA8u6f9Y7p/++TqfwKw20od+LOsdtvKh/cOV gQp/eSIAGhu8Ssm3+TIwVRKs90Vm05o8Js58buuuAedvLy60LdysavT6l5+5wtTzSIXW HlsG4RWAh3hVBfZIYn7VgdnUB8c1xa0wOcwXx3ac0+CtYnzTtkiB2pTZUPIFPHwgrahR GOyRuohSFDzpvwGUJG0RQnpEza4L1VWiFIJBuU6ZfcYq9pKhZHoKycesSsBqd+oWGRGW OoEljtf4QotrMxOEzonSjKy1Xu4DwEyimbv0QrH2s5G+NoyIDZb+uIGkUPMgjPILc4eK u0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758595167; x=1759199967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WtS+tUcTZk2GBqf6yxqhjiU0irGyIDNvqIFdhqaZrSY=; b=PqZjBp/y+A+857FpjiyJYnP6T0zjnNFBVnGaT+0GAMeMvuO+hahNPnPcgIKWWDShHO KD8OGwaNCR/2xmeybiA2tASLeAh9nixlZxrWfP75kO0GoTC1t2siicGjRtF+FrW418bX vNoe44UsKp8Yozgoc3wL6KlyZ+YZSaxuP8WLFRpgHazMqCKlNo9+4n6I4VLzs8M98+1a XDgqVqz+l4UFhIgOa2xxlwxFVd2lNCBpxWQkN43yKbzByt1yz8ShdqbkYZv8GgbkjiWU 2/puOfHqwboviohtXD9kcaB2QCiNqVDyo6uQ2FMvhQkoB5SeYz5m0JyW3Pg1LnzGM64K koyw== X-Gm-Message-State: AOJu0YwBzq5ITgTldVpmlM8T3dTgN8QcaNywhaIQKkShexm0iptMuXtk Et/OaTUGvCJl/bW8PDEcBxzkB0lS1XB9hvy4NlId6GHTH0gPaUiaEjnASWRpsX767WA775YQy3n FtfYS X-Gm-Gg: ASbGncsfctYEk+wgVUVu0rUroYfDEjwIPl1kd6sQymFdBjzj1Ipg8Slhxm+ojT3rmbx sZ2nDkkLTThksxDWvH+jzoyJuGtxc+cAzJNR3+4VECDClanueJOTsbw04emNskksKLd1f3uEqWV UnmsG3kA7HUrXIR4k6oSmQOYuC/hH88wwgXPnxmIdHQzSPYh+qVA4qVQfEqLOP0qJVqO7TLw6iB sFtYE1I3ejPnb4M+IEXZ9ayHy/7VATxhel66Z1/8t+3jTn2MBVkzzwNIm01q2jx9gnWKKzAcamr ezubfyBXPQdSI+M+N3bmDxqbViRjacDiIRkslb7wpGUTXq7dTLfrc7iInmTeG9FaKcR7YdPxt9a dy8DYuUUTYfEK8fqu1SdKAfkOP/45 X-Google-Smtp-Source: AGHT+IFhdkBYZJ64ekLETcR0+kLRvIW8hmVQeZ3JUqgpSGj4LuHeM+ubYQVBCmKgaFBEgQRM79KwiQ== X-Received: by 2002:a17:902:ef4c:b0:26e:62c9:1cc4 with SMTP id d9443c01a7336-27cc1197880mr10617925ad.4.1758595166932; Mon, 22 Sep 2025 19:39:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-riscv@nongnu.org Subject: [PATCH v2 04/12] target/riscv: Record misa_ext in TCGTBCPUState.cs_base Date: Mon, 22 Sep 2025 19:39:08 -0700 Message-ID: <20250923023922.3102471-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250923023922.3102471-1-richard.henderson@linaro.org> References: <20250923023922.3102471-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758595396658116600 Content-Type: text/plain; charset="utf-8" The tb_flush within write_misa was incorrect. It assumed that we could adjust the ISA of the current processor and discard all TB and all would be well. But MISA is per vcpu, so globally flushing TB does not mean that the TB matches the MISA of any given vcpu. By recording misa in the tb state, we ensure that the code generated matches the vcpu. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Reviewed-by: LIU Zhiwei --- Cc: Alistair Francis Cc: Weiwei Li Cc: Daniel Henrique Barboza Cc: Liu Zhiwei Cc: qemu-riscv@nongnu.org --- target/riscv/csr.c | 3 --- target/riscv/tcg/tcg-cpu.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 8842e07a73..3c8989f522 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -25,7 +25,6 @@ #include "pmu.h" #include "time_helper.h" #include "exec/cputlb.h" -#include "exec/tb-flush.h" #include "exec/icount.h" #include "accel/tcg/getpc.h" #include "qemu/guest-random.h" @@ -2173,8 +2172,6 @@ static RISCVException write_misa(CPURISCVState *env, = int csrno, env->mstatus &=3D ~MSTATUS_FS; } =20 - /* flush translation cache */ - tb_flush(env_cpu(env)); env->xl =3D riscv_cpu_mxl(env); return RISCV_EXCP_NONE; } diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c index 78fb279184..143ab079d4 100644 --- a/target/riscv/tcg/tcg-cpu.c +++ b/target/riscv/tcg/tcg-cpu.c @@ -191,7 +191,8 @@ static TCGTBCPUState riscv_get_tb_cpu_state(CPUState *c= s) =20 return (TCGTBCPUState){ .pc =3D env->xl =3D=3D MXL_RV32 ? env->pc & UINT32_MAX : env->pc, - .flags =3D flags + .flags =3D flags, + .cs_base =3D env->misa_ext, }; } =20 --=20 2.43.0