From nobody Sun Sep 28 17:06:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758567463; cv=none; d=zohomail.com; s=zohoarc; b=g6O/bTcOSCP9e9YK86s6S+KnKhjjl4NRFT3jsG5BxUMuaKPjU/7EngbruwM+KEsKhnunMqptEyr0oSLeM0nfUwd3/XUN9r7xXHmTCW6673UaGztleBJ6vZ+GKWR2WvvkjWL1U/1eSbOOKw+Da1++2lEC3ibh8Zs4e0FdkdXgMIE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758567463; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KT3njcGs3vlqxz+Aow0s8BlO+cvKAJjqrO8q+9uXab8=; b=Sq4m+ZQKQDYpDH2b17b/8DvknPUSJ5XFBrScZOBNHbXafeGg3NohgZTdVIQrMUrKuTesK3o5vkSehAiZfNmO0S4Rbi6hMY2q3XtyJuzV9qm9uflKuWm7WF0jyv2j6oFIwaE8f5yVomngbmEc0ZBsfZYU+ItVazuTdOoMZ1vLMig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758567463065485.4395858853079; Mon, 22 Sep 2025 11:57:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0lfx-00050U-M7; Mon, 22 Sep 2025 14:54:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0lfX-00044P-4q for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:53:47 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v0lfD-0004yP-0j for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:53:46 -0400 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-b55517e74e3so1361945a12.2 for ; Mon, 22 Sep 2025 11:53:25 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2698018a472sm138554795ad.58.2025.09.22.11.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 11:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758567204; x=1759172004; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KT3njcGs3vlqxz+Aow0s8BlO+cvKAJjqrO8q+9uXab8=; b=DDgZh9wrDbwWFozu/+amIkiUQw7D+zpuO0mpBwPmXJMIWJyMehxXILD4YAGn27UG7s v73nriBqgQ5tXia2aYmIUipnU74OQpTE/ATNx4lbRjWmUBlgbu9A7n1BYAmLZhTDd5e5 AeyBobKM1CNP/RYNPKVFZEHgnPuZ1SfbgaJWgtnJEic3gK9SUNKhg+8ijXVbrr/JPsWk 5sHNmIBwWPbA8yCsJ3mOM9sMVziHvZo6Giw94gsHANS/0oPVjkJFy43gGPt+pVqk//rB YJS5fGeCqS+2XKaqa1wvNqnc/EI255B/j3lKYv31cKXYR4xCsdmdl1tQhO3AvmNErkLQ HKOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758567204; x=1759172004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KT3njcGs3vlqxz+Aow0s8BlO+cvKAJjqrO8q+9uXab8=; b=JVNe2HibKSYVVGjpkxNh2voXdD9k22n+3iXcJsEUTLRb82USqM86fZSe5lvToUnHCw CDn9XM3wyrV8mhdRf/pbtR02fPen8pfbdFRHEfFh5e25Cf6MPnzXFzd7yWN9LZ7GA9fh 0jYWtngIqhV0YQYo0ZMdbdHd29UlftpOeGNhnEXKrXvNnXOidRlUs8wd5fYWOBRR2OVf xbe9S2po1aYmJaCaWYKbNL+9/lwp4AhRyNjxAUlJz+vGEnnzgLwJEfZTF0OPhA6ZEMfw uNFWz0Jc8kxpg0QZZ1kdHPZNshLq1blvsDxHJ9BugzuipS/L5Dsuby7J5uoS6V4SBggS FTrw== X-Gm-Message-State: AOJu0YzekB+FVCwd/htBZKUX5lYPFXmbCFg+Q4VHH/BAEz4MKvaUohiT uaxu+F5kJ7zmW0jyHguUj9SMjvV0WALGWcq5//dIvBBlviCE2WJ7yZQiE38LRXELDs9a2LVT+5H B5MNC X-Gm-Gg: ASbGnctXzJKEr5PjTK5KcCRePYI693MG/slw2DTlexMR6Z/xmVLVE0FOkZq/AUjRGRF 7L8yACndGyCX6C21/lOinUfuW3c+I3qOupIvUCjpnRY/PyVA7qHph9zJ7cE0jhfqFwoyvI5iVjE bv7b1Ri1PsLDQdNpVvPJB8/Wh4+IX9quCAbQcOIZpBjLVbFu9uS2yxm8ypISapw1/eEfNCnE7xd OOsAMmNvdKym4ojfXfJ3YX7tZbUT/9hnnRcEXMR48zmOGsWt/FmZ4Btuus0hJ2wPtE5e3AwgvsB PrY5LbhDqdEmwMfo+GplxGPjqvUdqXYdioWz6pDYfqZFq9V0ZtHbTNH6aNIQMgQubSl4sG/9mix Qfix/2YQiIBgTORGJ5IWj9rxX7zco X-Google-Smtp-Source: AGHT+IHj8n8IItN0eTMc7vp39f1NJ0fYhpL3F7oia4f6F21zcFsXwWHfljHADvwuyM0xrZpybIogxQ== X-Received: by 2002:a17:903:b48:b0:24b:e55:334 with SMTP id d9443c01a7336-269ba3ec96cmr146371725ad.8.1758567203575; Mon, 22 Sep 2025 11:53:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Pierrick Bouvier Subject: [PATCH v5 52/76] target/arm: Implement GCSPOPM Date: Mon, 22 Sep 2025 11:49:00 -0700 Message-ID: <20250922184924.2754205-53-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250922184924.2754205-1-richard.henderson@linaro.org> References: <20250922184924.2754205-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758567464561116600 Content-Type: text/plain; charset="utf-8" Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/cpregs.h | 1 + target/arm/cpregs-gcs.c | 3 +++ target/arm/tcg/translate-a64.c | 24 ++++++++++++++++++++++++ 3 files changed, 28 insertions(+) diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h index d22ae383cd..81d8f0e32b 100644 --- a/target/arm/cpregs.h +++ b/target/arm/cpregs.h @@ -49,6 +49,7 @@ enum { ARM_CP_DC_GZVA =3D 0x0007, /* Special: gcs instructions */ ARM_CP_GCSPUSHM =3D 0x0008, + ARM_CP_GCSPOPM =3D 0x0009, =20 /* Flag: reads produce resetvalue; writes ignored. */ ARM_CP_CONST =3D 1 << 4, diff --git a/target/arm/cpregs-gcs.c b/target/arm/cpregs-gcs.c index cc5a0b86e4..15d383b2a4 100644 --- a/target/arm/cpregs-gcs.c +++ b/target/arm/cpregs-gcs.c @@ -100,6 +100,9 @@ static const ARMCPRegInfo gcs_reginfo[] =3D { .opc0 =3D 1, .opc1 =3D 3, .crn =3D 7, .crm =3D 7, .opc2 =3D 0, .access =3D PL0_W, .accessfn =3D access_gcspushm, .fgt =3D FGT_NGCSPUSHM_EL1, .type =3D ARM_CP_GCSPUSHM }, + { .name =3D "GCSPOPM", .state =3D ARM_CP_STATE_AA64, + .opc0 =3D 1, .opc1 =3D 3, .crn =3D 7, .crm =3D 7, .opc2 =3D 1, + .access =3D PL0_R, .type =3D ARM_CP_GCSPOPM }, }; =20 void define_gcs_cpregs(ARMCPU *cpu) diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index e2af10c075..c52b02b003 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -2521,6 +2521,24 @@ static void gen_sysreg_undef(DisasContext *s, bool i= sread, gen_exception_insn(s, 0, EXCP_UDEF, syndrome); } =20 +static void gen_gcspopm(DisasContext *s, int rt) +{ + TCGv_i64 gcspr =3D cpu_gcspr[s->current_el]; + int mmuidx =3D core_gcs_mem_index(s->mmu_idx); + MemOp mop =3D finalize_memop(s, MO_64 | MO_ALIGN); + TCGv_i64 value =3D tcg_temp_new_i64(); + TCGLabel *fail_label =3D + delay_exception(s, EXCP_UDEF, syn_gcs_data_check(GCS_IT_GCSPOPM, r= t)); + + /* The value at top-of-stack must have low 2 bits clear. */ + tcg_gen_qemu_ld_i64(value, clean_data_tbi(s, gcspr), mmuidx, mop); + tcg_gen_brcondi_i64(TCG_COND_TSTNE, value, 3, fail_label); + + /* Complete the pop and return the value. */ + tcg_gen_addi_i64(gcspr, gcspr, 8); + tcg_gen_mov_i64(cpu_reg(s, rt), value); +} + /* * Look up @key, returning the cpreg, which must exist. * Additionally, the new cpreg must also be accessible. @@ -2832,6 +2850,12 @@ static void handle_sys(DisasContext *s, bool isread, gen_add_gcs_record(s, cpu_reg(s, rt)); } return; + case ARM_CP_GCSPOPM: + /* Note that X[rt] is unchanged if !GCSEnabled. */ + if (s->gcs_en) { + gen_gcspopm(s, rt); + } + return; default: g_assert_not_reached(); } --=20 2.43.0