From nobody Sun Sep 28 17:06:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758568217; cv=none; d=zohomail.com; s=zohoarc; b=Sn7zxB6nY5ay+Jwb331ETKvhqWmw62kpd3ARUWuVc8rp4wMlO6sEqYww9R+dc0IHDf51I3h4EF/ZbkX8TGHq02uwKlfh4+Psxn5f60yrZaR8tuGDVhLuXsos39WgV2MtiyYff36917nmHJyLsdTD2icYV+KEWYc7SChdhvRyWh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758568217; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TRMGkSahDRDIyhY1Pf+KcfrLPaCj+CJxCc4+NBDjs/c=; b=Fzc+9s3HWMhlh3ecMxQYfQsScC3n7niq7o5B4dlm3B7AyLaL8fR8f3j68REwfccehFCIH55XfLkuJDOPjyGgasxscjN407DgsdbcAoytyu/bru5HHhojhzT7S/t+8mIfZUTq4pvQ4C6XKe8EirH8AVIX5QOjT5v9nLYj+Asj8Hw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758568217014185.2277049495417; Mon, 22 Sep 2025 12:10:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0lfi-0004fI-9O; Mon, 22 Sep 2025 14:53:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0lfT-0003ux-O4 for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:53:46 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v0lf9-0004xN-T5 for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:53:42 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-279e2554b6fso9432855ad.2 for ; Mon, 22 Sep 2025 11:53:20 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2698018a472sm138554795ad.58.2025.09.22.11.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 11:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758567199; x=1759171999; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TRMGkSahDRDIyhY1Pf+KcfrLPaCj+CJxCc4+NBDjs/c=; b=EXo+I5c5dou7oUmx/J32POv8Ej+lwIHgNq/lQsyBZwU2EElDu9udEUT5eFXoVoD9H9 CPSmZ0u2NSElDO3gcwZg8j8tnXatJyGsYA+EGSdgatTP4U4n49VztwYV5CwY0kvHC0Hy To30ggaYdlh15t85VqnJoqiBzch+lOZC7lXEdoHpmRsgiTNIF623hF+2CZ3DjMZP1UgG ltNaDlB3mPgNU7rRiyBQ8KxG5pocs9Wj8vMP6xEfYAwjjWVLpbuP1CDWZL2N3T/BQwx/ IZaoB12TMPWX4w6JVIYZp9BKGMVwAg2pkkRW63L8lKqnq7UhJQF+A3Di6Eo6Cc1w+0z3 /8cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758567199; x=1759171999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRMGkSahDRDIyhY1Pf+KcfrLPaCj+CJxCc4+NBDjs/c=; b=wy13fx88IHydDTQF/edZedGI/nNFk2wjgn+jmaJcuXou6B+7HYMztovqfKLSv7KGii leu4f/9vdVKdtiFjlZ5U5sJOKIH80ZADU+u6RkRiPiy8gxlhGlS/M/z2sTYPLbMuhIMJ ZV5X9ZtgKG0Vb8WkHzb/YPmRStmrge9iWmOZMjIIRAehxbgEdzLz60W74i8UoTQkaJN1 OM7ms4zPPub8l3NoYzOd7vl1PujBJAxbqPRsuhEzWye2wOSprWfv06XHbJCyiWqxUg+N BREsHfqNPpMjXUe/lWL0NQEJWfsMFjPpjvPkEk93AH95aQUe7S44W9Yq8C1fOYrCpdhk hsiA== X-Gm-Message-State: AOJu0YyLvvtye/AeN8D8P1fCP7q9vjNlqnYTzkZZuirJrKRG/W6Ievel CJTxYe/wxytTuRiOploXgW8jO3HccVgTV83MAg1a3A4lnwgKpA48A7AlAybp19wb6TzMhZuS0uw af5RA X-Gm-Gg: ASbGnctJ8hxQMUnXjbQGpIEBJAW1hEA/oSncx0CEN41TgMRelYuXY8ftsQcDFyCf4oh y+mOFm6wwKaB3WPn6Ty7pr/1dXqMvuLPrV7mOqV1J0Lvhe4k8HwHnlYeDLk7h7sEhvDh/NEFSDZ gitBrAUgax4bnIDE/JoqQ6ARLlg4g2HHIwv7mLTbP6Ex1MtwKR+wif7t8go9xMDtPQz+dw5wjUf lfLz9nQoMZIcPCAp19+Z1450WluIlyldLRAEx5o1d28PamY3GRXOrBGzHqcPywzW/OEZRNGNxwr e74nFf0TRAiYHj3JOl7Io/Lpu41DIcF47HwjfCuCExzF6Qr8/lcALvQDjo7Wmx3r/aGkniKVRPy 3GlRGFEFITWgaqQMgIAh4UWaW0F4EpcXHuCwnWW4= X-Google-Smtp-Source: AGHT+IExyq1klN3I6uzuB/YJNf++Vp8JA6G2zCD5/7hU3EOr4Brz+R0bFXwQK3i5cXT7IDyPOLHl1g== X-Received: by 2002:a17:902:ea02:b0:27b:472e:3a23 with SMTP id d9443c01a7336-27b472e3b6fmr29636145ad.14.1758567199079; Mon, 22 Sep 2025 11:53:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Pierrick Bouvier Subject: [PATCH v5 47/76] target/arm: Emit HSTR trap exception out of line Date: Mon, 22 Sep 2025 11:48:55 -0700 Message-ID: <20250922184924.2754205-48-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250922184924.2754205-1-richard.henderson@linaro.org> References: <20250922184924.2754205-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758568217596116600 Content-Type: text/plain; charset="utf-8" Use delay_exception_el to move the exception out of line. Use TCG_COND_TSTNE instead of separate AND+NE. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/tcg/translate.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index 78d26aac04..57bc8ea4c5 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -1774,21 +1774,11 @@ static void do_coproc_insn(DisasContext *s, int cpn= um, int is64, =20 if (maskbit !=3D 4 && maskbit !=3D 14) { /* T4 and T14 are RES0 so never cause traps */ - TCGv_i32 t; - DisasLabel over =3D gen_disas_label(s); + TCGLabel *fail =3D delay_exception_el(s, EXCP_UDEF, syndrome, = 2); + TCGv_i32 t =3D + load_cpu_offset(offsetoflow32(CPUARMState, cp15.hstr_el2)); =20 - t =3D load_cpu_offset(offsetoflow32(CPUARMState, cp15.hstr_el2= )); - tcg_gen_andi_i32(t, t, 1u << maskbit); - tcg_gen_brcondi_i32(TCG_COND_EQ, t, 0, over.label); - - gen_exception_insn_el(s, 0, EXCP_UDEF, syndrome, 2); - /* - * gen_exception_insn() will set is_jmp to DISAS_NORETURN, - * but since we're conditionally branching over it, we want - * to assume continue-to-next-instruction. - */ - s->base.is_jmp =3D DISAS_NEXT; - set_disas_label(s, over); + tcg_gen_brcondi_i32(TCG_COND_TSTNE, t, 1u << maskbit, fail); } } =20 --=20 2.43.0