From nobody Sun Sep 28 17:04:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758567102; cv=none; d=zohomail.com; s=zohoarc; b=nrEerHRkPwRrfPjrp35ntTyX4TvyixvGeI7UyZE1aFevKR141HTO30aSd/MO07fYx0QaBmx89MNjyKa4tBY1bynat+7dvstY3QgZSUZhLRpv1wP6ZYoMb6L/8Ke0ZBEz0+wapqwEHgFIhc3equRj/AFhXWWcBRePxFdhJTwuTtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758567102; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ePluHC0H/NP5Mr3iGwvDk85qezCPg64S4ISl6e9Zi/A=; b=aXl3WcTD+lzsBVRhAT2O/lBy8YzDgcqpH0GM9gfu415/qiEvT4G6f+d0uFKOquCkhY5Eeq2kcJ1Z9Yi8pPi56n92dirzwRyiIpxb5qU1PtQ6cBzwKiQiC/U6+pK7gfjbTFVwx67u552gHt0FTFanzzN9JvFe1I/W0KtoX50POJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758567102738477.0329626610354; Mon, 22 Sep 2025 11:51:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0lcq-0005hM-0G; Mon, 22 Sep 2025 14:51:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0lcD-00059v-Or for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:50:21 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v0lby-0004R8-SU for qemu-devel@nongnu.org; Mon, 22 Sep 2025 14:50:21 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-77f35113821so1180760b3a.0 for ; Mon, 22 Sep 2025 11:50:06 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77e5fe6de75sm10583861b3a.19.2025.09.22.11.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 11:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758567005; x=1759171805; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ePluHC0H/NP5Mr3iGwvDk85qezCPg64S4ISl6e9Zi/A=; b=e302XKQG3JBdA35jxSU00tuIHvF3OcwwGQR+KIIr+onwM3Eu3Fy05IfebnxnszQrAh IRz+Xo35R7kye+vCCWfos/WJJzQ9gH92E9Jtz+9MikwJFEpP5y40Z6pe/bv5gFu55nmQ GfgbH1W9bnEbi5w1iBNUl8CZ9Lv4FWRgtBZJ0dx8iruG/MlUc1xLHQVexp3Wm0Bl6j0F Dhe8h+3cyXgTsHkFoSHt2cNyEg2pwWqtVmoL8lCxTr6ZzNJw7wOfyk9wzf295JPOShew xjckfwzQYwmi5qAcz+KYWcBvQMn1bxALnGt0D3cyIe2ibmu/YL+Nn2wcz/yHBnxyo/SI VWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758567005; x=1759171805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ePluHC0H/NP5Mr3iGwvDk85qezCPg64S4ISl6e9Zi/A=; b=BKb0VOmLHXWZNRYQ5oGVwDP5RW1eBoPOcZoZWkWtLp/GSAvi73sSlXpPFG3zRwYJxL xrUAfltQLGaemLKiuKbKr++c7gFrrNv1WFp8wVad8JumnFVtBYydT6FlvEMvioOiQ86f NGZbwcr9EM7GZH8Kp3A7IB+9x6F2fIckhblplJwsuh4TcUx8CG+jjXyKKIsS6oiYGz9+ 1t1nF09abCo3X8Oe5IQH/fkF9g5BL116yuhfvmTIjLa5QWZJoP8F+HHx7Zqi00RPkRdv uZIyCts3MzCQqCTMA0QeWizhQZsHZs5l8svwvhiZr27BjAVCU6wvBLBIcpQ6iMuDVOU+ 2zOA== X-Gm-Message-State: AOJu0YwsX+X/CutOZNz5N56go4jLtIRM8qL8J+EWaEM2RK56RHj8CyHL Cj1mVS5u9MmW/NZQlIn0MfOxjFtIRSFrJxhgyeJ2v7AnGbQ7OUaU9jdeL3iEZ79tQMVGefvu++0 hXkZI X-Gm-Gg: ASbGncttW5rgPXj6KevzRt7VznCMBTaPwb2gM5EI3Lqz5jHZ/itHe0WinwmOxTKiuXt OJsYtX+9DHWlKGaqm5BEGRruEHUHTSGMzwEFSziNX+heGd7Kz0QiADsgiXA49Tr9lnbtKZNllcE Qhc+JKT+tMbc4r6iMKegC0XGPxbNHrDP62+Qv9mZHgCBUR/HcmbPcint/IRpQ/DyhEkdvmZP8uO Xwv/cWcaZjM2xAhj8n96b/YoKM/eaeLiwkDt3oIoqJ2XPljzhAiV4yhvXgEsoRV3gqTwSu1bBoE Lf++Gt/mZgOwenLPpziatCsc+RVswWp2l8nlVkrQOBSqfZwWT9bCpdYa7imqniZcBEst/tyHwDz q6C7hMO9OxYQS+YH37/ZlLDUg4MZk X-Google-Smtp-Source: AGHT+IGznF8vcVQNXZl4n9D3ByK1OCWQV3jQPV9q8x3fqNxGF0QHJqlcnKvu+5n4I0uMT/aiD2DANg== X-Received: by 2002:a05:6a00:1887:b0:77f:1a7e:7bc0 with SMTP id d2e1a72fcca58-77f1a7e85b8mr10602472b3a.31.1758567005232; Mon, 22 Sep 2025 11:50:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Pierrick Bouvier Subject: [PATCH v5 32/76] target/arm: Support page protections for GCS mmu indexes Date: Mon, 22 Sep 2025 11:48:40 -0700 Message-ID: <20250922184924.2754205-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250922184924.2754205-1-richard.henderson@linaro.org> References: <20250922184924.2754205-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758567105211116600 Content-Type: text/plain; charset="utf-8" Take read and write from the s1perms.gcs bit computed by the Arm pseudocode. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/ptw.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 16ca2b6187..bfa0aeb4c0 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -1583,12 +1583,16 @@ static int get_S1prot_indirect(CPUARMState *env, S1= Translate *ptw, } } =20 - if (perm & PAGE_WXN) { + if (regime_is_gcs(mmu_idx)) { + /* + * Note that the one s1perms.gcs bit controls both read and write + * access via AccessType_GCS. See AArch64.S1CheckPermissions. + */ + perm =3D (perm & PAGE_GCS ? PAGE_READ | PAGE_WRITE : 0); + } else if (perm & PAGE_WXN) { perm &=3D ~PAGE_EXEC; } =20 - /* TODO: FEAT_GCS */ - return perm & PAGE_RWX; } =20 @@ -2241,6 +2245,13 @@ static bool get_phys_addr_lpae(CPUARMState *env, S1T= ranslate *ptw, */ prot =3D get_S1prot_indirect(env, ptw, mmu_idx, pi, po, result->f.attrs.space, out_space); + } else if (regime_is_gcs(mmu_idx)) { + /* + * While one must use indirect permissions to successfully + * use GCS instructions, AArch64.S1DirectBasePermissions + * faithfully supplies s1perms.gcs =3D 0, Just In Case. + */ + prot =3D 0; } else { int xn =3D extract64(attrs, 54, 1); int pxn =3D extract64(attrs, 53, 1); --=20 2.43.0