From nobody Sun Sep 28 16:36:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758534323; cv=none; d=zohomail.com; s=zohoarc; b=YV/QVwav4nKCrkCKLMgZv/JpDiNQ0OHw3SE997Qv0kZ13r6a272TdVL9NMWvtL9LP8VVgUBlZ8zfoijbXK6HUZIjiUiiISXRxr3xz6w2t9GKE79+eOfJ9Gw+MhCaLKGrxz9rtvgfcKl2psTZmRS9YQcA3d7atbQjhI5GxclE8TQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758534323; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xka3pneMH2qFxqRVxyDw79VsTx+gMXoNji+Y4GSMTqs=; b=m5AUgdFPrFM9tLaxE0QXSuCOliW+Yx7gWxBNDbOfun7XGU0hQXESKoPGmcd1kXEFP1Oj0XPJOC3FT5R45yWP98qISFdlpZyZdSIuo8bAQj6SVQHXlH5DovR7/r3dJcDXvjvTDvrf0ociAIuzCBog1EY5EMKPnoUUBgKM3VV0tYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175853432389817.266728550986613; Mon, 22 Sep 2025 02:45:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0d6B-000708-WC; Mon, 22 Sep 2025 05:44:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0d5W-0005id-M0 for qemu-devel@nongnu.org; Mon, 22 Sep 2025 05:44:08 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v0d4p-00020P-6d for qemu-devel@nongnu.org; Mon, 22 Sep 2025 05:43:49 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3b9edf4cf6cso3582871f8f.3 for ; Mon, 22 Sep 2025 02:43:18 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464eadd7e11sm205573335e9.0.2025.09.22.02.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 02:43:14 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B93785FA5C; Mon, 22 Sep 2025 10:37:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758534196; x=1759138996; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xka3pneMH2qFxqRVxyDw79VsTx+gMXoNji+Y4GSMTqs=; b=tEyTOQfbIqxEBM68XpojlbCSsx5xe383/w1q5GxhNL1kmVFswctE1z/JUYMuuyl8HA PovVGMNtb9evrn4TVV2YvPsZPkjXQNvKVR9RaTlOGheaV87mWa+hY+dFpGgXI+jCpusV bZlb0YDqO7EL7ZvTXKc3fdYi+hDCzwkjUbI5uuBU/dt0SJ/Bvy8DJyTVdJY8nLd+t6iw /vTbmIAIXujUuN5bNKOkT8fgLilygFAkOUgBPs7dH7dy+t/KIWrt96MYTVOlayfRj2F0 /RCWSDKLzUFHr6FCTVTwWQeoLfo4FMiyumcD4QB/IjxQ6uhXvfYrsl0K8UJmvO2WFABg SMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758534196; x=1759138996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xka3pneMH2qFxqRVxyDw79VsTx+gMXoNji+Y4GSMTqs=; b=oLzjDDX3ZaEhuF0gItLhuGisg+3wAQpppWuDabzwkaZ4OpJPJO+HuN5u6v8OBa7BBn LTHyYEfcZQcU+ifWFSg7g6ji+lsYm/VPihFA5sxqSXwPnvTxHbjb/VQJPggmtdQ+MEOa 6dBtrVzWR1mpkPJVRV+nXtgsV/HgvZCbTzGWymGzvP1AS40gSGKoUifYMwhfl8HypUor X/kEdt4shVyf0rrWNhWsQFlnkdN2g4S2uUO/LJ84/te2gXJ4gxH54w/Um/XI2p+tM5Vf 1MFK/w7ILGJ3aNwC/r1236p9pP4XR0Hu1f3f3Cr/LsVJ/aowrzLgDWOXhz077Dro2mxc 5S9g== X-Gm-Message-State: AOJu0Yw7nAVipP9FcS8lCbuxpY7fJss0Xpc1+SgJ0fAvc3WdETUG2wuV KJ4tMAKyZCUSOkRxV6BC2xtNKFqBGsYxCcr66t85xhP9y25mSLSlThhNYM/XNPs9TAo= X-Gm-Gg: ASbGncsv7v3QLVDu50j324pITc/HmeiZKtsEPaO+fXDF/BQj5bqgueJpb3jrNkrVtu3 RJiaMK9bV37E1NJq0x3XHjKwiabVPMk548NM0SZEHJnlLlmteYP+BbwwgF/eJhIrQ5lDlmZpNCH fPWeGKd4GtBcMetdkPYvyMRtsuIRqQ3EO71AZNylAjKCwQiawEYzXgL0tOowb1tj273zqFR+dUf 5K5bogoYamePcvdFRfWxt1Vos7tyZVzLBZcYF6FTPsVFe0NS4eG/REf61h+SrDmkrqzp9E2tW07 MNwViKNWSruo9rloXEf484mQYaP3VIbi7x4DRrsuDWiY8O1ZVa/MatFSfQ0nVAJ/XsADeDRmR+4 86/fV378CSsfbTTxRCq0k0J8= X-Google-Smtp-Source: AGHT+IF9euK6P/jVSKmTMYqDnTu7Pa+8D/t3miko6mM1UHE+U/WgS/i4aGQZMAkNCSbkFIvJ9QqFQw== X-Received: by 2002:a5d:5d0b:0:b0:400:c7c0:52af with SMTP id ffacd0b85a97d-400c7c052d6mr1177801f8f.1.1758534195638; Mon, 22 Sep 2025 02:43:15 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alexandre Iooss , Mahmoud Mandour , qemu-riscv@nongnu.org, Daniel Henrique Barboza , Thomas Huth , Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Weiwei Li , Pierrick Bouvier , Liu Zhiwei , Manos Pitsidianakis Subject: [PATCH 23/25] contrib/plugins/uftrace: implement x64 support Date: Mon, 22 Sep 2025 10:37:08 +0100 Message-ID: <20250922093711.2768983-24-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250922093711.2768983-1-alex.bennee@linaro.org> References: <20250922093711.2768983-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758534325622116600 From: Pierrick Bouvier It's trivial to implement x64 support, as it's the same stack layout as aarch64. Reviewed-by: Manos Pitsidianakis Signed-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-8-pierrick.bouvier@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- contrib/plugins/uftrace.c | 86 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 86 insertions(+) diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index 2386cc723bc..b7d6124d2f5 100644 --- a/contrib/plugins/uftrace.c +++ b/contrib/plugins/uftrace.c @@ -82,6 +82,21 @@ typedef struct { struct qemu_plugin_register *reg_scr_el3; } Aarch64Cpu; =20 +typedef enum { + X64_RING0, + X64_RING1, + X64_RING2, + X64_RING3, + X64_REAL_MODE, + X64_PRIVILEGE_LEVEL_MAX, +} X64PrivilegeLevel; + +typedef struct { + struct qemu_plugin_register *reg_rbp; + struct qemu_plugin_register *reg_cs; + struct qemu_plugin_register *reg_cr0; +} X64Cpu; + typedef struct { uint64_t timestamp; uint64_t data; @@ -570,6 +585,75 @@ static CpuOps aarch64_ops =3D { .does_insn_modify_frame_pointer =3D aarch64_does_insn_modify_frame_poi= nter, }; =20 +static uint8_t x64_num_privilege_levels(void) +{ + return X64_PRIVILEGE_LEVEL_MAX; +} + +static const char *x64_get_privilege_level_name(uint8_t pl) +{ + switch (pl) { + case X64_RING0: return "Ring0"; + case X64_RING1: return "Ring1"; + case X64_RING2: return "Ring2"; + case X64_RING3: return "Ring3"; + case X64_REAL_MODE: return "RealMode"; + default: + g_assert_not_reached(); + } +} + +static uint8_t x64_get_privilege_level(Cpu *cpu_) +{ + X64Cpu *cpu =3D cpu_->arch; + uint64_t cr0 =3D cpu_read_register64(cpu_, cpu->reg_cr0); + uint64_t protected_mode =3D (cr0 >> 0) & 0b1; + if (!protected_mode) { + return X64_REAL_MODE; + } + uint32_t cs =3D cpu_read_register32(cpu_, cpu->reg_cs); + uint32_t ring_level =3D (cs >> 0) & 0b11; + return ring_level; +} + +static uint64_t x64_get_frame_pointer(Cpu *cpu_) +{ + X64Cpu *cpu =3D cpu_->arch; + return cpu_read_register64(cpu_, cpu->reg_rbp); +} + +static void x64_init(Cpu *cpu_) +{ + X64Cpu *cpu =3D g_new0(X64Cpu, 1); + cpu_->arch =3D cpu; + cpu->reg_rbp =3D plugin_find_register("rbp"); + g_assert(cpu->reg_rbp); + cpu->reg_cs =3D plugin_find_register("cs"); + g_assert(cpu->reg_cs); + cpu->reg_cr0 =3D plugin_find_register("cr0"); + g_assert(cpu->reg_cr0); +} + +static void x64_end(Cpu *cpu) +{ + g_free(cpu->arch); +} + +static bool x64_does_insn_modify_frame_pointer(const char *disas) +{ + return strstr(disas, "rbp"); +} + +static CpuOps x64_ops =3D { + .init =3D x64_init, + .end =3D x64_end, + .get_frame_pointer =3D x64_get_frame_pointer, + .get_privilege_level =3D x64_get_privilege_level, + .num_privilege_levels =3D x64_num_privilege_levels, + .get_privilege_level_name =3D x64_get_privilege_level_name, + .does_insn_modify_frame_pointer =3D x64_does_insn_modify_frame_pointer, +}; + static void track_privilege_change(unsigned int cpu_index, void *udata) { Cpu *cpu =3D qemu_plugin_scoreboard_find(score, cpu_index); @@ -777,6 +861,8 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_= id_t id, =20 if (!strcmp(info->target_name, "aarch64")) { arch_ops =3D aarch64_ops; + } else if (!strcmp(info->target_name, "x86_64")) { + arch_ops =3D x64_ops; } else { fprintf(stderr, "plugin uftrace: %s target is not supported\n", info->target_name); --=20 2.47.3