From nobody Sun Sep 28 16:32:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1758412111; cv=none; d=zohomail.com; s=zohoarc; b=d+Uo68rmYJG21vL5nmNeW/NxsAEbwC86RrNg3LHb9ldXM3/Mf/+j4GnPLmqKHZCRVEXzgqua1H7UcerfMYD/FZu916WoW7qFKKVG8WC455hKSuwbstmpRaLY9PBqdiy1VCCYuWIFGM8WMYcIyy//N8/H5J93XEBZGN/Vzx516VM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758412111; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HYx7pMoLMlA55eAoyUpvv6FTZmSkAyUPk75Kdc+JD+M=; b=KGAxlcGMZsCh9A32xU/G/i4oKXAjaZahx/gU+FOxlXBYGwrT6fTG4vHJy9gxzK9fLsy24ESB225vRlu6xZPghUB9WEIT3Dp8HDIdBf4MLrePbgTOUxQ4wL4oQdBiqqcxpPgKB3SWSbUupn3Z7ARLzMCcliZGSqZh3n2KJ8nWagY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758412111301833.0285714028679; Sat, 20 Sep 2025 16:48:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v07Hf-0004zx-Cl; Sat, 20 Sep 2025 19:46:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v07HW-0004e6-Uj for qemu-devel@nongnu.org; Sat, 20 Sep 2025 19:46:19 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v07HT-0006fn-EB for qemu-devel@nongnu.org; Sat, 20 Sep 2025 19:46:17 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3fa528f127fso110153f8f.1 for ; Sat, 20 Sep 2025 16:46:15 -0700 (PDT) Received: from localhost (mem-185.47.220.165.jmnet.cz. [185.47.220.165]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3f0e28c83d6sm7956363f8f.56.2025.09.20.16.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Sep 2025 16:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758411974; x=1759016774; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HYx7pMoLMlA55eAoyUpvv6FTZmSkAyUPk75Kdc+JD+M=; b=ipltAab5kBo4VDABpIUVJEutnIVIiRSb1Bo0ippQGb8e2ODryUlAa+6FMSlwV3+H34 6uVb/LPfGv101PptELFiwqmDGz05katpjL27DF9pDc0/7/Z2eQqQ0RBVm6VDDPE9RrWQ LR8ZHaDcly2+ZW0S8sEEyVu/ErjD4Mgbn5EVPjcOVMNkKwqdRSDZAm3DjtI7c/zC3+ww lX3WlsIoVkxMZFMhLpGjF3kDBD9AeqsGbEXaUZvmexzfC7iMII/xp/CkMgTlCnrl33Um 6C3vAgjdZ58himeJ5T7NAOPdQkc7S0+OgUlKq7ATgnvL4o6m3Yt8pN0pa9bN7blSE7xW mxXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758411974; x=1759016774; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HYx7pMoLMlA55eAoyUpvv6FTZmSkAyUPk75Kdc+JD+M=; b=PoPvwiVmT76nqAjCRFnRaGnViI81GN9L8+B2r8SrNjLUOzfhD0T9S5+cvV8h1mlLUE 8Ebgg+0j/s0SrGVmsrr9emFZRFi1+8/YCwzMmjCrvfxtP1DZvSCFUxMFY3uRCiizpt/J RidsThHRB6l2QRRLV7OjmfETlNHXs13qzRhw9fPjTq/2YoZkbiEDGdbnvBnEXP5y49+d U1owu8sZgQv/2lFDMLfW9kSCDqvRiNETJQHGQqsRfBRvDynqLKqviIJ2px71AmLQsxPC d0CnucTEW4eF+A5nJauEfvmhrfY9i8Miffnnjom7k6PhmKkkLVRdR00fKOvTx8JQ55RR D4cg== X-Gm-Message-State: AOJu0YyVT4kBGJckopwLEHq52hiX4gvdWNZgNlKGCVSG96EQMCN+BEqQ XR5949ZWyh6brs4q3EUxEg20D5FdrFTJpjEmpiJvCaX1NFsv1aU7kajQ X-Gm-Gg: ASbGncuYIx7TFtdkU6JCjYKMnxSRmV74tPEB7DByKVAqO/GYKX6uRcoathJHPQs9Zqk aBhSbktxdBQoknTlla+RBduB68SP82MWvdM9OaWd/hdsEVk13cpOtd1d6xtVIdeLQ57kzzJQugb Bp/UXV18/EOW86BbbbaGNeFXt/h5ywydqR1iPsGRgHrSjnxKByjOxa/varNwDEgoeDy+BWKypnO isf1XMQQwrEITK0c/BvmnuqtNjX+v2LiwsTnd792Ty2Wa9ro5mdzwgXjxtIPC4gEFUrw7LuI/tZ sbJoxqzVY6SdbqmVhLmis8yNZ+jLJ1EYokI3HwuYy8To2MANMfXhGfufEXDMNep6PTuDjDvmpRt jXAKwpw1X0jyiUoHZ0xaBX28Ybna2sGtacgiH7KrVxfG3Z0EnOXrP X-Google-Smtp-Source: AGHT+IGPN4r096oi637NfyZhf47t4mGi0x+7iHiXoyRm6ajNwJPkPpCEkGY7RArCZJqr5zUqE+jJZg== X-Received: by 2002:a05:6000:420d:b0:3e9:d9bd:504f with SMTP id ffacd0b85a97d-3ee1acd872cmr9166383f8f.21.1758411973716; Sat, 20 Sep 2025 16:46:13 -0700 (PDT) From: Filip Hejsek Date: Sun, 21 Sep 2025 01:45:36 +0200 Subject: [PATCH RFC v5 06/12] char-stdio: add support for the terminal size MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250921-console-resize-v5-6-89e3c6727060@gmail.com> References: <20250921-console-resize-v5-0-89e3c6727060@gmail.com> In-Reply-To: <20250921-console-resize-v5-0-89e3c6727060@gmail.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , "Michael S. Tsirkin" , Laurent Vivier , Amit Shah , Markus Armbruster , Eric Blake , Eduardo Habkost , Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Maximilian Immanuel Brandtner , Szymon Lukasz , Filip Hejsek X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758411962; l=2562; i=filip.hejsek@gmail.com; s=20250912; h=from:subject:message-id; bh=V63fftPmCKW7OIY7EbGz9LcdIQD/m0AHLknnEXYwd4g=; b=eSEs/mTzvYQHHmv7A6IM68Xu+N/P5wwB7eAsjpJXFkUmdteOu+Om8kOWKKOi2dgnfeO2XKDC/ n+qZgHSBnxYAbNWJKCFTbnwXdkg52cJ/zJlhUYI6wn1a+WqXJ8XKTao X-Developer-Key: i=filip.hejsek@gmail.com; a=ed25519; pk=nakB8gEK3oi+Q/5dBTMCy/LgZL47NP60z1jeDR6O/WU= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=filip.hejsek@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1758412111622116600 From: Szymon Lukasz Update the terminal size upon SIGWINCH delivery. Signed-off-by: Szymon Lukasz [Filip: use DECLARE_INSTANCE_CHECKER] Signed-off-by: Filip Hejsek Reviewed-by: Daniel P. Berrang=C3=A9 --- chardev/char-stdio.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/chardev/char-stdio.c b/chardev/char-stdio.c index 48db8d2f30fcf0b481c79ea69aab720454596a05..b3475391f088f1e570b74cc40e3= 0f679dbe9b574 100644 --- a/chardev/char-stdio.c +++ b/chardev/char-stdio.c @@ -34,7 +34,9 @@ #include "chardev/char-win-stdio.h" #else #include +#include #include "chardev/char-fd.h" +#include "qemu/main-loop.h" #endif =20 #ifndef _WIN32 @@ -46,6 +48,14 @@ static bool stdio_in_use; static bool stdio_allow_signal; static bool stdio_echo_state; =20 +typedef struct { + FDChardev parent; + Notifier resize_notifier; +} StdioChardev; + +DECLARE_INSTANCE_CHECKER(StdioChardev, STDIO_CHARDEV, + TYPE_CHARDEV_STDIO) + static void term_exit(void) { if (stdio_in_use) { @@ -85,11 +95,26 @@ static void term_stdio_handler(int sig) qemu_chr_set_echo_stdio(NULL, stdio_echo_state); } =20 +static void qemu_chr_resize_stdio(Chardev *chr) +{ + struct winsize ws; + if (ioctl(1, TIOCGWINSZ, &ws) !=3D -1) { + qemu_chr_resize(chr, ws.ws_col, ws.ws_row); + } +} + +static void term_resize_notify(Notifier *n, void *data) +{ + StdioChardev *s =3D container_of(n, StdioChardev, resize_notifier); + qemu_chr_resize_stdio(CHARDEV(s)); +} + static void qemu_chr_open_stdio(Chardev *chr, ChardevBackend *backend, bool *be_opened, Error **errp) { + StdioChardev *s =3D STDIO_CHARDEV(chr); ChardevStdio *opts =3D backend->u.stdio.data; struct sigaction act; =20 @@ -121,6 +146,10 @@ static void qemu_chr_open_stdio(Chardev *chr, =20 stdio_allow_signal =3D !opts->has_signal || opts->signal; qemu_chr_set_echo_stdio(chr, false); + + qemu_chr_resize_stdio(chr); + s->resize_notifier.notify =3D term_resize_notify; + sigwinch_add_notifier(&s->resize_notifier); } #endif =20 @@ -160,6 +189,7 @@ static const TypeInfo char_stdio_type_info =3D { .parent =3D TYPE_CHARDEV_WIN_STDIO, #else .parent =3D TYPE_CHARDEV_FD, + .instance_size =3D sizeof(StdioChardev), #endif .instance_finalize =3D char_stdio_finalize, .class_init =3D char_stdio_class_init, --=20 2.51.0