From nobody Sun Sep 28 16:34:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1758383152; cv=none; d=zohomail.com; s=zohoarc; b=bbdVbJ7HAcaKejtQ326HtaXBx3X9un+R1UOVsJ5MkxOtI5pFSKPXe9lc0RbrEEHYdUFkUdN0CcgRR5nYIrl91L5uIWLpdq/OcBUN5Zjn8WCpqTmUgHoNC81nRs5coasnryTqKI9MZ3EQglaQWVTCrzNA0er7K0VnNoxnsjS7YJI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758383152; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qL8cjH8+hA0sJFG681yjWWNua6EqSDIkVZ6P+AkvHLU=; b=Du/DzMP82CzQ1lnZbICk2DSXdKDVKHUHzEndy9CTB5K8DwRMzfhFM9IIurMXvpIGQUunrHo6DEPi3uBbCGEa7o7XeosXQ/iTUr9iXBtbqw9kvI6KhaCNcc+5C/jUC3OJQn93zUlW+7meOsPKbtU+vRmz9RAmG+2j+PsqXIVUHxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758383152895180.9638301297514; Sat, 20 Sep 2025 08:45:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzzkn-0007zs-Ib; Sat, 20 Sep 2025 11:44:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzzke-0007va-UX; Sat, 20 Sep 2025 11:43:54 -0400 Received: from mgamail.intel.com ([198.175.65.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzzkb-0001zC-Hc; Sat, 20 Sep 2025 11:43:50 -0400 Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2025 08:43:44 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by fmviesa004.fm.intel.com with ESMTP; 20 Sep 2025 08:43:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758383030; x=1789919030; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e2m8PPZayoxqwvYik36u1YFgyjvQ2yQsYIRZWJ/B+oc=; b=ZGUmHXvIELot7WBiaJ5EttDbZz/gxyI/G2N0iy7OcjY1ZkmrMtQizpmj dkOBkXikB+Xza7LNN9KH3Uk/ecMyWSNYxCTrLs58jJkyLbpj68vxzq898 AXY7wMME8TXh0bxy+PRjOwA10wTAiTnw+qvwVu9p3a63z9wS8/7HqLvGO Fj/uk5sYRa1pCy1ivgg1tCjRM1qzJonq9H3Pwj+0ofAkonjWiXXjKoLGD UF4AA/gbHFpU+9LSJLg9XHVi5wHme104SP3GMCESqBf+Vuh8mXvYgBMn+ it7aind9ZLmFhu7DZX0q1vUgPFOCATBPWqg8XJPkrRFXjmSJ6W4mCFO4H w==; X-CSE-ConnectionGUID: WxP2DggDSnilSN42Za8ujw== X-CSE-MsgGUID: 14InECDLSaWG8UgJf98F5Q== X-IronPort-AV: E=McAfee;i="6800,10657,11559"; a="70955509" X-IronPort-AV: E=Sophos;i="6.18,281,1751266800"; d="scan'208";a="70955509" X-CSE-ConnectionGUID: tf4WPbhGT2io0nZ715Y6CQ== X-CSE-MsgGUID: KBXVuPVlSW+cXm450W2Wvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,281,1751266800"; d="scan'208";a="181349441" From: Zhao Liu To: Paolo Bonzini , Manos Pitsidianakis Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, Zhao Liu Subject: [PATCH v2 03/12] rust/qemu-macros: Fix Clippy's complaints about lambda parameter naming Date: Sun, 21 Sep 2025 00:05:11 +0800 Message-Id: <20250920160520.3699591-4-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250920160520.3699591-1-zhao1.liu@intel.com> References: <20250920160520.3699591-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.11; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.045, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1758383154088116600 Content-Type: text/plain; charset="utf-8" error: `rename` shadows a previous, unrelated binding --> qemu-macros/src/lib.rs:265:14 | 265 | |rename| -> Result { | ^^^^^^ | note: previous binding is here --> qemu-macros/src/lib.rs:245:30 | 245 | let DeviceProperty { rename, defval } =3D prop; | ^^^^^^ =3D help: for further information visit https://rust-lang.github.io/rus= t-clippy/master/index.html#shadow_unrelated =3D note: requested on the command line with `-D clippy::shadow-unrelat= ed` Rename the lambda parameter to "prop_rename" to fix the above clippy error. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu --- rust/qemu-macros/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs index 8151fb6d4e1e..ed2b997b24a4 100644 --- a/rust/qemu-macros/src/lib.rs +++ b/rust/qemu-macros/src/lib.rs @@ -246,8 +246,8 @@ macro_rules! str_to_c_str { =20 let prop_name =3D rename.map_or_else( || str_to_c_str!(field_name.to_string(), field_name.span()), - |rename| -> Result { - match rename { + |prop_rename| -> Result { + match prop_rename { DevicePropertyName::CStr(cstr_lit) =3D> Ok(quote! { #c= str_lit }), DevicePropertyName::Str(str_lit) =3D> { str_to_c_str!(str_lit.value(), str_lit.span()) --=20 2.34.1