From nobody Sun Sep 28 16:34:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1758383091; cv=none; d=zohomail.com; s=zohoarc; b=F7uf/j5pu2SBbLJK/w73Maty8bGIBHyQy+dtvbzzUpiCrZXot7S6w06VEwOSmA+HeYdLaFkbJodGXSt1oA/nSjvl8hyOWk0AfCpbmkAiZrkGZJNO5eTElR8+nb5a/1HJWzAxFx+YTdTnBaXodHUkAihkRKQYme+sKJUBqo66bVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758383091; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7J0BkQcmV1V7SMmiN42CpFg+JqAagVcmaSiTHYZJUkM=; b=Z/9JphdsNWmlJM2LtbLkTCmOV8ABxItrm2fABMB9ReVof1krJIjX9dh0aMjtM5NDgZDgixS/G6ROSUUdpxJMQ+/+IcnaG+7PxJMZB4yRtNFLhfUYFzEgT/9P1xbhFoZ6yThJhjiRJWxGH5EnHco2Fx68Ds/ij3D6N2uVEdYTvNI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175838309194952.019976983723495; Sat, 20 Sep 2025 08:44:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzzlF-00086j-8f; Sat, 20 Sep 2025 11:44:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzzl7-00085a-MU; Sat, 20 Sep 2025 11:44:21 -0400 Received: from mgamail.intel.com ([198.175.65.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzzl6-0001zT-4A; Sat, 20 Sep 2025 11:44:21 -0400 Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2025 08:43:58 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by fmviesa004.fm.intel.com with ESMTP; 20 Sep 2025 08:43:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758383061; x=1789919061; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L8gnmi+J4MzRrbiFkXtGqJm6GBBwWXfcXWg3n8slJpE=; b=NRlQdUs4wUSIVH/GK9Wu0NQ/AjIH2Hk5wYZPiynWt23nXEeXFov/gq2z p/sVmKz94ctpf2fysSZSRBNB+xwC3n13kflcad5M3CUyJdd9pAxgu2XlG udobLbNamBVeruNOcT6IjEFXCi3V+S9Fo9bvXKj2Wlu6iAyzVcLoaB0Hb TNpzctTlJDn9Yl1RV+Y2z1kt/ejpKhjnJosDlqiCL4IjthOPKVBr7gVcB VKC7Cr+jIXPpRJYF3NmmdppjdbOqqVeSuERjp6HbxNxqDs+krCtTkdQCW G/u37oSxaNdPqtkcvQsro435pLQ0o6LKGn3P9C2cjUeEVsq3cavBJBv2y w==; X-CSE-ConnectionGUID: HdAnyg9qR9yoRlUW6DvyfQ== X-CSE-MsgGUID: /iF6uqb2QzGtalYIOsB9qA== X-IronPort-AV: E=McAfee;i="6800,10657,11559"; a="70955579" X-IronPort-AV: E=Sophos;i="6.18,281,1751266800"; d="scan'208";a="70955579" X-CSE-ConnectionGUID: zBAUwL6vTbyJ0gic2vC3vw== X-CSE-MsgGUID: C6lN+5phRnG4vu/Xt5AHLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,281,1751266800"; d="scan'208";a="181349494" From: Zhao Liu To: Paolo Bonzini , Manos Pitsidianakis Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, Zhao Liu Subject: [PATCH v2 12/12] rust/qdev: Drop declare_properties & define_property macros Date: Sun, 21 Sep 2025 00:05:20 +0800 Message-Id: <20250920160520.3699591-13-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250920160520.3699591-1-zhao1.liu@intel.com> References: <20250920160520.3699591-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.11; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.045, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1758383093648116600 Content-Type: text/plain; charset="utf-8" After HPET's #property conversion, there's no use case for declare_properties & define_property. So get rid of them for now. In future, if there's something that #property really cannot resolve, they can be brought back. Reviewed-by: Manos Pitsidianakis Signed-off-by: Zhao Liu --- rust/hw/core/src/qdev.rs | 53 ---------------------------------------- 1 file changed, 53 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 5cc8a35d1ab0..c3097a284d73 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -248,59 +248,6 @@ pub fn class_init(&mut self) { } } =20 -#[macro_export] -macro_rules! define_property { - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty, bit =3D $b= itnr:expr, default =3D $defval:expr$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - bitnr: $bitnr, - set_default: true, - defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval = as u64 }, - ..::common::zeroable::Zeroable::ZERO - } - }; - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty, default = =3D $defval:expr$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - set_default: true, - defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval = as u64 }, - ..::common::zeroable::Zeroable::ZERO - } - }; - ($name:expr, $state:ty, $field:ident, $prop:expr, $type:ty$(,)*) =3D> { - $crate::bindings::Property { - // use associated function syntax for type checking - name: ::std::ffi::CStr::as_ptr($name), - info: $prop, - offset: ::std::mem::offset_of!($state, $field) as isize, - set_default: false, - ..::common::zeroable::Zeroable::ZERO - } - }; -} - -#[macro_export] -macro_rules! declare_properties { - ($ident:ident, $($prop:expr),*$(,)*) =3D> { - pub static $ident: [$crate::bindings::Property; { - let mut len =3D 0; - $({ - _ =3D stringify!($prop); - len +=3D 1; - })* - len - }] =3D [ - $($prop),*, - ]; - }; -} - unsafe impl ObjectType for DeviceState { type Class =3D DeviceClass; const TYPE_NAME: &'static CStr =3D --=20 2.34.1