From nobody Sun Sep 28 16:35:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1758276018; cv=none; d=zohomail.com; s=zohoarc; b=mIG4vKhX371QUJnWDz7z4ZeZBmzCgh8FtnIYwefkIpSVM43gHwh/EHeIqCAzjjRt+A837VGVfde+PteBEgYEbrldsnf5NZtRDqG1S12+pUkFIdFXbtw5wW72jwbdr6gYbv2vQbEFGhtTQzXf02A0IzUlT8N7lxX96v2K9Sh2ZuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758276018; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2Br9SnRNFti6c0drviITVAgb0JbgHHv09a0Qx40m5tQ=; b=BvkoXLm95pRrHTPXvNQN5yoFThua0vxDvKkhyKUKwjXHEWAQjWwFNGGhmvFd+uIZJE8uXwGKI7XqV9QeFOgjtI+qVxoIueCQbGN642NLHgaFeXzvatihIJrH3ft4Kmhagi3kQFaPdZJbHs66RmiExuFB39HGN8e5fNQJ6fIJ7kE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758276018388608.6093232593845; Fri, 19 Sep 2025 03:00:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzXr4-0006E1-0G; Fri, 19 Sep 2025 05:56:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzXqc-0005hL-18 for qemu-devel@nongnu.org; Fri, 19 Sep 2025 05:56:11 -0400 Received: from forwardcorp1d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzXqY-0004bN-9y for qemu-devel@nongnu.org; Fri, 19 Sep 2025 05:56:09 -0400 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1621:0:640:12d9:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 0CB5B80EB1; Fri, 19 Sep 2025 12:56:00 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:a72::1:38]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id ntP1fK1GvGk0-y00Yv60n; Fri, 19 Sep 2025 12:55:59 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1758275759; bh=2Br9SnRNFti6c0drviITVAgb0JbgHHv09a0Qx40m5tQ=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=dgT9o8rQmOO0yP/TwrMXGlFsiDygA2qLDme7ULWQ6L4ZfoAxTNmCPAL3W2CkqgCBn 64Ivoh14/MuiPwVF2xuibaWJCQDeB6D3mw/ZcqBflt72pyCLUC1+lHykcAO5aR2qHS LSp9BrqmBZFb3WSkY01pFoaMge2/14/zlXY1+6iE= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: mst@redhat.com Cc: qemu-devel@nongnu.org, philmd@linaro.org, thuth@redhat.com, eblake@redhat.com, michael.roth@amd.com, armbru@redhat.com, farosas@suse.de, peterx@redhat.com, berrange@redhat.com, jasowang@redhat.com, steven.sistare@oracle.com, leiyang@redhat.com, davydov-max@yandex-team.ru, yc-core@yandex-team.ru, Vladimir Sementsov-Ogievskiy Subject: [PATCH v5 12/19] net/tap: use net_tap_setup() in net_init_bridge() Date: Fri, 19 Sep 2025 12:55:38 +0300 Message-ID: <20250919095545.1912042-13-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250919095545.1912042-1-vsementsov@yandex-team.ru> References: <20250919095545.1912042-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1758276019749116600 Content-Type: text/plain; charset="utf-8" Finalize the concept of pair net_tap_new() + net_tap_setup(). Now, the only extra part for bridge in net_tap_setup() is initializing vhost_net, but it's under if (s->vhostfd !=3D -1), we never come into it for bridge case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index b7175e4b10..4ca3cc75d8 100644 --- a/net/tap.c +++ b/net/tap.c @@ -697,7 +697,7 @@ int net_init_bridge(const Netdev *netdev, const char *n= ame, } =20 s =3D net_tap_new(peer, "bridge", name, NULL, NULL, &error_abort); - net_tap_set_fd(s, fd, vnet_hdr, &error_abort); + net_tap_setup(s, fd, vnet_hdr, &error_abort); =20 qemu_set_info_str(&s->nc, "helper=3D%s,br=3D%s", helper, br); =20 --=20 2.48.1