From nobody Sun Sep 28 17:05:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1758040350; cv=none; d=zohomail.com; s=zohoarc; b=Shtp4885nvVpxkRwvxMVwTfagXiMB5FBIgeHlyXLNhCqEkojJEgT/6e5iolDUmRClTBs5fFE5hQFjRDCPWlsDDnsY4JrExx48VCCbYJmOA1f23zb8IV6p1dhIs4/1SCzaW9+mQQXBcvSq9gFWSK0a2e2If33VWkglFSF6GIueYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758040350; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B1wV+2F5KNU3mIM7GIxs37jfPasDNnuYiomuDixjfDM=; b=jE2SCVWSCMiKmPokK1ba8adFWiu9VKjZ+vMkSMC3A5LtNmJmnBqOGGW0z1kPHKcXx3WoP3ZcnxKVuouU2vSF6N3m/v9ksJlVCSJ4QpoN9ZgaxmkcSAcZep5lYn+tJpIGjjWydiIC+X0R0cdIKNW2fdT5AvyAA27ZFwwobYpupvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758040350651940.5168025190512; Tue, 16 Sep 2025 09:32:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uyYTy-0003gi-MY; Tue, 16 Sep 2025 12:24:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyYTm-0003cN-RR for qemu-devel@nongnu.org; Tue, 16 Sep 2025 12:24:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyYTk-0002l4-82 for qemu-devel@nongnu.org; Tue, 16 Sep 2025 12:24:30 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-ls5m_pfiPXi3AcrNBdg7OQ-1; Tue, 16 Sep 2025 12:24:23 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ABFCC18004D8; Tue, 16 Sep 2025 16:24:22 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.80.221]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B9B4419560B8; Tue, 16 Sep 2025 16:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758039867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B1wV+2F5KNU3mIM7GIxs37jfPasDNnuYiomuDixjfDM=; b=bYjbvqPX0vy3aroxrtBg1+s1va8roC+SpnSd1DU273vkxhpID3558XEfNQ28/N8rDJKDgF 80N4dj+x5zdTEhlQiIg9jWh5a5lHhqph19z8pk7Qx0+Q1xzIeTL77OXvXpSmJg9ikuUqmu gwMcVVh6ppjIgoHoPpCj4E6MyptyJd4= X-MC-Unique: ls5m_pfiPXi3AcrNBdg7OQ-1 X-Mimecast-MFC-AGG-ID: ls5m_pfiPXi3AcrNBdg7OQ_1758039862 From: John Snow To: qemu-devel@nongnu.org Cc: Kevin Wolf , Michael Roth , John Snow , Hanna Reitz , Peter Maydell , Cleber Rosa , qemu-block@nongnu.org, Markus Armbruster , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 04/19] python: backport 'protocol: adjust logging name when changing client name' Date: Tue, 16 Sep 2025 12:23:49 -0400 Message-ID: <20250916162404.9195-5-jsnow@redhat.com> In-Reply-To: <20250916162404.9195-1-jsnow@redhat.com> References: <20250916162404.9195-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.009, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1758040351419116600 The client name is mutable, so the logging name should also change to reflect it when it changes. Signed-off-by: John Snow cherry picked from commit python-qemu-qmp@e10b73c633ce138ba30bc8beccd2ab319= 89eaf3d Reviewed-by: Daniel P. Berrang=C3=A9 --- python/qemu/qmp/protocol.py | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py index 86e588881b7..ec4762c567b 100644 --- a/python/qemu/qmp/protocol.py +++ b/python/qemu/qmp/protocol.py @@ -217,10 +217,8 @@ class AsyncProtocol(Generic[T]): # ------------------------- =20 def __init__(self, name: Optional[str] =3D None) -> None: - #: The nickname for this connection, if any. - self.name: Optional[str] =3D name - if self.name is not None: - self.logger =3D self.logger.getChild(self.name) + self._name: Optional[str] + self.name =3D name =20 # stream I/O self._reader: Optional[StreamReader] =3D None @@ -257,6 +255,24 @@ def __repr__(self) -> str: tokens.append(f"runstate=3D{self.runstate.name}") return f"<{cls_name} {' '.join(tokens)}>" =20 + @property + def name(self) -> Optional[str]: + """ + The nickname for this connection, if any. + + This name is used for differentiating instances in debug output. + """ + return self._name + + @name.setter + def name(self, name: Optional[str]) -> None: + logger =3D logging.getLogger(__name__) + if name: + self.logger =3D logger.getChild(name) + else: + self.logger =3D logger + self._name =3D name + @property # @upper_half def runstate(self) -> Runstate: """The current `Runstate` of the connection.""" --=20 2.51.0