From nobody Sat Feb 7 04:19:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1758032726; cv=none; d=zohomail.com; s=zohoarc; b=YnFESCcRyIyIVv09isUWW/Kcar4hLKIkCVHc6uCQWwS9t2UuO4iXV5LkkQ2G4lfs+OroOC/ifAits3tjvxNVr/gHpYH2Lq1yp+vB2/mXwu2bwuzUCVqPKHON87PjFtWtL3AjSIXsDB7oScVQ7E23Zx0WYnjm9UmrOyrEnkTHh5c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758032726; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y9C7TeSELE/I78PqGnfI0xNq18ESqIf/4E122jlCx3E=; b=UPLA0E/RR9Cdc89mT4LObASBjhzJbKWb+xPOoGE66IPwAoPm9P0FiTuMh/qSBrql57HTDWhCb+VvklpndHB3GHP6ZiRVTixnTVnwN1MYim4fzi5Kkmzr8UQsH88sgkO3htq5tLlNQG7HN7LRvn5vnUIz+dyme6nbyWyBf2szt8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758032726304389.15810853778544; Tue, 16 Sep 2025 07:25:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uyWar-0006MJ-LF; Tue, 16 Sep 2025 10:23:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyWaW-0005uE-MK for qemu-devel@nongnu.org; Tue, 16 Sep 2025 10:23:20 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uyWaP-0008Nk-HY for qemu-devel@nongnu.org; Tue, 16 Sep 2025 10:23:19 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-24c8ef94e5dso44818675ad.1 for ; Tue, 16 Sep 2025 07:23:04 -0700 (PDT) Received: from stoup.. ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2651d2df15esm73459905ad.45.2025.09.16.07.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 07:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758032583; x=1758637383; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y9C7TeSELE/I78PqGnfI0xNq18ESqIf/4E122jlCx3E=; b=XYNnMLfgUDiMeEYl9kSNrge8OkddtfEgo/p1ugxdy2+ZUpeWb8cfpyDOSbqAoaBWvj uIM22Y0lNmIIGmLoBd8KJNhDrK9gjtEPLtkGlCLsGLqm2FZiE4lAK4ZteZyvWOKsEpHH Ubo4R6gB4sQV48406v5B/lKEQp+tt6muxMuVqzDCqTToFQ4eLpk0Nm4gDo//Y+7XGSrm RKdnmF3sbaeHmQjmatj+Ae6f+JAb17DYFcGNT4odf7eaRxnrpRXUT0zVjNPLPawOMVcq dkOjeTgRl9slBfYVI2rjCZb2YEcZHjmtnE6csS9RyPOU84ORXdHjGHEg8gs89rGQXDEA CsDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758032583; x=1758637383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y9C7TeSELE/I78PqGnfI0xNq18ESqIf/4E122jlCx3E=; b=jPdhOC95Ue3aocvgPfvM//zOxJAF90Fv9pJNaZ0TEL1N4pYy1DnPvaoHq2MrONj3lY jl1jr0wu+3ufCWDnvPBJgZJcMhPE+NKaZI6tdtxOpBQz/5b5IhZ4Z+dTQEfFHFYkT4jh BoLUwxjY6FUI1OwUucZBZn2i7p8CBXSY8TKO8awVWxceZMIp9LszvFxJgOuTQnR6Dwws I6pfmuHYKccof3I1fiNhQF1xN21Ff+jr4du9H6TAdgWFnF4LGC3bu1FSOgRKAZQllesl UbiHdnj6wZ3j66HB8PW2tXIMviIXVDjizmMivj5nQ3NY8KD7praRGiVvMBRx//3nRZUo +dSw== X-Gm-Message-State: AOJu0YwOhgLdwJfV+nqftH9Sv/sRHe5hj+xc7axopn+ZRLWhoSmK/cHM XDR1REzrvK2LT1RNG6r/k/Qu8vXQfnhsZ056TkAp1cuv9Aiw8B2hYCD/NGu7z/l0M68BC510xeP sJrx3 X-Gm-Gg: ASbGncsPUoiAvxNFiq1jTE22TOpnjVWrIAKfjc4DX6UQ6LdHclXimUB5o15VCFnat4c Qu+qrlvPhwx27GMV+XlNJi0MUOobjhf9upbgSvodjkWpMme40wpnR4Pot1YftXWmS1KR5V3Ps+J lKaL9tPi1xtsUIRZFZRjfbdT7Vv8JmQ6CZ1mFBfiY0ouiP0pcIseR9TOW26kyf/gwftPrjr4avy Nn5TNvBSANofHiIYkaomb06GumL5QOi1a+xKPetSovoT1cypp0zC/dxADfNlZV+YdcOjpw0daH1 06mBGtE6iw1FjJCaQCEIxndnobdgssLBrdC7UjNjid3OwKlZiwbWtnbCquZEcteuplgnAUZfHJ5 V1dI0PSszdAn7IG2Ze1TY//VAFrKA X-Google-Smtp-Source: AGHT+IE+Qfbk0b0Y3115cRAlVaar1X+didrD2Gf9E3LVprk0+7tgZLKad651m7yXduDlH2+ZtlQ1nQ== X-Received: by 2002:a17:902:cccc:b0:267:c1ae:8f04 with SMTP id d9443c01a7336-267d15f1e77mr28050565ad.20.1758032583386; Tue, 16 Sep 2025 07:23:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v2 30/36] target/arm: Move endianness fixup for 32-bit registers Date: Tue, 16 Sep 2025 07:22:31 -0700 Message-ID: <20250916142238.664316-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250916142238.664316-1-richard.henderson@linaro.org> References: <20250916142238.664316-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1758032726768116601 Content-Type: text/plain; charset="utf-8" Move the test outside of the banked register block, and repeat the AA32 test. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/helper.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 7828268c7f..0f681c15e0 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -7493,14 +7493,21 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, ARM= CPRegInfo *r, */ r->type |=3D ARM_CP_ALIAS; } - - if (HOST_BIG_ENDIAN && - r->state =3D=3D ARM_CP_STATE_BOTH && r->fieldoffset) { - r->fieldoffset +=3D sizeof(uint32_t); - } } } =20 + /* + * For 32-bit AArch32 regs shared with 64-bit AArch64 regs, + * adjust the field offset for endianness. This had to be + * delayed until banked registers were resolved. + */ + if (HOST_BIG_ENDIAN && + state =3D=3D ARM_CP_STATE_AA32 && + r->state =3D=3D ARM_CP_STATE_BOTH && + r->fieldoffset) { + r->fieldoffset +=3D sizeof(uint32_t); + } + /* * Special registers (ie NOP/WFI) are never migratable and * are not even raw-accessible. --=20 2.43.0