From nobody Sun Sep 28 17:13:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1758028742; cv=none; d=zohomail.com; s=zohoarc; b=c8eTBo6UZGJNHtaZFOUPN5t32UpR3OjfTOKS35YzgymLdD6iHpFa6R34E5IqkasC5N/mZ7tli7oS8gK/vLSh2mC2LDKRAcFp3K/LWfQEiw+mVTn1hfzisLDGlboOleKU0waj6WMe5rszTTS8qkkundXe/Vu8GkFtOgmI1+aS0KU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758028742; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=U0iIBse8ZC8ENtg6o1H6rx8s5OyGvuvA2kcUutepzk4=; b=kosL8tLWSZGwt4pMTajjv4Kjo2tt8bhqd1zGK687Tx9eNMewEfsE6TAcSQjtjhHDRabZC3Gm027Y8a3LcP3bgTcZqFtvjT+zVa+DaMSgIme8AL6MmesgyNwwhCNryPnI/3bbxTQ6bPlj4YLMMsASOGfTdSQ/i5DrSZV2+CXxq3I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1758028742614599.776025236927; Tue, 16 Sep 2025 06:19:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uyVXD-0006VU-0y; Tue, 16 Sep 2025 09:15:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyVW0-0005QO-QK; Tue, 16 Sep 2025 09:14:41 -0400 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyVVq-0006a2-Dm; Tue, 16 Sep 2025 09:14:35 -0400 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id CB4B6C0263; Tue, 16 Sep 2025 16:14:18 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:16c::1:b]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 5EQRob1Gj0U0-3my5EPvY; Tue, 16 Sep 2025 16:14:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1758028458; bh=U0iIBse8ZC8ENtg6o1H6rx8s5OyGvuvA2kcUutepzk4=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=Wt6JiF/oig+D6kxMkAJQpg7UeOgTxxpZIj1OH39s4DySwZaPBUxATOtlRoWkzXfC1 aJdP5nGT3XPAGAS2i2bhQz42m+rqy0r4sbG21oPyMG15nyenURrPlBj/TR5Mj4+rp0 PlgP5hnz6frSRRKb0lAAiqNY+AUbAfryFVDwVDyA= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: berrange@redhat.com Cc: qemu-devel@nongnu.org, peterx@redhat.com, qemu-block@nongnu.org, vsementsov@yandex-team.ru, leiyang@redhat.com, marcandre.lureau@redhat.com, Paolo Bonzini Subject: [PATCH v5 12/13] chardev: close an fd on failure path Date: Tue, 16 Sep 2025 16:14:01 +0300 Message-ID: <20250916131403.368343-13-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250916131403.368343-1-vsementsov@yandex-team.ru> References: <20250916131403.368343-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1758028744247116600 There are at least two failure paths, where we forget to close an fd. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrang=C3=A9 --- chardev/char-pty.c | 1 + chardev/char-serial.c | 1 + 2 files changed, 2 insertions(+) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index fe6bfb043d..b066f01412 100644 --- a/chardev/char-pty.c +++ b/chardev/char-pty.c @@ -350,6 +350,7 @@ static void char_pty_open(Chardev *chr, =20 close(slave_fd); if (!qemu_set_blocking(master_fd, false, errp)) { + close(master_fd); return; } =20 diff --git a/chardev/char-serial.c b/chardev/char-serial.c index c622d758db..4c6ca713eb 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -272,6 +272,7 @@ static void qmp_chardev_open_serial(Chardev *chr, return; } if (!qemu_set_blocking(fd, false, errp)) { + close(fd); return; } tty_serial_init(fd, 115200, 'N', 8, 1); --=20 2.48.1