From nobody Sun Sep 28 17:06:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1758011801; cv=none; d=zohomail.com; s=zohoarc; b=J04zEMT5ftATsn6AXNrF2oAERtOVXExHVuKA4qJgQhtcEzDSTRo/LsZHEasW7NtILNOhZkmstfMLRyDl2OjYO1UUryv0Podk+79LU5wco/qnZL23l+pEZKVrZ41K2CIu/MfBJ/dvBWxP0119rsNP1w16Sp/Po6ABg4MSRy+Jhe4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1758011801; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L2NIZpYPNvkwFF2x+pKlVE3aWBWzllrQ3vIp9JaQ5QA=; b=Wt325VQWVN3l2+oJp7AgctN/7JVjDe4c4mACtRaNiEYxQlFGNUtxxCA/2bQdigTfNyORqsUdqCgb7rT06YsuAhZghf58NOJ74YT/OQbM/6772Eg9HnFPtAxKlwewKQAtYenlYT2nbr2w++mp/BsCt++Dka7uDfqGgEtv7eayyCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175801180165350.46057635793659; Tue, 16 Sep 2025 01:36:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uyR9B-0006tQ-KE; Tue, 16 Sep 2025 04:34:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyR97-0006gn-Ki; Tue, 16 Sep 2025 04:34:41 -0400 Received: from mgamail.intel.com ([198.175.65.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uyR91-000603-Uv; Tue, 16 Sep 2025 04:34:39 -0400 Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2025 01:34:22 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.39]) by orviesa007.jf.intel.com with ESMTP; 16 Sep 2025 01:34:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758011676; x=1789547676; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VO7sI8EkKjiuIxmrP/H7OvNMu6oE7ELux2ybMT1pdIE=; b=RxZjw3nR/SrdA6FOpORankBlxmtxA4kjwJldj73z6992bur4z9pFy94D LjhrZE2PeuOdTUqwtJ9GQGTERSMx5Q41T8eWCP90fsOF41z3MXi6RRpz6 6rACCKSaWXVKt/Qwm4k4gEmWlut05KuBOt44H52d/ky+eT9/i9Arcyus9 eDqdzrp5poCZQA9dhFIWEI302dxuS2uSLjWZWLJRztvA7Py74A+AW1SlK muSXjAE/zziTxt4gbKEf1w7GkfB+xSDttq2UTU9kmattSdxJSrYG74jwi pRlJT/tnmo5om0XhZw0C/ulZtUs110tD0TPFvfR9JxvCGYWVRjOib24t+ w==; X-CSE-ConnectionGUID: uW9GqoXtQbm/VoxKE8JaJg== X-CSE-MsgGUID: w9wKpmMZSmKtwdMXhowwhw== X-IronPort-AV: E=McAfee;i="6800,10657,11554"; a="77725179" X-IronPort-AV: E=Sophos;i="6.18,268,1751266800"; d="scan'208";a="77725179" X-CSE-ConnectionGUID: GlwNrBC1T/qr+Tr/Pahf+A== X-CSE-MsgGUID: 5JSql50AQzOflj35Hn3NGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,268,1751266800"; d="scan'208";a="174691082" From: Zhao Liu To: Paolo Bonzini , Manos Pitsidianakis Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, Zhao Liu Subject: [PATCH 07/12] rust/qdev: Rename PropertyInfo field from VALUE to BASE_INFO Date: Tue, 16 Sep 2025 16:55:52 +0800 Message-Id: <20250916085557.2008344-8-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916085557.2008344-1-zhao1.liu@intel.com> References: <20250916085557.2008344-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.10; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.035, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1758011802386116600 Content-Type: text/plain; charset="utf-8" Bit property info will added next. To distinguish different info fields, rename `VALUE` to `BASE_INFO`, then it can better reflect that it represents the basic property info. Signed-off-by: Zhao Liu Reviewed-by: Manos Pitsidianakis --- rust/hw/core/src/qdev.rs | 12 ++++++------ rust/qemu-macros/src/lib.rs | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs index 2735e2b2c109..d887046d8de1 100644 --- a/rust/hw/core/src/qdev.rs +++ b/rust/hw/core/src/qdev.rs @@ -109,13 +109,13 @@ pub trait ResettablePhasesImpl { /// /// # Safety /// -/// This trait is marked as `unsafe` because `VALUE` must be a valid raw +/// This trait is marked as `unsafe` because `BASE_INFO` must be a valid r= aw /// reference to a [`bindings::PropertyInfo`]. /// /// Note we could not use a regular reference: /// /// ```text -/// const VALUE: &bindings::PropertyInfo =3D ... +/// const BASE_INFO: &bindings::PropertyInfo =3D ... /// ``` /// /// because this results in the following compiler error: @@ -131,22 +131,22 @@ pub trait ResettablePhasesImpl { /// It is the implementer's responsibility to provide a valid /// [`bindings::PropertyInfo`] pointer for the trait implementation to be = safe. pub unsafe trait QDevProp { - const VALUE: *const bindings::PropertyInfo; + const BASE_INFO: *const bindings::PropertyInfo; } =20 /// Use [`bindings::qdev_prop_bool`] for `bool`. unsafe impl QDevProp for bool { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_bool); + const BASE_INFO: *const bindings::PropertyInfo =3D addr_of!(bindings::= qdev_prop_bool); } =20 /// Use [`bindings::qdev_prop_uint64`] for `u64`. unsafe impl QDevProp for u64 { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_uint64); + const BASE_INFO: *const bindings::PropertyInfo =3D addr_of!(bindings::= qdev_prop_uint64); } =20 /// Use [`bindings::qdev_prop_chr`] for [`chardev::CharBackend`]. unsafe impl QDevProp for chardev::CharBackend { - const VALUE: *const bindings::PropertyInfo =3D addr_of!(bindings::qdev= _prop_chr); + const BASE_INFO: *const bindings::PropertyInfo =3D addr_of!(bindings::= qdev_prop_chr); } =20 /// Trait to define device properties. diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs index ed4064d6e110..b43ca31bae30 100644 --- a/rust/qemu-macros/src/lib.rs +++ b/rust/qemu-macros/src/lib.rs @@ -272,7 +272,7 @@ macro_rules! str_to_c_str { }, )?; let field_ty =3D field.ty.clone(); - let qdev_prop =3D quote! { <#field_ty as ::hwcore::QDevProp>::VALU= E }; + let qdev_prop =3D quote! { <#field_ty as ::hwcore::QDevProp>::BASE= _INFO }; let set_default =3D defval.is_some(); let defval =3D defval.unwrap_or(syn::Expr::Verbatim(quote! { 0 })); properties_expanded.push(quote! { --=20 2.34.1