From nobody Sun Sep 28 17:06:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1757751795; cv=none; d=zohomail.com; s=zohoarc; b=Y9eMx1jLu48mjWiUFxq0W3f73wOOGsrwVVt7CS6PMM2AuEhqMDv3PjBwKGUpQPWwR+UJ2HCUzLsqExT9TqHMfVRjPEU/NcOYKRfc9c2auvWh8RKtoIZbFNcWW6pWm3O7vG2GByDaTP4F9Vbv6YYwPdEJS2fq3YYNhORvFyK+AyE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757751795; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F5uQt5ustiZIdzCYn4xmtqTsqlJ6I63W6ymofZAy7J0=; b=PYeW7B+vT1Zgo47V4Sw6S+BOMrW9CrB2l516noGwIsm28ieVhgGyFkquG61ogjtEoCXttwfqqdAhIuAbkPA7K1fCdsADn6dGvSb4yu19Duy4wbZEkextwp2GYjt75XIt09DfHR9RKd4uW0xfw9esAjn1tC7hXmlVcvSp2p6xuL8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757751795194979.5367056040952; Sat, 13 Sep 2025 01:23:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uxLNy-0004PZ-0K; Sat, 13 Sep 2025 04:13:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uxLN8-00025p-Ck for qemu-devel@nongnu.org; Sat, 13 Sep 2025 04:12:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uxLN6-0005L4-J1 for qemu-devel@nongnu.org; Sat, 13 Sep 2025 04:12:38 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-oUNNH6MTNdSPeIbWQwLUjw-1; Sat, 13 Sep 2025 04:12:34 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3df2f4aedd1so1862778f8f.3 for ; Sat, 13 Sep 2025 01:12:33 -0700 (PDT) Received: from [192.168.10.48] ([151.95.56.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607ccf93sm9469194f8f.38.2025.09.13.01.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Sep 2025 01:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757751155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5uQt5ustiZIdzCYn4xmtqTsqlJ6I63W6ymofZAy7J0=; b=A0H5qHb/Srq7Ek3PMhAEnCh5m7JyIar8vEqloJ9Gq0RuSYHjezjm5rn4IrM0Fqnl6Z9FCg o7FEtvTtb6uG9eKNUZkjuRb/R7GKO7hz1AhnJqyhvEfRu/wV2lHxnADTteHy1tiDlRFqTg WQKKZN9iH119rr2GrRGy4/EI6V5zqj0= X-MC-Unique: oUNNH6MTNdSPeIbWQwLUjw-1 X-Mimecast-MFC-AGG-ID: oUNNH6MTNdSPeIbWQwLUjw_1757751153 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757751152; x=1758355952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F5uQt5ustiZIdzCYn4xmtqTsqlJ6I63W6ymofZAy7J0=; b=R9gasxy3viIzbOqalpgPODuO6lkag4hwivZUYbdnvOQfMLP7Z0ID22KGycvOemX2Mt oFaqGwV7MGqM9WYSl/DqVSAv7ZMyICerDew7uQO0ud5v0OW39T/yFvc0KRLBBLYqEEK8 gDmENB91njCchmlnn7IPdUjkT3MBhcmOA43YV/4Gpsfkjs+13RcEfkUMoAideePnrGIU 1mInibIdipHyDJ1SmQuU7ow360o+6wEyka5z10WrIh1161lrwrhGGuiIXb4GlZDXiMSf Vey97J3rtoufAhsfxKKxyApQKrxn1wwW4/aELSqxxzCH5xZZYf92QnBupFw8TbAxDWW8 3VWQ== X-Gm-Message-State: AOJu0YyuGMAsNfGdf5ZLBWksv9nGoRAkSseSnUpcpkB1DL7hXYsuwKre b5vbfm7NVo4TZSkrCm+u9eb3SU3PwrtikwqCWpv8S/vLG8ZDrMHRUXFq1vtw5ZAmCpm0iYwNADT oIpwNJ7r9IR4/gp1VtRcXLc90RVfWAEHG037dUXhF4iPpV+4ZJ+ADQoYKce7cNCMk9dUNfeEq+e M1xQ52HjoISAucxAKMj4RHWEsyngChMqJhwbeaJreU X-Gm-Gg: ASbGncuYV8AjIj4/SJbJIU9wWN8YPNQj2xgHpZLDsFnoLcN3akJY6Ps0lTJvUY5mJNU d8ZJ5PEYuMNS3rZnTMXbqSDlqmmIQUAZuw/p18qa/s2YACVFwoZyL9mMYVL5L8VMndLfSzudFEl lF0gsBMZFaKsSROCnF+z1WlWaeAl5okQvT7YbWDXz5zEYH9vZKvYDs00KtwPJsLiXjIyZv1BykV HJ3Ith9yNOV6kcZJwmEJyX0PjO8G/ZejQ1iIsCtw+Nll4NDAnCpLNmY+fqUI1TwzurQmSXhDGyA mW6trsUzchRELgAyODuEW9PXqQtjZVdyIWf/Rk4cTwkaps2YptG7ifvd3Ep2lXsk1NqQyfArouz /TK4KzqpveGbTai42ka7FICtfZtFLPjEZ1yWmjfEWpmw= X-Received: by 2002:a5d:5c84:0:b0:3e4:f71e:2d7e with SMTP id ffacd0b85a97d-3e765798576mr4616383f8f.23.1757751152022; Sat, 13 Sep 2025 01:12:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9gKJ6zhYZUit2MO51JvZlTcvpfh7rjKP0NCSAJJY3k0/6Lb4S6RCDvPPCkLTYXBEY5PCMZg== X-Received: by 2002:a5d:5c84:0:b0:3e4:f71e:2d7e with SMTP id ffacd0b85a97d-3e765798576mr4616363f8f.23.1757751151561; Sat, 13 Sep 2025 01:12:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Xiaoyao Li Subject: [PULL 61/61] accel/kvm: Set guest_memfd_offset to non-zero value only when guest_memfd is valid Date: Sat, 13 Sep 2025 10:09:42 +0200 Message-ID: <20250913080943.11710-62-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250913080943.11710-1-pbonzini@redhat.com> References: <20250913080943.11710-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1757751796369116600 Content-Type: text/plain; charset="utf-8" From: Xiaoyao Li Current QEMU unconditionally sets the guest_memfd_offset of KVMSlot in kvm_set_phys_mem(), which leads to the trace of kvm_set_user_memory looks: kvm_set_user_memory AddrSpace#0 Slot#4 flags=3D0x2 gpa=3D0xe0000 size=3D0x2= 0000 ua=3D0x7f5840de0000 guest_memfd=3D-1 guest_memfd_offset=3D0x3e0000 ret= =3D0 It's confusing that the guest_memfd_offset has a non-zero value while the guest_memfd is invalid (-1). Change to only set guest_memfd_offset when guest_memfd is valid and leave it as 0 when no valid guest_memfd. Signed-off-by: Xiaoyao Li Link: https://lore.kernel.org/r/20250728115707.1374614-4-xiaoyao.li@intel.c= om Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 72b571a6972..9060599cd73 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -1595,7 +1595,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, mem->ram =3D ram; mem->flags =3D kvm_mem_flags(mr); mem->guest_memfd =3D mr->ram_block->guest_memfd; - mem->guest_memfd_offset =3D (uint8_t*)ram - mr->ram_block->host; + mem->guest_memfd_offset =3D mem->guest_memfd >=3D 0 ? + (uint8_t*)ram - mr->ram_block->host : 0; =20 kvm_slot_init_dirty_bitmap(mem); err =3D kvm_set_user_memory_region(kml, mem, true); --=20 2.51.0