From nobody Sun Sep 28 17:03:46 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1757701426; cv=none; d=zohomail.com; s=zohoarc; b=RvVZ14UTM/W2++4hwMbkffEz7VT3zHGmS0jk7aSop5MhZmr62WWjW2KPtNm+xBKPy3jt6TcQFD/7OhkwIQvQZM9OddS39nY3XfEcE5SdCMZDQ7eHy/eN9OFazZUtIf6exuexLmx0Gyco86f+XZhtASfIsA8KnqRgiI+rC9rjIzQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757701426; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tE82+/gc49jV7lxFy1jmA8hoihzee202gsVD7g/JEEk=; b=WU+C7lEoPydNhwI8S+ZLSEB3FjRQRZggA9SauK0/aTfO1WJ/9bFxGgx9zI5+Ht7JbH0TDpP041U+feJXJsm4flaQExByLXPO3+ES9fxvCiKumS9QEUJ+789cg1efWX29jGAi0B6RjyKlahPdxXNVbWpgxJFUm+0s/k0Aqg5uaYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757701426804464.03114131607674; Fri, 12 Sep 2025 11:23:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ux8Pa-0004VK-KA; Fri, 12 Sep 2025 14:22:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ux8PY-0004V2-VG for qemu-devel@nongnu.org; Fri, 12 Sep 2025 14:22:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ux8PX-0005GJ-9Q for qemu-devel@nongnu.org; Fri, 12 Sep 2025 14:22:16 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-Oat8Vj6aMwe6qtSwaHC0Ng-1; Fri, 12 Sep 2025 14:22:11 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B32251956086 for ; Fri, 12 Sep 2025 18:22:10 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.154]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4982C18003FC; Fri, 12 Sep 2025 18:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757701332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tE82+/gc49jV7lxFy1jmA8hoihzee202gsVD7g/JEEk=; b=jOcoKTISInKo5Zl/OsUSKLUOak+cUcvBueE4fYYzzyLiglhquyrp2dQqWRUaxZzNMdlgdE j1ov6L1H65EretNh0ynhqV5CO2ncih8BhQq7rI5KLak//r6cZMSoaxQPOt7dgo/eJ+VTue u7aBfsuPH7HiPwP8br9VYEkNn6ZietI= X-MC-Unique: Oat8Vj6aMwe6qtSwaHC0Ng-1 X-Mimecast-MFC-AGG-ID: Oat8Vj6aMwe6qtSwaHC0Ng_1757701330 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/6] tests/functional: replace avocado process with subprocess Date: Fri, 12 Sep 2025 19:21:57 +0100 Message-ID: <20250912182200.643909-4-berrange@redhat.com> In-Reply-To: <20250912182200.643909-1-berrange@redhat.com> References: <20250912182200.643909-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1757701428916116600 The standard python subprocess.check_call method is better than avocado.utils.process as it doesn't require stuffing all args into a single string. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- tests/functional/reverse_debugging.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/reverse_debugging.py b/tests/functional/rever= se_debugging.py index 405eb6b3b7..1b880cda8f 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -11,6 +11,7 @@ # later. See the COPYING file in the top-level directory. import os import logging +from subprocess import check_output =20 from qemu_test import LinuxKernelTest, get_qemu_img from qemu_test.ports import Ports @@ -100,8 +101,6 @@ def vm_get_icount(vm): return vm.qmp('query-replay')['return']['icount'] =20 def reverse_debugging(self, shift=3D7, args=3DNone): - from avocado.utils import process - logger =3D logging.getLogger('replay') =20 # create qcow2 for snapshots @@ -111,8 +110,9 @@ def reverse_debugging(self, shift=3D7, args=3DNone): if qemu_img is None: self.skipTest('Could not find "qemu-img", which is required to= ' 'create the temporary qcow2 image') - cmd =3D '%s create -f qcow2 %s 128M' % (qemu_img, image_path) - process.run(cmd) + out =3D check_output([qemu_img, 'create', '-f', 'qcow2', image_pat= h, '128M'], + encoding=3D'utf8') + logger.info("qemu-img: %s" % out) =20 replay_path =3D os.path.join(self.workdir, 'replay.bin') =20 --=20 2.50.1