From nobody Sun Sep 28 17:40:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1757648680; cv=none; d=zohomail.com; s=zohoarc; b=OG8q/xhIJXzBALXBhMXxXHNAEIVz7FwVrYTH1mhfaq2rh+8mJhDSBMv3P8EtZRvzm/0KYRM8lf5FB8JNNbEJkJKzPbkfv2gQOEjUY/1MMy9lmyTrBq8B10ntzgoEWtJQNSIi672Cgmyuuum9ttiHWVqD6YSJ+OSCjTV1iXpownc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757648680; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BMp08n4abJTiAjD0sjEHPnkehDOAKZyGVLvyGKxNOZc=; b=ATdVzES3DekfxJWWWETdl7t1h1KuWQjCaz7e8LGZEbkQhl7nJ0xOBxe7I4yByE/L6PIHlPAF+OEEDBEox9q9EMApMRWR2qmgwR9Yo40hI/IgaqDinAbkFYTT7DaC4zskrHEkfSS78yrHEAigHdJycFDaNb91tTWK1QJN8vyRCGw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17576486807760.29260701586827054; Thu, 11 Sep 2025 20:44:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwuh8-00072Y-Ni; Thu, 11 Sep 2025 23:43:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwuh1-00070T-QA for qemu-devel@nongnu.org; Thu, 11 Sep 2025 23:43:24 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uwugo-0007vj-Kr for qemu-devel@nongnu.org; Thu, 11 Sep 2025 23:43:23 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-45dfb8e986aso14958925e9.0 for ; Thu, 11 Sep 2025 20:43:08 -0700 (PDT) Received: from localhost (mem-185.47.220.165.jmnet.cz. [185.47.220.165]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45e03729c76sm46199205e9.6.2025.09.11.20.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 20:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757648586; x=1758253386; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BMp08n4abJTiAjD0sjEHPnkehDOAKZyGVLvyGKxNOZc=; b=G4iQuM3gXeGe0cOTWkUvxBWzJcYG0EEDJgRWptEGVsn66gIFmKxTBnYMVlvPbkG0re 6dWPMYue3E8TUNQ1xgAwMDyg3N7eY57Nv7kfvlAo8duAcZBP5p1jAM5xFom9RXqfynKP vFD9cHv39D9RFPmrv2BAzZkeI6dZ9CaYPVLn+lBY0YMMrHjeVLhSCB8Yjg1srDHsmW73 WEg++w33/bIx2d1f+zFTOqAYk0iyhMFv223Q5kUDrTxEfrQkkPZhH6JyZe/V0yYYNZav 8lLUnH1cKWdWA/Qd1jTExiBGohAN66Y/+c8Q0AuFLvQ0AKZ3FNge7fC4WgVaAOqQa8l9 4Yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757648586; x=1758253386; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BMp08n4abJTiAjD0sjEHPnkehDOAKZyGVLvyGKxNOZc=; b=beLxGUa6dKzGp5W/N0YT1+etVM4Psg4hkuNUa6zyuG3OpdMEJyiYMMDoYyV4GVhS4H tbEgIQptPEkV8z3424DDH8FoFkGMmO7b8f2AkdbtYiNIuv06h9ErwitgmczreT857mR3 KURlXG8tFbYQefKMvTRkWi2uDcFkIizI5B53D/nDoEmINHYycKn6T8W4yLz+x+F8ys6Y S48mqRduGtxRB82Ez/AMU65RZrRMUr4X0MdhjzWH9K813Z941qydAk21m5MBs2QudbAo D1D2UrG2ya45cWeNceJYQv/iKRP3x6ttKImPaBtkmpzTZbviakdgU60X5QAmkpLVqwhQ JQCw== X-Gm-Message-State: AOJu0Ywqve0fmaPn1v5EPtN+L5OkJkZ9ZxD4ZNYyyNeK+aqLEqQaQhfp ZeJSORoGL8xOVseAj7vlhCOlWiH/1/TkuC+XYHH/4TBTv/ACTBU2GoUF X-Gm-Gg: ASbGncsOI3fMCcRd9vUSl5GuJV/iu4pJ+Nc83PQeDOSIFSHK/0CM0zTWCBu9z8uT3BU TVEpfMh4b+hukgQ2LgKEdHG7ePbM+VgBHWaMow8sIfyaf/pVV1GnjVoKehHS+lUYZDUZ+wknTbJ PXfikJP8Rekh9OCSa2v5Q/9hs1rS9Z3OPFyr8mUTUkyATgtoPPnS93mdeoAkUIftL0FCRDPkhxr 4FS5ShA0NDM3ZrsFO9jYH74PCgI5wEjtvE3UbpGrTFg4nIQxNIbGMxM2VDoAtmsQeP9GmGaxJLa /lPmZ9hiNCkxKtQVlLHao3PZRFAOM5o0cCQiWmutmE0yVglnKkn1SYKzC9ItglDiAy+Z1elrHKA 2YaAoxIEpGl0eX6wbEyV+18bWlS3kG191PxtinuW0buAJLMqiBGjmBu5c+ABtcCg= X-Google-Smtp-Source: AGHT+IEp/0M8SiiD7QfqsDNFl5TjJGZlN9sw6L8PaaY1cYNH+uAjbc3ujdRvI5CaVRmm8iRtAnKp0w== X-Received: by 2002:a05:6000:1a86:b0:3e7:46f1:dfcb with SMTP id ffacd0b85a97d-3e7657929a5mr1453061f8f.26.1757648586049; Thu, 11 Sep 2025 20:43:06 -0700 (PDT) From: Filip Hejsek Date: Fri, 12 Sep 2025 05:39:50 +0200 Subject: [PATCH v4 05/10] main-loop: change the handling of SIGWINCH MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250912-console-resize-v4-5-7925e444afc4@gmail.com> References: <20250912-console-resize-v4-0-7925e444afc4@gmail.com> In-Reply-To: <20250912-console-resize-v4-0-7925e444afc4@gmail.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , "Michael S. Tsirkin" , Laurent Vivier , Amit Shah , Markus Armbruster , Eric Blake , Eduardo Habkost , Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , Szymon Lukasz , Filip Hejsek X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757648577; l=3415; i=filip.hejsek@gmail.com; s=20250912; h=from:subject:message-id; bh=x7H0XeeMERCwGAq1s4DtG6vInlpV+u3ZG4ViaEkuoc8=; b=C5ow/Nv/1ml2Ys0+8l4uqOWX7RhXx9T6oezmSRiuSuLt4pubVNTswWhR4XSjVoFJNLItw9gPq zoezWn1ODqDBerO3G57ywsQqaJStztivNd4ylzhd98iyjtDBjVAlRGy X-Developer-Key: i=filip.hejsek@gmail.com; a=ed25519; pk=nakB8gEK3oi+Q/5dBTMCy/LgZL47NP60z1jeDR6O/WU= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=filip.hejsek@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1757648682838116600 From: Szymon Lukasz Block SIGWINCH, so it is delivered only via signalfd. Install a handler that uses NotifierList to tell interested parties about SIGWINCH delivery. Signed-off-by: Szymon Lukasz Signed-off-by: Filip Hejsek --- include/qemu/main-loop.h | 4 ++++ ui/curses.c | 11 ++++++----- util/main-loop.c | 21 +++++++++++++++++++++ 3 files changed, 31 insertions(+), 5 deletions(-) diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h index 4e2436b1968b5c513f7d4e84e010b0d4fb31a1b1..7cc45c3a274434020fe33b1ca0a= 4d839de994e97 100644 --- a/include/qemu/main-loop.h +++ b/include/qemu/main-loop.h @@ -431,4 +431,8 @@ typedef struct MainLoopPoll { void main_loop_poll_add_notifier(Notifier *notify); void main_loop_poll_remove_notifier(Notifier *notify); =20 +#ifndef _WIN32 +void sigwinch_add_notifier(Notifier *n); +#endif + #endif diff --git a/ui/curses.c b/ui/curses.c index 161f78c35c32fc03ad576d2bd8e91bdfe09b265d..d1b308d5f8051e99f12f4d32435= a04e294060a10 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -33,6 +33,7 @@ #include =20 #include "qapi/error.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "ui/console.h" #include "ui/input.h" @@ -149,7 +150,7 @@ static void curses_resize(DisplayChangeListener *dcl, } =20 #if !defined(_WIN32) && defined(SIGWINCH) && defined(KEY_RESIZE) -static volatile sig_atomic_t got_sigwinch; +static bool got_sigwinch; static void curses_winch_check(void) { struct winsize { @@ -172,17 +173,17 @@ static void curses_winch_check(void) invalidate =3D 1; } =20 -static void curses_winch_handler(int signum) +static void curses_winch_handler(Notifier *n, void *data) { got_sigwinch =3D true; } =20 static void curses_winch_init(void) { - struct sigaction old, winch =3D { - .sa_handler =3D curses_winch_handler, + static Notifier n =3D { + .notify =3D curses_winch_handler }; - sigaction(SIGWINCH, &winch, &old); + sigwinch_add_notifier(&n); } #else static void curses_winch_check(void) {} diff --git a/util/main-loop.c b/util/main-loop.c index 51aeb2432e77eae7081c6945e21812acc71b5f37..db4bb9c88dade805bc98322c1a0= 53c65e9e97f7e 100644 --- a/util/main-loop.c +++ b/util/main-loop.c @@ -100,6 +100,7 @@ static int qemu_signal_init(Error **errp) sigaddset(&set, SIGIO); sigaddset(&set, SIGALRM); sigaddset(&set, SIGBUS); + sigaddset(&set, SIGWINCH); /* SIGINT cannot be handled via signalfd, so that ^C can be used * to interrupt QEMU when it is being run under gdb. SIGHUP and * SIGTERM are also handled asynchronously, even though it is not @@ -121,6 +122,26 @@ static int qemu_signal_init(Error **errp) return 0; } =20 +static NotifierList sigwinch_notifiers =3D + NOTIFIER_LIST_INITIALIZER(sigwinch_notifiers); + +static void sigwinch_handler(int signum) +{ + notifier_list_notify(&sigwinch_notifiers, NULL); +} + +void sigwinch_add_notifier(Notifier *n) +{ + if (notifier_list_empty(&sigwinch_notifiers)) { + struct sigaction action =3D { + .sa_handler =3D sigwinch_handler, + }; + sigaction(SIGWINCH, &action, NULL); + } + + notifier_list_add(&sigwinch_notifiers, n); +} + #else /* _WIN32 */ =20 static int qemu_signal_init(Error **errp) --=20 2.51.0