From nobody Sun Sep 28 17:12:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1757606906; cv=none; d=zohomail.com; s=zohoarc; b=Cnqm+nQQ/lg4ousUMYLPKBA0CU9iiD+KDu0lE+bV/uW7Gs/5L+02frhrQoMkQdLm9KGH8i6VlMQj/XH0l+XHjxhKre5FvaMsnQpeCe4ilBxsZXBhOEYkXiNxINmuuT1udScI1BrIBIWckpWv96osI4Q6DqkOjwvrVFK4VxAPRek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757606906; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nZFC+ElBJPA1AjpB7Nc8nsuONRYfUOZ2+Qi69XrYzlo=; b=kA4ExCXgCEcYE1VtkUPSwDmzwlMuMANURfqB4sA563j6ymZ5pPHGivSRi/3u/zYc+SqwP/H/a0tnntG0784mIgGUGmMx7a5vk1/s3ZV6hnWJym5DO1WMnZdrkjIcSpuWp1uHkwxx0BVL9LBIbfFOB76ZiEo14GBf7UL304Bvd2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757606906480165.5182415675224; Thu, 11 Sep 2025 09:08:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwjpC-00058L-7t; Thu, 11 Sep 2025 12:07:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwjp6-00056V-SB for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:02 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uwjp4-00068y-If for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:00 -0400 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-b4c3d8bd21eso603247a12.2 for ; Thu, 11 Sep 2025 09:06:57 -0700 (PDT) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd9903a2asm2618765a91.24.2025.09.11.09.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 09:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1757606816; x=1758211616; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nZFC+ElBJPA1AjpB7Nc8nsuONRYfUOZ2+Qi69XrYzlo=; b=T8IPqNFVYH2c9c6igwPOIr09pj5mLTPwAZ5AerXgLqZ64kO2w2YfJpPIA47Tw5h77t ATufqBIfxaD3alcYgybbOIZ1+OhjBcrDr9o7JtOuV2sThvXT+R1ktSOo6v0N2XDrGsrp Y3eZIIMUa0REYdZvMLTn8+S8Q0+HuN7JajAXndgvGDZdnUdnjSJzoC+Jtp+BzChCk5/T q9DELiCKxqRJMBLBr3srlF5J1iQfSHuLuQ8LlHpxLT4D0cr/ggwQn7XWiMczra7vdGQH 8q8vZ59JYmCVC3NwzgBuTq7+ZnZmYQmWgcMTKRtYJwyZam1LzpQiuFkhnQxVNNs2QEd3 HUzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757606816; x=1758211616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZFC+ElBJPA1AjpB7Nc8nsuONRYfUOZ2+Qi69XrYzlo=; b=oYgTFI/owvz7d/Jaflu3BZ8dU/j1s6RQv+Q8FUgYNgCsuHk97n5H0PEOFDjcGoJGIM /pRxcqHCPzRTQeDVM2Cy/FQ+F4f5BFNqhGSZngPgH0QR3HH/0qQ7zGbMdJo5mCUe26BW sDiHhNZi7oMJSXlqkQgYayVNvVn/59v0tjxlMo59LOImU/jJa43CTLejFmbWSZE+Awmi WqcoE6HtFMv2aAcAnJQcoOvhe+W9eP8iAn2AYNVZA9JnXFsP9Qmo8C2MUAwlST2CReRS r7V1iigt3RWvgTjs7mup1N9OrzeHMbw7y59S6GnwQy60XA4U8q8APkbDpqa8v2Z3Sl0h IcNg== X-Gm-Message-State: AOJu0YyTMFSMP+pMhglS4pV7KAI7ujU3GvQ6brw+vv3lwxUdP8cqCFJ8 l9uU3zA6bE97HNnEQ7oxapwbn6R1R8UvIvUZMGfH/yjiqinaSEyQAC261h0pWtu4mmp5fsHYZlE y4HdCSy2/34Jc1NExnm+rFThIoyDHrpDrUmL6CBwI+fdtKf+BDMalGWz245TkPn/P3plZqMUO7w SOt4sDTh6bXCmQNdR/ofHeq2Vt37CjoAfdDdcDsUwspRtqfQ== X-Gm-Gg: ASbGncuW07Gej0z/j2Rk/OjDZLMXVVJbUn0rYiwyiMxYDw6dVeC1pdL8CqG5d1Bsusl VdN2Di7XP5ekrprfrWS4ipgL/d4Yb5I1blUBV5PqlqG3kaJHTIa4nLaXLQCHHRJYdFVVjusBnCJ uZLKqVVwIuhFDOzkYWrtHPo/nB4VhocUimaPd+bbTOJp8lNb22pEjMNwEp+dd+KKwDt4kJVAw1e mHXIXxnXM9zzbii3DEfS8aDJsIfFvHVC6Yl0SnoEemBhkqmBkem1O0Z782YEh9QpTrJSB2MXddY rO8/6PT6UPmj+TRpBNjwUANmBCM+mvdfKFbBOJEyp2QS6/f9aqJaZaDuNte88LLw8AavuCoVLtU velXKjUE7mDG66Vt3Mzw82EPs/30HvYT9Z7Ssxo4/ee6wdRCzosCfqLa44+2FYq6qnDCqNEk= X-Google-Smtp-Source: AGHT+IFjeu0KSReedT4gszyGkIA9bES2oc+Nw8PGZ3HYA1jB/xtHwMR3Y+uSYLOJPoCYD8WtWNIAgQ== X-Received: by 2002:a17:903:b0b:b0:249:1156:31f3 with SMTP id d9443c01a7336-25d243e7fd8mr56435ad.8.1757606815906; Thu, 11 Sep 2025 09:06:55 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-riscv@nongnu.org (open list:SiFive Machines), Frank Chang , Emmanuel Blot Subject: [PATCH 1/4] hw/char: sifive_uart: Raise IRQ according to the Tx/Rx watermark thresholds Date: Fri, 12 Sep 2025 00:06:43 +0800 Message-ID: <20250911160647.5710-2-frank.chang@sifive.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250911160647.5710-1-frank.chang@sifive.com> References: <20250911160647.5710-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=frank.chang@sifive.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1757606908048116600 Content-Type: text/plain; charset="utf-8" From: Frank Chang Currently, the SiFive UART raises an IRQ whenever: 1. ie.txwm is enabled. 2. ie.rxwm is enabled and the Rx FIFO is not empty. It does not check the watermark thresholds set by software. However, since commit [1] changed the SiFive UART character printing from synchronous to asynchronous, Tx overflows may occur, causing characters to be dropped when running Linux because: 1. The Linux SiFive UART driver sets the transmit watermark level to 1 [2], meaning a transmit watermark interrupt is raised whenever a character is enqueued into the Tx FIFO. 2. Upon receiving a transmit watermark interrupt, the Linux driver transfers up to a full Tx FIFO's worth of characters from the Linux serial transmit buffer [3], without checking the txdata.full flag before transferring multiple characters [4]. To fix this issue, we must honor the Tx/Rx watermark thresholds and raise interrupts only when the Tx threshold is exceeded or the Rx threshold is undercut. [1] 53c1557b230986ab6320a58e1b2c26216ecd86d5 [2] https://github.com/torvalds/linux/blob/master/drivers/tty/serial/sifive= .c#L1039 [3] https://github.com/torvalds/linux/blob/master/drivers/tty/serial/sifive= .c#L538 [4] https://github.com/torvalds/linux/blob/master/drivers/tty/serial/sifive= .c#L291 Signed-off-by: Frank Chang Signed-off-by: Emmanuel Blot Reviewed-by: Alistair Francis --- hw/char/sifive_uart.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 9bc697a67b5..138c31fcabf 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -35,16 +35,17 @@ */ =20 /* Returns the state of the IP (interrupt pending) register */ -static uint64_t sifive_uart_ip(SiFiveUARTState *s) +static uint32_t sifive_uart_ip(SiFiveUARTState *s) { - uint64_t ret =3D 0; + uint32_t ret =3D 0; =20 - uint64_t txcnt =3D SIFIVE_UART_GET_TXCNT(s->txctrl); - uint64_t rxcnt =3D SIFIVE_UART_GET_RXCNT(s->rxctrl); + uint32_t txcnt =3D SIFIVE_UART_GET_TXCNT(s->txctrl); + uint32_t rxcnt =3D SIFIVE_UART_GET_RXCNT(s->rxctrl); =20 - if (txcnt !=3D 0) { + if (fifo8_num_used(&s->tx_fifo) < txcnt) { ret |=3D SIFIVE_UART_IP_TXWM; } + if (s->rx_fifo_len > rxcnt) { ret |=3D SIFIVE_UART_IP_RXWM; } @@ -55,15 +56,14 @@ static uint64_t sifive_uart_ip(SiFiveUARTState *s) static void sifive_uart_update_irq(SiFiveUARTState *s) { int cond =3D 0; - if ((s->ie & SIFIVE_UART_IE_TXWM) || - ((s->ie & SIFIVE_UART_IE_RXWM) && s->rx_fifo_len)) { + uint32_t ip =3D sifive_uart_ip(s); + + if (((ip & SIFIVE_UART_IP_TXWM) && (s->ie & SIFIVE_UART_IE_TXWM)) || + ((ip & SIFIVE_UART_IP_RXWM) && (s->ie & SIFIVE_UART_IE_RXWM))) { cond =3D 1; } - if (cond) { - qemu_irq_raise(s->irq); - } else { - qemu_irq_lower(s->irq); - } + + qemu_set_irq(s->irq, cond); } =20 static gboolean sifive_uart_xmit(void *do_not_use, GIOCondition cond, --=20 2.49.0 From nobody Sun Sep 28 17:12:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1757606900; cv=none; d=zohomail.com; s=zohoarc; b=FHIN9gfrn4j9hJNpsc8tPN4jKoqgr3MNBDb2NdYODNrYZHfNM4UcW1BDAlu/IIoGC9YvJse/yWvbmp1vqW2oMtkxXNcwoYX1CLm8SWiOCoS3gDw3U+yRxaby6vv7cFDp2sWzm8dCj2xcNzms1x7H9sX+BJ+d155sSY6EAXnqc78= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757606900; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vtn/P0RSi7hHJExTcycuQeWBhjKBhcvfR0eoJo2mnyg=; b=bIFuiH3x9HjJZgRtctMToGepivvUO2hQtgFw+oazV8zOYcFfASeLue9MJt4D2huT1iwN33NV2XGBSOKH4NPK+HFSZms9tZYfJmKLLPHrNQvk7SAF12wK0WgVe+mKmJbwHGmMuvMNx8sYlq5Ew12t8LWlJq+DLvSwx8fXyAUOK8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757606900440906.9609330755484; Thu, 11 Sep 2025 09:08:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwjpD-00059X-Nk; Thu, 11 Sep 2025 12:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwjp7-00056e-PU for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:02 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uwjp6-00069R-25 for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:01 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-b4fb8d3a2dbso718774a12.3 for ; Thu, 11 Sep 2025 09:06:59 -0700 (PDT) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd9903a2asm2618765a91.24.2025.09.11.09.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 09:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1757606818; x=1758211618; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vtn/P0RSi7hHJExTcycuQeWBhjKBhcvfR0eoJo2mnyg=; b=ISpUqbZRtT4r7zCAFy5vldedAUnSSGz/pG7b9SVVIuOVpmm6F5qfQVHOTbe6R+Rgvo hw2CZl8idgA5FzU5eAu1Mij1MOIEUtgOfQOm5KjBX/9e0TSIzWq+Q958oA5VPCccnqTq rr46AB5Y12LlglP+7HEA/fUEU23v9q82R9we0Ud7gfQDqf1c56usZfDvW34wf2SYPzkr MpQYjNd4M4dBzuxmHTdKLKtIRYHJ1/57bAGtDNbr9ZcMxoKEE7sBmZZPuuMom4sHRZbD jNmdXbj5Ep/o6kVv4ZY59xJ80B2zR+qwn3EZ8M/XvkbCcnkUxMJ2+z6rtOyaVcxxx6mv a27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757606818; x=1758211618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vtn/P0RSi7hHJExTcycuQeWBhjKBhcvfR0eoJo2mnyg=; b=cT/KkSewDF7dlMsqTKjPv+OVEDa9QzBeS0C/QkyNdrihhtd9p9EAmluIxC0usQD773 I34qu2FZTkTF+LBuemyoVB6wBSCVPSqCpZNXRlkjCz6YyuN8dFzkpegb2lk/qLuvl6q1 ZpG9Svd96hgomOJwRJsbaX42gLAK2dxO+5uImkcWtPpKZL8zE1m3bZ60tJqcFIF+cPY3 aczSE8g2cc3a5kXU+NhUc3iO3J4tqSiYhBbiJsflbrDAwY1mffyY+ok1xIeZZAgL4YTF QdjRc6GrA4+pqolQqvYBuJRZFqy+NeNXFD3Ay5+5NenNtHL57mJTLoRP+QKIo2eDgbm6 lGzA== X-Gm-Message-State: AOJu0YzOyDO9gjHc3uoExT6iwU1TYP0WW23P1pL1W75iAhQOgunl/SyJ GXzjmopmnZyxQpK8qKuKSJE5PPNu4MhrzqBOIzrF+SUSz18QlubInWuVdfrXvs701V1hssCbum8 H6kjuO7vTz/Nv5V/hWUbePby7TrekTMqjWPdSIwK944o9uzlxpcdRUiG0gNUaCKmnrUU03z0A5P WTPCOPf36EBQc8N0ziKbMbGf5ic4MnW10fjpQHSuq4bmB8MA== X-Gm-Gg: ASbGncv91qZ7sa3t3bZfG4QwDEIEE1IckwKj/1jsvM/vtNLnCRFKNOMasOQymH6Api2 Crt2Oczot3puzKaHXRaMS1PxcStfdKWWnGxB4CHElQDLFUClA4leNWsN22qb9o+mfu0DKisGE9Y spfmGrxj88jWvgICGQhobKqQDN1RXRPO7bag2dbE01t+N/5+LWQpw9Z+NMbmfFWjdMnE/JtR82r iLOqdbBX1b8EAdfHUPMnVtEITkpMj2RirIctbgLGhxTW7YK3+nCcEyQXrBbSJ+UPFC+UeYifleY fAg0UyVJ5D/vQl31BxoQyu4PyGyr74pZ+sAOzxx0qBaFmHaf0RCVf3QiNg8reAnfsoBNGEVnwIX /KlrNPjMuMrAfP+tZ4sqBmWHufz3Ck9ocF3SGm3Yo+EfdbDY12kIDdPjX1Jx2 X-Google-Smtp-Source: AGHT+IHSG7yc6QMm1MwjKEtdgpTLLmYFqDutKKmlNN/Skkiwm3gmRfQXNxpur/zJQlqMqpTo99hbUA== X-Received: by 2002:a17:90b:2683:b0:327:ba77:a47 with SMTP id 98e67ed59e1d1-32d43f05b51mr28369135a91.15.1757606817949; Thu, 11 Sep 2025 09:06:57 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-riscv@nongnu.org (open list:SiFive Machines), Frank Chang Subject: [PATCH 2/4] hw/char: sifive_uart: Avoid pushing Tx FIFO when size is zero Date: Fri, 12 Sep 2025 00:06:44 +0800 Message-ID: <20250911160647.5710-3-frank.chang@sifive.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250911160647.5710-1-frank.chang@sifive.com> References: <20250911160647.5710-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=frank.chang@sifive.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1757606901843116600 Content-Type: text/plain; charset="utf-8" From: Frank Chang There's no need to call fifo8_push_all() when size is zero. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis --- hw/char/sifive_uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 138c31fcabf..401f869680d 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -122,7 +122,9 @@ static void sifive_uart_write_tx_fifo(SiFiveUARTState *= s, const uint8_t *buf, qemu_log_mask(LOG_GUEST_ERROR, "sifive_uart: TX FIFO overflow"); } =20 - fifo8_push_all(&s->tx_fifo, buf, size); + if (size > 0) { + fifo8_push_all(&s->tx_fifo, buf, size); + } =20 if (fifo8_is_full(&s->tx_fifo)) { s->txfifo |=3D SIFIVE_UART_TXFIFO_FULL; --=20 2.49.0 From nobody Sun Sep 28 17:12:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1757606878; cv=none; d=zohomail.com; s=zohoarc; b=Qh9ZbjGFljrnoy4HBgbD6o7zezJ6ayooMP2LY+CbSeSyc4fEgR4TtYcn0Eo1j4JJ7DrUufpTn6RqIzYVcZyZghLEvCpIc95QKDo4rcu6CmRzwJRfOof6NzKl2dY/Z+7q9TUTmY8uYq7qrH5rrb7nSESudwdgD0hkCLkfaaBv0XM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757606878; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gOAYaDxWDZsV2hmIOq3wdPqI2Hus4uIY85BIAbPxojY=; b=EjuN9hq+dQ9QNx8QsngqXT8KmzAQpj2gBtIUmIjjyeiO6sdJErnDHBToy5Bw7c7lDbt/LhiErbBI70Dl2Kwn8m1l3Zo/tMqdXDovCTqH5TLFTguFccOXTnC/ifsfJQEg5pQ/WC6rfhRMJ1wAF89SiZnG0MUb7gwQm3FKLTzc7E0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757606878867644.2896552990329; Thu, 11 Sep 2025 09:07:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwjpK-0005Av-Iv; Thu, 11 Sep 2025 12:07:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwjpJ-0005Ai-40 for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:13 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uwjpF-0006Cu-UF for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:11 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2570bf6058aso12122735ad.0 for ; Thu, 11 Sep 2025 09:07:09 -0700 (PDT) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd9903a2asm2618765a91.24.2025.09.11.09.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 09:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1757606828; x=1758211628; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gOAYaDxWDZsV2hmIOq3wdPqI2Hus4uIY85BIAbPxojY=; b=hDb4wYJU+3I6dYwQY7rFPj3vfOh2+tppSC4LpxxxubpzU7aiGooG2ITbm3uWoU/IB/ xBIJkRbvS+bNltpnweAQJ58qXsrs1tmWQf7z1w8U1t+4CoRzt1ocT290FHnyqBprfNH2 h1S43tDr71uQExA3HAGqbZKWotBXMqSzaOBleTQOKLGAkcfIZ71JPMLrg6VjK/l1Y8Td SovA8rsZZa9RmnqkuyK4qZfE7Lza0nsvnmIPJHr5opszbI2PG9XtKgWTcLm9l3hHHJl0 0JmcJWLX2DZ++I4s2fme9UNhNdIDJUz/sDqtS8g4/XChDXrcMNW3F0wGCgJTjNrXKVzY Tv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757606828; x=1758211628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gOAYaDxWDZsV2hmIOq3wdPqI2Hus4uIY85BIAbPxojY=; b=l2vP7xmMWe5BwQ8JV21QR42uyh2Qg5Y3lJRtotZeIJizzsLQxYVy+iQbH0aKxXN6/M GfVhKKzM2Uf0mEI9YT9Ro3iLjF221w0XxwHcHaH/sfWdfuO3gYzVROqom1MlRsWfDYrf 9InBpYVmXVLCojFfLnXAnyNw1pPWkYTtZTYu0oX92uhn1xwmUO8SfnmquFWYO+vXfSOs TdLMkzW0FxZiEPaDpUA356Yi4GTQIEqB63uzjEhS+jGstPT5yX6ewBqZm63jRbwLGMnI 6npJNThaIg97LrDck59FKHqHhaWmGvjALX89aYFgo+RUYaMxQexZRC6JipFzTT/mOTXs nUng== X-Gm-Message-State: AOJu0YxsP5d5tXJQoxJ91JdLU7eNsVdCsQK70OR3KaMgUv2KocBxzKNc HIzP/iowCSPevVs+9Bdde7IvS7tbC0Cb6bkUkZcHawjsRzmKLqQVjRTGt0pZRMBqJDCfkW79SO0 LXrzgjAHAaa1PwHmil8K4mC5BVXztmIaTft4Hc8sBMwZaZVF+dJN8CChZ86obpYduNyAY/MII78 ai2AsRBcvHIgg4L6ECn9U4gFfbL87XDrasRv33LBwYMBGWVg== X-Gm-Gg: ASbGncuK934dRALZ3uJO5NeEfSg+XBKRMEZYq2L69SOzs/vIqZbfUYurbipaLwOFemu I8MhD5x4uLFTDau83uyWI9tfwlh1Uf+ki5qJAP4fJ62HdAWZE8JVTmF8RIo7Zswrdt2IC2Rf1JP EvqV22zCM+G68enN+QfpftcqJZ7jvweeAqS5osuJcjFVP0J80A06D9v+MEp7PT/HERO+hDB3Lzx JXIVfVeBIMgumjoqhY74ayJxo6V++/pKR8nk8KJqGA0XstQHPX8SxcR9z19FXfciSCOMOZcKNXE w1orkuQvtqBR5TEUBN6d14x4ASxD4nAzegveL/c6mJ4CS+zFSqJpwbpNB9nKwQ9yz0ZLpU0Zuyd jXF5Vebz3jM6b3uBTKzj9jA6eujJ//8/7dY7+hU8VPvtyTyUkVg== X-Google-Smtp-Source: AGHT+IFF3wVYM4l1p86RBmrAbQ/XlaasdQuUrymGbpxc89MHBDtqcizKMgN0UYlu+xGL1QiOu6nQcg== X-Received: by 2002:a17:902:e549:b0:251:493c:43e5 with SMTP id d9443c01a7336-25d214f424cmr475355ad.0.1757606820254; Thu, 11 Sep 2025 09:07:00 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-riscv@nongnu.org (open list:SiFive Machines), Frank Chang Subject: [PATCH 3/4] hw/char: sifive_uart: Remove outdated comment about Tx FIFO Date: Fri, 12 Sep 2025 00:06:45 +0800 Message-ID: <20250911160647.5710-4-frank.chang@sifive.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250911160647.5710-1-frank.chang@sifive.com> References: <20250911160647.5710-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=frank.chang@sifive.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1757606879571116600 Content-Type: text/plain; charset="utf-8" From: Frank Chang Since Tx FIFO is now implemented using "qemu/fifo8.h", remove the comment that no longer reflects the current implementation. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis --- hw/char/sifive_uart.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 401f869680d..baef0bd9c28 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -28,12 +28,6 @@ =20 #define TX_INTERRUPT_TRIGGER_DELAY_NS 100 =20 -/* - * Not yet implemented: - * - * Transmit FIFO using "qemu/fifo8.h" - */ - /* Returns the state of the IP (interrupt pending) register */ static uint32_t sifive_uart_ip(SiFiveUARTState *s) { --=20 2.49.0 From nobody Sun Sep 28 17:12:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1757606856; cv=none; d=zohomail.com; s=zohoarc; b=FnoYrBsocnOp7MslnStD3b/e+TkQR4U8l+R30Bo+92RmohD8PhhZFAOYUUT+4ZfN0kN9o6rE1tiONTUVTXoDlec0MTJtuvffP+/+RPK6lcttSiD6JNQ3HRfS0/cqhN4FOtdW8FU/dNfPkSYvbS24JqfA2dWvmxfO97Y0sdEr1NM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757606856; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UIhBt/gfm4MfQLRC2cneq/+C/BNaiAz/oeMtDs6zQnA=; b=Fiex2gWMBrM47hK12PDcPjk7owOTmxKjdorMdZLcYSodjX5BaNMJJWGrS5PEoPlOA0VWxoMHdWxbw/9Da0uLzGBaGSNPjbzeRFwBOcUpEw6iNrl9TGIXW2lHeSTptlezJu8FoN9n2hnSm/X1E5/YikEN5Otif0haQgt0bWS4VQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757606856182596.9001987674818; Thu, 11 Sep 2025 09:07:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uwjpD-00059J-Hg; Thu, 11 Sep 2025 12:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uwjpC-00058S-9R for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:06 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uwjpA-0006AM-7e for qemu-devel@nongnu.org; Thu, 11 Sep 2025 12:07:05 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-32de096c067so438609a91.0 for ; Thu, 11 Sep 2025 09:07:03 -0700 (PDT) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32dd9903a2asm2618765a91.24.2025.09.11.09.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Sep 2025 09:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1757606822; x=1758211622; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UIhBt/gfm4MfQLRC2cneq/+C/BNaiAz/oeMtDs6zQnA=; b=PUGPQszprDrH25oPwap2QYkjh1bOVQNsoFE8Fe8E1cdwoE2Rr+nFmKUGWaJsswcOgt Gi8uxidtlOFICzjQitosHAYi5Fz02bobHMAfHvN20t6Rna+jrmvvQKYH1rERhE7Lx35H LoQk7+MrJ4cZMi3Ch/3Ey1mHIYs+lL0NK0XczgGWJjaVPyGGeNjSaKjQpntwuKws8PRG kkImkQ5K03agGrf/3mrFKLQfAe2jn1Ty+25Qnf747+WHGUVdjOsaCFpNBpWxZrwzlCHm 7Hx6LQC88Bk2Wnk6XiZ6BWQmehn7tF1SZedgHLwfWCCIvYhg+5XmcybpAxYo3tAlgvvA 0YNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757606822; x=1758211622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UIhBt/gfm4MfQLRC2cneq/+C/BNaiAz/oeMtDs6zQnA=; b=KItkijA//kUJtliL5ExjAQatnLshEedAC0boZ3Ruie/oOUJhX3FbQAl+7Y0HQ2RjdL BlJ3UD9DqarzgvS5fBD/hD+JdbijCwE08ABhrc2dfedkqSVD8Zo2hJmR9YeiOQV6vm6n kW+s10PzbiOQnvjIe7DIkT/yJ6q6Vvy1YfPf9TMGw60x1rw1f2yNXni3E/YbtkSMnlyT mtCSeS850pSLOZ1zmcy/uNjpQkBDIFYKKEs8Pk/McYZIa7IuVmrNJ0221DReZYuZ3gln UiR0Y8httd5vkhv7LNH5KpuQkUTpD4lnFNRng9XPIj24ps880uZigM/F+hmUduhQxNlY aCVA== X-Gm-Message-State: AOJu0YwjmpabUjlNT+zqrV1CW7I3kIgdCA6Agi2CB4ovI2oQkmC3KKG7 ZN8Y6IUGIgvLGdkPATB+4Eg4MwPq3k0GzkTfhwPVgBczMExLsL0fRXeTYPLn5TlXGP1JF29Pf2h YUqFIjmaRhsdoTcE+Ias59NHYCG4tZrJ3h83OWSli2mKsNxbC0DmwVSUowYN5HrDldctL+xIIOU Dx1AZe1NnTImwMZGi3wEQyQdbytzF7oCooeTbr+XVcoo/Kgg== X-Gm-Gg: ASbGnct6z00pXzWe8DXOoZambVng4pfgn+ZNgmAWsxDr9TSOyqOa+6Qmn1gzGY+n9R+ 4sDvFZFiyRJ5gOQrlSBXOQJV4NOvlaMY+UEI/PuvwJRxIe8AnuHyrsoXw/kBaDvspFnibGC6FNh XyRejYxOWwhnsGyUcYLZlw/FwhxLPDcTWhWvDTMeNKgSuE1q4A/e0lph+ssT3TJ4Z3imzOaV7Yw tdybQICBlDu3DuGiPirVWjrRFkiRqoe5sc3L9Mx2FS/6qgDtWLvspALc4pH4o/XJjmCMnD+kxk+ 0LJ6obnZnrtvd31U/Y70DvVlZiNN9ebKO0EXYkOUHj840w3Cx0E/Q8a1abmdOH3on3oQOKyiyCG YiKuK1uzb9xJjEBTG3YLOAY6vO3h1PzYfc6QP6m6iZnRLHzQrByKJrJ9coEIh X-Google-Smtp-Source: AGHT+IGrXv1a1syGeNZS7H98f7pe9op4VyS741NsSQnqqfmADV4og4MPk4p+CszzYk5IxU49CG2HFg== X-Received: by 2002:a17:90b:4e8b:b0:32b:6ac0:863f with SMTP id 98e67ed59e1d1-32d43f5a67bmr23253381a91.18.1757606822268; Thu, 11 Sep 2025 09:07:02 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-riscv@nongnu.org (open list:SiFive Machines), Frank Chang Subject: [PATCH 4/4] hw/char: sifive_uart: Add newline to error message Date: Fri, 12 Sep 2025 00:06:46 +0800 Message-ID: <20250911160647.5710-5-frank.chang@sifive.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250911160647.5710-1-frank.chang@sifive.com> References: <20250911160647.5710-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=frank.chang@sifive.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1757606857311116600 Content-Type: text/plain; charset="utf-8" From: Frank Chang Adds a missing newline character to the error message. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis --- hw/char/sifive_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index baef0bd9c28..e7357d585a1 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -113,7 +113,7 @@ static void sifive_uart_write_tx_fifo(SiFiveUARTState *= s, const uint8_t *buf, =20 if (size > fifo8_num_free(&s->tx_fifo)) { size =3D fifo8_num_free(&s->tx_fifo); - qemu_log_mask(LOG_GUEST_ERROR, "sifive_uart: TX FIFO overflow"); + qemu_log_mask(LOG_GUEST_ERROR, "sifive_uart: TX FIFO overflow.\n"); } =20 if (size > 0) { --=20 2.49.0