From nobody Sun Sep 28 17:44:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1757425973; cv=none; d=zohomail.com; s=zohoarc; b=LkEt0h32KRag8+5QX6020PQ48WnAhqxXs51Yrku/zi2usqUnuaaZg3Lq8w0YgCJygtjSdPKnfv4sZiIqJqp/XjG2m1xhJCifrXpi8rZky+bIrc8FIVjiqkqvOKJSk+kNn4+Ok2+ZHsi3/GeCVh1O0fJMT5GTArB8ugcX89ZVIqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757425973; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8hvnwMVASc0iPfq0fUmCscKOthayeJNSO/WaWKuRJh8=; b=NYTMWlIOmFeMR+ELzTLdVl0PVh8//9CVosbZWVBlde+PQ1XMcXBps3FetdnPEbYmz9CR2RZ+eeOk8Jy9LfhaaiqidxLU7SJsoRW4XMQMh2fTHhRWf8i/4Q8Z5wx7Ia+MQ07VTk+KxtJAfsLnZRPkZMA7wN83Mj0JLAx/TL5DXEk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757425973841286.9993361899858; Tue, 9 Sep 2025 06:52:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvylk-0000l0-Sc; Tue, 09 Sep 2025 09:52:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvylZ-0000jV-9Z for qemu-devel@nongnu.org; Tue, 09 Sep 2025 09:52:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvylS-0005Ex-Px for qemu-devel@nongnu.org; Tue, 09 Sep 2025 09:52:11 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-zbxhwd5NNtOjgGO9XuNbJQ-1; Tue, 09 Sep 2025 09:52:03 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1266195608E; Tue, 9 Sep 2025 13:52:02 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.46]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E742E1800446; Tue, 9 Sep 2025 13:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757425925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8hvnwMVASc0iPfq0fUmCscKOthayeJNSO/WaWKuRJh8=; b=B6uU323w1YwPF9pZvX093Sxp7PYrcg94b6G1xfwihteYbRzt1kCrs3DAphWkhe73MxiXH/ pVa0udTW7KDATE9QisGizXukVLuuceH6qdPKdfj1f3E32DOvyF0TEOlRf7HSH79aEMt2yC V7CJl3WhvVuHsznmJ4wdM4U0VJSvx/w= X-MC-Unique: zbxhwd5NNtOjgGO9XuNbJQ-1 X-Mimecast-MFC-AGG-ID: zbxhwd5NNtOjgGO9XuNbJQ_1757425922 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 06/23] tests/functional/m68k: Avoid ResourceWarning in the nextcube test Date: Tue, 9 Sep 2025 15:51:30 +0200 Message-ID: <20250909135147.612345-7-thuth@redhat.com> In-Reply-To: <20250909135147.612345-1-thuth@redhat.com> References: <20250909135147.612345-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1757425976467124100 From: Thomas Huth Since commit c3fd296cf7b1 ("functional: always enable all python warnings") we enabled more warnings for the functional tests. This triggers now a warning in the nextcube test: tests/functional/m68k/test_nextcube.py:47: ResourceWarning: unclosed file <_io.BufferedReader name=3D'tests/functional/m68k/test_next= cube.NextCubeMachine.test_bootrom_framebuffer_size/scratch/dump.ppm'> width, height =3D Image.open(screenshot_path).size Use a proper "with" context to avoid it. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20250829142000.62320-1-thuth@redhat.com> --- tests/functional/m68k/test_nextcube.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k= /test_nextcube.py index 13c72bd136a..c1610e58456 100755 --- a/tests/functional/m68k/test_nextcube.py +++ b/tests/functional/m68k/test_nextcube.py @@ -44,7 +44,8 @@ def test_bootrom_framebuffer_size(self): self.check_bootrom_framebuffer(screenshot_path) =20 from PIL import Image - width, height =3D Image.open(screenshot_path).size + with Image.open(screenshot_path) as image: + width, height =3D image.size self.assertEqual(width, 1120) self.assertEqual(height, 832) =20 --=20 2.51.0