From nobody Sun Sep 28 17:03:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1757392561; cv=none; d=zohomail.com; s=zohoarc; b=KyN9GRyrVfqPHKfGz9f/3G+N8o9r5mJF897NDijktssC3axQJ8UlFLIyghFRoflGuJm3/yc2nT9gdlBBmjzfYBBwAVTCK6qeUlVvYmTGn/wnZyd34731MMOOM8J62TPDFVsfJkLEW+zc8IoJHxj/UXu4bUioH9X2C7meXxNjB08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757392561; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WzDwa5raG8Sm10+4ENnYqbcNfW3OS0HNvh0la9YBPno=; b=Gicf7zG6RWamAttN5cxDxJYYoVVwNfak2I8M1odJfuJzuSXoJeK3FDse2auCNI3NQ+6ifyi+w/9xaYIII7GwgF5YafeI994lH7VPC5bqNBFqwqu8pMWz0Wvc3FifEdQTf1eoJOxW1qtM6JPboHoELb1mFrmOUrNfLTWtumB6Rkk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757392561136489.9574657380863; Mon, 8 Sep 2025 21:36:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvq3p-0006JR-2Q; Tue, 09 Sep 2025 00:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvq3n-0006IY-Fx; Tue, 09 Sep 2025 00:34:27 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uvq3k-0003GI-Io; Tue, 09 Sep 2025 00:34:27 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-b4c72885c8bso4232149a12.0; Mon, 08 Sep 2025 21:34:22 -0700 (PDT) Received: from fedora ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-774661247cdsm606534b3a.33.2025.09.08.21.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 21:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757392460; x=1757997260; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WzDwa5raG8Sm10+4ENnYqbcNfW3OS0HNvh0la9YBPno=; b=M8ciZTl3UwF9C8XaGsDXQZfiRCVBv3rcCJ3OfluOwe9/ZWkwWBovTJNpCe9xh1QLX1 tM/VNZaBv337W5Pjo7gj0rAP3QC0BhWOA7952g3Hvmqc4TRcHk9Ijrz/Rieb7CMZFgpN zBtXs3qZIMZ+EqNk4JitM1RSezGOWGSWL2mNfWwozrRq70RcOrkt3qs+UbAe5xTa2n/X hMc695CqHxjXp+uRdOpLB39JIWCIeriJXb7wYLogK6zgNFKcUacRqyC1yIG3UW+F2Bj9 g5hLVTrhmVFiDt2OxpydkQU2p/iG8pCDBwAZIj4X3ihwKBD7hztPCl9ZPSjZ6asGDb4k D/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757392460; x=1757997260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WzDwa5raG8Sm10+4ENnYqbcNfW3OS0HNvh0la9YBPno=; b=Z2Dd1ad2YiOetNryKAGhWx86tl8BGEKXwFYIk5b5Y2IB8YDnhDE9470gryNSL126ln puheklu3NBI3q5Elb6qGxymvOR2uEs94IQpc49Jb6CUiPGNzTx8f0Rt98U9MTNdTADjZ 3JkesvN1VbBe0AtCujJwOLrBq8NxuSnWz7vcqFiDN/IUzlBQjgCMc89/lDogWTYlB3RI 97EP7v8D4bVky4KsjejM/Pb2o9nR6eadKvrfWvVR6u7ICNVM7wbA2ivYJ8kfXAStVGqf xh2NQ+TSYWt25LGiXgWFFkJ4leaf30pbGyvzjuemWfkSqgToz0ZvhAT/mYHw7U/siXnk JIEg== X-Forwarded-Encrypted: i=1; AJvYcCXDdNesXtTIzWincctT44cqmD441c017M7c2FmDCC7vpVzu9c98PEB7/7e12lu2iL4CS+POEWsDqFvd@nongnu.org X-Gm-Message-State: AOJu0YwL6INpoDpvgnlCPKBRZrbW6/0wak6Eff2sZRxGqaDAZY88NVv4 J4UUy5RV5W6KzdhyUsx09W6kjNXvOLiuCS0CqzXElZGeThJ6zQi5Y/PW X-Gm-Gg: ASbGncssHyIbJPwv6DM6Yp8xklZveBgUhx39mr8ohs98lylbUyGIPer80tyuYSbnMpS jNQXVvW7is/LnHqo2eiMXvQ61rJf8JevzEfNJNAIRBnQn6tm7JJevAlJIWJZixK7mK5BfcPHN0F xNlOTbzTDX85yBEZMqXwBVL1WCklA4gDg4YYhpNr9fK9dJhEPTVjMeNJz9ud4pMP7NnJdfrnxhi FOy/ycx3aXBRkFAdZkWBcTVlxqsbIbzKMKJMxWFquVXAulg0jfB0hCqv3xbLXQSYrx3mYVg9f8X bOiwu4w1sBJyNPK7j9gJaDyLw/7B4jno2wmNL0x1kwJm4ky3AjpUM1jm/43AQFf91cclUw/mD0h HcwkMSm5ne5PuD7NKvR1lhwxlNr+dgNxszsdreQ== X-Google-Smtp-Source: AGHT+IHFSBwyK2utun2TNC4gGtAzdCXBgUG0lg2FqmBo8o2awc7edJTWsyKuaOKzLXOGjvs6Jgvwog== X-Received: by 2002:a17:903:46cb:b0:24d:f9f:de8f with SMTP id d9443c01a7336-2516fbdcc8amr155936605ad.17.1757392460026; Mon, 08 Sep 2025 21:34:20 -0700 (PDT) From: Wilfred Mallawa To: Alistair Francis , Keith Busch , Klaus Jensen , Jesper Devantier , Stefan Hajnoczi , Fam Zheng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kevin Wolf , Hanna Reitz , "Michael S . Tsirkin" , Marcel Apfelbaum Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Jonathan Cameron , Wilfred Mallawa Subject: [PATCH v5 4/5] spdm: define SPDM transport enum types Date: Tue, 9 Sep 2025 14:32:59 +1000 Message-ID: <20250909043259.93140-6-wilfred.opensource@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250909043259.93140-2-wilfred.opensource@gmail.com> References: <20250909043259.93140-2-wilfred.opensource@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=wilfred.opensource@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1757392562249124100 Content-Type: text/plain; charset="utf-8" From: Wilfred Mallawa SPDM maybe used over different transports. This patch specifies the trasnport types as an enum with a qdev property definition such that a user input transport type (string) can be mapped directly into the respective SPDM transportenum for internal use. Signed-off-by: Wilfred Mallawa Reviewed-by: Jonathan Cameron --- backends/spdm-socket.c | 23 +++++++++++++++++++++++ include/system/spdm-socket.h | 19 +++++++++++++++---- 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/backends/spdm-socket.c b/backends/spdm-socket.c index 845ea87b72..2321ab72d5 100644 --- a/backends/spdm-socket.c +++ b/backends/spdm-socket.c @@ -13,6 +13,9 @@ #include "qemu/osdep.h" #include "system/spdm-socket.h" #include "qapi/error.h" +#include "hw/qdev-properties.h" +#include "hw/qdev-properties-system.h" +#include "hw/core/qdev-prop-internal.h" =20 static bool read_bytes(const int socket, uint8_t *buffer, size_t number_of_bytes) @@ -247,3 +250,23 @@ void spdm_socket_close(const int socket, uint32_t tran= sport_type) send_platform_data(socket, transport_type, SPDM_SOCKET_COMMAND_SHUTDOWN, NULL, 0); } + +const QEnumLookup SpdmTransport_lookup =3D { + .array =3D (const char *const[]) { + [SPDM_SOCKET_TRANSPORT_TYPE_UNSPEC] =3D "unspecified", + [SPDM_SOCKET_TRANSPORT_TYPE_MCTP] =3D "mctp", + [SPDM_SOCKET_TRANSPORT_TYPE_PCI_DOE] =3D "doe", + [SPDM_SOCKET_TRANSPORT_TYPE_SCSI] =3D "scsi", + [SPDM_SOCKET_TRANSPORT_TYPE_NVME] =3D "nvme", + }, + .size =3D SPDM_SOCKET_TRANSPORT_TYPE_MAX +}; + +const PropertyInfo qdev_prop_spdm_trans =3D { + .type =3D "SpdmTransportType", + .description =3D "Spdm Transport, doe/nvme/mctp/scsi/unspecified", + .enum_table =3D &SpdmTransport_lookup, + .get =3D qdev_propinfo_get_enum, + .set =3D qdev_propinfo_set_enum, + .set_default_value =3D qdev_propinfo_set_default_value_enum, +}; diff --git a/include/system/spdm-socket.h b/include/system/spdm-socket.h index 3d27cc366f..6edbf5185b 100644 --- a/include/system/spdm-socket.h +++ b/include/system/spdm-socket.h @@ -110,11 +110,22 @@ typedef struct { #define SPDM_SOCKET_COMMAND_UNKOWN 0xFFFF #define SPDM_SOCKET_COMMAND_TEST 0xDEAD =20 -#define SPDM_SOCKET_TRANSPORT_TYPE_MCTP 0x01 -#define SPDM_SOCKET_TRANSPORT_TYPE_PCI_DOE 0x02 -#define SPDM_SOCKET_TRANSPORT_TYPE_NVME 0x04 - #define SPDM_SOCKET_MAX_MESSAGE_BUFFER_SIZE 0x1200 #define SPDM_SOCKET_MAX_MSG_STATUS_LEN 0x02 =20 +typedef enum SpdmTransportType { + SPDM_SOCKET_TRANSPORT_TYPE_UNSPEC =3D 0, + SPDM_SOCKET_TRANSPORT_TYPE_MCTP, + SPDM_SOCKET_TRANSPORT_TYPE_PCI_DOE, + SPDM_SOCKET_TRANSPORT_TYPE_SCSI, + SPDM_SOCKET_TRANSPORT_TYPE_NVME, + SPDM_SOCKET_TRANSPORT_TYPE_MAX +} SpdmTransportType; + +extern const PropertyInfo qdev_prop_spdm_trans; + +#define DEFINE_PROP_SPDM_TRANS(_name, _state, _field, _default) \ + DEFINE_PROP_UNSIGNED(_name, _state, _field, _default, \ + qdev_prop_spdm_trans, SpdmTransportType) + #endif --=20 2.51.0