From nobody Wed Sep 10 05:57:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1757351034; cv=none; d=zohomail.com; s=zohoarc; b=ZMmE3Ar7aAiTbOqdA6GyyjpnFYp9H2BOCY77zImVsxYO+xPuEo9imlsCOaEuGrSyyl3KxxB9Ta8ucuZg8HkSZS6nIi6qy8KD0wXkMKyhyP0ZQB52gF6M5u+4EkZNgQFxZa0+KevihfeIKbSR2Wz+bks6nO+J1s94RHfzKGm06Xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757351034; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LxL649bZ9kgLbkNAweSzp4umnC2umcgzjheXrcb5Kvc=; b=enSnFAIKdrGFLE3T8oO0B1fiNcWDbjGq+YKzmNZdK8Qoo8VnmtPnJjng/ar7Hc+jTWrf63rwtT7bIHe2gxonAPaRFDC0WwbSMlxVgOccAFv0liXOO56xN8VBMJdh+14Ej87YW1zEx3czr0SU8yw0RrNkuYeq9sSTC4x6k6v3tAE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17573510345611023.2911036967951; Mon, 8 Sep 2025 10:03:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvf9A-0007Or-4s; Mon, 08 Sep 2025 12:55:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvf8v-00079k-BC for qemu-devel@nongnu.org; Mon, 08 Sep 2025 12:55:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvf8s-0001dx-27 for qemu-devel@nongnu.org; Mon, 08 Sep 2025 12:55:00 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-UfzzD-4jP0-E-iV9DNHPgw-1; Mon, 08 Sep 2025 12:54:50 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BC1C1800447; Mon, 8 Sep 2025 16:54:49 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.50]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8AD28300018D; Mon, 8 Sep 2025 16:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757350493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxL649bZ9kgLbkNAweSzp4umnC2umcgzjheXrcb5Kvc=; b=EgYl/zM9fjIC6POllRgLfplXotXwsF5FCg+/X9VmCYOgn97MbifrQhqWUXjv8PuBhDGd++ jHC/Wl2huYvamzccwvFpuKc/ElWUxpK6UETvPvwgzOzcTiPkqXvDNfyu9qmlzJbGk6aXoD vChS5VxI/Mo1p+1C76Sp8BCBUGVGOKs= X-MC-Unique: UfzzD-4jP0-E-iV9DNHPgw-1 X-Mimecast-MFC-AGG-ID: UfzzD-4jP0-E-iV9DNHPgw_1757350489 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , Mark Cave-Ayland , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Levon Subject: [PULL 19/31] vfio/container.c: use QOM casts where appropriate Date: Mon, 8 Sep 2025 18:53:42 +0200 Message-ID: <20250908165354.1731444-20-clg@redhat.com> In-Reply-To: <20250908165354.1731444-1-clg@redhat.com> References: <20250908165354.1731444-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1757351036549116600 From: Mark Cave-Ayland Use QOM casts to convert between VFIOUserContainer and VFIOContainerBase in= stead of accessing bcontainer directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: John Levon Link: https://lore.kernel.org/qemu-devel/20250715093110.107317-10-mark.cave= ayland@nutanix.com Signed-off-by: C=C3=A9dric Le Goater --- hw/vfio-user/container.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/vfio-user/container.c b/hw/vfio-user/container.c index d589dd90f501bbb3442c7fdc263529501086510d..3cdbd44c1aac2153dd099139a39= 56a3a0bb9b48e 100644 --- a/hw/vfio-user/container.c +++ b/hw/vfio-user/container.c @@ -24,16 +24,14 @@ */ static void vfio_user_listener_begin(VFIOContainerBase *bcontainer) { - VFIOUserContainer *container =3D container_of(bcontainer, VFIOUserCont= ainer, - bcontainer); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(bcontainer); =20 container->proxy->async_ops =3D true; } =20 static void vfio_user_listener_commit(VFIOContainerBase *bcontainer) { - VFIOUserContainer *container =3D container_of(bcontainer, VFIOUserCont= ainer, - bcontainer); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(bcontainer); =20 /* wait here for any async requests sent during the transaction */ container->proxy->async_ops =3D false; @@ -44,8 +42,8 @@ static int vfio_user_dma_unmap(const VFIOContainerBase *b= container, hwaddr iova, ram_addr_t size, IOMMUTLBEntry *iotlb, bool unmap_all) { - VFIOUserContainer *container =3D container_of(bcontainer, VFIOUserCont= ainer, - bcontainer); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(bcontainer); + Error *local_err =3D NULL; int ret =3D 0; =20 @@ -86,8 +84,8 @@ static int vfio_user_dma_map(const VFIOContainerBase *bco= ntainer, hwaddr iova, ram_addr_t size, void *vaddr, bool readonly, MemoryRegion *mrp) { - VFIOUserContainer *container =3D container_of(bcontainer, VFIOUserCont= ainer, - bcontainer); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(bcontainer); + int fd =3D memory_region_get_fd(mrp); Error *local_err =3D NULL; int ret =3D 0; @@ -173,8 +171,7 @@ static int vfio_user_query_dirty_bitmap(const VFIOConta= inerBase *bcontainer, =20 static bool vfio_user_setup(VFIOContainerBase *bcontainer, Error **errp) { - VFIOUserContainer *container =3D container_of(bcontainer, VFIOUserCont= ainer, - bcontainer); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(bcontainer); =20 assert(container->proxy->dma_pgsizes !=3D 0); bcontainer->pgsizes =3D container->proxy->dma_pgsizes; @@ -218,7 +215,7 @@ vfio_user_container_connect(AddressSpace *as, VFIODevic= e *vbasedev, goto put_space_exit; } =20 - bcontainer =3D &container->bcontainer; + bcontainer =3D VFIO_IOMMU(container); =20 ret =3D ram_block_uncoordinated_discard_disable(true); if (ret) { @@ -263,7 +260,7 @@ put_space_exit: =20 static void vfio_user_container_disconnect(VFIOUserContainer *container) { - VFIOContainerBase *bcontainer =3D &container->bcontainer; + VFIOContainerBase *bcontainer =3D VFIO_IOMMU(container); VFIOIOMMUClass *vioc =3D VFIO_IOMMU_GET_CLASS(bcontainer); VFIOAddressSpace *space =3D bcontainer->space; =20 @@ -291,7 +288,7 @@ static bool vfio_user_device_get(VFIOUserContainer *con= tainer, =20 vbasedev->fd =3D -1; =20 - vfio_device_prepare(vbasedev, &container->bcontainer, &info); + vfio_device_prepare(vbasedev, VFIO_IOMMU(container), &info); =20 return true; } @@ -315,8 +312,7 @@ static bool vfio_user_device_attach(const char *name, V= FIODevice *vbasedev, =20 static void vfio_user_device_detach(VFIODevice *vbasedev) { - VFIOUserContainer *container =3D container_of(vbasedev->bcontainer, - VFIOUserContainer, bcontai= ner); + VFIOUserContainer *container =3D VFIO_IOMMU_USER(vbasedev->bcontainer); =20 vfio_device_unprepare(vbasedev); =20 --=20 2.51.0