From nobody Wed Sep 10 04:31:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1757339965; cv=none; d=zohomail.com; s=zohoarc; b=PZylRx9suBIzLLQyHwkAtY02qCFTUZTVckRvIR0Hy02dFrayQjbC5GSTKSAXWs2ArcuKBlnepv+pvzm3iESE3BxRhadquAeW0db4MhOEmYe/AsgPliKu4MxY4Zn63IJ049Qkefm7jV/lN2QcCG8lCUoyNIWpS9x/CgigdT6T6aE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757339965; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KYR8qniNbAIhKaaxm22geyDivz6LBRyhYUYXniKr9r4=; b=Fb1RcLbHdjbhlrRlVqTWDo86bINPVIYC02Exv2BdJUVhvDu3UKIwehO/AsA2iOJvJH6SKBUI58AgLhCa92KMTMNhrAto3XC7C835sC1C29VgcApbKMQ1FtNii/orCz1UqGyrEuqI0MP2St9gRJ59uqXnkYAjoy1OjSFwxY/Eivk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757339965247800.5549282926208; Mon, 8 Sep 2025 06:59:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvcNY-0003vQ-1c; Mon, 08 Sep 2025 09:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvcNV-0003tw-FN for qemu-devel@nongnu.org; Mon, 08 Sep 2025 09:57:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvcNM-0005cS-BZ for qemu-devel@nongnu.org; Mon, 08 Sep 2025 09:57:52 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-EmIJ1ubWOUW2qetZiby80g-1; Mon, 08 Sep 2025 09:57:28 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 926B519560AB; Mon, 8 Sep 2025 13:57:27 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.93]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0B3B6180044F; Mon, 8 Sep 2025 13:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757339852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KYR8qniNbAIhKaaxm22geyDivz6LBRyhYUYXniKr9r4=; b=XKHXf0ANUbGrCxDqrrPNEdPACQ/g+geEojwyr76zdT71qbO91bcvhb0J/ATh5GVjlg6igA jz6m2Mi0GMRVAqyLpvlUCJC6D0tqYNBZ50d6Iya9TLSz+NpnUdCOYg0SMyUHBzSjWcMTOC Q4Jwgqg/Kj5xwYFc/bfhXDzHHqOf6bc= X-MC-Unique: EmIJ1ubWOUW2qetZiby80g-1 X-Mimecast-MFC-AGG-ID: EmIJ1ubWOUW2qetZiby80g_1757339847 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] tests/functional: fix infinite loop on console EOF Date: Mon, 8 Sep 2025 14:57:19 +0100 Message-ID: <20250908135722.3375580-2-berrange@redhat.com> In-Reply-To: <20250908135722.3375580-1-berrange@redhat.com> References: <20250908135722.3375580-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1757339967352124101 The 'recv' method will return an empty byte array, not None, when the socket has EOF. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth --- tests/functional/qemu_test/cmd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test= /cmd.py index dc5f422b77..2fb731ca24 100644 --- a/tests/functional/qemu_test/cmd.py +++ b/tests/functional/qemu_test/cmd.py @@ -51,7 +51,7 @@ def _console_read_line_until_match(test, vm, success, fai= lure): done =3D False while True: c =3D vm.console_socket.recv(1) - if c is None: + if not c: done =3D True test.fail( f"EOF in console, expected '{success}'") --=20 2.50.1