From nobody Sat Sep 6 17:16:35 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1757080430; cv=none; d=zohomail.com; s=zohoarc; b=nCt2oj+lop53ziXN/jSsy7mAw5mPvx4smhYezneveX21ss3Skmr6Ws9QCaalgUfqoERARKXM3R6dhV8BB4NBdwExsEMRuWJqreluLRFH2/AdY9wGzSIUfLCr8/nv1joF2AyrvpWqZCJv4wxGgF4951zssSQq0nAsmUTHSHvwNhI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757080430; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Eu31Z84cv7HW21LtKBhasXjdiIYgRYFKi7HX9Rx+K30=; b=RqCLGx0LNIuQ2eOOuOAPXuyIrBNi9y1lNYpsfcJenF5SFbzfHXLI0BAq1eCBAAZjtpa3oeM7Mb9yfIbVfdlQvBd+ksbck00GLvaf+2f7izCU1MMbwBLt6A1lpKy3vyu+6Vggqh3pGgq13H3hDY59FJEXCS/qTJI2AI4OUiG61ag= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175708043059140.718263233874836; Fri, 5 Sep 2025 06:53:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuWqN-0001jh-EX; Fri, 05 Sep 2025 09:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuWqK-0001iB-QG for qemu-devel@nongnu.org; Fri, 05 Sep 2025 09:51:09 -0400 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuWq2-0006XE-Mz for qemu-devel@nongnu.org; Fri, 05 Sep 2025 09:51:07 -0400 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 224AEC108F; Fri, 05 Sep 2025 16:50:44 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:b8f::1:11]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id foiXcl3Gh8c0-5dQR3RFv; Fri, 05 Sep 2025 16:50:43 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1757080243; bh=Eu31Z84cv7HW21LtKBhasXjdiIYgRYFKi7HX9Rx+K30=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=AziRMqq4QwEcPwXORTUOAUDMw9mG9z12zfp2fS1LKD0HJW3toMI5QlyptkhrfypNH IT3gohqYj6mpRaDFLbEcS/5cxltcCcm6+s+iZxaLz8X9geLtJZvncj7vNFfu156IpM 1AHSxCZ+ikj5ld1qK331EirAhHJhPG1g1ksXY/LY= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: jasowang@redhat.com Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, leiyang@redhat.com, steven.sistare@oracle.com, yc-core@yandex-team.ru, peterx@redhat.com, mst@redhat.com, farosas@suse.de, eblake@redhat.com, armbru@redhat.com, thuth@redhat.com, philmd@linaro.org, berrange@redhat.com Subject: [PATCH v3 2/9] net/tap: keep exit notifier only when downscript set Date: Fri, 5 Sep 2025 16:50:32 +0300 Message-ID: <20250905135039.2202924-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250905135039.2202924-1-vsementsov@yandex-team.ru> References: <20250905135039.2202924-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1757080432435116601 Content-Type: text/plain; charset="utf-8" The notifier is used only to call the downscript. Avoid extra notifier for other cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/net/tap.c b/net/tap.c index 151fb73820..4f3512a831 100644 --- a/net/tap.c +++ b/net/tap.c @@ -336,8 +336,10 @@ static void tap_cleanup(NetClientState *nc) =20 qemu_purge_queued_packets(nc); =20 - tap_exit_notify(&s->exit, NULL); - qemu_remove_exit_notifier(&s->exit); + if (s->exit.notify) { + tap_exit_notify(&s->exit, NULL); + qemu_remove_exit_notifier(&s->exit); + } =20 tap_read_poll(s, false); tap_write_poll(s, false); @@ -727,9 +729,7 @@ static int net_tap_fd_init_common(const Netdev *netdev,= NetClientState *peer, } tap_read_poll(s, true); s->vhost_net =3D NULL; - - s->exit.notify =3D tap_exit_notify; - qemu_add_exit_notifier(&s->exit); + s->exit.notify =3D NULL; =20 if (netdev->type =3D=3D NET_CLIENT_DRIVER_BRIDGE) { const NetdevBridgeOptions *bridge =3D &netdev->u.bridge; @@ -757,6 +757,8 @@ static int net_tap_fd_init_common(const Netdev *netdev,= NetClientState *peer, snprintf(s->down_script, sizeof(s->down_script), "%s", downscr= ipt); snprintf(s->down_script_arg, sizeof(s->down_script_arg), "%s", ifname); + s->exit.notify =3D tap_exit_notify; + qemu_add_exit_notifier(&s->exit); } } =20 --=20 2.48.1