From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073177; cv=none; d=zohomail.com; s=zohoarc; b=kUs7DBAEUvfLLtWazeGZGOF/ZySnJ9kaNpHgab6Bw5QPT1odzHyFGzibSVFL5Twc/HYiHLUoToR0Q5M7ZK1eLDyfZpuhx59v0agLlP+hWH8w9dLjqALfCq4bp2YuVOJtQOpXIIFG2NZt2fuxndLj0Yksfv7g0vjsOwNL7QbhUq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073177; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yBFgDZ+KFYIfRuUAnB7MMFYJ1NFGAOxLls8M4S/0WOc=; b=VEB6FWhQzvG/noxSig/1bDVWtrj37c9lDZYovbxtZQuc4YwDkA0z9eLIKgNpYrGy/rgbToFgCVNHh2j5H5hjxXpQT+OnKxPNbapXv3igHzI2/Fbktmxaj4Izo7kTNaRfMTi+ffYe1Fb6uD7K+jktBjMC4c+R3F+WbANVGa3BNZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073177356913.5447799173274; Fri, 5 Sep 2025 04:52:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUyv-0001Zf-RX; Fri, 05 Sep 2025 07:51:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUyr-0001X6-9V for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:49 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyd-0003YJ-Q0 for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:42 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-45dd505a1dfso8746335e9.2 for ; Fri, 05 Sep 2025 04:51:33 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073090; x=1757677890; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBFgDZ+KFYIfRuUAnB7MMFYJ1NFGAOxLls8M4S/0WOc=; b=teqy8vXf1EkoNnL28HdyxRDkoWntJ3X22m8xAq+f2+EKObiSMQLUNuzXrzynVs3zZr th0zZduaGaJyUSuUpr/x8FD3SbwzmEaTAxNvFxSOf/KXdMcnuj9yMo80x3rdGf2z5geN HXM0JRdxOsbthQJBBeHICJX/MkbAqAdaOfOWuJSeKTRkExH6STIw1NAD6DpL2gpQ9ETV 11BLTl8nIQ2seDMDvSRWr2mwOSLGctvw7Oj6p5TVVA2plz1DiMWXDIiw+P4mNmbUbJDI ZpfFp85ZLw59h9yf8VFgY6Krl5waSjEeuwMb1tq5GISuNMhdYL6EO0md38Nn34tF34La 9pEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073090; x=1757677890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yBFgDZ+KFYIfRuUAnB7MMFYJ1NFGAOxLls8M4S/0WOc=; b=MB6XpmPudaStThWO7ipG2kPJlSZB84VsFnzN5CmiX+NK0jaBvfnm7netHrB1BxFPKX KWjr7eHDk1WvFZyRVIe/HIr4a27oZokRiNWHt6dNV1mfUI+sbSWPicvUk2T9NFoLJ1qi ehcLDjHtJ4ufHJPhHh6dpKi8U4Dpx4NZezYpWGMCl9k9uTYUoOm7PvOZtb12mTWqUwdI aY7WiQ7PA+pT8WHw5tubVqfVN35daA0hl26Q26wDO9jmPt4ay0RwXQciTnrc0jL/ApQy eOkq7rE45nnSUVlcrjUHA6n9XCoIJt9ViR7Ms6NJAzPoqlfa41ysJg5q3QJBs/m/T+R+ 63Sg== X-Gm-Message-State: AOJu0YwQD39S73YvMU9l90Z5+qEh82ECFfboU78xwwPAAS8d+Kk0ZpPe WRYrHFGY3TBxzo8CqFqjKvWMfvcJgU5zD55qIpHzDI2AGxkJlTVuOjmJ2fm1wDIt9fGSzBLIBXn x5iXQ0Ho= X-Gm-Gg: ASbGnctnNi5EBPKAuqE2zlLoM39qYftfki0gKWWaA8tKdPrp+IkHsIZqIKmsfjZpeSL coDmbu9098DKxtcwUwHyX27GdEOXrZKEa6ly6GpFsHSkLsw6SOpgTv/MgktO0yuE0/k4MHqhyTd RC8tfNIOh8j+1pHYXgGqMvFHeSzjUWIQq6e0AqEGOW5g/0+DWERoJvr08ZYUqrr+js+0cnHz4p0 29QE2BPXG/WA29Kx2y4Agiu6onyeN5AaPDbXIlA//+tjtiL5vUgQqeKcpJDw+yqM/hG1OWyagyb JsA2uqAb6NvwI17/Fu0OtaY27WMmVsE+s6s6LUxTLoNVbTKgH7im2Hum7Dc5qkwLKJTySCk1D2A cq8ZghVZc3fgHJHhmMSsu1unbyTQhZOl2yyMKITbqEGdRhHoYyhhiac4M X-Google-Smtp-Source: AGHT+IFIkiQeKl4Z5CZeAy1gvzjXpMMW5mlt/KfS0LwjJfqmMiFNs95iYEM4bUyBPj2lSX9/BtLfEg== X-Received: by 2002:a05:600c:1f84:b0:45b:7ce0:fb8a with SMTP id 5b1f17b1804b1-45b8559bd2fmr186286995e9.35.1757073090388; Fri, 05 Sep 2025 04:51:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 1/7] target/sparc: Allow TRANS macro with no extra arguments Date: Fri, 5 Sep 2025 13:51:22 +0200 Message-ID: <20250905115128.376295-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073180571124100 Content-Type: text/plain; charset="utf-8" Use ## to drop the preceding comma if __VA_ARGS__ is empty. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index b922e53bf1..336583beab 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2487,7 +2487,7 @@ static int extract_qfpreg(DisasContext *dc, int x) =20 #define TRANS(NAME, AVAIL, FUNC, ...) \ static bool trans_##NAME(DisasContext *dc, arg_##NAME *a) \ - { return avail_##AVAIL(dc) && FUNC(dc, __VA_ARGS__); } + { return avail_##AVAIL(dc) && FUNC(dc, ## __VA_ARGS__); } =20 #define avail_ALL(C) true #ifdef TARGET_SPARC64 --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073257; cv=none; d=zohomail.com; s=zohoarc; b=QZJH02nbar+adWc3g1a5je3B/Hr9CpFyY3G4xWtYuqyngo/vPpgogYh3T51Bv64fbIHI/qBYduRDYsIAb2oWQ6GJy8gf77iDpuRhos44dpNjjSpiQ0yr8ZKCmvE5GsP8Qz6kVjqedyxKlyAK1Wbs3ew6erfuW8aTmC8fzDW7rOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073257; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xlzJQOFlorrMw5CndfvG4jengOA2DFNt3pdatOiYndA=; b=ctaNuvy+MbH4yC5OscmgZqcT0yEBXt43qEpg2U52xsQSyl/vjf7MLOwBP5WpWnGuTZLadsDoKnqybK3YtKqR1Mj7cWSeuE+5Oni4TfoNCZdJh/KLb0z0H4caeeZekyLUzOFKJb2LRl1Qd26fqLSVT2LctJVuUZKksuQzoa2djr0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073256974351.70050635915425; Fri, 5 Sep 2025 04:54:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUz0-0001bS-2R; Fri, 05 Sep 2025 07:51:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUyw-0001Zm-Go for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:54 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyh-0003YN-Sz for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:53 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-45b7722ea37so10957455e9.1 for ; Fri, 05 Sep 2025 04:51:33 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073091; x=1757677891; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xlzJQOFlorrMw5CndfvG4jengOA2DFNt3pdatOiYndA=; b=d0puMIR9dvQmvt4Y2caxHiScWvI6PQMnH44my797pWyr2CeWmVfU0saq/S8M4/07LC hM1QAVs7Z0KCcR+BJC7OyMvmVu5hVwp9FiA0c3GE/3Fei0yWEJVVeQZ5kDmBgf5D0P56 AUjOIT+5v1x4+RxI86tTHY8ppPj1LNuw/uFjMiDjZV4QZcfAU3RfGjR1p9fNx/VRgmY3 Ar9JtzNWCvJWxvEL0Tc2+Oycv35WxsmddvQF7rKLU1n/wXeewyxVK65hNf+O+DvlwxQt 4OEYR0R4/r6+Z137vgTRgAhAPiC9C/EwBdoVAruSBm3eILowuX8bR+qCRq7lT7YGm/07 mEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073091; x=1757677891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xlzJQOFlorrMw5CndfvG4jengOA2DFNt3pdatOiYndA=; b=aDslgtHOv2z6CnnluEToOAuXbyypHKY03JDEAq0ggbokQFegsnzDiDQF511V0jGBwg 2BG5WE6wwaEQg8W788dF4ImCDr3BlCiSX5PjX4OQEJGXyx8lz/SzRaDMP1wq1mZekw3H PdeFfVBhnDPZsXFT/nEaDKXi4zc4FfJyA9BEzDL+yBTQ4KxFeyqj3g3UiSZiE7y2ZzxH kX8hrb6yLMXUDKQWA+oWipnHQ+/xD3zX8ZfZRXXzbsoyDxXOsSxVzFtHcEWQxOJ/ETm+ N53zMUf9p/rjGIt9Ve4rv73GbV0+IqqT8DGgXwI+BA9cnLKtz1NkNmkXN3g8lQv7A/H8 OhkA== X-Gm-Message-State: AOJu0YySIz8aFz7W2wKS1ZyUg1W8oaN2pjqMcGMv5d7WFOjdSkeqsXBJ DIyirqe7ewWXeD7TKKNgjLpROHh2FqU61JDlHBlz107FTOHeXLNKfJxkr0uTarm0M0QYmHTsgP7 wTDMmBN4= X-Gm-Gg: ASbGncuJUtVYi79Tp0NC5MI60FqnFoMCjxzD12dIqX+HrUfCR9E3M6VL+uc6XeN95oE UtycBIVVWaFxMujJlUzWGeEdELxf6uNIC7ykaxbQU40+bnSbqebEjKagfX0ozrRoCLy+SdDBpel adZ7gqdJGT6wIsIMljDojLV3ccY8iAGp0iDJCzQAAIKvILNQrw40X5x4uiaQnvHYqYY/A2UPeaI 4zj9tDNR0dn0kp4Bbg9tkwECmA9M/oKsw9XmnIl4vbEIGnjI96hy9KtDrqczPJoUoa+CcYEUDDS LbuGxmUMbA/1JjtkgHwFTNgXOVHKsbuSEWX0CimRwvSJJOyuekI+C3OH0HB714BAiQ3LXF+k177 woAGdHsazyWp7nZN7MUK7tAQllD6Puvm3sdCzuwGoU9bBy2eGAdGxwjFS X-Google-Smtp-Source: AGHT+IEBa4QclhZsjHuBj4L+oqb4qsbaioZfkhBNDnOIMF7Jxb64n3elhC/sm1WQWRI5aIcSakTX1g== X-Received: by 2002:a05:600c:8706:b0:45c:b523:5a09 with SMTP id 5b1f17b1804b1-45dd5b52cacmr29819905e9.16.1757073091228; Fri, 05 Sep 2025 04:51:31 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 2/7] target/sparc: Loosen decode of STBAR for v8 Date: Fri, 5 Sep 2025 13:51:23 +0200 Message-ID: <20250905115128.376295-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073258919124101 Content-Type: text/plain; charset="utf-8" Solaris 8 appears to have a bug whereby it executes v9 MEMBAR instructions when booting a freshly installed image. According to the SPARC v8 architecture manual, whilst bits 13 and bits 12-0 of the "Read State Register Instructions" are notionally zero, they are marked as unused (i.e. ignored). Fixes: af25071c1d ("target/sparc: Move RDASR, STBAR, MEMBAR to decodetree") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3097 Signed-off-by: Richard Henderson Reviewed-by: Mark Cave-Ayland Tested-by: Mark Cave-Ayland --- target/sparc/translate.c | 5 ++++- target/sparc/insns.decode | 13 ++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 336583beab..ece393fffc 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2823,12 +2823,15 @@ static bool trans_Tcc_i_v9(DisasContext *dc, arg_Tc= c_i_v9 *a) return do_tcc(dc, a->cond, a->cc, a->rs1, true, a->i); } =20 -static bool trans_STBAR(DisasContext *dc, arg_STBAR *a) +static bool do_stbar(DisasContext *dc) { tcg_gen_mb(TCG_MO_ST_ST | TCG_BAR_SC); return advance_pc(dc); } =20 +TRANS(STBAR_v8, 32, do_stbar) +TRANS(STBAR_v9, 64, do_stbar) + static bool trans_MEMBAR(DisasContext *dc, arg_MEMBAR *a) { if (avail_32(dc)) { diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 9e39d23273..1b1b85e9c2 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -88,7 +88,7 @@ CALL 01 i:s30 =20 { [ - STBAR 10 00000 101000 01111 0 0000000000000 + STBAR_v9 10 00000 101000 01111 0 0000000000000 MEMBAR 10 00000 101000 01111 1 000000 cmask:3 mmask:4 =20 RDCCR 10 rd:5 101000 00010 0 0000000000000 @@ -107,6 +107,17 @@ CALL 01 i:s30 RDSTICK_CMPR 10 rd:5 101000 11001 0 0000000000000 RDSTRAND_STATUS 10 rd:5 101000 11010 0 0000000000000 ] + + # The v8 manual, section B.30 STBAR instruction, says + # bits [12:0] are ignored, but bit 13 must be 0. + # However, section B.28 Read State Register Instruction has a + # comment that RDASR with rs1 =3D 15, rd =3D 0 is STBAR. Here, + # bit 13 is also ignored and rd !=3D 0 is merely reserved. + # + # Solaris 8 executes v9 MEMBAR instruction 0x8143e008 during boot. + # This confirms that bit 13 is ignored, as 0x8143c000 is STBAR. + STBAR_v8 10 ----- 101000 01111 - ------------- + # Before v8, all rs1 accepted; otherwise rs1=3D=3D0. RDY 10 rd:5 101000 rs1:5 0 0000000000000 } --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073272; cv=none; d=zohomail.com; s=zohoarc; b=AHcqjaLNGyR9Ta4fWQvrnhhZYaub9ygQ1IiTIeA/JIofHcRGnbMr0FmzyEIGrx7qtfbXGMhOvYRSlXgvkcuKeU9jH6mGNYLF7tgVJKPa+qpNjQ9OzZtkpg4Z8ZFT7REtMzogaSaoghZhV5izRpJWAP+DSeBbHZBdNqR6gJBlOFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073272; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QRAc5xsl1m+VhgQiShnpQM6Hj9dAAWKFHFsWJQupR0Q=; b=JhErfWNG+8wQNvBcgBPcSG+REkDqJkpW8mzC1J4e5Tj2RWpX1zcQLeVQHv9hY2Gf+8PWJhOcH+xrxgZstKjiXchV1ZDbkqgDlRjMlSK8MX24rWTFj6ijwCp17eDIBYg3TGF/lgZ+Xz1zZE2bTp1Ld5c4IPFVM6IH1AkjlVy56+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073272820760.2790450114101; Fri, 5 Sep 2025 04:54:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUz6-0001dY-94; Fri, 05 Sep 2025 07:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUyw-0001Zn-K2 for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:55 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyh-0003YW-E8 for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:53 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-45b83ae1734so12212725e9.0 for ; Fri, 05 Sep 2025 04:51:35 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073092; x=1757677892; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QRAc5xsl1m+VhgQiShnpQM6Hj9dAAWKFHFsWJQupR0Q=; b=RKywCmrWEqtA63n0aOWj+eMGkPSTDQ/NQbhYLwrcwG7UnVaak9vyagvyDKfuAcAurh nWS4K3R0WLenjMMwJeE/Ayy1Y0AskCQEkBvne6LjND4s6A5lFky/4gINYdNErIH7Y+cB jSrq46Yw55iF6+Nzkg3+b1RqeXYi/z8NYboYIiHEyaId5nUMoGUmMepfl6X2Wkl+2TGr 1V+VcFZLBITQcGr9gcU/stSIF2fDhF0/EhDR6XsaaBFu0wFw5G41uLpaSxMx20XmBgwY bdbb8WUse0/8716uHO8YWs6PrkL1ZDfWDyW2LaLpmr4fGDjSG2w3qKyFhb9244ES7CrH aTQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073092; x=1757677892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QRAc5xsl1m+VhgQiShnpQM6Hj9dAAWKFHFsWJQupR0Q=; b=uaMSz+prQcHMeeapGhJsKRbzr4Ie0fPCgEe0MEBgUY6uq0ZxYtlGpfI0Tzl5pUXqu5 bVaR2fOJ7PorVd8NVAion90UrOdok1pHYBzuB3DPOP7a6FtNQ0Hi3TSb6aE5NlDapTYV SI2bH0Qfg+7UmXpsDmx2KQcBENWyuXMzgynngIoOu26avQH6QCSeyv/QL/jFDdliXT50 +7BV0JeZUMHABdrM09Qxbo/I0HAwFvfESz8F4cL2/h1/+LFLjkGGETaCD227DL24VyiI b0jvMDQxc21SLGqcQ3c/O0xyxEMOdNW4QXbE/oCB3rv8qJypcCTvA+Eccfuv3k37Zx08 k1dQ== X-Gm-Message-State: AOJu0YwjpfpHtqFVm/vqBCiGxVzKeoYxIvOUAlBFzLwZ+JD/QyX2U4gM /YAr0drcN7HFc9WdD6vE478kNhcWtyBlaHeEMiwAufCp+uAicKtUptmQ/WWHf68TfP91tmQLHAx MT3txFqI= X-Gm-Gg: ASbGnctDSvRf7Gcy40YOvolWSI49q06CFMUYfKnocScL2pL0XbimRNYtgv4JFpiJuIu zfZwNXGm+ndqmBjduCIkx4h0bQl+j1pIkhD0lTBwMiLxj9fTrDKdvYBvgcCOQVzWtVja4shG/7+ NDakl9nZ52a257WUf/M8NnwDiFYm/9kmkm3AsKRDYZu7+6Cb7uAJLRy1srtGHaNrMmgSlBQs7w/ jEW4owF0IOmy9xmlOUxGSuE5PiEmE2oDHlw9cyjjRuxQTh0rQ6IyjXH/MxAEh8VgEBrjEBJMD5Q E3tm8kH3BAU0DOX6O3FBTFTvwH3FQzxwXJHmwf87Gm8tbWctXlBuGJaphbcWjhh9D+eIhepiM10 wkPKBfWYlAN+XvtRflQ3qHktJHw/7HtaIxfQMLOwrK3hddw== X-Google-Smtp-Source: AGHT+IECuoN9SI3WJVaYQ8UbPL01dMYz7L+gYRudquYjCkk0F3MMQAmJ8sb2A0h8U5VkNznuy7Jv9A== X-Received: by 2002:a05:600c:1914:b0:45b:8a6f:c6de with SMTP id 5b1f17b1804b1-45b8a6fc825mr157000985e9.29.1757073092245; Fri, 05 Sep 2025 04:51:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 3/7] target/sparc: Loosen decode of RDY for v7 Date: Fri, 5 Sep 2025 13:51:24 +0200 Message-ID: <20250905115128.376295-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073273635116600 Content-Type: text/plain; charset="utf-8" Bits [18:0] are not decoded with v7, and for v8 unused values of rs1 simply produce undefined results. Fixes: af25071c1d ("target/sparc: Move RDASR, STBAR, MEMBAR to decodetree") Signed-off-by: Richard Henderson Reviewed-by: Mark Cave-Ayland Tested-by: Mark Cave-Ayland --- target/sparc/translate.c | 14 ++------------ target/sparc/insns.decode | 12 ++++++++++-- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index ece393fffc..cfdd9c1ce4 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2863,18 +2863,8 @@ static TCGv do_rdy(DisasContext *dc, TCGv dst) return cpu_y; } =20 -static bool trans_RDY(DisasContext *dc, arg_RDY *a) -{ - /* - * TODO: Need a feature bit for sparcv8. In the meantime, treat all - * 32-bit cpus like sparcv7, which ignores the rs1 field. - * This matches after all other ASR, so Leon3 Asr17 is handled first. - */ - if (avail_64(dc) && a->rs1 !=3D 0) { - return false; - } - return do_rd_special(dc, true, a->rd, do_rdy); -} +TRANS(RDY_v7, 32, do_rd_special, true, a->rd, do_rdy) +TRANS(RDY_v9, 64, do_rd_special, true, a->rd, do_rdy) =20 static TCGv do_rd_leon3_config(DisasContext *dc, TCGv dst) { diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 1b1b85e9c2..74848996ae 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -91,6 +91,7 @@ CALL 01 i:s30 STBAR_v9 10 00000 101000 01111 0 0000000000000 MEMBAR 10 00000 101000 01111 1 000000 cmask:3 mmask:4 =20 + RDY_v9 10 rd:5 101000 00000 0 0000000000000 RDCCR 10 rd:5 101000 00010 0 0000000000000 RDASI 10 rd:5 101000 00011 0 0000000000000 RDTICK 10 rd:5 101000 00100 0 0000000000000 @@ -118,8 +119,15 @@ CALL 01 i:s30 # This confirms that bit 13 is ignored, as 0x8143c000 is STBAR. STBAR_v8 10 ----- 101000 01111 - ------------- =20 - # Before v8, all rs1 accepted; otherwise rs1=3D=3D0. - RDY 10 rd:5 101000 rs1:5 0 0000000000000 + # For v7, bits [18:0] are ignored. + # For v8, bits [18:14], aka rs1, are repurposed and rs1 =3D 0 is RDY, + # and other values are RDASR. However, the v8 manual explicitly + # says that rs1 in 1..14 yield undefined results and do not cause + # an illegal instruction trap, and rs1 in 16..31 are available for + # implementation specific usage. + # Implement not causing an illegal instruction trap for v8 by + # continuing to interpret unused values per v7, i.e. as RDY. + RDY_v7 10 rd:5 101000 ----- - ------------- } =20 { --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073178; cv=none; d=zohomail.com; s=zohoarc; b=AWhlASacXOYZopxwgnp9KnZ7PpXhk13wMptGvDczd/9GGWgxTqgx8CzctChj5JRdpVsu2OGhBuM2Gin6e6sOSr7A1iwGAoOvQpQlIXb8wAfKfCs16732V+ZJdyGR1Amv54Gb1KhzbBk4DSPJTjkQ+lUdexUm62tn/tyDnxFrG1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073178; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vIej8KJ0qwZtdzS8NUwMCivvv646uavNq2u0pssJkXg=; b=EcTFp4cJT3+0yNj5kQcOL6vfm0Mqte6tHBRMQPDfQbn0CWoNEYKXyZBQfJVvPR75e/XDDNNPuDwQ/2ICGoUz8bMogZuL6hRRILspFnwE3prvi0nHYA5f8t/rWWgY3GoMA7BAbsrFrN+t+KPSuJwqmWg02XTYCw5fZH5R8pDJz3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073178518531.8229258883626; Fri, 5 Sep 2025 04:52:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUz1-0001c1-80; Fri, 05 Sep 2025 07:52:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUyr-0001XA-Bm for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:49 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyg-0003Yg-0d for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:45 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-45cb5492350so13672705e9.1 for ; Fri, 05 Sep 2025 04:51:35 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073093; x=1757677893; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIej8KJ0qwZtdzS8NUwMCivvv646uavNq2u0pssJkXg=; b=nxeBQeOexKgxmcc8dIgfTRjImKfi2Pu4CYlAXqAuinU+xeSTpwlyRi1tApKq/iMGvO bleuEoCOiWEmX9tNZl+G9ukow+BnXiphiG8zGJlHju9EYyvkHZRu7PdjO4Ynkz8mbtCM vLZ/rwPKpqOQm/XATJhNup8CsI88Q4DEpclVo5VyibdOiBwB//uZfyB/C8tqWWqu8eR5 0GQbjPrdYQQQ9Aja63TLtOB3LOdd9Mf8bCr1m0Fe4mGD24FICZXdhDu4A1+1Rh69kl71 PxsYka1OaCAURjiTeKuvpSwZHMavKpknFjV/QUP9Lonu7+hjUOqme+hJOZREzD8iXK+W ruyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073093; x=1757677893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIej8KJ0qwZtdzS8NUwMCivvv646uavNq2u0pssJkXg=; b=kPlyZWFfUH+6bYuaZneJFQ/z1zFNP1Si2bskb6t7rwFxrjhpSm+5O/OUbSdd0Hr7mv OKhYkw3hgHzYUd5F3sXTiXfbzvDju/D7bVCPoxYpOCvYpVUKT1IgBlbEFOgErRZen2FS F/Z8uNqIQESm+Bbv3OIxsOR3Yb9kdcSuJmsXESS5FvuDdvVPOWGeZ7bmrjJz1hjmRMyF ucIc18LbO4yaxOTCWc7IycVHFxT9G0BvugqROe8NR60JugClsqSdQoHgCP1/flf/Tuzx hc0HE4L3YhxrajWjWPIJWHu76HontBjBupOOeAP4Ttdq7B454JyUaidd6LB1YS2e9pE3 qQQg== X-Gm-Message-State: AOJu0Yxwe2MHNiDfveWe5q68HpLcH7Orzm1sbe+mVrEMr/gvun+6PPh4 1zK9TiZeu3tyk7TNnWIZpLXuv76viydF5VTX2hKTAS4Hb7sGHbPK1+mKD7y/rPKe+lPRYLR+ZuC K6PefuxM= X-Gm-Gg: ASbGncsyzckWdUxnvJDLkEBagr25uN3SQbNXmkTJx9mZway4dPSGHq585+JhKkxvNdW 3Qs2s1ToJox6XfCoO1/ltMsP4+6Z/IT54tbZJ35efKWYlev0maJcM5XWfz8TE1XxSnN9AET5DLj UJSg6/h+RMpMokEuXyBAFxhwFdjPbKzZh4yAtcNKJ1ULZKj9giDktoL/wEaPwR/PX16OAmgxJXq eG1lauj3AROVNeERUA6EkaLpuT/8Qds+0X3MGsEtn4dGRHst4ALb0qfK+Wan20sKTwrESd8Y1UJ cYAs+mdUPw0vCL5MMzxkz/LNokreMO4wEXpeUfA+Xa6ygYoGdLe/UH5zPCt9RqfFT7ed2Slp8Kd dK4C8rtGYMNPP8HYldtEV36nCSsuUFVsWV4aCaj8R5k1lpeaXzm66KoGf X-Google-Smtp-Source: AGHT+IFslXC4H90qzOvyr2CEJPIRysjktd5kGzk7jTBOxYlRFWjPpmU1si5QVhLOftaoP2L/MlytPg== X-Received: by 2002:a05:600c:4452:b0:455:f187:6203 with SMTP id 5b1f17b1804b1-45b855983cfmr168873545e9.27.1757073093264; Fri, 05 Sep 2025 04:51:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 4/7] target/sparc: Loosen decode of RDPSR for v7 Date: Fri, 5 Sep 2025 13:51:25 +0200 Message-ID: <20250905115128.376295-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073180974116600 Content-Type: text/plain; charset="utf-8" For v7, bits [18:0] are ignored. For v8, bits [18:14] are reserved and bits [13:0] are ignored. Fixes: 668bb9b755e ("target/sparc: Move RDPSR, RDHPR to decodetree") Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 74848996ae..1c6403ad8a 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -158,14 +158,16 @@ CALL 01 i:s30 } =20 { - RDPSR 10 rd:5 101001 00000 0 0000000000000 - RDHPR_hpstate 10 rd:5 101001 00000 0 0000000000000 + [ + RDHPR_hpstate 10 rd:5 101001 00000 0 0000000000000 + RDHPR_htstate 10 rd:5 101001 00001 0 0000000000000 + RDHPR_hintp 10 rd:5 101001 00011 0 0000000000000 + RDHPR_htba 10 rd:5 101001 00101 0 0000000000000 + RDHPR_hver 10 rd:5 101001 00110 0 0000000000000 + RDHPR_hstick_cmpr 10 rd:5 101001 11111 0 0000000000000 + ] + RDPSR 10 rd:5 101001 ----- - ------------- } -RDHPR_htstate 10 rd:5 101001 00001 0 0000000000000 -RDHPR_hintp 10 rd:5 101001 00011 0 0000000000000 -RDHPR_htba 10 rd:5 101001 00101 0 0000000000000 -RDHPR_hver 10 rd:5 101001 00110 0 0000000000000 -RDHPR_hstick_cmpr 10 rd:5 101001 11111 0 0000000000000 =20 { WRPSR 10 00000 110001 ..... . ............. @n_r_ri --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073236; cv=none; d=zohomail.com; s=zohoarc; b=JLu+isjWQxcPRp8widvHwVR279fhk5NgMeT4gXmda6+jqWzrKfndwsbbj32gq/NBorMVjCBWyiJkXkYzRsL1Y42Zk7nSjxw/e7pSzV+0jGfzcLiUSPugc0b/ntNS6z5ytgw/S3FKpSBvCMhQ0qqQ5WS5siyqFAx7lASC/3gVb/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073236; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tmFgSmczyo5Sgsms5P8rKy808EH5x+SNkSDEiE+RR/Q=; b=G0yBS/y86VU8Vb2SPixJgsM+sp5eoio+m/OYsa0Jznpeqb2W9Dr+hheUnLXw/erSnLF2Y3YZ+3eHrEv3tYbM6rVCS8Tb55MEex12OEpHK8f4Wz8uI7QppjsSAsqNSd1xjvsqWg+sFWWD+wEGBOzY8yuCmEKt1t633OFU103l3X0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073236879401.24310043997684; Fri, 5 Sep 2025 04:53:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUzC-0001eQ-J2; Fri, 05 Sep 2025 07:52:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUyy-0001bF-IH for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:56 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyi-0003Yq-JE for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:56 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-45b89147cfbso22028815e9.3 for ; Fri, 05 Sep 2025 04:51:37 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073094; x=1757677894; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tmFgSmczyo5Sgsms5P8rKy808EH5x+SNkSDEiE+RR/Q=; b=X4fRcVNvfizf8pFd5dgaQJT39RTcb4fZkjMQZ1BBQsw2DVegHX00DY8wtiJYTdXg1V C4By/nsEM+cg+nMaXjNjiCZwh69lLOEBUU14kpLiIXrfkEPfNBBcUtsOvfyTF3AFOOBk 9woXHPR9o4n+un8oEU34xQmpYiuRYsTE0hxQxe4K9E3dHEEE/rkFuC0IYMkC53tJWzdK peynfbpVAyQlWfJDDkchjhFiDOVMdpYPy7jC1q6SLZ625etmHFtaejgYQl7TQbOWQ9AS Ja+e+QzZKkjcPIR4Qzw15nSC8WLzMCqFRCUu4nJDBTAyw1SSRiBXzmKjZ4AcDDiZ/Wnh 59OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073094; x=1757677894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmFgSmczyo5Sgsms5P8rKy808EH5x+SNkSDEiE+RR/Q=; b=ZGt4UTVu1EcDc/Wnv8/4mWK8XdDf/MmIlXTXInA72vy3WDlhbX8dcR1vbB61HgzAAB N/H02Fd6nv8/Crh/Ib5jjl0dRxxdSyINmPA+RSBV7CmXW3uxWBDpOk71kwxnQZpQvceP IBs7h/NcWHw8fVGgvZTsc97uGF0zjR5ZJaEBPVabtGhQ4ApXkDS6WMUrVjUdoaMDZkAy rsJzyNWi5/SuNpsR4JLs5sqKOApKT/Ir+us9yQSxhN02t4R5y1Jv7/xFwDM3D8pstwvJ ZFcc4I+0s/6atP6BR8vYmm0VymqckY4OSx+dHCiAkk2lh5TpluSgSwvAbOGRwc0wrFsQ GqTQ== X-Gm-Message-State: AOJu0Yxp9ex/8QqvorEIWBJGOmFiL0o5vlyVAvHtlPwN1pBu7kGvt6xv 3sw593HZR+Tc/9rF2l4zymTgnJyAGKNC15qNPxWELwoczAdcwS4WQfx9Vg70EWcc1fXMMGpiT01 bmLa3OKI= X-Gm-Gg: ASbGnctVdaTZcG+tRaJyIxOalaOpRxwYy5ZKL7L9MzP1Ik1qolifhcGwu3rkJfNWb61 4uSd0cjB3bTJH03tEsk76Ppsa+WrG49ENQa3j6eacmmiHZBmNE8EfFHf/OTa/8LlqtqIcVdE6n2 SWYRgcX4IrseOAQ6Ur7J/mgAAycDwdNY3jQ7v0/SSlofc4VFSu7R8rw0aDoz03O1imaue21xsxK cqqgjltobiSE80JB02FlRzRGihCDPgV8Md9Kmsov/iz43SpgbQB0GCKHbaaVoo4Qp58iKyeUQNt N/1+B0sPo8/jPP+an1ppib0bEhQGEh+usk19Ag5HAM3sb6SgXZ+FTdaLK9tT3FaS3Wi661Tax+F 5HT48WRpFMzg1l2rmQC1oHVwH46FIB9JSQtcveV8TIKpXYWvvkifelVeW X-Google-Smtp-Source: AGHT+IFyGXYhD20UtGaA5U0F9zMDVVkyRZsSiLNMSLCeuF4/KYtNxfutMPtKdbxW0eKig8fQpF9mPA== X-Received: by 2002:a05:600c:a43:b0:459:d3ce:2cbd with SMTP id 5b1f17b1804b1-45b8556a7acmr186011435e9.13.1757073094158; Fri, 05 Sep 2025 04:51:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 5/7] target/sparc: Loosen decode of RDWIM for v7 Date: Fri, 5 Sep 2025 13:51:26 +0200 Message-ID: <20250905115128.376295-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073237233116600 Content-Type: text/plain; charset="utf-8" For v7, bits [18:0] are ignored. For v8, bits [18:14] are reserved and bits [13:0] are ignored. Fixes: 5d617bfba07 ("target/sparc: Move RDWIM, RDPR to decodetree") Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 40 ++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 1c6403ad8a..77b2f54fdf 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -180,26 +180,28 @@ RESTORED 10 00001 110001 00000 0 000000000= 0000 # UA2005 INVALW =20 { - RDWIM 10 rd:5 101010 00000 0 0000000000000 - RDPR_tpc 10 rd:5 101010 00000 0 0000000000000 + [ + RDPR_tpc 10 rd:5 101010 00000 0 0000000000000 + RDPR_tnpc 10 rd:5 101010 00001 0 0000000000000 + RDPR_tstate 10 rd:5 101010 00010 0 0000000000000 + RDPR_tt 10 rd:5 101010 00011 0 0000000000000 + RDPR_tick 10 rd:5 101010 00100 0 0000000000000 + RDPR_tba 10 rd:5 101010 00101 0 0000000000000 + RDPR_pstate 10 rd:5 101010 00110 0 0000000000000 + RDPR_tl 10 rd:5 101010 00111 0 0000000000000 + RDPR_pil 10 rd:5 101010 01000 0 0000000000000 + RDPR_cwp 10 rd:5 101010 01001 0 0000000000000 + RDPR_cansave 10 rd:5 101010 01010 0 0000000000000 + RDPR_canrestore 10 rd:5 101010 01011 0 0000000000000 + RDPR_cleanwin 10 rd:5 101010 01100 0 0000000000000 + RDPR_otherwin 10 rd:5 101010 01101 0 0000000000000 + RDPR_wstate 10 rd:5 101010 01110 0 0000000000000 + RDPR_gl 10 rd:5 101010 10000 0 0000000000000 + RDPR_strand_status 10 rd:5 101010 11010 0 0000000000000 + RDPR_ver 10 rd:5 101010 11111 0 0000000000000 + ] + RDWIM 10 rd:5 101010 ----- - ------------- } -RDPR_tnpc 10 rd:5 101010 00001 0 0000000000000 -RDPR_tstate 10 rd:5 101010 00010 0 0000000000000 -RDPR_tt 10 rd:5 101010 00011 0 0000000000000 -RDPR_tick 10 rd:5 101010 00100 0 0000000000000 -RDPR_tba 10 rd:5 101010 00101 0 0000000000000 -RDPR_pstate 10 rd:5 101010 00110 0 0000000000000 -RDPR_tl 10 rd:5 101010 00111 0 0000000000000 -RDPR_pil 10 rd:5 101010 01000 0 0000000000000 -RDPR_cwp 10 rd:5 101010 01001 0 0000000000000 -RDPR_cansave 10 rd:5 101010 01010 0 0000000000000 -RDPR_canrestore 10 rd:5 101010 01011 0 0000000000000 -RDPR_cleanwin 10 rd:5 101010 01100 0 0000000000000 -RDPR_otherwin 10 rd:5 101010 01101 0 0000000000000 -RDPR_wstate 10 rd:5 101010 01110 0 0000000000000 -RDPR_gl 10 rd:5 101010 10000 0 0000000000000 -RDPR_strand_status 10 rd:5 101010 11010 0 0000000000000 -RDPR_ver 10 rd:5 101010 11111 0 0000000000000 =20 { WRWIM 10 00000 110010 ..... . ............. @n_r_ri --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073185; cv=none; d=zohomail.com; s=zohoarc; b=f+1bukDp1chUy+iJyX5/yAPtWxzZyCLDuShdk8nLu7cogfIjii5a1yMfnomNNBI6ypohkmHLGxf445w8XReUpxokyvtddnTXUyeEpHa1JbVRpWuYNX11bCHzooqIkjAYCvi29Rra25xwMAnDk2SYjNVAB4oilQ9FVi5YZfmsyL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073185; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gMEJQTJL/edhgJnuQuFiZysU4+KbfpRG/smBkAD+K1E=; b=io4Jv0/dc8sbByMVcKv1mXHK0vdLqc2eMo2Bt5wRfGYbTzMO4yVAc0roZgxYwsKjucCpYEpVAK3cIr9BdT92K5fImUOdXZOW44Dch6UPYZmI1gu+bZHCvo1H3WzGsX1bI7EaY83b1B4W4RwvH1kQkCVoHKnpgZPpEKPq36l77EI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073185292924.7067852725799; Fri, 5 Sep 2025 04:53:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUzK-0001fH-9l; Fri, 05 Sep 2025 07:52:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUz1-0001cA-7I for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:59 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUyo-0003Yu-Rv for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:58 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-45b7722ea37so10957885e9.1 for ; Fri, 05 Sep 2025 04:51:38 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073095; x=1757677895; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gMEJQTJL/edhgJnuQuFiZysU4+KbfpRG/smBkAD+K1E=; b=la7oGrDzLHb5tsc4w+rqxR1isWUSmtxaafMlNHQBIsmHOAPZj9/GI4acBiFEFjC1tF 9Gpb42+ULFsJTnuY2xVAuEsEjgmuuG4Atp1lmz8jcVUdRFx5h0V30/TlT+5ANYfZjklQ eJRROh35xSivNj6eHjEejD338/evZJBqjXSZEikYx8QndQZyKle+eRo7f0+CMGMccCjX tIneU3KqAmBWrww4xW2o4AYKaoq+Co04pKNwqtIAjPaE3KTvBYXnrvCQlTRz7fxIpfZE 90eteDC9blniCM4xAqrFWPI6F0KdXZ2mICc3LF2sLedmoCz5FEFt2Ih2FS+j1gc7JYRD mlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073095; x=1757677895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gMEJQTJL/edhgJnuQuFiZysU4+KbfpRG/smBkAD+K1E=; b=iKoTMod7ao0VelesKUZ/pJr5Z2awKFskRt2lxM3gmeB2y//m7X/2YogIZR/TutyINi ikNAS9Gm9LCZZ1KVcicTU9iNeJ+S+F3czZZw640vdzbLUV+rtC+MBtMehNuTSMI8t3WQ hvi7O5gNtj5UmXFbJVdmQ4eM+Bb9MBE/dsOD3moEO4e31XixzUe0fBlNppwh3nbp2W57 e5dT450qtHMnceSL96CiL8IN6dYzJxULEvMTT6JKaYWLMVmKv8MNQgxfjbN6MVodzoqs 97Q3RYksP/tO7g1QaTAaP1aM59sZr8UPp7eXNrTq2ZkpzK4bVIHeNM7UsssPWnMSazyk yO2g== X-Gm-Message-State: AOJu0YxmJlBdE4yvS1AhtXvdEAaxQDGu3bTaEwEqKRPji72nIPLOkvXp vO4UkS+mNXIwSZLiraIDLPyWkOd0/M+7DNJ4YR7Y+4boEfAVOwy4hkh19209F7TI57Eo4SFKF7l IkysbTZM= X-Gm-Gg: ASbGncv0n5VCvPh+BJjHqV/d2gKVC2KscaJx+n3SLXN2loO9YdA7WAG9SBBnUlN7RMq YrCJmhXZx/UR1kLvPbKKRPR0LKkImLj6Y2m/6q/8kC6+3T8L1md54ytjNM/Tk1qi9U1+jq64s93 FiTUSXrwJVYcLHYRImDwD27ZJiVusEzJF0wIRCZCI3hRSTQestvGOQYjttu7QZI3EuWjsxSoVya G6iYyTO7OwXzaxsw5KNXo81zw1rF4Sf+qaY4inlaIHhjK09qxFdTjMtv5z1iRixCID1JoI4g+B2 kbwuk7Foegze/mlS+Q5iT2GoQk7x+96DFwNjncOTw4f7q9MP8IreoTh1FXdHStIZO117YlhCivy MBBGzfj21NXETkWzWqOaNt2eMXVFbWmDimPWSTTeG6rKaeucqH+sCUL1i X-Google-Smtp-Source: AGHT+IFvjrZ06XXXR4tcqqqdQT2/P1b8d1DsJhZJznY1+lauamW/Nc5VnDDUy4zKe50NPJeoGrFrhg== X-Received: by 2002:a05:600c:310a:b0:45d:dc6c:9e30 with SMTP id 5b1f17b1804b1-45ddc6ca1a1mr2190825e9.14.1757073095108; Fri, 05 Sep 2025 04:51:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 6/7] target/sparc: Loosen decode of RDTBR for v7 Date: Fri, 5 Sep 2025 13:51:27 +0200 Message-ID: <20250905115128.376295-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073186927116600 Content-Type: text/plain; charset="utf-8" For v7, bits [18:0] are ignored. For v8, bits [18:14] are reserved and bits [13:0] are ignored. Fixes: e8325dc02d0 ("target/sparc: Move RDTBR, FLUSHW to decodetree") Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 77b2f54fdf..242ec42016 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -226,7 +226,7 @@ WRPR_strand_status 10 11010 110010 ..... . ...........= .. @n_r_ri =20 { FLUSHW 10 00000 101011 00000 0 0000000000000 - RDTBR 10 rd:5 101011 00000 0 0000000000000 + RDTBR 10 rd:5 101011 ----- - ------------- } =20 { --=20 2.43.0 From nobody Sat Sep 6 15:00:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1757073266; cv=none; d=zohomail.com; s=zohoarc; b=aeVyTD+41zC7C0IUY+PwizLFiLrGgKZ6quZBXySX+eiHQ3yA7QzK1Qe8+rQaNUVOJ2xxvKm0jLAogQ4lEM3j7XFvQbeFZ05bFRLX9T7vqI5CehzMehVV8cUoPR+va1Ai6n7lw57YPMIz1saJdXNKSZreR8aw9ft4wwGLbfuc8YQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757073266; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B99K9Dv9ZtO1Q8pfxV+jw9jadiWOHe4ZFjv0MH8KRzU=; b=mlwqYqCOn4XtuvCg/XrsIck6qa/eFvrRWDRqEYm0wGiYZYqcrsvijwUAuedYcQymcZIbXeN7I14dEOX0ifKXyEy3ISAbPcWoKOJrKNlBFaSdrxQtdRTrFUDnIzprNC1SHJYUlyM8gURBt2YwjAOIqU2qnGYO8Spq4Vw6smYmE/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1757073266494691.9845446260906; Fri, 5 Sep 2025 04:54:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uuUzE-0001em-Jg; Fri, 05 Sep 2025 07:52:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuUz1-0001bY-4Y for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:59 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uuUym-0003Z3-7Y for qemu-devel@nongnu.org; Fri, 05 Sep 2025 07:51:57 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-45b83ae1734so12213075e9.0 for ; Fri, 05 Sep 2025 04:51:38 -0700 (PDT) Received: from stoup.dot1x.polimi.it ([131.175.126.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b8f2d3c88sm194285115e9.19.2025.09.05.04.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 04:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757073096; x=1757677896; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B99K9Dv9ZtO1Q8pfxV+jw9jadiWOHe4ZFjv0MH8KRzU=; b=jRgSsno4U4GNhK4I5m+383DJmwnVwBVmsCu0hGEgJc7d7HkRucNbkYYHNoM9XK8LLO AL7zlaqFOQvCdru2Ygodcfa05GteoiwFITHXmjyiJ+eLPNWF9lxrDM3mLRwfx3r3Yc4+ aj4UWjxZ2g3ZuqxY0rYrnsPF1g3RJee6hLB5VLrn0T+D9fsd7SehaM+7LUpghZr35oGA Bv7o2ySwsf/HfiVbY5TJD8GJHb1wALPY9sq2PTNpJzoNw5urKhNyw8f9cq+Ck3Ex0Xft lEoU+EPVPiTJjcrtdgFXdxSzD9qbnql3o6e101SqW2tq894zyr6J7ifbssnibs2pbhdV q+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757073096; x=1757677896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B99K9Dv9ZtO1Q8pfxV+jw9jadiWOHe4ZFjv0MH8KRzU=; b=wOo2+bOR01HxGMSOgdDlFRHgQNuCcl+JgHVV9x0LtqHhfUcDXqqBnDh2LqOhuKYbHz L9ZrSIMUyGMk5+nAs7U/D0yjOf5uNZP6SGsU07xjShsYidYmIucSGBiWY04g5rs/xF/X 1HeIqaOotstMcZrvenLhPsIYt8++wOgzVG2ePSSwWTnuUM8iQLYgEMGpgL1cpqVvPpcV zxaQkQwoEvas1R80pfRBtlPFxI91lYe1JZ5mYJTe7XzoDWObloFVtMc8iIpK468xRDnX cj68VKPqqLYML1G8TLhD4fQ65WijmfBPt1kf4EI2Ik+BRnHmEXhpJd8Jx9PR+fHCaoIr q8iw== X-Gm-Message-State: AOJu0YxTwLmP0lb19G1JiZt/wG5bBBGsfB/mOPan9Oe0STBK1UhJTks6 TFNuDZv+aGo5/IVzn6e0zekuAK+HGbR9EYlua1kXng3tUVCUZH2mIRLaD2zjRAlEPEG5a9i28qS aB9UKrmU= X-Gm-Gg: ASbGnctSwvNLusLRWzsEck/POA3uN7nvnF2DP4H+7mw5THxF13OqiOzWJb7aPV4Wakr zaUBO9dCE5jFoViQ8fltpkG7dfVEj4+4ubLNqFvaAhN2424Wio0BLFH64ItoZuxiPC4mc+vJaU1 gGuxp/GJKOi6CCU6VTtQ2RPxd3782Pwch/txW/DOeqGeU69CFldaRhdBCdvZI4fW5Je2QKTYHrs /8nfCt0P9cSP3yfwDAmQ8/7kLcQW7y0wF7exqiZwtOCfhuovmRvrsk93Y6TiCmTayNgr4TaOWa6 HcMQxUpZMZZgnh+OyRoFiKXVNJkxXEQXdwdON7hH5U2brUTMi2RlBr0WMZ72G/7xPcps4kIHXxh L+0UCEwbz7IHcQH8PQvWlcHSb5pr1dxrJwEDWrqkS5yhZ2VvTU3QOUkIJ X-Google-Smtp-Source: AGHT+IG98cPYSN61pNWZAn9mgybnfPrmrqP/rL0L0ltI0bEapIFp9wTv/gnxd2M6Py+INCMUDip85Q== X-Received: by 2002:a05:600c:1e89:b0:45d:d903:beea with SMTP id 5b1f17b1804b1-45dd903c5admr21045525e9.30.1757073095918; Fri, 05 Sep 2025 04:51:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com Subject: [PATCH v2 7/7] target/sparc: Relax decode of rs2_or_imm for v7 Date: Fri, 5 Sep 2025 13:51:28 +0200 Message-ID: <20250905115128.376295-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250905115128.376295-1-richard.henderson@linaro.org> References: <20250905115128.376295-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1757073269013124100 Content-Type: text/plain; charset="utf-8" For v7, bits [13:5] are ignored for !imm. For v8, those same bits are reserved, but are not trapped. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 56 ++++++++++++++++++++++++++-------------- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index cfdd9c1ce4..810e2491a6 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2526,6 +2526,32 @@ static int extract_qfpreg(DisasContext *dc, int x) # define avail_VIS4(C) false #endif =20 +/* + * We decoded bit 13 as imm, and bits [12:0] as rs2_or_imm. + * For v9, if !imm, then the unused bits [12:5] must be zero. + * For v7 and v8, the unused bits are ignored; clear them here. + */ +static bool check_rs2(DisasContext *dc, int *rs2) +{ + if (unlikely(*rs2 & ~0x1f)) { + if (avail_64(dc)) { + return false; + } + *rs2 &=3D 0x1f; + } + return true; +} + +static bool check_r_r_ri(DisasContext *dc, arg_r_r_ri *a) +{ + return a->imm || check_rs2(dc, &a->rs2_or_imm); +} + +static bool check_r_r_ri_cc(DisasContext *dc, arg_r_r_ri_cc *a) +{ + return a->imm || check_rs2(dc, &a->rs2_or_imm); +} + /* Default case for non jump instructions. */ static bool advance_pc(DisasContext *dc) { @@ -3249,8 +3275,7 @@ static bool do_wr_special(DisasContext *dc, arg_r_r_r= i *a, bool priv, { TCGv src; =20 - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && (a->rs2_or_imm & ~0x1f)) { + if (!check_r_r_ri(dc, a)) { return false; } if (!priv) { @@ -3693,8 +3718,7 @@ static bool do_arith_int(DisasContext *dc, arg_r_r_ri= _cc *a, { TCGv dst, src1; =20 - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && a->rs2_or_imm & ~0x1f) { + if (!check_r_r_ri_cc(dc, a)) { return false; } =20 @@ -3778,11 +3802,11 @@ static bool trans_OR(DisasContext *dc, arg_r_r_ri_c= c *a) { /* OR with %g0 is the canonical alias for MOV. */ if (!a->cc && a->rs1 =3D=3D 0) { + if (!check_r_r_ri_cc(dc, a)) { + return false; + } if (a->imm || a->rs2_or_imm =3D=3D 0) { gen_store_gpr(dc, a->rd, tcg_constant_tl(a->rs2_or_imm)); - } else if (a->rs2_or_imm & ~0x1f) { - /* For simplicity, we under-decoded the rs2 form. */ - return false; } else { gen_store_gpr(dc, a->rd, cpu_regs[a->rs2_or_imm]); } @@ -3799,8 +3823,7 @@ static bool trans_UDIV(DisasContext *dc, arg_r_r_ri *= a) if (!avail_DIV(dc)) { return false; } - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && a->rs2_or_imm & ~0x1f) { + if (!check_r_r_ri(dc, a)) { return false; } =20 @@ -3851,8 +3874,7 @@ static bool trans_UDIVX(DisasContext *dc, arg_r_r_ri = *a) if (!avail_64(dc)) { return false; } - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && a->rs2_or_imm & ~0x1f) { + if (!check_r_r_ri(dc, a)) { return false; } =20 @@ -3889,8 +3911,7 @@ static bool trans_SDIVX(DisasContext *dc, arg_r_r_ri = *a) if (!avail_64(dc)) { return false; } - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && a->rs2_or_imm & ~0x1f) { + if (!check_r_r_ri(dc, a)) { return false; } =20 @@ -4186,8 +4207,7 @@ TRANS(SRA_i, ALL, do_shift_i, a, false, false) =20 static TCGv gen_rs2_or_imm(DisasContext *dc, bool imm, int rs2_or_imm) { - /* For simplicity, we under-decoded the rs2 form. */ - if (!imm && rs2_or_imm & ~0x1f) { + if (!imm && !check_rs2(dc, &rs2_or_imm)) { return NULL; } if (imm || rs2_or_imm =3D=3D 0) { @@ -4250,8 +4270,7 @@ static bool do_add_special(DisasContext *dc, arg_r_r_= ri *a, { TCGv src1, sum; =20 - /* For simplicity, we under-decoded the rs2 form. */ - if (!a->imm && a->rs2_or_imm & ~0x1f) { + if (!check_r_r_ri(dc, a)) { return false; } =20 @@ -4369,8 +4388,7 @@ static TCGv gen_ldst_addr(DisasContext *dc, int rs1, = bool imm, int rs2_or_imm) { TCGv addr, tmp =3D NULL; =20 - /* For simplicity, we under-decoded the rs2 form. */ - if (!imm && rs2_or_imm & ~0x1f) { + if (!imm && !check_rs2(dc, &rs2_or_imm)) { return NULL; } =20 --=20 2.43.0