From nobody Sat Sep 6 17:17:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1756903996; cv=none; d=zohomail.com; s=zohoarc; b=AN0PlBAaKoNmxL2P+5GRps8FiLdAqM8qFNZ5gULRcRzlmgKH1S4bHQXdwj3tGO+MXAx4qJABfIGlD3WuHF/lIS7WaZsaDzzNzP5UCkC+8ePwatjcEN2VOQXBdkOShQBrfJ3vHpHFtogWaSuFP1a7kZLN5F8N+qcgcBRxP/xESHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756903996; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KLbs8RyNjizHaxX5jDH2xXLE6IMpI0rDJXUkJQfOEbQ=; b=dS1aKxLoMScBA++tUdW+4Py0kyMHoUHKgf6MT0x5VciNfJHInluf4MU9Zjsf5zpcKcF7ea3euuxBb27wFXQXgwWBw6tfM9HDF93Oeqxcwhspob/Kyk0kKw4BNmHZnQgvirUaP1tbR1+9FxP4J25JD3Hmb/ZfsJxH3e9NmBel7TE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756903996986215.32134811732135; Wed, 3 Sep 2025 05:53:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utmw6-00063V-Jf; Wed, 03 Sep 2025 08:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utmvv-0005vo-59 for qemu-devel@nongnu.org; Wed, 03 Sep 2025 08:49:51 -0400 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utmvr-0000ly-5t for qemu-devel@nongnu.org; Wed, 03 Sep 2025 08:49:50 -0400 Received: from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net [IPv6:2a02:6b8:c2d:7394:0:640:5a8a:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 5117FC018F; Wed, 03 Sep 2025 15:49:42 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:b8f::1:11]) by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id anf8gZ3GnW20-28RIoyo6; Wed, 03 Sep 2025 15:49:41 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1756903781; bh=KLbs8RyNjizHaxX5jDH2xXLE6IMpI0rDJXUkJQfOEbQ=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=eyNsyr58kc8Zxu7qghMG8RgU4WF0fu9z2iNx/e2LEbcioqnwEvcCzSw4P68TT+myR cPKmLQn07yAwJI4mWxwar2tY2ElV2R9puZ6qMqGDokzVUfVi8wFIncln/LaED5RewR lbfopeqM5pALy9ZYUGqGfbPJ1IdUOOM778I4W3QQ= Authentication-Results: mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: jasowang@redhat.com Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, leiyang@redhat.com, steven.sistare@oracle.com, yc-core@yandex-team.ru Subject: [PATCH v3 09/19] net/tap: drop extra tap_fd_get_ifname() call Date: Wed, 3 Sep 2025 15:49:23 +0300 Message-ID: <20250903124934.1169899-10-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250903124934.1169899-1-vsementsov@yandex-team.ru> References: <20250903124934.1169899-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1756903997336116600 Content-Type: text/plain; charset="utf-8" tap_open() cares to update ifname, no reason to call extra ioctl. Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by: Lei Yang --- net/tap.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/net/tap.c b/net/tap.c index cfa4ccc651..c007cd272a 100644 --- a/net/tap.c +++ b/net/tap.c @@ -933,14 +933,6 @@ int net_init_tap(const Netdev *netdev, const char *nam= e, return -1; } =20 - if (queues > 1 && i =3D=3D 0 && !tap->ifname) { - if (tap_fd_get_ifname(fd, ifname)) { - error_setg(errp, "Fail to get ifname"); - close(fd); - return -1; - } - } - ret =3D net_init_tap_one(tap, peer, "tap", name, ifname, i >=3D 1 ? "no" : script, i >=3D 1 ? "no" : downscript, --=20 2.48.1