From nobody Sat Sep 6 16:56:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756894511; cv=none; d=zohomail.com; s=zohoarc; b=kvd5lycdc+Xyk7ppJlhaG3jVTsW3uUL1zubFRl40aGy8/cqTdkbea4h9hnx0aH0Vh1PlddiVoDEVY3LNEXLtyUYI7qrhByL7bLx5YSJ+eAyZRWeULyynp1jVtC7H8dIW+HY760trKtPOOna+t/POEe+KgSuKemGyrlhMANx+oOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756894511; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yf4kdomIxvqW13orl0RD2fI/Yew6aBRirZc6xfkUNAY=; b=j9WkQokftczmj6bjm/m/MGKeuKnOK37VwCUxzHRT5XNrLXiC2eljX22/anpUntnfa2Or3byESNWvIIRfdp4Q8bednDJaxgxTf2zssPOny6nJsNI5u9t2cTmuIgc4sVflKf9QOlyi0VW5F/16AcZd2rOwHilomDSMHfGmCX94Vm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756894511081102.03490345314572; Wed, 3 Sep 2025 03:15:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utkVw-0007ek-5M; Wed, 03 Sep 2025 06:14:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utkVt-0007Wj-GI for qemu-devel@nongnu.org; Wed, 03 Sep 2025 06:14:49 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1utkVq-0001O7-Ph for qemu-devel@nongnu.org; Wed, 03 Sep 2025 06:14:49 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-61cbfa1d820so12646914a12.3 for ; Wed, 03 Sep 2025 03:14:46 -0700 (PDT) Received: from localhost.localdomain (98.red-88-29-180.dynamicip.rima-tde.net. [88.29.180.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d60d93b949sm12824030f8f.2.2025.09.03.03.07.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 03 Sep 2025 03:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756894484; x=1757499284; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yf4kdomIxvqW13orl0RD2fI/Yew6aBRirZc6xfkUNAY=; b=euFLi2Rl6bGdQ+TlfY/+Irb984M8dd/SWxoHEtMhJfQogGDW/Z5hdmkJsYT4UGgbNi pgUt3n4WUO/w2pNS72/gvhLSQbWikxsPV0F83Gj09XpJas12Ts/P1kw3DXAREnU00bf3 /sIm3yq9VD2KaXs+jEN/ZEBDg+D6V3ikzQ3JiK5YOSptMqYRjaIeVBLO0evRs2p2XE8Z 8RSWBgYvr46tnaChlzhXbXaVf+h25AyETcK3VgPx0RB9dPPu7JMi5nVZT5UfkYSCzgNH 8ChidUNpZZtLRuDXZ+A0w/GWnmGYOUmazFBi0jGv86DQixx4x0BXPDtnyPN2u1cs0p/c ouNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756894484; x=1757499284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yf4kdomIxvqW13orl0RD2fI/Yew6aBRirZc6xfkUNAY=; b=Cr8JMEYMz2Alt/cV1WpfFqLUEV4pBoXPOPuLz5IO633O3pE14VWNcDAZIlUJKNIXmh 0hjaI6GRvjMumk77ZhKx7lNo4Dq2440OSMS37AFiTWu7nhjpi0YomUYlbcFJemB08xVB YuDA/Fs0wqObp9CVYkKwHB1Q5p7Moe5YL7GCZgaOh4X0AHpk6vOErHmDBfWqv7qV/oF8 17yiH9VN37AFOYcmSNE2sSma+4qbg0Pipoeco4XXHxQziyoTEJh6+7w5PEckpRENC9Eh nO+HafU5g8V7vLwHDNSWXLINQITnfJ8VipDGdhcxHYWCqUFplsAp663do231DcvtxKpB MKJQ== X-Gm-Message-State: AOJu0YxpcIrgHPwDCmaJMuk8WIHZEnQJgedP+Zf1KOzejEoeteF7QI2c 7o8fsndBx/DOQElSaRjAaNfWJdED22Q/ozkD4/PLNPDZe6DqBsMQcRwporGSykEaJ+fXgUQM+Pu QSo/estw= X-Gm-Gg: ASbGnctefbqlZiKHs9wPNTNzUCdYIcMonoTayk4+0cYTybx/Xm6bykZp1InUhna4pqZ on0iufFOaoHfIUrNZi350jcDN3T05IYmpbWRikxZRVtBPICVr/vqvf70Nh5zrHvfZyaIef/+HoM rW5ALWH+D/+QA9sF91keZHM9W7Wpq7bsV4vrl3kK54rj93wYbTZDeoOnUKsoZyxxxbBQn6S6G2l sTO9+CL9jf1IQyJV44nt+MsWe8MJ1AuBEGimv/sFL2nG4Lx/qFGz6XqYKfZYIYYGTnB/GVbceSX u3viMFE5C2lbRmqugjtjVmw78uorLaC0dVEFKEpAQMp2kjPpNWi/Cot0ytCCUjBGoMuw2eZ95VI MQu0uYOLQg4Dcu0/EikBlLiVcWwHPHo73gkCdxCMV/qG3jbRAKfd/zJwMdpRiecu1EjhwIojTKv 0e2MjV5TlIplfszcMd X-Google-Smtp-Source: AGHT+IHQOgMwHD6oDDKECAt5zmKDDOUqxGnAqaTm4KCbQto5aqr8CIpnQHtWWtxQVCkwUEfEsfRmDQ== X-Received: by 2002:a5d:584b:0:b0:3cd:4ff9:c4a3 with SMTP id ffacd0b85a97d-3d1dfa191d4mr12271536f8f.35.1756894075252; Wed, 03 Sep 2025 03:07:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Graf , Richard Henderson , qemu-arm@nongnu.org, Mohamed Mediouni , Peter Maydell , Mads Ynddal , Phil Dennis-Jordan , Stefan Hajnoczi , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 02/24] target/arm/hvf: Check hv_vcpus_exit() returned value Date: Wed, 3 Sep 2025 12:06:38 +0200 Message-ID: <20250903100702.16726-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250903100702.16726-1-philmd@linaro.org> References: <20250903100702.16726-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=philmd@linaro.org; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756894513663124100 hv_vcpus_exit() returns a hv_return_t enum type (defined in ). Assert we succeeded, as we are not ready to handle any error path. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 5 ++++- target/arm/hvf/trace-events | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index d67372218de..65ac0bd71aa 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1086,8 +1086,11 @@ int hvf_arch_init_vcpu(CPUState *cpu) =20 void hvf_kick_vcpu_thread(CPUState *cpu) { + hv_return_t ret; + trace_hvf_kick_vcpu_thread(cpu->cpu_index, cpu->stop); cpus_kick_thread(cpu); - hv_vcpus_exit(&cpu->accel->fd, 1); + ret =3D hv_vcpus_exit(&cpu->accel->fd, 1); + assert_hvf_ok(ret); } =20 static void hvf_raise_exception(CPUState *cpu, uint32_t excp, diff --git a/target/arm/hvf/trace-events b/target/arm/hvf/trace-events index b29a995f3d3..538af6e0707 100644 --- a/target/arm/hvf/trace-events +++ b/target/arm/hvf/trace-events @@ -12,3 +12,4 @@ hvf_psci_call(uint64_t x0, uint64_t x1, uint64_t x2, uint= 64_t x3, uint32_t cpuid hvf_vgic_write(const char *name, uint64_t val) "vgic write to %s [val=3D0x= %016"PRIx64"]" hvf_vgic_read(const char *name, uint64_t val) "vgic read from %s [val=3D0x= %016"PRIx64"]" hvf_illegal_guest_state(void) "HV_ILLEGAL_GUEST_STATE" +hvf_kick_vcpu_thread(unsigned cpuidx, bool stop) "cpu:%u stop:%u" --=20 2.51.0