From nobody Sat Sep 6 17:16:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1756892792; cv=none; d=zohomail.com; s=zohoarc; b=a4SxleU34ztLvYto/DcYoVwlMcDWdcAnoi8dgW4dM4HK+vCyaFtAbasGPoQXXHgOhJ6+nI8WUeDCcMdeNkYNseXwNPoHXYZNTQzhaKSyPk9qaPqLTr3m0JA/SU7mJe0yVxWCw4JCseuvaqXxqyx4OrgagMHEDpHw8+3G4kQHpmo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756892792; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rpWIJmcNN5lupFdb4weg79+iSwld3z32WBQckX84HH0=; b=EONIjzXHtadhqQI8s6FFZWLM2YWa3+7S37JFBIw9vOvfbisCeXBCWMS5H16G7SbWTGn35iKJMHCkEGMwmxF8FIorpU2kQc4vXJVWzxOwRlxJsYoNnoCeVjqN/yRtPzpD4oAcgf5wT/TDT67gWuykSrsS5Q0tkLS4OIpw542sUgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756892792902458.0494272237802; Wed, 3 Sep 2025 02:46:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utk2Z-000698-In; Wed, 03 Sep 2025 05:44:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utk2V-00067F-Qr; Wed, 03 Sep 2025 05:44:27 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utk2U-0007ww-AG; Wed, 03 Sep 2025 05:44:27 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c21:2d8b:0:640:7d49:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 9DDE78078F; Wed, 03 Sep 2025 12:44:24 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:b8f::1:11]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id EicMoq3GhCg0-pbBdHC6g; Wed, 03 Sep 2025 12:44:24 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1756892664; bh=rpWIJmcNN5lupFdb4weg79+iSwld3z32WBQckX84HH0=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=W1qer5mvyh2vyNqBPyb1fFDrnv4Y+ZmQijVPWbsovY3Fgd8MW9QZ048xPrZCnUFI0 /FGwDF8c/zbttm6PNASFLLloTLw5lXcEdZMbdodxcfxD30qwS9qgSgafWctlwkneNq 3eCGs72DrRo7qjB++5xhTSkiyvxvwjh95AusmGnI= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: berrange@redhat.com Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, peterx@redhat.com, vsementsov@yandex-team.ru, Fabiano Rosas Subject: [PATCH 10/10] migration/qemu-file: don't make incoming fds blocking again Date: Wed, 3 Sep 2025 12:44:10 +0300 Message-ID: <20250903094411.1029449-11-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250903094411.1029449-1-vsementsov@yandex-team.ru> References: <20250903094411.1029449-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1756892795261116600 Content-Type: text/plain; charset="utf-8" In migration we want to pass fd "as is", not changing its blocking status. The only current user of these fds is CPR state (through VMSTATE_FD), which of-course doesn't want to modify fds on target when source is still running and use these fds. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/qemu-file.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index b1d042e298..b6ac190034 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -361,12 +361,6 @@ static ssize_t coroutine_mixed_fn qemu_fill_buffer(QEM= UFile *f) qemu_file_set_error_obj(f, len, local_error); } =20 - /* - * NOTE: don't worry about error_abort, it will be removed - * in the next commit - */ - qemu_fds_set_blockinging(fds, nfd, true, &error_abort); - for (int i =3D 0; i < nfd; i++) { FdEntry *fde =3D g_new0(FdEntry, 1); fde->fd =3D fds[i]; --=20 2.48.1