From nobody Sun Sep 28 16:32:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756849273; cv=none; d=zohomail.com; s=zohoarc; b=PcPUw00iCECNySfobJCuo3Nm5ihXdANMi71ckkCsV77n81Uifz7XdXjXoanpKS3jOtXy2ydEUFlT7A76BZSM/SBK/ejpiwYgyW3X45JJuzW7N8Got7X04RIWxQzfz1MDf3sKSVHosD/jWEG34H/th829PxCc6xY+nLrlGdAGv3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756849273; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8/AZsWJV3PvkJt4oVdod4Ydf8bV0b5EAA3J0l0E6vx8=; b=ZHW+h3ODeAPJInBNFAxa2IMC2+VOHE8cWInNUKwrlfLjPxTE0rn5pIgo5o2DbGv/X8Rrqvxm6PVwisHRwublBB9na8fqTu3uAXglDBZkCe+ngx6/ONo8agyOGih+3OEgr4wNgLpVUZ8Xdwc9hR3Y62KmdzUdhDzEqJ3iD0hSwiE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756849273018895.3333599891687; Tue, 2 Sep 2025 14:41:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utYjh-0002Of-F0; Tue, 02 Sep 2025 17:40:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utYjf-0002O2-PX for qemu-devel@nongnu.org; Tue, 02 Sep 2025 17:40:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utYjc-0003Fe-Po for qemu-devel@nongnu.org; Tue, 02 Sep 2025 17:40:15 -0400 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-UwIBzLj2PY6bx3_c0pINow-1; Tue, 02 Sep 2025 17:40:08 -0400 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70de0bdb600so96944286d6.1 for ; Tue, 02 Sep 2025 14:40:08 -0700 (PDT) Received: from x1.com (bras-base-aurron9134w-grc-11-174-89-135-121.dsl.bell.ca. [174.89.135.121]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-720ac262a4fsm18619106d6.11.2025.09.02.14.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Sep 2025 14:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756849210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8/AZsWJV3PvkJt4oVdod4Ydf8bV0b5EAA3J0l0E6vx8=; b=XOG9gbd8+FCM7WP7iA9/RFleyySpTs/eLrUAfjF2aK8u9Z+s8DoJTYCGpuc4k+GfmTbXmO iwTcEkX4RIAJMKACkMRk5nrcfR1uu4tpPpI5jVsU8jTXlVFJwZQQg0eYkoHNhGyZrkUKwF wrql7jo15/p0kMLALNzrQVel6AnxMPU= X-MC-Unique: UwIBzLj2PY6bx3_c0pINow-1 X-Mimecast-MFC-AGG-ID: UwIBzLj2PY6bx3_c0pINow_1756849208 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756849207; x=1757454007; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8/AZsWJV3PvkJt4oVdod4Ydf8bV0b5EAA3J0l0E6vx8=; b=DI4zXQ0pe2o+bPr8cmJ0rXiNNZ9uz5j6Ko27xUD5hYekEOQ2FW0ifH5lRSMgoe48Ui z2XX8yfEn1H6T7AaxpPrpbBoyR284ZFtAq8xBAXAGauv/Qh5PnSAQY22QsV4F2qmHcLL wQbIwmCHFcnVaOoKAcHrRJdEl26DW1jVJPuhBqqUjONFG49suOArWDSNN44Bat9FF1LQ XlS+nDkyzkLV9zHUUlud9dtix0jUkzYE7khi0AX5sMuzPkR+uES3tCW2nTX0fpE6SmtS coO5d3fJRoxKZ1o230OkoNxr884bOGvwuM93p1efeb6ovoWcYBx5GM7jGixEH1Akbu8B 9RjA== X-Gm-Message-State: AOJu0YxLCh4mdbsGvLITqHm9B4rEtvFT+USdV7+wI0emCj6eMei6FYv9 5257dwDiAsiIvJBQmLDL7b0vADsku3opTG78l8XKo4Ft7e7RFqzrQa2rOOns06x7qiPLtzNNNE5 gNj708Pw6RjJtnbOwQzApFvL6JtfL4HP2yMJXhxe+zplWhJWSHuTfRwnM+yfNWSJ7Zho8c3juuA Vxcmy3L8djXJvGoziEat8ubd2TkET4qmxjySv6Lw== X-Gm-Gg: ASbGnctO6G08wRXZLerDS5URbc80lKZJxa+l0//Rcm53RWjwLjTGReoNTDE4ZiwuFFo 9Kf0aq6Z0sOt7T555Swl0KL1W+lhPidBESUPe8f3HtvshcnTdQrB/C/Al1iVnxT0z6gzTCs0PlR ABpNYMiWMgqgDlVgcN939F6BeEjJ+mYb3BBWbgUG5i/BUOs5p+3s6W9BZbVVON5V04GcFPlQDR6 +EUSNMYxutRpzcoVwRKaNszatSoXQoLxWVrTYy9ybpdiqItNrSBknnlAO2vPOepAF4VLTlC4FPy jDqyasTi9t4+0dRVF6I5Ys2lkLbdJFkj5wRJQguBfH0KDo29nb4GsonFQpk/H1Eiu3bEbAAfpzH 5/eZc4Qk44CB2RXcJgNM= X-Received: by 2002:a05:6214:268a:b0:720:21b5:a696 with SMTP id 6a1803df08f44-72021b5dd63mr50361376d6.39.1756849207636; Tue, 02 Sep 2025 14:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzF0n3gWz2VIoIV1vg1eLTocu6B6Lwp9duH/zacVVZ8nl9DiFdzUY97LYAg9FL82hqRWiRHg== X-Received: by 2002:a05:6214:268a:b0:720:21b5:a696 with SMTP id 6a1803df08f44-72021b5dd63mr50361146d6.39.1756849207210; Tue, 02 Sep 2025 14:40:07 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: David Hildenbrand , peterx@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Peter Maydell Subject: [PATCH] memory: Fix addr for flatview_access_allowed() Date: Tue, 2 Sep 2025 17:40:05 -0400 Message-ID: <20250902214005.730358-1-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756849275836124100 flatview_access_allowed() should pass in the address offset of the memory region, rather than the global address space. Shouldn't be a major issue yet, since the addr is only used in an error log. Cc: Philippe Mathieu-Daud=C3=A9 Fixes: 3ab6fdc91b ("softmmu/physmem: Introduce MemTxAttrs::memory field and= MEMTX_ACCESS_ERROR") Signed-off-by: Peter Xu Reviewed-by: David Hildenbrand --- system/physmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index f498572fc8..019118cf75 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3027,7 +3027,7 @@ static MemTxResult flatview_write(FlatView *fv, hwadd= r addr, MemTxAttrs attrs, =20 l =3D len; mr =3D flatview_translate(fv, addr, &mr_addr, &l, true, attrs); - if (!flatview_access_allowed(mr, attrs, addr, len)) { + if (!flatview_access_allowed(mr, attrs, mr_addr, len)) { return MEMTX_ACCESS_ERROR; } return flatview_write_continue(fv, addr, attrs, buf, len, @@ -3118,7 +3118,7 @@ static MemTxResult flatview_read(FlatView *fv, hwaddr= addr, =20 l =3D len; mr =3D flatview_translate(fv, addr, &mr_addr, &l, false, attrs); - if (!flatview_access_allowed(mr, attrs, addr, len)) { + if (!flatview_access_allowed(mr, attrs, mr_addr, len)) { return MEMTX_ACCESS_ERROR; } return flatview_read_continue(fv, addr, attrs, buf, len, --=20 2.50.1