From nobody Sun Sep 28 17:05:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756818732; cv=none; d=zohomail.com; s=zohoarc; b=F/FHpvpw+6a8dizlvDbboOEPRL+phqPTUPze5Li5H3Up6dObv9XfhfEMgMyy0DaZZbdozJmzGhJbFDFNK4AUuPFi6a6Qov1z8s1iYZYH8CHGnOE2mr8f5Ph/zv+BhuoJ8THYoWCSj1sYYjYmizH03F/uZcNV0IW1ga6fjTyLLAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756818732; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GPee0txgZJCRwPW5GCHfm4cEZQr/K6Xo/55H9PnDEgg=; b=mJLp+DPMkE21ETe61nJP3mn5C0y/gK8x3R1rUySuTnFSutAfMYOammUtGu6AUzLASAB6UHEaxb56HzCAyT6Rb6CDEHGkVMuCfDpE5bZa/+SC6Zz/tf9C8C4/dGWPistnlxKibUDoAoR3RAuB/lVMVi6fYWjTRJfU2TJc6HLOxH8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTP id 175681873256752.48375984234451; Tue, 2 Sep 2025 06:12:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utQmU-0000Hn-PV; Tue, 02 Sep 2025 09:10:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utQmQ-0000Fy-Ng for qemu-devel@nongnu.org; Tue, 02 Sep 2025 09:10:34 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1utQmM-0004OV-19 for qemu-devel@nongnu.org; Tue, 02 Sep 2025 09:10:34 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3dad6252eacso264915f8f.1 for ; Tue, 02 Sep 2025 06:10:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9db4sm19733791f8f.47.2025.09.02.06.10.26 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 02 Sep 2025 06:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756818627; x=1757423427; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GPee0txgZJCRwPW5GCHfm4cEZQr/K6Xo/55H9PnDEgg=; b=X+MvMEvdTe3FG2ji8xXr17lNfZBPpA/koAPiW2Ir/3iBydw087fnfQRg4iOax44qgR uxMxMKEMzCeMoelx0TbkjJxlMxY17bdhAJnzUYDazgxPkI61g881SPtYSp05omc4+xyb En4JCWHjk03cG7a8efJD/uoPxkwHCSVxyGGbX90T/LJwzc/nRYkiC9TGW4m68KNCkSdG CiSd4XKc4yFICLx0x52Gj5Ya4qa47ENin6h0OiFAOs2TVZdb4oV4kv4NakiuZcJXQ+to P9L6vsf0On/vVxMAcWw2qbMWGd72qY9h45TYKaP8caH3Q5tcpoBjGQNaI855BjoU3N0V VuFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756818627; x=1757423427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GPee0txgZJCRwPW5GCHfm4cEZQr/K6Xo/55H9PnDEgg=; b=MH8iKTBD5zNv5HODAMymo+V2bFgB+wsHnkaiqKv9+fgxtL7Y/4jCVy3VMZ+NZYYMIy j1Yra6vmfIbduzQ4kZhM/V+HShxc5ARWBZIBoEJ0KJbw5k9MJTWogw/XcIkyhOtJedHI eyp8AGnOtnyy7ikJ04raEEqv4UicTYdQZlVjQvL7Uug64Cb2J/ireqXsezNXx72qiWBR BniY2pUgu3GJ7JmBqPobPiiRPkzk7p2pjgM2TziesKIwsuu7qWMzb3laJnZMz0oA7io1 IuRMiEk/C8Q0JYl/3zE1KVNRnVszukjSQUGiMiY8Y6CAFgn78Bpye31IFnRe8UPJqRoX iOUw== X-Gm-Message-State: AOJu0YzDXsxd0RonWmGCVTRqp/Jv7nM77hM4InOjNom6OYHvTIOi7dfN +Vl7ngOp/G0GZjNMrF3YQZ/59aY1oVc5b3FPSCjXDK+cfaMTrhkME0kCqBxxoNhqPq8qmHKyd2R 78qRS X-Gm-Gg: ASbGnctmgkT7aQGJagP04pevpB+crHf5GAIox9rox2rGBfGscxIiObWPLDaEX2RMZo7 O+sIpzsr5BS5BKdfOOkphaIfH8Bf5ilkMxDbl+eD6yhUm7GPKXbct4oKcfdvceTFf10sHUwdhlQ 3YAoBtlyzcrh1K8PGWW8YaYt9sWpyu1c4C/yWK2O3T8cLx/47e4yabVqabLX4vlhDqQ0Al9QXGR 3j86AzLyVf7rGB3kpGD7KtVy8VgsZNw1BmwjFUXi/2o2BW9ZrI4DRzvR5MR06syk+1YwcBpr/Sz YzP4RtMtCrswvw4b2CGdBIy0hfufRA4VBqhI2vZ4wVyInnMw3nhTb67iMTcMFWAYrZr7TKHZzkA ItMnmcJ2UI0PpKf5Oz4HWbnQ2KQzHTBuovgJhBvJxKy1iv3e3I+wyh4uutK0gFaslqEvIhQuW+v W6Emi2R8dPlQ/RzqCNeQ== X-Google-Smtp-Source: AGHT+IEIiVm1e17TkmkfQID/V++xhZwZF5wEPciowS03Y0lEDojUh88IZxrt4P4S50VYwWaMYhE6EA== X-Received: by 2002:a05:6000:1786:b0:3d1:4c3d:1933 with SMTP id ffacd0b85a97d-3d1dea8c5e9mr8976976f8f.43.1756818627324; Tue, 02 Sep 2025 06:10:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/39] target/ppc/kvm: Avoid using alloca() Date: Tue, 2 Sep 2025 15:09:39 +0200 Message-ID: <20250902131016.84968-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250902131016.84968-1-philmd@linaro.org> References: <20250902131016.84968-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756818734709116600 kvmppc_load_htab_chunk() is used for migration, thus is not a hot path. Use the heap instead of the stack, removing the alloca() call. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Manos Pitsidianakis Reviewed-by: Harsh Prateek Bora Message-Id: <20250901132626.28639-2-philmd@linaro.org> --- target/ppc/kvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index d145774b09a..2521ff65c6c 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2760,11 +2760,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bu= fsize, int64_t max_ns) int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, uint16_t n_valid, uint16_t n_invalid, Error **e= rrp) { - struct kvm_get_htab_header *buf; - size_t chunksize =3D sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; + size_t chunksize =3D sizeof(struct kvm_get_htab_header) + + n_valid * HASH_PTE_SIZE_64; + g_autofree struct kvm_get_htab_header *buf =3D g_malloc(chunksize); ssize_t rc; =20 - buf =3D alloca(chunksize); buf->index =3D index; buf->n_valid =3D n_valid; buf->n_invalid =3D n_invalid; --=20 2.51.0