From nobody Sun Sep 28 17:12:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1756785477; cv=none; d=zohomail.com; s=zohoarc; b=VbvUVcnH/o8l37iqXkNL6rZcpvn+ddE8HAq7Bm2JAHOahMFlSYbrNvSdP+bYz6SRzPECq7igWuelNblj4mcJp7d5whEeemo484tCMB6ZBLXwyjEHtjgALkrde6ETG9AN6pz3OWSSE0gV5+6NcUImgyX8rf+81NHJJSr0MTkWV0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756785477; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aSp83uHVSI0MnVI0UImBhnG9FGcruN7ODNKK+OFueJI=; b=Y7A2ioGh8DFPIzK40lbt2hpe2E2UqFmZfZTKelyRGQW6i3yk1kwXW7cBS5w4Csi4SvlmJ7TwK038lKve8wa+Mjb9CmL+3RU0CCraiv1gMQkHNbmGs763hbsIq3qwBIzZTwHL3zES0Dh17e+C1yA2HbFwfSV1zsvUQhm+Bz+Zak8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756785477764129.34830106554273; Mon, 1 Sep 2025 20:57:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utI0W-0007LV-UD; Mon, 01 Sep 2025 23:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utI0K-00077S-GB for qemu-devel@nongnu.org; Mon, 01 Sep 2025 23:48:22 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utI0H-0004XB-EF for qemu-devel@nongnu.org; Mon, 01 Sep 2025 23:48:20 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5822S2e6013176 for ; Tue, 2 Sep 2025 03:48:06 GMT Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ut2fea22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 03:48:06 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b4c949fc524so3228827a12.2 for ; Mon, 01 Sep 2025 20:48:05 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4cd006e2c6sm10633584a12.2.2025.09.01.20.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 20:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aSp83uHVSI0MnVI0UImBhnG9FGcruN7ODNKK+OFueJI=; b=jkdZoPTQlQH2zTSF 3tPuvjTQuMXl5hlQvjVL3wpr00rHHosm8RI8O4fcnD2nZBZDdB9FIzRxFO2Ggrtf GAWVOLxBaDRIQMXUD/ACfx+KkxXuP4cEeIVi+Wx7U+HU0MMWDsdD+Zl0ZMYsoVKI /lRvtUixsEaj5Reg+EH7kJOrI7hHyjAuVQGtSAV73In6LoufKRYVFiwjJHA0gdT3 oJdY4+PbGVUbuRRvstv73BoxqWEcCKHQ8plCPHw1apQjt9xDzwhnkJma7EFrfwb/ 0UekL0C+ApA5KANgYD3sKkYzRMZwmPOZssX/w0aakzMqxsBEKk+U3kImdpuBUWKc 93DRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756784885; x=1757389685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aSp83uHVSI0MnVI0UImBhnG9FGcruN7ODNKK+OFueJI=; b=Am+CqPjuV5HiSw+d3squirTGGqU7i5LfyAnqNRnzpRxqgzuw754ZvSoXso89WuyaIZ RyrFRBz5u/scCnj+Rpu79eUIPe5uziGlyCVp5nRfXUOB048DJ4Ftxo1HwcoOnpCU2GVs C6+v2woEFgyNO8On4i4y7fKCTDgESypPvZvz1T0dqlCD672vBcMVIuH25Ahhx5ZyIf2P phGiqb0A+CIeYSy+ZiZg38bDdLugOpHA8C8ifP3p1CMOP3xlDMUiJL6fhKsCcirplKHx zImdcYTFhdZ+CPlS988XwQwQqcjQsMZHUZU6Lv1hjToG6lxf1dMEK7fErDG0U3wcnD1Z 3nZA== X-Gm-Message-State: AOJu0YyP+bgQjPwEgWVquPym0rWfdkxkD7gF+JaDaosJ2ZM9M2FCJXo1 15fodsbvYqW0Ls4OBC0dTg8NKSGLqjfjPcUPewPhyi4k+E8/NX9E0SBg/7/VErkAOxQ86JL+qmQ ES8M36BExMjyqasdbdlnx3atPzfYwe7dx7X0bgOQVb6KBiQAJeAXTfsXTATd+nervL/wB X-Gm-Gg: ASbGncumSQHcQVrbGgkDJZylwukXtgCB1SAO0OLgA9mtn1TKIdkvBzkoOLQzOL6e4Ar SSBCTogeUqdiRJh4G4chVrWRo8yWIyyLE6IzOF4Qu3SByOqewXqg8Shsl6YPmqm8woiYOnhpTtO snkEaPaSS1iQy55BCWz8WWLIbxEpqkM66KqAxLisl2wZwL+dP+W9E335N6jVGGDLqDgyoDZbXMz Dd6EeZQSMOFwrmsXSR8Z3mPIZhKySSxNdS+r/G/NnJjO4YJBcSkh/1sxlSUm+LmeSrWUFcUWtM8 3+rF+B+T/DlCXJLQbNTZcTIEn++sFJ4N2IVSrSGDM4qv388UjmpGlTLzh/pfD23vxTSqFNYKOy8 Qni8JC90C+kmd X-Received: by 2002:a05:6a20:4321:b0:243:b5f3:fe5e with SMTP id adf61e73a8af0-243d6f7e8a1mr13305316637.53.1756784884665; Mon, 01 Sep 2025 20:48:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcg+WRCbrU6hRHurIij4mcQzF7+bsECZE42duAOyPhkU1w964zLppGEDMfML/22y+ig6XNoA== X-Received: by 2002:a05:6a20:4321:b0:243:b5f3:fe5e with SMTP id adf61e73a8af0-243d6f7e8a1mr13305275637.53.1756784884116; Mon, 01 Sep 2025 20:48:04 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, matheus.bernardino@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng, marco.liebel@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, Brian Cain , Matheus Tavares Bernardino Subject: [PATCH v2 36/40] target/hexagon: Add gdb support for sys regs Date: Mon, 1 Sep 2025 20:47:11 -0700 Message-Id: <20250902034715.1947718-37-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250902034715.1947718-1-brian.cain@oss.qualcomm.com> References: <20250902034715.1947718-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAzOCBTYWx0ZWRfX0G3G0akykn6X HKh7nhb/uT20XijypZSGfu1bjT9gQCzGJKsdYMS1SIM7X4D/fXCPHWE3n9+5SCbVWDDLRHz7KPP 6dr5RakE89x/Lv5tDWeyVtQpLxHeRrr0axGNf9+M2i1qMfGgSPalsyjNgXJ+1PZlricBqORrdM5 oXJrXycKU2YMbV6xYdPRvAq78oDKXMYueXpTlft6hTFLoTIQpl6wmeF02j/ulYS50P0Rmvt+f5W +YfaiuVFLSrvHYaIaDfvn4m+Xwmg+jhee9vrHlNNUg3V+ghorjhNyPY5jQ32aBKnGG2D4m5RkD+ hpumhZ1NbdhKEnjox/k5bXxqxpmZKCw8Xaw/7u0G3WacplMzw2VpGvh3k0PojCKwP0pcCxUceJ5 v16eizlG X-Proofpoint-ORIG-GUID: 0zR9gUf4cdstYTBSYSZg-F45EeDSQ7de X-Proofpoint-GUID: 0zR9gUf4cdstYTBSYSZg-F45EeDSQ7de X-Authority-Analysis: v=2.4 cv=U7iSDfru c=1 sm=1 tr=0 ts=68b668f6 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=NEAV23lmAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=igv5VeXmG1bnzZ-LDdkA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_01,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300038 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1756785479127116600 From: Brian Cain Co-authored-by: Matheus Tavares Bernardino Signed-off-by: Brian Cain --- target/hexagon/cpu.h | 6 ++ target/hexagon/internal.h | 4 ++ target/hexagon/cpu.c | 17 ++++++ target/hexagon/gdbstub.c | 45 ++++++++++++++ target/hexagon/op_helper.c | 22 +++++++ gdb-xml/hexagon-sys.xml | 116 +++++++++++++++++++++++++++++++++++++ 6 files changed, 210 insertions(+) create mode 100644 gdb-xml/hexagon-sys.xml diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h index 6b49912c08..627748392f 100644 --- a/target/hexagon/cpu.h +++ b/target/hexagon/cpu.h @@ -196,6 +196,12 @@ G_NORETURN void hexagon_raise_exception_err(CPUHexagon= State *env, uint32_t exception, uintptr_t pc); =20 +#ifndef CONFIG_USER_ONLY +uint32_t hexagon_greg_read(CPUHexagonState *env, uint32_t reg); +uint32_t hexagon_sreg_read(CPUHexagonState *env, uint32_t reg); +void hexagon_gdb_sreg_write(CPUHexagonState *env, uint32_t reg, uint32_t v= al); +#endif + typedef HexagonCPU ArchCPU; =20 void hexagon_translate_init(void); diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index 7cf7bcaa6c..c24c360921 100644 --- a/target/hexagon/internal.h +++ b/target/hexagon/internal.h @@ -22,6 +22,10 @@ =20 int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); +#ifndef CONFIG_USER_ONLY +int hexagon_sys_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n= ); +int hexagon_sys_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n); +#endif int hexagon_hvx_gdb_read_register(CPUState *env, GByteArray *mem_buf, int = n); int hexagon_hvx_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n); =20 diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 43fd13cd0d..2ee379121e 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -27,6 +27,10 @@ #include "exec/gdbstub.h" #include "accel/tcg/cpu-ops.h" =20 +#ifndef CONFIG_USER_ONLY +#include "sys_macros.h" +#endif + static void hexagon_v66_cpu_init(Object *obj) { } static void hexagon_v67_cpu_init(Object *obj) { } static void hexagon_v68_cpu_init(Object *obj) { } @@ -338,6 +342,12 @@ static void hexagon_cpu_realize(DeviceState *dev, Erro= r **errp) hexagon_hvx_gdb_write_register, gdb_find_static_feature("hexagon-hvx.xml"), 0= ); =20 +#ifndef CONFIG_USER_ONLY + gdb_register_coprocessor(cs, hexagon_sys_gdb_read_register, + hexagon_sys_gdb_write_register, + gdb_find_static_feature("hexagon-sys.xml"), 0= ); +#endif + qemu_init_vcpu(cs); cpu_reset(cs); mcc->parent_realize(dev, errp); @@ -393,6 +403,13 @@ static void hexagon_cpu_class_init(ObjectClass *c, con= st void *data) cc->tcg_ops =3D &hexagon_tcg_ops; } =20 +#ifndef CONFIG_USER_ONLY +uint32_t hexagon_greg_read(CPUHexagonState *env, uint32_t reg) +{ + g_assert_not_reached(); +} +#endif + #define DEFINE_CPU(type_name, initfn) \ { \ .name =3D type_name, \ diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c index 12d6b3bbcb..8476199b75 100644 --- a/target/hexagon/gdbstub.c +++ b/target/hexagon/gdbstub.c @@ -76,6 +76,51 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *me= m_buf, int n) g_assert_not_reached(); } =20 +#ifndef CONFIG_USER_ONLY +int hexagon_sys_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) +{ + CPUHexagonState *env =3D cpu_env(cs); + + if (n < NUM_SREGS) { + return gdb_get_regl(mem_buf, hexagon_sreg_read(env, n)); + } + n -=3D NUM_SREGS; + + if (n < NUM_GREGS) { + return gdb_get_regl(mem_buf, hexagon_greg_read(env, n)); + } + n -=3D NUM_GREGS; + + n -=3D TOTAL_PER_THREAD_REGS; + + if (n < NUM_PREGS) { + env->pred[n] =3D ldtul_p(mem_buf) & 0xff; + return sizeof(uint8_t); + } + + n -=3D NUM_PREGS; + + g_assert_not_reached(); +} + +int hexagon_sys_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) +{ + CPUHexagonState *env =3D cpu_env(cs); + + if (n < NUM_SREGS) { + hexagon_gdb_sreg_write(env, n, ldtul_p(mem_buf)); + return sizeof(target_ulong); + } + n -=3D NUM_SREGS; + + if (n < NUM_GREGS) { + return env->greg[n] =3D ldtul_p(mem_buf); + } + n -=3D NUM_GREGS; + + g_assert_not_reached(); +} +#endif static int gdb_get_vreg(CPUHexagonState *env, GByteArray *mem_buf, int n) { int total =3D 0; diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 7851f43475..a03fd078be 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -1494,6 +1494,23 @@ void HELPER(sreg_write)(CPUHexagonState *env, uint32= _t reg, uint32_t val) sreg_write(env, reg, val); } =20 +void HELPER(sreg_write_masked)(CPUHexagonState *env, uint32_t reg, uint32_= t val) +{ + BQL_LOCK_GUARD(); + sreg_write_masked(env, reg, val); +} + +void hexagon_gdb_sreg_write(CPUHexagonState *env, uint32_t reg, uint32_t v= al) +{ + BQL_LOCK_GUARD(); + sreg_write(env, reg, val); + /* + * The above is needed to run special logic for regs like syscfg, but = it + * won't set read-only bits. This will: + */ + arch_set_system_reg(env, reg, val); +} + void HELPER(sreg_write_pair)(CPUHexagonState *env, uint32_t reg, uint64_t = val) { BQL_LOCK_GUARD(); @@ -1546,6 +1563,11 @@ uint32_t HELPER(sreg_read)(CPUHexagonState *env, uin= t32_t reg) return sreg_read(env, reg); } =20 +uint32_t hexagon_sreg_read(CPUHexagonState *env, uint32_t reg) +{ + return sreg_read(env, reg); +} + uint64_t HELPER(sreg_read_pair)(CPUHexagonState *env, uint32_t reg) { BQL_LOCK_GUARD(); diff --git a/gdb-xml/hexagon-sys.xml b/gdb-xml/hexagon-sys.xml new file mode 100644 index 0000000000..8a84be28ab --- /dev/null +++ b/gdb-xml/hexagon-sys.xml @@ -0,0 +1,116 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --=20 2.34.1