From nobody Sun Sep 28 15:25:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756733247; cv=none; d=zohomail.com; s=zohoarc; b=no8GnAz/uwTrTXFkWmMsVRqMF+xUW3cBlJdyJMUdbn7yJBer4GmLNrbHQ2yIRJWqetyUX2qRqBFuzp96xepdCqA2Qo+FlLU3KKZEjN7GGvr2TGMb/QPxyDxdy8vf2cvdftAypNeBjGVDLxe/zDNdoZNQoI4LNMXrzYy7BlxgnFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756733247; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w3w1FiZdw8VHp7vBmM8UDjk+CIU/+vapRQH5dsIqp3U=; b=IQHIj0SOJ4UK91xtjAYvIfKztHjR+xn/TYMZ+GSctifndZHYkFtutlYIsGxS4ZdZUx6uFxdYHfb2P7CjsBkpNMG9fJ1aDlOoXXs2Y0PmzUThBDqLtWx2IxIqSp/yHG2eEbDwQKLjr1TnQQJ3iSby/TeZ1LBSXbb1pRjNgEgpg2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756733247117959.4367898615603; Mon, 1 Sep 2025 06:27:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut4YS-00026K-Hd; Mon, 01 Sep 2025 09:26:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut4YQ-00025U-ED for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:38 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ut4YO-0001NB-6t for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:38 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3c46686d1e6so2896680f8f.3 for ; Mon, 01 Sep 2025 06:26:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d15f7b012csm12130896f8f.63.2025.09.01.06.26.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 01 Sep 2025 06:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756733194; x=1757337994; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w3w1FiZdw8VHp7vBmM8UDjk+CIU/+vapRQH5dsIqp3U=; b=JMMIjHc21Gyf55mLU+3iO9MDoPBtodwm6oLBJfctceJ8CXBou7BxqrdfFQcPq24WH6 F3hbW9Fp0pplJyUSluipe4F6tnWLH6dNxg4qZi/j45NNlWpQwr6vHuf3P5C2+sCX5bQA FkyJiFQUEsc/EimrG83MpBc/5vgqGDkKXl5cLyJGDJJIwCPh0ZddRESIhLQI6mTMPzdD rKNO+b0hM3psBkvQNv3tqSrAxdNSpgLeG/Z/bvRfx4oQO2umva2lJOOJq+tZXb9KUkB7 I7TaOGGqatsirqsQFDdTiXdVVmpyfxig3M/VQghHkTggO1gyQvxfZL8GGz0lPC2C7Ufp quVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756733194; x=1757337994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w3w1FiZdw8VHp7vBmM8UDjk+CIU/+vapRQH5dsIqp3U=; b=YsycJBf/NEQSdFf3kfBqsnNPtH4uxjwMcyckrqwmUcOzf5sFJKjaP1g7/KMdyF8ZZj rfnvl/2YyHUIlvgef4LG4d8WQgtJZ5JxT0XGpHpDUQnulAbZ5/Fbgy37/RXAl2wtszJ0 fT6jBDyDEIRmBYvHvP+QKOHSFRUnM7/Px80+3V4hgEwzOiI9+UQ269HwLo8R1COVrFdB tMABZtR08L3ij8CUey47MxTm4aYimlhFKafhTg4hSFlSDigpI2Fgu7Zoh0opRr3WmTZK N53KR9zk9sLyWJzMjuR1vZcQbZPEiIGoEi+9CmskRn3JDmT/o73lMU+aUmaP51/qWYjl 2QgQ== X-Gm-Message-State: AOJu0YyHtCbbnAH8/skrXIIa0GGWVppRdUqTKFSNsPEAWr+/r2z5IBZH SugKsSrCAxlKtu0XXzCT8QVZEp8BMKLTb+R19Qc9zom0E1OzYlrFsBl5ocPP6WU59SrJorqqVva nOZH3 X-Gm-Gg: ASbGncvbVWW5dvR4wm+kw+tWgSsLgy4GsNOrr48FkLBPzIy68I5z2AIuh5oizGS9RFU b/1omuDUpLYtbPgfeUmolgyI3ob+Ca3LrUGw1PbZ9Brhajc0TCQAo6SzCJ1LNqPkKNqurRXC+Tm 6GADwhehEoX/Pn8+lYmRcd1PbrulC8Yb822sV/Y7CuNtKjHvn9bO0Y239uud/aXsm1Y5CCEb24X 0pfZSp3zMRJ13vIrXDHmZ0/tls6sZ1bffyQqWdHZy6UmMtr2kzn3Ql8t/zfqW7A4casWF8M7PqL dnGqJ2Hf92vmsYeK+xCZzMI86qDZIkx8Ixxmi0Dn0jnGk2C1Xikb4q0ly0Wgm8tfgNhg2VmZhVr zIuh1hYGAxzQ2sWvzWVLGPYYf9cIRvLXVqX6h4OCLdaN++Srww6hMJJwSE7ySXfdyyrNh+dMLmL dR3nRPolE= X-Google-Smtp-Source: AGHT+IH/QAHlxPbNMTYaJUtn3zT3bO63FA0TSMUQyXWPqmbg4KgBIu8+2jjlf2Aul+/W+uLb9CMgDQ== X-Received: by 2002:a05:6000:230d:b0:3d7:b12b:1312 with SMTP id ffacd0b85a97d-3d7b12b1a47mr1452198f8f.9.1756733193793; Mon, 01 Sep 2025 06:26:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Peter Maydell , Harsh Prateek Bora , Stefan Hajnoczi , Nicholas Piggin , Chinmay Rath , kvm@vger.kernel.org, Glenn Miles , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/3] target/ppc/kvm: Avoid using alloca() Date: Mon, 1 Sep 2025 15:26:24 +0200 Message-ID: <20250901132626.28639-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250901132626.28639-1-philmd@linaro.org> References: <20250901132626.28639-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756733248791116601 kvmppc_load_htab_chunk() is used for migration, thus is not a hot path. Use the heap instead of the stack, removing the alloca() call. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Harsh Prateek Bora Reviewed-by: Manos Pitsidianakis Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi --- target/ppc/kvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index d145774b09a..937b9ee986d 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2760,11 +2760,10 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bu= fsize, int64_t max_ns) int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, uint16_t n_valid, uint16_t n_invalid, Error **e= rrp) { - struct kvm_get_htab_header *buf; size_t chunksize =3D sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; + g_autofree struct kvm_get_htab_header *buf =3D g_malloc(chunksize); ssize_t rc; =20 - buf =3D alloca(chunksize); buf->index =3D index; buf->n_valid =3D n_valid; buf->n_invalid =3D n_invalid; --=20 2.51.0 From nobody Sun Sep 28 15:25:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756733247; cv=none; d=zohomail.com; s=zohoarc; b=QvIBCanlHrNIXGsg2Flh+FTpKeCjY/DaAA0wwE6lkQQxsmA2gglRbpsG5vYHbHFDPEIMNLpNDtnK3m7Co5gQVIY3v2yfEYIPUYt3LvbOR5AOrV1tbwInFr6Z3KkKAaRi26VcqDNLsnW6HNI4wfCdELiALtjawu5Vogx1c93sgpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756733247; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L+dSMANYXYS4eX2wt62pDprg7NzemwQS+AGCY6LE+2A=; b=UfDJiWSleeGhNzV1OhA4d5w5rDcm+yANptRUipiVdlnvRXn/bsJ6OcTBlGpaVJCYJnFvgyrE5bpOkettYcffN9DYUHJtgwpL+w8aW7axg4ou7ymiZoAVkI+jwRDaW4P5qpxPmsWYMLZ1SJjf08iLPNyV66HEcdUXq4tWUsXdzuY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756733247934244.33104080892963; Mon, 1 Sep 2025 06:27:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut4Yf-00029h-1k; Mon, 01 Sep 2025 09:26:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut4YX-00027X-Pq for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:45 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ut4YS-0001Oi-SY for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:45 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3d0dd9c9381so2945905f8f.1 for ; Mon, 01 Sep 2025 06:26:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3d0a7691340sm14439034f8f.39.2025.09.01.06.26.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 01 Sep 2025 06:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756733199; x=1757337999; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L+dSMANYXYS4eX2wt62pDprg7NzemwQS+AGCY6LE+2A=; b=i8CsUBVWCPUI1LiCR4aJlKMSWtaH3rWgG01BKSsVA1qP+aFFLsPRExjGqxr0V4Ffoc JKdUWTcbHzPOKKSiald8IrWMOiWOpPZcn8Kx4wpZ0cqWiu2SeaHvrXKcwPbsaYuVJhIu v0GH+QdxoliOR/Sz1aBjSA+219YS3NJdZ5lgeTA+nQkGYl21aUYHTXVRPCN4B40S+DIF ebCaFYjZ7tHUxxGoD1bkIetGgg/sl9DXiqvvmBt8CFtkUJxMpUvP/2PxNnL7nA7RhvqM DtbOk7Lj+Iw9Is1af/voeL5A2uZFlUu30nzUvE+8LR3NWJCEULhqjgzF42u6jD9LgUNm t1kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756733199; x=1757337999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L+dSMANYXYS4eX2wt62pDprg7NzemwQS+AGCY6LE+2A=; b=XC6dYLsNRNNqGjFNguhYD1b4IWZXXH2/JT5y2MJcRqShrstoSGRCI6Sf248tfNb/cX U4Y23w2MeELTL3NBiP5GPtc3yndTsOfWo49a42xC8+942+3V+WCyQlgsxmLZ4BHUyjV7 leAjsDLtQvszNN+8hmuTHZBPnlZf0FHA/calqLXqlcG4//2IryFuXS2YM0uD+1UdQ8Jm R+fcyyI8KnQUFukT7lgoe15x/GQtt0zoBN+m8OVKXh233K+3zlgScw8hh3wLZ4/Gfe5I UuduGLBfS9BWRs+1I09L918rYXRv4Dt0dq+sOm4Eg2KdQWqW+JLplbvObl7FJibAPsgY jhig== X-Gm-Message-State: AOJu0YwW5xnzLCkSN15QMpDSujQXV85A9zbm36bJBx9fXW0NSvUBRIhf RpsrkpK/kcHu5vAfLiSLdnVUXwvz2Xvv+fwyDrVojkmuVWIIQ3qa9lRONuilaXHoZQoH4vw78+E MKo3y X-Gm-Gg: ASbGncsYl2a7QqdphQ2cAzVfPCkVZw+nHD/MBhXhMbARSNWxgLZQrkmTyh35VxfIiJo PYpUV7DYSqqRdZSqW+kK4xt45V8YlLja6RMyIVoLt4z0NBsGk3C9BEFiZ+DNIGij646w2OyFzLT sy8jvbQVkL4jnABEEyqmJzIAEs8ccqC77UtOGma3mIGBM8Zwg/LvWOQEMZXGAnYM2BIt/UagbyH sMxB9WjMSbbKB+fydpJkh8N2EpRpkVbr6wTyFp4sppgbEDykXQomp51CpMWq0drZimEBmUVzps9 BDZHUvazjbYh+NAYn1KKy/GQifDUk/tmM1lKeej1ctCNASX9dWkc/ZUUyQ39DJSGp+MWrlVMVzg z/MnI1JKeHoEyCPOS8qGp35Tt2QlINIQPqdP9XXDu9fmSJVh+hLr7Ekczjrd5Qnj3H3cjWPUk8D D051bL9tU= X-Google-Smtp-Source: AGHT+IH/biFnPlU5sduD1LlOAZlDqq09up2/DXS+LzpPSrlccEYwoUtgNnCXPzTclSesIQRP6VzILg== X-Received: by 2002:a05:6000:4205:b0:3d9:415c:b146 with SMTP id ffacd0b85a97d-3d9415cb164mr246904f8f.15.1756733198715; Mon, 01 Sep 2025 06:26:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Peter Maydell , Harsh Prateek Bora , Stefan Hajnoczi , Nicholas Piggin , Chinmay Rath , kvm@vger.kernel.org, Glenn Miles , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v2 2/3] buildsys: Prohibit alloca() use on system code Date: Mon, 1 Sep 2025 15:26:25 +0200 Message-ID: <20250901132626.28639-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250901132626.28639-1-philmd@linaro.org> References: <20250901132626.28639-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756733248765116600 Similarly to commit 64c1a544352 ("meson: Enable -Wvla") with variable length arrays, forbid alloca() uses on system code. There are few uses on ancient linux-user code, do not bother there. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Stefan Hajnoczi --- meson.build | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.build index 0d42de61ae6..3d1dc2e9e26 100644 --- a/meson.build +++ b/meson.build @@ -775,6 +775,10 @@ if host_os !=3D 'darwin' endif endif =20 +if have_system + warn_flags +=3D ['-Walloca'] +endif + # Set up C++ compiler flags qemu_cxxflags =3D [] if 'cpp' in all_languages --=20 2.51.0 From nobody Sun Sep 28 15:25:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756733248; cv=none; d=zohomail.com; s=zohoarc; b=mKDXwyKv+MeWUJaMIPGjERXLbR8EHB85YZ4GK0Ss1gpMaWZNeCnRfIEzMj47e3uyPMukoULbadf/RaPdzF2Kev/ong/gxkUm1eKkVl8kRyhcZy596btNSANk0kmsMKmwYpScBjrvsaiglFz0io8fpEkdfMUA0TI7CKKl0+c0/ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756733248; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IyXvNak2OKRXWskNTtQkqe4CdzhDwlWUh7NjxtzZsaw=; b=i+zbmncpCNrB4Nv2Dv+EgP7wamZ8PqNXbSNEElav/7Wl/pd49Zq+m0UNMgMIjvhSbf/LnbKUG68UCgxC169VcKJ6IQhDAxH1K3Q+jiqDrGvZPxZciZTaCuxvyr3yPIf32pc4h6Gy8en0KmrjSCvVe8q0jR+AdOjRPiaPQE67A50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756733248559400.9980892712347; Mon, 1 Sep 2025 06:27:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut4Yk-0002D9-CO; Mon, 01 Sep 2025 09:26:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut4Ye-00029r-3H for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:52 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ut4YX-0001PI-ST for qemu-devel@nongnu.org; Mon, 01 Sep 2025 09:26:51 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45b627ea685so37220185e9.1 for ; Mon, 01 Sep 2025 06:26:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f306c93sm240511515e9.14.2025.09.01.06.26.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 01 Sep 2025 06:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756733204; x=1757338004; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IyXvNak2OKRXWskNTtQkqe4CdzhDwlWUh7NjxtzZsaw=; b=HAADyh58WM/GH4iVOgJQIBK6lBjhBiL6Y9NEkFNukdFWDJxfnCATNzPdQcmvaALLMO MK16xVnwtLAjDb362yA014QnZn7lBQBGnVAI5xzql1iyswcBo67d8mlNCm6mDlGE34L3 YMyW7SKKw+zA+JQBb7bZkrYoieVxYBki7IUKCw1wqNCUXsNajpzcWPNLcqkrco7I57Fk eolhf0+ixYuM51ZJQL/aj/ZT+XdTwIu3W27vIA1BmlQF000+FJbtaVVZmT4D7lYGIQyR PhTsEqFgIR8f4u1SxJpCcrhTAWcQa6HEr56+Ppjaz8IX8XNRIexCT1rS1fsbjl9Jsftu VmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756733204; x=1757338004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IyXvNak2OKRXWskNTtQkqe4CdzhDwlWUh7NjxtzZsaw=; b=GU9glkdXmfQLPoi+BKyTsfyUj7vE8yguarD/botQhwPPFO4BFdlKnlsAtw8iOl/MGN AMLhooXoqMpwjQvYq0G2Ci44rj5mmu73/YnrF2PojAG8FyKgNo1aEVaQwLA1jUSuuX6r Xu9ZRflGU6Bgu4ZTj/K96oYZRm/mpi+BPi48i8LSL85uXd/R72HEyPVmoInaFoNQwC2d Q5ATc6FlZPsy/az3M7e2/eC+zqonyHJq5VQ+f+e+etxSdkT0BN2NOigfN5i4mrkm5wEB Alz1+NJ7XrzDK9yfv8CHi1akvd+XlRi/XXh7vRH5gfT5JxVMk8hU6CTzQ1JhovOfjKNr ynVw== X-Gm-Message-State: AOJu0YxtShdnopSC68k8pk9iVFKHuvJ22LE/cWu5t+k6fuezgkwuWuwT XPtdwozfJK6eEjlyDsTSc9A3262QiBWq0suc5Z7Ohd7IHTUYzeZ/ONQZGAqj+k/HtOLzw6NBu1J umP4J X-Gm-Gg: ASbGncsGQf9V+DlBok9kh/HrtF4W8StpNGiOyAFzoHnh73ov7mZmK0YEGiTAsST4VjO LgNqr7eZj80+ylO2kUxTMQIGUuBtZOcgIkyJehd+HWsOFHLmwGEqqMxL9orRA1CBGbvspygXKMX 1HICLPkbjwYLutL9AFtHiwq/awy9u+MadbaDw+A5dqEULnBQYBtidNI6oMRg9CoLBEzifGP7dZd eFIaHtqhAR830KjyCU17qaCaZRFfgsc7sdPOKTIIgsOJfKvpo7/5dYKJ+S6ZYh3SfZOeMzDlH8T pxPvEp9XESJ2h+yfPOS4vI19EByM3Tj9HCJeKgQ5KlFyN2kMCVS/ezBHXI91IfffifKLqWrv4Ee 1pIPFm512KqopqAQHcfU3Ue+QtOSKLkFQfQzcJLyu91wCFmKOT3gMZmAuq1CHwyWPe/jlmqug X-Google-Smtp-Source: AGHT+IFxk1oMEs+7TSEUZFjOaTMjdD9yFbHhe/UTsg1JhXdhq8eWAumv9rYthd/OcoCrSH7dulAkvQ== X-Received: by 2002:a05:600c:8b22:b0:459:dde3:1a56 with SMTP id 5b1f17b1804b1-45b855b3b23mr62404115e9.28.1756733203643; Mon, 01 Sep 2025 06:26:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Peter Maydell , Harsh Prateek Bora , Stefan Hajnoczi , Nicholas Piggin , Chinmay Rath , kvm@vger.kernel.org, Glenn Miles , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Armbruster Subject: [PATCH v2 3/3] docs/devel/style: Mention alloca() family API is forbidden Date: Mon, 1 Sep 2025 15:26:26 +0200 Message-ID: <20250901132626.28639-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250901132626.28639-1-philmd@linaro.org> References: <20250901132626.28639-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756733250611116600 Suggested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Stefan Hajnoczi --- docs/devel/style.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst index d025933808e..941fe14bfd4 100644 --- a/docs/devel/style.rst +++ b/docs/devel/style.rst @@ -446,8 +446,8 @@ Low level memory management =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =20 Use of the ``malloc/free/realloc/calloc/valloc/memalign/posix_memalign`` -APIs is not allowed in the QEMU codebase. Instead of these routines, -use the GLib memory allocation routines +or ``alloca/g_alloca/g_newa/g_newa0`` APIs is not allowed in the QEMU code= base. +Instead of these routines, use the GLib memory allocation routines ``g_malloc/g_malloc0/g_new/g_new0/g_realloc/g_free`` or QEMU's ``qemu_memalign/qemu_blockalign/qemu_vfree`` APIs. =20 --=20 2.51.0