From nobody Sun Sep 28 16:28:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756728860; cv=none; d=zohomail.com; s=zohoarc; b=UAs5/ruxVnBeLvvVZbgh+9uZNyBBg6JpMP3Nzab6RD65HEeTmQvWUrKhsec6L9GKS/XXWc/xYii8Y7Pp/iM8njuKy/Q9yE/GlFb0HDWoaEv8/7GtYBqTjL4+5FhygdAxPqMBFFZKxB7E7qiW7CCW7iaSaDr76IdRbueDL8jQDyg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756728860; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Date:Resent-To:References:Resent-Message-ID:Resent-From:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bRV9OOJyHJvhWIpd9mvExzO8HtMA/H5nba9hQcm9jMc=; b=ACi+HKlnisOK8CXgCOIizMQwzajHanbsIBFVlUQEeMBT01nBBxBojrbv8m5d2riSwyo9/PkztTORCKNbyjVqhpKc4lWS3izft30gj38fffOGB91mcQ7gWadNQICbfxCYEiN7o6l+RKxwfRTsWlFc/4GfendkC+atoS7bwOA9c0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756728860645264.8876499107688; Mon, 1 Sep 2025 05:14:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut3P3-0001hR-8Q; Mon, 01 Sep 2025 08:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OV-0001QE-2B for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OH-0006D2-Ub for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:17 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-qJ2LIQ-SNZ6c_zVvbaHb-A-1; Mon, 01 Sep 2025 08:11:56 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A841F195608A; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 48BC030001A2; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6A69521E6924; Mon, 01 Sep 2025 14:11:51 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9F40621E6924; Mon, 01 Sep 2025 13:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756728719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=bRV9OOJyHJvhWIpd9mvExzO8HtMA/H5nba9hQcm9jMc=; b=OmDPKT8Q1ovh0CtG7flWAWRZwla17N2GzLSY00HxWmHMBycRGn6Fig/8dSnhgGHsZN5q0Q 6lxBEHAsYvMDBZ2areK3LZbTlaxUmzG+ZDevTSFC0Y7dt8NEyFr+uEUHhz6TqBD/5Usp6y aY8hcCSW2Xggh72I7+nkHb+mUpUd1d0= X-MC-Unique: qJ2LIQ-SNZ6c_zVvbaHb-A-1 X-Mimecast-MFC-AGG-ID: qJ2LIQ-SNZ6c_zVvbaHb-A_1756728714 Resent-To: qemu-devel@nongnu.org, richard.henderson@linaro.org Resent-From: Markus Armbruster Resent-Date: Mon, 01 Sep 2025 14:11:51 +0200 Resent-Message-ID: <87v7m22wzc.fsf@pond.sub.org> X-From-Line: armbru@redhat.com Mon Sep 1 13:53:00 2025 X-Original-To: armbru From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Steve Sistare Subject: [PULL 1/5] qtest/qom-test: Shallow testing of qom-list / qom-get Date: Mon, 1 Sep 2025 13:52:56 +0200 Message-ID: <20250901115300.2541937-2-armbru@redhat.com> In-Reply-To: <20250901115300.2541937-1-armbru@redhat.com> References: <20250901115300.2541937-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Lines: 41 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756728862033116600 Content-Type: text/plain; charset="utf-8" This test traverses the QOM sub-tree rooted at /machine with a combination of qom-list and qom-get. In my x86_64 testing, it runs almost 12000 QMP commands in 34 seconds. With -m slow, we test more machines, and it takes almost 84000 commands in almost four minutes. Since commit 3dd93992ffb (tests/qtest/qom-test: unit test for qom-list-get), the test traverses this tree a second time, with qom-list-get. In my x86_64 testing, this takes some 200 QMP commands and around two seconds, and some 1100 in just under 12s with -m slow. Traversing the entire tree is useful, because it exercise the QOM property getters. Traversing it twice not so much. Make the qom-list / qom-get test shallow unless -m slow is given: don't recurse. Cuts the number of commands to around 600, and run time to under 5s for me. Signed-off-by: Markus Armbruster Message-ID: <20250725135034.2280477-3-armbru@redhat.com> Reviewed-by: Steve Sistare --- tests/qtest/qom-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 4ade1c728c..7dea0d802d 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -180,7 +180,7 @@ static void test_properties(QTestState *qts, const char= *path, bool recurse) links =3D g_slist_delete_link(links, links); } while (children) { - test_properties(qts, children->data, true); + test_properties(qts, children->data, g_test_slow()); g_free(children->data); children =3D g_slist_delete_link(children, children); } --=20 2.49.0 From nobody Sun Sep 28 16:28:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756728812; cv=none; d=zohomail.com; s=zohoarc; b=h5hjh1dfgbOeqAVk55iSDfsvz0/drG0HXHxYaGAf4vvescgFEduIuQmYk9FJMppZpnczm8uU9z4kEB832C3pzOnZPcCZSSNRmrfED13kOemK2UAjV79mppTRvS5JFKQStmrIy38+DQpZcr8BMNAIb3evqsDhzmL27K/e7g39/pU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756728812; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Date:Resent-To:References:Resent-Message-ID:Resent-From:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hYAt5OdegkmQavTKluTT3PGB4sCDDQMCHHmoN9ydOtE=; b=Ja8g+f3CfURKqUoFk7cgYvBT87rHDSaNL/ULsiJyHg9DYj9w38t0z6YTVyUPUISAVd9i+9Rx/1RpUv02m2QNSMbkuVgGkUfLg2kjRETa6cS8m7rFRgw+ALohac5RAqSE1oObT7u8uHgg+/CINwMUE62RBGyYVUrx4bxB9HWwkUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756728812691417.2627311513305; Mon, 1 Sep 2025 05:13:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut3Ou-0001U1-Ef; Mon, 01 Sep 2025 08:12:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OT-0001Ph-H8 for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OG-0006D1-7x for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:16 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-_t7I7wyAOd6SUHEzYTBXMA-1; Mon, 01 Sep 2025 08:11:56 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 675AF1800357; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20DB7180028F; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 742B821E6925; Mon, 01 Sep 2025 14:11:51 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A303221E6925; Mon, 01 Sep 2025 13:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756728719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=hYAt5OdegkmQavTKluTT3PGB4sCDDQMCHHmoN9ydOtE=; b=FOp9C8tALbvgmZWK1btvGZ3dGlKS+ZD3ZcFcjiXPt2JGbQ4+kCuDUhU2cw6GVrt0eOXmOx MfSKinxrQv7KcErGlI4uPMEoiCtRxunMrzaH2MW//MnlkTdE1aQTtooonBMdRdzAKD9xLS qkbBQ+zEC7pN3LRmz8sQz8K+U3IZftk= X-MC-Unique: _t7I7wyAOd6SUHEzYTBXMA-1 X-Mimecast-MFC-AGG-ID: _t7I7wyAOd6SUHEzYTBXMA_1756728714 Resent-To: qemu-devel@nongnu.org, richard.henderson@linaro.org Resent-From: Markus Armbruster Resent-Date: Mon, 01 Sep 2025 14:11:51 +0200 Resent-Message-ID: <87qzwq2wzc.fsf@pond.sub.org> X-From-Line: armbru@redhat.com Mon Sep 1 13:53:00 2025 X-Original-To: armbru From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Steve Sistare Subject: [PULL 2/5] qtest/qom-test: Traverse entire QOM tree Date: Mon, 1 Sep 2025 13:52:57 +0200 Message-ID: <20250901115300.2541937-3-armbru@redhat.com> In-Reply-To: <20250901115300.2541937-1-armbru@redhat.com> References: <20250901115300.2541937-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Lines: 30 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756728815097124100 Content-Type: text/plain; charset="utf-8" This test traverses the QOM sub-tree rooted at /machine. Traverse the entire tree instead. The x86_64 test runs some 40 additional QMP commands, and stays under 5s for me. Signed-off-by: Markus Armbruster Message-ID: <20250725135034.2280477-4-armbru@redhat.com> Reviewed-by: Steve Sistare --- tests/qtest/qom-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 7dea0d802d..a2db56bf22 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -211,7 +211,7 @@ static void test_machine(gconstpointer data) =20 test_properties(qts, "/machine", true); =20 - qlist_append_str(paths, "/machine"); + qlist_append_str(paths, "/"); test_list_get(qts, paths); test_list_get_value(qts); =20 --=20 2.49.0 From nobody Sun Sep 28 16:28:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756728806; cv=none; d=zohomail.com; s=zohoarc; b=asbuL7+mjSESGAUa7BGOJxI9fUzUTB3PiQTxqJVI/9dY7zDBgAGQjRv+kk0291uTJzihbPFjgcCi1/k+x9Pt27LucyGrXAfS4elTIbe3JjFViC/1teNfwGJHw8xn2kZegjtFvSDJmnpghng4IjX3PhSfKL8Md2J67IPwAjzatfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756728806; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Date:Resent-To:References:Resent-Message-ID:Resent-From:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FSN5P9oAzI6KeIFbHSJwmI6uOs4VIgbaSKqk6qbWR7Q=; b=SZ1/3HnXE6l5e0AzkQurDwGy6HyVw68ePGJhtaB7huwqz2mzEiAxKb32379e9GffepKqzt+r1NNJvGzKhK09+yiJ6JFPO/aCessGUPsU0tAT1xDRV/uVxOkz1EqT88e4+5XECfLt6z2X9xjlBmpDo6tYttuGCkgrvzGRe+qRTs8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756728806429225.049639650362; Mon, 1 Sep 2025 05:13:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut3Oi-0001QX-8O; Mon, 01 Sep 2025 08:12:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OP-0001Os-6Z for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OD-0006Cg-2c for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:12 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-bQwQQS8JOKCoV0hEYKsntA-1; Mon, 01 Sep 2025 08:11:55 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 900F6180036E; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2F93C180029F; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7D7F421E6935; Mon, 01 Sep 2025 14:11:51 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A6EE821E6935; Mon, 01 Sep 2025 13:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756728716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=FSN5P9oAzI6KeIFbHSJwmI6uOs4VIgbaSKqk6qbWR7Q=; b=epSzbgX21TR4VIx/XZLoW09hqRqlStcPSvLVASxGvjqfJp24E3uNUaiePoejiXHQjjNUp7 OOF6OFklObAPaShxuVY06LUM+j9GPS9IfMIX2fxG/nH6sXuY1HVFdzQSvnna38PeFNEAQW mhWgYn69qhQ7i6Kp7gic+i/I0HOxgrk= X-MC-Unique: bQwQQS8JOKCoV0hEYKsntA-1 X-Mimecast-MFC-AGG-ID: bQwQQS8JOKCoV0hEYKsntA_1756728714 Resent-To: qemu-devel@nongnu.org, richard.henderson@linaro.org Resent-From: Markus Armbruster Resent-Date: Mon, 01 Sep 2025 14:11:51 +0200 Resent-Message-ID: <87ms7e2wzc.fsf@pond.sub.org> X-From-Line: armbru@redhat.com Mon Sep 1 13:53:00 2025 X-Original-To: armbru From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Steve Sistare Subject: [PULL 3/5] qtest/qom-test: Don't bother to execute QMP command quit Date: Mon, 1 Sep 2025 13:52:58 +0200 Message-ID: <20250901115300.2541937-4-armbru@redhat.com> In-Reply-To: <20250901115300.2541937-1-armbru@redhat.com> References: <20250901115300.2541937-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Lines: 26 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756728807104124100 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Message-ID: <20250725135034.2280477-5-armbru@redhat.com> Reviewed-by: Steve Sistare --- tests/qtest/qom-test.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index a2db56bf22..2da9918e16 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -215,10 +215,6 @@ static void test_machine(gconstpointer data) test_list_get(qts, paths); test_list_get_value(qts); =20 - response =3D qtest_qmp(qts, "{ 'execute': 'quit' }"); - g_assert(qdict_haskey(response, "return")); - qobject_unref(response); - qtest_quit(qts); g_free((void *)machine); } --=20 2.49.0 From nobody Sun Sep 28 16:28:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756728861; cv=none; d=zohomail.com; s=zohoarc; b=FoEeOIwKtPGDdO3DNOL240a35Ex9U8w8qcKq8048F6DvIJmNQJIdnMtwfI7yYPdc2e8yJfup+dOr6rElvGGs74BPbapQg63QSW5dds+QGUkNUZ+bEFB5QiP12E3/WwvYYWOKyjI/ECRRCWipLI1oO55wAjndzsk3/XpHTZZrF8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756728861; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Date:Resent-To:References:Resent-Message-ID:Resent-From:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qR6Xhcpa+sEC5RF82chLA0IzBpbmra43dODoPLjs+ac=; b=hF9fVWRvMyBnTGtxFeJsDRMejtnGImBWGFlGw6OoZWaT8Ir6EJzmVax6XtiTgfZKapLE86gWobZD6r7TcCgF67y6Mts1W9qdFB0vGc+AGrhxDd8azMFmcGl1ChAYXIgYsrX4WB9jZS+esfGdJEjT7kMwDSuw/3Eg4GaJXu8qDAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756728861694523.2830562927362; Mon, 1 Sep 2025 05:14:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut3P6-0001m3-GQ; Mon, 01 Sep 2025 08:12:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3Oc-0001RD-42 for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3OI-0006D4-3X for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:23 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-2quXbpMfMt2daaVn2C42AA-1; Mon, 01 Sep 2025 08:11:58 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62ACB180034A; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C06D180047F; Mon, 1 Sep 2025 12:11:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 86AEA21E6773; Mon, 01 Sep 2025 14:11:51 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AB1AD21E675E; Mon, 01 Sep 2025 13:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756728719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=qR6Xhcpa+sEC5RF82chLA0IzBpbmra43dODoPLjs+ac=; b=Vwfc7LdQ5fo5Si/GxGqBaQdMFgewC7f5qXURLUb1b1Nd+XGkZ3vW2b8HF6KXVJaQmf5RHk b9vgrHDXFwPCNyjJ91iRQr9xOTqUO0BPGvyIVDxOe0xgxe8GssXAadqvSDqoGEiVEv7bxF UljS2tkuF947qgoPYbNTESSGLC7xCnc= X-MC-Unique: 2quXbpMfMt2daaVn2C42AA-1 X-Mimecast-MFC-AGG-ID: 2quXbpMfMt2daaVn2C42AA_1756728715 Resent-To: qemu-devel@nongnu.org, richard.henderson@linaro.org Resent-From: Markus Armbruster Resent-Date: Mon, 01 Sep 2025 14:11:51 +0200 Resent-Message-ID: <87iki22wzc.fsf@pond.sub.org> X-From-Line: armbru@redhat.com Mon Sep 1 13:53:00 2025 X-Original-To: armbru From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 4/5] MAINTAINERS: Cover tests/qtest/qom-test.c Date: Mon, 1 Sep 2025 13:52:59 +0200 Message-ID: <20250901115300.2541937-5-armbru@redhat.com> In-Reply-To: <20250901115300.2541937-1-armbru@redhat.com> References: <20250901115300.2541937-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Lines: 22 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756728863770124100 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Message-ID: <20250725135034.2280477-6-armbru@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8147fff352..0207946537 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3454,6 +3454,7 @@ F: qom/ F: tests/unit/check-qom-interface.c F: tests/unit/check-qom-proplist.c F: tests/unit/test-qdev-global-props.c +F: tests/qtest/qom-test.c =20 QOM boilerplate conversion script M: Eduardo Habkost --=20 2.49.0 From nobody Sun Sep 28 16:28:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756728811; cv=none; d=zohomail.com; s=zohoarc; b=Z+PJ+AorhpyLpijBiav5qnfEagvGwRkE+ohe9Uw2CE/159LaFhYZGPdJ2kQEzEmwopgRGhsfqFlbq143Bk26LQ6LevVDPXpjmk+uSxtFwdCd6uNtcvVvxR2a1uAT+iGg2i2cl2BqvjGBVp+p1hBdEtKrm1uWmfvJ8l4oByM1Mb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756728811; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Date:Resent-To:References:Resent-Message-ID:Resent-From:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UZz6/zeejZkwvJJJjKyQ4lcGhhR0a2ff2nsIdivviqI=; b=KJqO+RJNjTDoLmzn7YwH1JHemp/XEgK5jIQPh46vaKNEO40EyXhyL0/RCWNDvK4FgPaFr/UhqPbMKrkPh8QFDIr8MYU6+SOdPbOb2xjq7hAWPqr97UhJLYq+PDzck/IhrbMacA7zCVO6uEP6t9HyYQH3SyIb/R5jvFpAjfmkiRI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756728811176467.674682825108; Mon, 1 Sep 2025 05:13:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut3Oz-0001ei-JO; Mon, 01 Sep 2025 08:12:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3Oc-0001RF-4P for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut3ON-0006DM-QC for qemu-devel@nongnu.org; Mon, 01 Sep 2025 08:12:23 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-ftEDinsyP_2Inn6Oj_l9Jg-1; Mon, 01 Sep 2025 08:11:58 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D95ED180048E; Mon, 1 Sep 2025 12:11:57 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A00519560B4; Mon, 1 Sep 2025 12:11:57 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 925F521E6774; Mon, 01 Sep 2025 14:11:51 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AF06A21E6774; Mon, 01 Sep 2025 13:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756728722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=UZz6/zeejZkwvJJJjKyQ4lcGhhR0a2ff2nsIdivviqI=; b=PXeyFia4MJEGMlk8dlveOGi2dVYD++kFCvHd3rqJyPj92r+Tjv5gJWfuTt1EpdJ455Rktu HwuhzBa91TQLTgXnE8f5mwsYnUcMiQMnLifMVxq0nyckUrohkmvuZb20rCh2G3zjfO3H39 vyxIfw4EVRhloQOfvYegllfXGf6sHJY= X-MC-Unique: ftEDinsyP_2Inn6Oj_l9Jg-1 X-Mimecast-MFC-AGG-ID: ftEDinsyP_2Inn6Oj_l9Jg_1756728718 Resent-To: qemu-devel@nongnu.org, richard.henderson@linaro.org Resent-From: Markus Armbruster Resent-Date: Mon, 01 Sep 2025 14:11:51 +0200 Resent-Message-ID: <87ecsq2wzc.fsf@pond.sub.org> X-From-Line: armbru@redhat.com Mon Sep 1 13:53:00 2025 X-Original-To: armbru From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PULL 5/5] Revert "tests/qtest: use qos_printf instead of g_test_message" Date: Mon, 1 Sep 2025 13:53:00 +0200 Message-ID: <20250901115300.2541937-6-armbru@redhat.com> In-Reply-To: <20250901115300.2541937-1-armbru@redhat.com> References: <20250901115300.2541937-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Lines: 168 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756728813203124100 Content-Type: text/plain; charset="utf-8" This reverts commit 30ea13e9d97dcbd4ea541ddf9e8857fa1d5cb30f. Also rewrites qos_printf() calls added later. "make check" prints many lines like stdout: 138: UNKNOWN: # # qos_test running single test in subprocess stdout: 139: UNKNOWN: # # set_protocol_features: 0x42 stdout: 140: UNKNOWN: # # set_owner: start of session stdout: 141: UNKNOWN: # # vhost-user: un-handled message: 14 stdout: 142: UNKNOWN: # # vhost-user: un-handled message: 14 stdout: 143: UNKNOWN: # # set_vring(0)=3Denabled stdout: 144: UNKNOWN: # # set_vring(1)=3Denabled stdout: 145: UNKNOWN: # # set_vring(0)=3Denabled stdout: 146: UNKNOWN: # # set_vring(1)=3Denabled stdout: 147: UNKNOWN: # # set_vring(0)=3Denabled stdout: 148: UNKNOWN: # # set_vring(1)=3Denabled stdout: 149: UNKNOWN: # # set_vring(0)=3Denabled stdout: 150: UNKNOWN: # # set_vring(1)=3Denabled stdout: 151: UNKNOWN: # # set_vring(0)=3Denabled stdout: 152: UNKNOWN: # # set_vring(1)=3Denabled stdout: 153: UNKNOWN: # # set_vring_num: 0/256 stdout: 154: UNKNOWN: # # set_vring_addr: 0x7f9060000000/0x7f905fff= f000/0x7f9060001000 Turns out this is qos-test, and the culprit is a commit meant to ease debugging. Revert it until a better solution is found. Signed-off-by: Markus Armbruster Message-ID: <20250728145747.3165315-1-armbru@redhat.com> [Commit message clarified] --- tests/qtest/qos-test.c | 5 ----- tests/qtest/vhost-user-test.c | 27 +++++++++++++-------------- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c index abfd4b9512..00f39f33f6 100644 --- a/tests/qtest/qos-test.c +++ b/tests/qtest/qos-test.c @@ -328,11 +328,6 @@ static void walk_path(QOSGraphNode *orig_path, int len) int main(int argc, char **argv, char** envp) { g_test_init(&argc, &argv, NULL); - - if (g_test_subprocess()) { - qos_printf("qos_test running single test in subprocess\n"); - } - if (g_test_verbose()) { qos_printf("ENVIRONMENT VARIABLES: {\n"); for (char **env =3D envp; *env !=3D 0; env++) { diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index 75cb3e44b2..56472ca709 100644 --- a/tests/qtest/vhost-user-test.c +++ b/tests/qtest/vhost-user-test.c @@ -26,7 +26,6 @@ #include "libqos/virtio-pci.h" =20 #include "libqos/malloc-pc.h" -#include "libqos/qgraph_internal.h" #include "hw/virtio/virtio-net.h" =20 #include "standard-headers/linux/vhost_types.h" @@ -345,7 +344,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) } =20 if (size !=3D VHOST_USER_HDR_SIZE) { - qos_printf("%s: Wrong message size received %d\n", __func__, size); + g_test_message("Wrong message size received %d", size); return; } =20 @@ -356,8 +355,8 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) p +=3D VHOST_USER_HDR_SIZE; size =3D qemu_chr_fe_read_all(chr, p, msg.size); if (size !=3D msg.size) { - qos_printf("%s: Wrong message size received %d !=3D %d\n", - __func__, size, msg.size); + g_test_message("Wrong message size received %d !=3D %d", + size, msg.size); goto out; } } @@ -393,7 +392,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) * We don't need to do anything here, the remote is just * letting us know it is in charge. Just log it. */ - qos_printf("set_owner: start of session\n"); + g_test_message("set_owner: start of session\n"); break; =20 case VHOST_USER_GET_PROTOCOL_FEATURES: @@ -419,7 +418,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) * the remote end to send this. There is no handshake reply so * just log the details for debugging. */ - qos_printf("set_protocol_features: 0x%"PRIx64 "\n", msg.payload.u6= 4); + g_test_message("set_protocol_features: 0x%"PRIx64 "\n", msg.payloa= d.u64); break; =20 /* @@ -427,11 +426,11 @@ static void chr_read(void *opaque, const uint8_t *buf= , int size) * address of the vrings but we can simply report them. */ case VHOST_USER_SET_VRING_NUM: - qos_printf("set_vring_num: %d/%d\n", + g_test_message("set_vring_num: %d/%d\n", msg.payload.state.index, msg.payload.state.num); break; case VHOST_USER_SET_VRING_ADDR: - qos_printf("set_vring_addr: 0x%"PRIx64"/0x%"PRIx64"/0x%"PRIx64"\n", + g_test_message("set_vring_addr: 0x%"PRIx64"/0x%"PRIx64"/0x%"PRIx64= "\n", msg.payload.addr.avail_user_addr, msg.payload.addr.desc_user_addr, msg.payload.addr.used_user_addr); @@ -464,7 +463,7 @@ static void chr_read(void *opaque, const uint8_t *buf, = int size) case VHOST_USER_SET_VRING_CALL: /* consume the fd */ if (!qemu_chr_fe_get_msgfds(chr, &fd, 1) && fd < 0) { - qos_printf("call fd: %d, do not set non-blocking\n", fd); + g_test_message("call fd: %d, do not set non-blocking\n", fd); break; } /* @@ -510,12 +509,12 @@ static void chr_read(void *opaque, const uint8_t *buf= , int size) * fully functioning vhost-user we would enable/disable the * vring monitoring. */ - qos_printf("set_vring(%d)=3D%s\n", msg.payload.state.index, + g_test_message("set_vring(%d)=3D%s\n", msg.payload.state.index, msg.payload.state.num ? "enabled" : "disabled"); break; =20 default: - qos_printf("vhost-user: un-handled message: %d\n", msg.request); + g_test_message("vhost-user: un-handled message: %d\n", msg.request= ); break; } =20 @@ -539,7 +538,7 @@ static const char *init_hugepagefs(void) } =20 if (access(path, R_OK | W_OK | X_OK)) { - qos_printf("access on path (%s): %s", path, strerror(errno)); + g_test_message("access on path (%s): %s", path, strerror(errno)); g_test_fail(); return NULL; } @@ -549,13 +548,13 @@ static const char *init_hugepagefs(void) } while (ret !=3D 0 && errno =3D=3D EINTR); =20 if (ret !=3D 0) { - qos_printf("statfs on path (%s): %s", path, strerror(errno)); + g_test_message("statfs on path (%s): %s", path, strerror(errno)); g_test_fail(); return NULL; } =20 if (fs.f_type !=3D HUGETLBFS_MAGIC) { - qos_printf("Warning: path not on HugeTLBFS: %s", path); + g_test_message("Warning: path not on HugeTLBFS: %s", path); g_test_fail(); return NULL; } --=20 2.49.0