From nobody Sun Sep 28 16:34:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756725946; cv=none; d=zohomail.com; s=zohoarc; b=aXmq3DERSNVtb+oN0ybigdg4JEC5z6HTG0ryPHiPeDRNI97LkRMjSv52E9lr8w/Z/Sod2SB8ngLPbx/cBw2uK+/hPRpSsoYTWsdoAN1mDkvgmPGuTLD3yZ1Jr6+JSjxEIb5WvAtzGomv3lrrArbWHKcAL6D690nFO2yaSxX9FNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756725946; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=JKbrB0s6B1hxtiguHSN3mL4QozFKLp4LyEThmokh9/o=; b=FAEDuym2Wz/FcJYl7a7t/OSGQmM1ARo1Vjq4dRC+p8xVjmWJLitPdgCDXnMdEv4vjRMwzXLcGT3/K1aLqS2lDrv09sO/GLyoqUBcdxfDeT6bTwemX/pDuh8EUlxDt+r/oZfMctcZDU+fFeduJ1Rf/chQQojfjQ4OU6c0NkRDY6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756725946494705.4160504413367; Mon, 1 Sep 2025 04:25:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut2eZ-0000Om-SL; Mon, 01 Sep 2025 07:24:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut2eR-0000JJ-3G for qemu-devel@nongnu.org; Mon, 01 Sep 2025 07:24:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut2eP-0006Cz-40 for qemu-devel@nongnu.org; Mon, 01 Sep 2025 07:24:42 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-14bvx3jKObWLuH2DO3mx2A-1; Mon, 01 Sep 2025 07:24:35 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 656141800289; Mon, 1 Sep 2025 11:24:34 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.32.80]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8750B1800294; Mon, 1 Sep 2025 11:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756725879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JKbrB0s6B1hxtiguHSN3mL4QozFKLp4LyEThmokh9/o=; b=H3kzfdmp8avHViZYn4HYkkgCD5aAei0Oi1bufD8INLtvSVJGweHDdwwUSUxk5323zoB+jH FkyXw55woy3+BMolDBDUeVlBnT0WpN5FRsfMHrd3YGgNLE4PjKrkMtzUP2QZQ6xTjATHO8 4g7LCoD01KcUIQOnbJtbrq9fwNCN8B4= X-MC-Unique: 14bvx3jKObWLuH2DO3mx2A-1 X-Mimecast-MFC-AGG-ID: 14bvx3jKObWLuH2DO3mx2A_1756725874 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Stefan Hajnoczi , Richard Henderson Subject: [PULL v2 7/9] qga-vss: Write hex value of error in log Date: Mon, 1 Sep 2025 14:24:11 +0300 Message-ID: <20250901112413.114314-8-kkostiuk@redhat.com> In-Reply-To: <20250901112413.114314-1-kkostiuk@redhat.com> References: <20250901112413.114314-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756725947677116600 Content-Type: text/plain; charset="utf-8" QGA-VSS writes error using error_setg_win32_internal, which call g_win32_error_message. g_win32_error_message - translate a Win32 error code (as returned by GetLastError()) into the corresponding message. In the same time, we call error_setg_win32_internal with error codes from different Windows componets like VSS or Performance monitor that provides different codes and can't be converted with g_win32_error_message. In this case, the empty suffix will be returned so error will be masked. This commit directly add hex value of error code. Reproduce: - Run QGA command: {"execute": "guest-fsfreeze-freeze-list", "arguments": = {"mountpoints": ["D:"]}} QGA error example: - before changes: {"error": {"class": "GenericError", "desc": "failed to add D: to snapshot= set: "}} - after changes: {"error": {"class": "GenericError", "desc": "failed to add D: to snapshot= set: Windows error 0x8004230e: "}} Reviewed-by: Yan Vugenfirer Link: https://lore.kernel.org/qemu-devel/20250825135311.138330-1-kkostiuk@r= edhat.com Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index bc260abb96..5615955b6f 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -28,8 +28,9 @@ =20 #define err_set(e, err, fmt, ...) { = \ (e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__,= \ - err, fmt, ## __VA_ARGS__); = \ - qga_debug(fmt, ## __VA_ARGS__); = \ + err, fmt ": Windows error 0x%lx", = \ + ## __VA_ARGS__, err); = \ + qga_debug(fmt ": Windows error 0x%lx", ## __VA_ARGS__, err); = \ } /* Bad idea, works only when (e)->errp !=3D NULL: */ #define err_is_set(e) ((e)->errp && *(e)->errp) --=20 2.50.1