From nobody Sun Sep 28 16:28:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756572451676902.7988118691968; Sat, 30 Aug 2025 09:47:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usOQk-0001BY-UV; Sat, 30 Aug 2025 12:27:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usI2z-0007pA-Li for qemu-devel@nongnu.org; Sat, 30 Aug 2025 05:38:57 -0400 Received: from m239-4.eu.mailgun.net ([185.250.239.4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1usI2x-0002Me-Ea for qemu-devel@nongnu.org; Sat, 30 Aug 2025 05:38:57 -0400 Received: from fedora (pub082136115007.dh-hfc.datazug.ch [82.136.115.7]) by 93518a5527e07c5c8c323cd912038c47e23a9b50108f025ab03e83a0b0c23c7b with SMTP id 68b2c6ad64422a0f643c0ac8; Sat, 30 Aug 2025 09:38:53 GMT DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=0x65c.net; q=dns/txt; s=email; t=1756546733; x=1756553933; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=BEBbS3D81KIa7i5AIgyciRF8qIIH2Siayt4a3kPs16c=; b=CfYBBVAEASub6x608psb/mSFGhcVsnn/0WnGargJBjGC3ARtje7MGcwnetsMpmbRkrBrdPSAX7v+e/fFNhQWW2wsukOb50BNjhTvi5W2WpiGjuwsL605f1QJYBPpsw2RpR7S0om40abcAtxf3qp0dytobIHj2HbT95C98f6UbbDfWSH0OFlv804twp14AXXu86Bm+wQXLj0P9gmOuaHuG093GpCnsES5QCKUqutGE12EMrjrJFI0QtUByJxWxCrradnk1EdHiP3T5zFLtK/zqrlBWkG6uHxM1BD7/b+2lXD0yz3OHyNSpel+4B/AVWkoyRRqCLClJmRi4cFaYI9YPg== X-Mailgun-Sid: WyJiNjdhNCIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjU0ZWY0Il0= X-Mailgun-Sending-Ip: 185.250.239.4 From: Alessandro Ratti To: qemu-devel@nongnu.org Cc: alessandro.ratti@gmail.com, Alessandro Ratti Subject: [PATCH] virtio: prefix error messages with "virtio:" Date: Sat, 30 Aug 2025 11:31:47 +0200 Message-ID: <20250830093844.452039-2-alessandro@0x65c.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250830093844.452039-1-alessandro@0x65c.net> References: <20250830093844.452039-1-alessandro@0x65c.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.250.239.4; envelope-from=bounce+db73df.54ef4-qemu-devel=nongnu.org@0x65c.net; helo=m239-4.eu.mailgun.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 30 Aug 2025 09:06:12 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Invalid signature record: Signature is expired since 308m.) X-ZM-MESSAGEID: 1756572452620116600 Content-Type: text/plain; charset="utf-8" The error message introduced in commit e45da653223 in virtio_init_region_cache() was unclear: qemu-system-i386: Cannot map used This patch modifies virtio_error() to prepend all error messages with "virtio: ", making it easier to trace their origin. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/230 Buglink: https://bugs.launchpad.net/qemu/+bug/1919021 Signed-off-by: Alessandro Ratti --- hw/virtio/virtio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 9a81ad912e..c43ac4d320 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3934,11 +3934,16 @@ void virtio_device_set_child_bus_name(VirtIODevice = *vdev, char *bus_name) void G_GNUC_PRINTF(2, 3) virtio_error(VirtIODevice *vdev, const char *fmt,= ...) { va_list ap; + char *prefixed_fmt; + + prefixed_fmt =3D g_strdup_printf("virtio: %s", fmt); =20 va_start(ap, fmt); - error_vreport(fmt, ap); + error_vreport(prefixed_fmt, ap); va_end(ap); =20 + g_free(prefixed_fmt); + if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { vdev->status =3D vdev->status | VIRTIO_CONFIG_S_NEEDS_RESET; virtio_notify_config(vdev); --=20 2.39.5