From nobody Tue Sep 9 05:58:03 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756576253; cv=none; d=zohomail.com; s=zohoarc; b=MBePrWCZflwHivgb+sICvW3s8k/bFpI+zQbj2598i3zVYTnRS3wYLT8l1ufBxnnINUXz7a0tylPnPgceOPJjnz5QGXJJX+6CoygPW3YlGm1rLD5dmvqu1rYhQL9Q/XlZpN1TT3v0QkLfYwDZbLuJH/DC/r1FslzP/GD2t+SOaAE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756576253; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DZyOZ5ibz8YB1lWsiaU/JxXFHwk/vo9PWaKWI3jDReA=; b=K7P4UUenhjf9RnNHEl36VLoXurfb1BhsHI74qNWliGJIobIeAYRjK2YciZn3PhZLw4P8tsOlJyNblrh5UWRuNzLvEu2GrmxsTKGLiBQAA/8OpzbhN3MqxzFfwVl+kbZlCM2OmqJIPd7mYK8GBjqKoUSvrLH2yhFB8fNrMyuNJlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756576253371389.7964492670483; Sat, 30 Aug 2025 10:50:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usNvN-0004yC-0c; Sat, 30 Aug 2025 11:55:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usELj-0005t9-WE for qemu-devel@nongnu.org; Sat, 30 Aug 2025 01:42:06 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1usELg-00046G-Ob for qemu-devel@nongnu.org; Sat, 30 Aug 2025 01:42:02 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-b49cf21320aso3039782a12.1 for ; Fri, 29 Aug 2025 22:42:00 -0700 (PDT) Received: from stoup.. (122-150-204-48.dyn.ip.vocus.au. [122.150.204.48]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4d96829a66sm2435905a12.6.2025.08.29.22.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 22:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756532519; x=1757137319; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DZyOZ5ibz8YB1lWsiaU/JxXFHwk/vo9PWaKWI3jDReA=; b=woFakJBpAkWEZl3DVdle8hXFEtUjK6RGYHHfDUNfkfCl8BI32jOVExc4svPV83TTbF DLDxPgXiJeiva0UNHzsbMGrjMZVWquOxooRXCku0C3rv7QXOvsFRUWzgjzgbuMZnpE0C 34/NSApBZ226jj5x1hHvqwofcaAu/3ZEcAn/9va1CQbcJAfUIgJUPvtKlsjHMsEVMSuL DW0EqJt89QQJK7hsSdbEBaQKDAP1BQK6ubYPF5FkhH7b0mlvyrwLd818du12zUG6/5Vs UNWP7TZFVhHVK9tE38MJdhRrdz+WFvAuWhcMN7hM6mpeOY+0FKW69QkE2p7eLMPLqZzg MoGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756532519; x=1757137319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZyOZ5ibz8YB1lWsiaU/JxXFHwk/vo9PWaKWI3jDReA=; b=IYRbbf+3UIiyFU/lzSFX2Cexppw3aXk/k5b7kiCcBqpkqAD9nUPGITAOxOMVnxnmyU TMLeI/dpcm1UJ6xHqFCvZ9WBAQvgLjPLmjvkrEHNQyjTgqtnLkXZS6qoUR4tuywazXOD Z/BscULJQa8A52O/qkWNBBIWPFWd64SJwNVVse39R0Iq5ISb6QHHvkHViRw9LFQz0cSg caEoQUmxkl9a1PeS6haVv1GOUmb92rfSb9RAFTmfbDOGKYdNHPPalllV0I5+Qtff1A+Y OZZSK9S4E2VMgnZwvHqaL9RoANGe3Si0fbrttIkISFceFZSa+t3G+8VB7G6WUr2Q/B9+ Ghhg== X-Gm-Message-State: AOJu0Yz0dxpMCJQUlrk2O2vV0GHJHQaQ2JtXoRUatS5fEoUAPkPUj/jX N0fBTZ9pczQa0pHNxWTlPcQMLUi9RxWw6iOn4cWvvKW+B1/M9kZyUNk+CXxwsSpY8IjIP+MAj+z hPYa+4dc= X-Gm-Gg: ASbGncvf+5eIzGNKQymfdxFDhC0Sd4aBlYZsGuSENTHWzoLmDgu651rA/VP07UeSb0o SaguSI87HueREFh7Fgo/KaZj1baStCZec77KjGj4KiQ53n7PeiRmqMVl8JPmElhklPgEC6CpdSw lsB2ssrv8AsNDcvOOawCiS0l4zP2jzUfO4hVLIS7J2cU5TbhFRegAdKEL4LWkfGcFNiRzCaRjfO 24YrQQEvl0U9KiDXLREZCeyPeE8zIVYtL6D3tnKbJWz1K0dyQSk5d1+KtwjIsth8ThtdVckzV47 EEMj08bpI1mplsONtr02jyzFS0na42pLnbGEIynJRGdTYObI6jxLwesYcb3myUQ7tGaMsv5FnW3 K2H/uJ3k7i+foMyPKUWgFEmUtDye9DeT3M6CJnI1/+GEeWYaub59Cz8/LNlzK X-Google-Smtp-Source: AGHT+IGy9M+jfEKInLDx/wPZPtI3vEwu3bjqVOtpz4NnBS21UmV5qG9Xh4Ry9zDFhIqi5lpI0fDvdQ== X-Received: by 2002:a17:903:41cc:b0:224:23be:c569 with SMTP id d9443c01a7336-249448f4103mr12371095ad.22.1756532519253; Fri, 29 Aug 2025 22:41:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Pierrick Bouvier Subject: [PATCH v4 09/84] target/arm: Add prot_check parameter to do_ats_write Date: Sat, 30 Aug 2025 15:40:13 +1000 Message-ID: <20250830054128.448363-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250830054128.448363-1-richard.henderson@linaro.org> References: <20250830054128.448363-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756576254619116600 Content-Type: text/plain; charset="utf-8" Separate protection check from access type, in preparation for skipping the protection check altogether. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/tcg/cpregs-at.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/tcg/cpregs-at.c b/target/arm/tcg/cpregs-at.c index 2ff0b3e76f..bebf168997 100644 --- a/target/arm/tcg/cpregs-at.c +++ b/target/arm/tcg/cpregs-at.c @@ -24,14 +24,14 @@ static int par_el1_shareability(GetPhysAddrResult *res) } =20 static uint64_t do_ats_write(CPUARMState *env, uint64_t value, - MMUAccessType access_type, ARMMMUIdx mmu_idx, + unsigned prot_check, ARMMMUIdx mmu_idx, ARMSecuritySpace ss) { uint64_t par64; bool format64 =3D false; ARMMMUFaultInfo fi =3D {}; GetPhysAddrResult res =3D {}; - bool ret =3D get_phys_addr_for_at(env, value, 1 << access_type, + bool ret =3D get_phys_addr_for_at(env, value, prot_check, mmu_idx, ss, &res, &fi); =20 /* @@ -191,7 +191,7 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t= value, =20 static void ats_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t v= alue) { - MMUAccessType access_type =3D ri->opc2 & 1 ? MMU_DATA_STORE : MMU_DATA= _LOAD; + unsigned access_perm =3D ri->opc2 & 1 ? PAGE_WRITE : PAGE_READ; uint64_t par64; ARMMMUIdx mmu_idx; int el =3D arm_current_el(env); @@ -253,7 +253,7 @@ static void ats_write(CPUARMState *env, const ARMCPRegI= nfo *ri, uint64_t value) g_assert_not_reached(); } =20 - par64 =3D do_ats_write(env, value, access_type, mmu_idx, ss); + par64 =3D do_ats_write(env, value, access_perm, mmu_idx, ss); =20 A32_BANKED_CURRENT_REG_SET(env, par, par64); } @@ -261,11 +261,11 @@ static void ats_write(CPUARMState *env, const ARMCPRe= gInfo *ri, uint64_t value) static void ats1h_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { - MMUAccessType access_type =3D ri->opc2 & 1 ? MMU_DATA_STORE : MMU_DATA= _LOAD; + unsigned access_perm =3D ri->opc2 & 1 ? PAGE_WRITE : PAGE_READ; uint64_t par64; =20 /* There is no SecureEL2 for AArch32. */ - par64 =3D do_ats_write(env, value, access_type, ARMMMUIdx_E2, + par64 =3D do_ats_write(env, value, access_perm, ARMMMUIdx_E2, ARMSS_NonSecure); =20 A32_BANKED_CURRENT_REG_SET(env, par, par64); @@ -309,7 +309,7 @@ static CPAccessResult at_s1e01_access(CPUARMState *env,= const ARMCPRegInfo *ri, static void ats_write64(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { - MMUAccessType access_type =3D ri->opc2 & 1 ? MMU_DATA_STORE : MMU_DATA= _LOAD; + unsigned access_perm =3D ri->opc2 & 1 ? PAGE_WRITE : PAGE_READ; ARMMMUIdx mmu_idx; uint64_t hcr_el2 =3D arm_hcr_el2_eff(env); bool regime_e20 =3D (hcr_el2 & (HCR_E2H | HCR_TGE)) =3D=3D (HCR_E2H | = HCR_TGE); @@ -352,7 +352,7 @@ static void ats_write64(CPUARMState *env, const ARMCPRe= gInfo *ri, } =20 ss =3D for_el3 ? arm_security_space(env) : arm_security_space_below_el= 3(env); - env->cp15.par_el[1] =3D do_ats_write(env, value, access_type, mmu_idx,= ss); + env->cp15.par_el[1] =3D do_ats_write(env, value, access_perm, mmu_idx,= ss); } =20 static CPAccessResult ats_access(CPUARMState *env, const ARMCPRegInfo *ri, --=20 2.43.0