From nobody Sun Sep 28 16:33:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756572411; cv=none; d=zohomail.com; s=zohoarc; b=UreWzdMXCfPG56u/r72t5WUwfyC6A3uIPbYy3h7YvMO62UUCwvserbEF6Ynw8aGi2DltthnmdA2oONJLRb+kjPWOqrWX5x4BYARfq4HxlqeVLlNxc+U0+lDTJXHsA1/U9i3oVb8rRSaCE0jkRWb51aQvtxclKbldhWrmNBYYYFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756572411; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EK8ZniS31eKfAuecJyHjMuA5swX2F7mkJn3tAORFulo=; b=N7OozuIO25iH2I9fxKn3C7enpeT9uTXD7G2/nsF5ZiEiHIlXnsedkz4jlh4G4Mj24L/sD8iSHMxahlMT/VsFSG0eKKKBqo5INMB2BXMGY4KTX8tLbe+pQ73A3LRwGZ0zCGiF+WgJSx/HuU/1diARILOZ4HMak1579u80RaQ3Mqw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756572411773815.5581739011444; Sat, 30 Aug 2025 09:46:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usNe8-0003Qf-SY; Sat, 30 Aug 2025 11:37:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1us5Mk-0006Dt-TE for qemu-devel@nongnu.org; Fri, 29 Aug 2025 16:06:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1us5Mi-00058J-Lx for qemu-devel@nongnu.org; Fri, 29 Aug 2025 16:06:29 -0400 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-RqJkaTMgNVaRqe3yMKCHDQ-1; Fri, 29 Aug 2025 16:06:24 -0400 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-24927876fadso9158145ad.2 for ; Fri, 29 Aug 2025 13:06:24 -0700 (PDT) Received: from armenon-kvm.bengluru.csb ([49.47.195.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-327d8f66f16sm3570543a91.0.2025.08.29.13.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 13:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756497987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EK8ZniS31eKfAuecJyHjMuA5swX2F7mkJn3tAORFulo=; b=M4px4nUTRsIEXZwIWf+JXlb109l9UxDR/n/I745CdolcGsLmrjtkhOzLcY3voSDFvODW9x fXZsFMrIoZGXneQQjOLnyDv6X/IQoACSpEgrvmRu6GslGT2jaArfIYzQAMCZ4mrC0OoKhW 6GUzmHBKJ3cw/N7o378hTBd3rIpFEEM= X-MC-Unique: RqJkaTMgNVaRqe3yMKCHDQ-1 X-Mimecast-MFC-AGG-ID: RqJkaTMgNVaRqe3yMKCHDQ_1756497984 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756497984; x=1757102784; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EK8ZniS31eKfAuecJyHjMuA5swX2F7mkJn3tAORFulo=; b=WZH/sDMw9GlqEtdS/vK/Y4Sz8soERo6JfmW0Zv7zpv6rfxy3LewTZTfW4fi96KUuF5 R7VCkfBNJktOx4kOoOVt59qqwGDwhNlY8NF28N9Uo2m4pYAvINmzOMJ9txmMM8SqDm6P HNdcbAhVt24guoOLwO8zPwrPBorN2ch+wDM8tqu2tFWGK/0g380WLetJyOuYU7M3VCJm LN8fFK0iZPCM5oJ11xFMRg0fL0aNqpNNHCuVtHaZLEflQJ5SEHvjFEqEiSKYMPGa2toK H8Dpo/IxkTlYj5029n/IL1Nekgh9ng+sn2WGc/0TjfivfdQH7BaPYAMNM6YcXHpEldi7 oz8g== X-Gm-Message-State: AOJu0YyoZEOfXN96lDPZg/uZcj2ndGfxzAexBSE06xBgSDo7YcJmkWgD P15Dy84O61xQEL5TFpTyO5XJvS60AVEIiuAcP8iF1HnqOmzaOrVLj7uJH1cdV/zYdMeu3BO7zFV E3TYqae272eWgXdYXUg3393NlahMBQxLoLRxpnezxfOCoo1C6iQIUoeqn X-Gm-Gg: ASbGncvV07thfrPH1zrEADRLVJtsg5VY9qla02u7smgah7tXszALpcqvx00lSPNnSYZ 1VA1UGNx0R10GhjzZJn0dPkHGn1k2opgG4aW03KjxoBOhkaMz0BEta/s/HrJoaxgEJmw+efuTVU +ORCjAH62Z/9wBse/2577I27SbsJbcUzF4PB2NoqOmVQzAeqKMovTZi5DUgnLS9xaFScx4bXL4g 8zvf49r7XiIro5BD92YAtHpRYTeR+ceJfWf7DsGzwQsMzD5RqhFjmWVMQdUmxEirt00CblFLoqn giJlEdmAJKdsNkYh4bAMeTpMPvJTKcxs4Onc/pMSLcYTGn7NG4p1bg== X-Received: by 2002:a17:902:e54f:b0:246:a532:3343 with SMTP id d9443c01a7336-246a5323a3cmr315115505ad.10.1756497983741; Fri, 29 Aug 2025 13:06:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGaksZqggjQ8NuqRcRP2WUGJ0hf1LDRm0cmz7dgENVz/im4xsVjGHviXLKSxNPegdTOKSJ8Wg== X-Received: by 2002:a17:902:e54f:b0:246:a532:3343 with SMTP id d9443c01a7336-246a5323a3cmr315115155ad.10.1756497983318; Fri, 29 Aug 2025 13:06:23 -0700 (PDT) From: Arun Menon Date: Sat, 30 Aug 2025 01:31:57 +0530 Subject: [PATCH v13 17/27] migration: push Error **errp into loadvm_postcopy_handle_run() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250830-propagate_tpm_error-v13-17-a4e777b7eb2c@redhat.com> References: <20250830-propagate_tpm_error-v13-0-a4e777b7eb2c@redhat.com> In-Reply-To: <20250830-propagate_tpm_error-v13-0-a4e777b7eb2c@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Xu , Fabiano Rosas , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , "Michael S. Tsirkin" , Marcel Apfelbaum , Cornelia Huck , Halil Pasic , Eric Farman , Thomas Huth , Christian Borntraeger , Matthew Rosato , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Nicholas Piggin , Harsh Prateek Bora , Paolo Bonzini , Fam Zheng , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steve Sistare , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Hailiang Zhang , Stefan Berger , Peter Maydell , qemu-arm@nongnu.org, Arun Menon , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1888; i=armenon@redhat.com; h=from:subject:message-id; bh=Bc7pNWeaQQJR7xn/IMqCNxln9K0U+dn3FXOfz+z8MlM=; b=owGbwMvMwCWWVaVqcZPfqI/xtFoSQ8Ymdt/GP3zhWkejXE12KHN/+leSIp+5xzVJ8+iFtTJ7m N4XK8zpKGVhEONikBVTZGn4GiDbFFAYEWn78jrMHFYmkCEMXJwCMBFHTob/Xjt4xSzzNwvsFtrx XK6QbbaTWdwlPf6Us4+vfLPS9/14hZFhxk57zj+3Q940P992LTsjZ/KJEwcPyNw58OaOlWbjpCv 7mAA= X-Developer-Key: i=armenon@redhat.com; a=openpgp; fpr=80F5501D82507158593DE9D76A7A2538D90F328E Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756572414386116600 This is an incremental step in converting vmstate loading code to report error via Error objects instead of directly printing it to console/monitor. It is ensured that loadvm_postcopy_handle_run() must report an error in errp, in case of failure. Reviewed-by: Fabiano Rosas Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Arun Menon --- migration/savevm.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index c681d6d21af356a97645f2a0d36e7440e3bd95c6..3ab20bd3de980ecfd79ab29697e= 3e1527ab3e73c 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2273,13 +2273,13 @@ static void loadvm_postcopy_handle_run_bh(void *opa= que) } =20 /* After all discards we can start running and asking for pages */ -static int loadvm_postcopy_handle_run(MigrationIncomingState *mis) +static int loadvm_postcopy_handle_run(MigrationIncomingState *mis, Error *= *errp) { PostcopyState ps =3D postcopy_state_get(); =20 trace_loadvm_postcopy_handle_run(); if (ps !=3D POSTCOPY_INCOMING_LISTENING) { - error_report("CMD_POSTCOPY_RUN in wrong postcopy state (%d)", ps); + error_setg(errp, "CMD_POSTCOPY_RUN in wrong postcopy state (%d)", = ps); return -1; } =20 @@ -2626,11 +2626,7 @@ static int loadvm_process_command(QEMUFile *f, Error= **errp) return loadvm_postcopy_handle_listen(mis, errp); =20 case MIG_CMD_POSTCOPY_RUN: - ret =3D loadvm_postcopy_handle_run(mis); - if (ret < 0) { - error_setg(errp, "Failed to load device state command: %d", re= t); - } - return ret; + return loadvm_postcopy_handle_run(mis, errp); =20 case MIG_CMD_POSTCOPY_RAM_DISCARD: ret =3D loadvm_postcopy_ram_handle_discard(mis, len); --=20 2.51.0