From nobody Sat Sep 6 06:50:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756574652; cv=none; d=zohomail.com; s=zohoarc; b=MhZUbqgLwRGIFjW3ziQ8KNNdkxFglJHB/IowlcLiCxA4PppyjiZb8qwAsiCEBOZuhOtyZsvpvzWY2c2I6n4soipaM1I/LpH8OZvN8FQ5fYJ0xThfCDcCQDjs3k/oeQp6/5UQMTqMMPwcRlKTCo2Bq04niuYElHmpvhfNtjr5FlY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756574652; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jUNUdhp/2kvl0t2rlFqMP5IKnOgcmAf+2Ax3cFj3WDc=; b=gW6ML8LG4MQ9us373G9VADgBMbUaVvX0WViUViPkRDaqo472uRBt2zNFMD+u4ZLjOr9pHDGwnAoZoABb45n9dn7tXCwbspe7r1NtmIGiIQHuuhFV6ojf+SRyvVI6Se8wbmEY0JEciR9NylRaQbbJ9uiBd+eC5/uIOx0FSCQZnmA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756574652493813.5182183506188; Sat, 30 Aug 2025 10:24:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usNOh-0004LH-7T; Sat, 30 Aug 2025 11:21:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1us15E-00020n-Kc for qemu-devel@nongnu.org; Fri, 29 Aug 2025 11:32:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1us15C-0000be-TI for qemu-devel@nongnu.org; Fri, 29 Aug 2025 11:32:08 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-oZtP84KqOYS8ZYaEbJ0DKQ-1; Fri, 29 Aug 2025 11:32:04 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b7d497abbso9700525e9.0 for ; Fri, 29 Aug 2025 08:32:04 -0700 (PDT) Received: from [192.168.10.48] ([151.95.56.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf340b3f6esm3712275f8f.54.2025.08.29.08.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 08:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756481525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jUNUdhp/2kvl0t2rlFqMP5IKnOgcmAf+2Ax3cFj3WDc=; b=fJ3cSmUCHhgYG2zexZuKwguEyr8F7zC8MA/eXuD3rvqzvlo3ba21CdZ83d/Cs3jaLsF08P Xr3U1NskItlVZO177whlfVQ0zFaGA2UQO7/SQz0CeZ3LWmFGOIBBpvU9REWZxTI9C3QNUc QrtCg0f7I1wzwNFZmtkhDB2mA0epye8= X-MC-Unique: oZtP84KqOYS8ZYaEbJ0DKQ-1 X-Mimecast-MFC-AGG-ID: oZtP84KqOYS8ZYaEbJ0DKQ_1756481524 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756481523; x=1757086323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jUNUdhp/2kvl0t2rlFqMP5IKnOgcmAf+2Ax3cFj3WDc=; b=BXx3QMVqAODrtTc2r3LpRnE4by6u5OPUtLvPhNsAviEJd9BTzJdCx1vQEPCbhKPZJn lLDSGFv2bO2qGtWplNux5i1+UPI9PqfPLLPaKiUB7D94ULubs5qnCkL+X/6H2C7piRHN 7HlkXH32iNL64Lbd8Xbg/0gxBfZCXAZavATbVQj0VyGuo88uBG1j/E5YUgHmWjrt8ZDP 8fPYMErI/xlcAIJrTrwB0FMk2nClv0JTgvKNjLe9O5vH2YxBMbSRzf2Yk86uy53NZCBZ toQ+vrS9ERL8OM2TUWFdV2WyFOik3kDoJVk1rfN8tQZM3gm5zA3GPEPHgTS4FKu/FaUd 3xsw== X-Gm-Message-State: AOJu0YyhDoyW+Rs72ZHHYUA+6RZxahUIi15+KUqNtjrnBdcGSduxd85W ItRd33rP55FFkRBiqnSL+9I3zEUDTR/0K/DqH8ulyNalmQz1vYjp4qrxlx7WFYIgncWCxNqhMh8 8gROPhH4/I1nQhQs9/tjImMcCE9lB2a9Rk1uA12Tloq3Da7S0cB3yQHqPNUiIk4uaupvFaUSIPg n5tO6RNXY4GChFPbfxBXeQyVksdBclybr7qFuq5fan X-Gm-Gg: ASbGncvzZQvNcsXY69OdHB+jnhakeMLi3hVLesyRIJMZ8tVBOPZJBXQW5zjKA8NjK/D z6rn5vXY9Shk51u0BrAUJ0ltNhAHqD9BKFcFex+YUa3Mo0Az2Ud7Kt13z8DWmn4NX5/8MS1a41t Lbws8rsMnk2Pi8nBylooudLIJIMkMh0cwAARNKdpj2Jr9nr8WUhqiyr81Y6bUly4UOrVyF5g+xv kdrUY+hEwBc9pTpJ/BLNuTYApVwxSsyg5jBcLNsKhUkJfCGUVkoZDlgdhTvE9XmEsy9dXvzGL6y +C4wNBHcqz/jHCsBYQqF0WJ4uV3QBL8bAEaB4ReuS9U8MSFDyRNCytRtaWH6Da9jMPswfrYx5G9 2V+JSscCL3mEfnSW97m2Hk38YZSzArpPPDpFUz7jYmz0= X-Received: by 2002:a05:600c:1c0c:b0:458:bda4:43df with SMTP id 5b1f17b1804b1-45b727a2c43mr93391755e9.17.1756481522667; Fri, 29 Aug 2025 08:32:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiKA5+9WcGOj9LIZVY6JkHxRNRVWnG6VPlf9GCNQzCnQ7A6Jqm4X+VAmtCmBqxZuKvwfqvRg== X-Received: by 2002:a05:600c:1c0c:b0:458:bda4:43df with SMTP id 5b1f17b1804b1-45b727a2c43mr93391485e9.17.1756481522204; Fri, 29 Aug 2025 08:32:02 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: peterx@redhat.com, richard.henderson@linaro.org, imammedo@redhat.com Subject: [PATCH 18/18] tcg/user: do not set exit_request gratuitously Date: Fri, 29 Aug 2025 17:31:15 +0200 Message-ID: <20250829153115.1590048-14-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250829152909.1589668-1-pbonzini@redhat.com> References: <20250829152909.1589668-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756574653083116600 Content-Type: text/plain; charset="utf-8" Whenever user-mode emulation needs to go all the way out of the cpu exec loop, it uses cpu_exit(), which already sets cpu->exit_request. Therefore, there is no need for tcg_kick_vcpu_thread() to set cpu->exit_request again outside system emulation. Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov --- accel/tcg/cpu-exec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index ad94f96b252..7c20d9db122 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -751,6 +751,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) =20 void tcg_kick_vcpu_thread(CPUState *cpu) { +#ifndef CONFIG_USER_ONLY /* * Ensure cpu_exec will see the reason why the exit request was set. * FIXME: this is not always needed. Other accelerators instead @@ -758,6 +759,7 @@ void tcg_kick_vcpu_thread(CPUState *cpu) * CPU thread; see kvm_arch_pre_run() for example. */ qatomic_store_release(&cpu->exit_request, true); +#endif =20 /* Ensure cpu_exec will see the exit request after TCG has exited. */ qatomic_store_release(&cpu->neg.icount_decr.u16.high, -1); --=20 2.51.0