From nobody Sun Sep 28 16:30:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756567947; cv=none; d=zohomail.com; s=zohoarc; b=c3XimdjJiclCBk7xi8Wq8RS9z6useVBqqVDOqu4bTPqfIaQ8hC3M2LLNEL2TjlNdmbP6D2lEdOvlL+Yg1cd8YrLWfn7waUgCfJg7end7/Deem4Lsblz5uF1ca2BhlluK3okRtHdiVL7dpTmBekng7q0Gi6V63+vuKRmlMb//ols= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756567947; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yxoy21IR96c+Q5DUdbsmFFGBfBDLqDyltAfmnPFJ63I=; b=V4ewQerWXC3WXagvhQC8BryXMShJ81MDKBGrlqOuKVKVk40cT/Jj9WOYYdatuW9OA9jU+Vlb6Z1zpinKEaShEfQ/kLxvm6A0K0+z8MOWgTPRty69RzMnJl/PKNceVIeUo7ueZpK8r/G5+rELXWSOAZPBopE5xi/Wns3wmX7hob0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756567947523362.5021768312522; Sat, 30 Aug 2025 08:32:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usNHT-0000lZ-Sc; Sat, 30 Aug 2025 11:14:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uryi5-0000yO-5D for qemu-devel@nongnu.org; Fri, 29 Aug 2025 09:00:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uryi3-00089D-CL for qemu-devel@nongnu.org; Fri, 29 Aug 2025 09:00:04 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-Ama32dD4N3-_cD1UL_wOHw-1; Fri, 29 Aug 2025 09:00:00 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45a1b0bd6a9so11531135e9.2 for ; Fri, 29 Aug 2025 06:00:00 -0700 (PDT) Received: from [192.168.10.48] ([151.95.56.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf276cc915sm3273840f8f.21.2025.08.29.05.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Aug 2025 05:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756472402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yxoy21IR96c+Q5DUdbsmFFGBfBDLqDyltAfmnPFJ63I=; b=jKubaDgeaIZrJB1PKQKMzLH0miypLUnrhdZWwJXksAIDcZa1FJIj9UXCBhoa4+q8A4usnw NUqQqGxbykl1MbmvDJmdhQXBwAc39L453YkMW4nZ/Mv1YdL+4eX8s4UhIsFSoOJyrftpTJ DqI8BGIJUpzNEi9pSScRTnd19sNFNk4= X-MC-Unique: Ama32dD4N3-_cD1UL_wOHw-1 X-Mimecast-MFC-AGG-ID: Ama32dD4N3-_cD1UL_wOHw_1756472399 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756472398; x=1757077198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yxoy21IR96c+Q5DUdbsmFFGBfBDLqDyltAfmnPFJ63I=; b=axUYXNUhGWC8qA8dicht80IknMMgBan41tIHAzu4jZX+515r+w9XhNV04NkbdXSgVV 5i5rAespkWv4OE28rl2meuetJb22moWiPgfJHYWbGNFtrOdstmyd+eRaZ0H/GdWG3wiD guhBbgu52lJB8nl7o6Gcm2J3j6nxzjMSzTuZhF9JiEEb7nMA+L4RuDBpTJe9L/kszVJa 8PBZ1bQKTVTy1g/run9Z2eYjLia4rsWmq0iSY01hf+DN+4Ymd1B+tQQzeVjnEnqiJK3W jbFJm5/L8XG6lTvkgfFFQ6HWUAUu5bzbsq+bWu8JERtRsp8idrpGmUiTIwhPjW9kCewt hjSw== X-Gm-Message-State: AOJu0YzPWfNMUQ4FNNZMXlcT/VgRgIF7M9kBLpuJ+58c2qBmi86lbJRJ 0is1Hd4F5TxncsNS7jHZd/4rv0bGDEq42q1OX+7lyaBMISIcu9jVeatYix88CRHwHszY2pzjXj/ CwjADm/rH9lbCu6AfbfyJanvm79K4cDEGGwgXgrJUDm0Ex4kMCHTPiwq9+0+zl/dmjLHUNn0ecM sMUMOor+sitlFz0MyUt/f1OWDbJRnSaL76tDtWhKoh X-Gm-Gg: ASbGncsouyLIBHhzP0B6mV3PmzB3C5hHI5e2TbMebfMD7kD4Pg8wuv07j9VaD7a4NVD 689PSOpNPmzFTvxi+WI7DpFC9mikbfcxUvJuquhvOkH6yuT2saRm0TjQRp+1g1PEidHv3ktGAYK xKSFyu4S4P1S6oRxNJSXTm3NpTXr8245+VTu8jO2DEh9MObFQuMYQZVwBKtywYUZ1AjyMTVKKuY 7MRC9ZCmdJFGNcweGU2i+/I5KlvRyAF5nwCaSFpJnt5L4Zh6VNZpZ3ofHmVlf1iFwKszlv8RHrN eQzD8/VMJRXwp7/MAs+ZlBLA7sZZr7b7+aRViQkSrge19/HSJ2toUwN7Q3jJz2bxQAlWWlcn1w3 sUnwOoo9YszRmQueD46ewOnP8N6yXL5cmBrStblwl7R8= X-Received: by 2002:a05:6000:26d2:b0:3d0:d6e6:5d76 with SMTP id ffacd0b85a97d-3d0d6e664b1mr1445343f8f.55.1756472398143; Fri, 29 Aug 2025 05:59:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHt0cX2L/zzLDzf7Rh9RUDJy1nUsZVdlXOQZJTOPoem8luhXtgrmrOY7rCXPWMS+/1u1hgagg== X-Received: by 2002:a05:6000:26d2:b0:3d0:d6e6:5d76 with SMTP id ffacd0b85a97d-3d0d6e664b1mr1445311f8f.55.1756472397658; Fri, 29 Aug 2025 05:59:57 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Xiaoyao Li Subject: [PULL 08/28] hw/i386/pc_piix.c: remove SMI and piix4_pm initialisation from pc_init_isa() Date: Fri, 29 Aug 2025 14:59:15 +0200 Message-ID: <20250829125935.1526984-9-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250829125935.1526984-1-pbonzini@redhat.com> References: <20250829125935.1526984-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756567951024124100 From: Mark Cave-Ayland These are based upon the PIIX4 PCI chipset and so can never be used on an i= sapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li Link: https://lore.kernel.org/r/20250828111057.468712-9-mark.caveayland@nut= anix.com Signed-off-by: Paolo Bonzini --- hw/i386/pc_piix.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5ae265bd538..57b02da5a82 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -441,8 +441,6 @@ static void pc_init_isa(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); ISABus *isa_bus; - Object *piix4_pm =3D NULL; - qemu_irq smi_irq; uint32_t irq; GSIState *gsi_state; MemoryRegion *ram_memory; @@ -618,23 +616,6 @@ static void pc_init_isa(MachineState *machine) } #endif =20 - if (piix4_pm) { - smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - - qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); - pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); - /* TODO: Populate SPD eeprom data. */ - smbus_eeprom_init(pcms->smbus, 8, NULL, 0); - - object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - TYPE_HOTPLUG_HANDLER, - (Object **)&x86ms->acpi_dev, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - piix4_pm, &error_abort); - } - if (machine->nvdimms_state->is_enabled) { nvdimm_init_acpi_state(machine->nvdimms_state, system_io, x86_nvdimm_acpi_dsmio, --=20 2.51.0